Merge lp:~3v1n0/unity/spread-title-flicker-fix-7.1 into lp:unity

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Christopher Townsend
Approved revision: no longer in the source branch.
Merged at revision: 3567
Proposed branch: lp:~3v1n0/unity/spread-title-flicker-fix-7.1
Merge into: lp:unity
Diff against target: 14 lines (+1/-1)
1 file modified
unity-shared/PluginAdapter.cpp (+1/-1)
To merge this branch: bzr merge lp:~3v1n0/unity/spread-title-flicker-fix-7.1
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Christopher Townsend Approve
Review via email: mp+190734@code.launchpad.net

Commit message

PluginAdapter: set the spread window state before spreading or the callback will get a wrong state

Description of the change

To post a comment you must log in.
Revision history for this message
Christopher Townsend (townsend) wrote :

LGTM. +1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Christopher Townsend (townsend) wrote :

Marco,

Ugh, didn't notice that this MP was targeted to lp:unity instead of lp:unity/7.1. Need to fix that:)

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

2013/10/11 Christopher Townsend <email address hidden>:
> Marco,
>
> Ugh, didn't notice that this MP was targeted to lp:unity instead of lp:unity/7.1. Need to fix that:)

Yes, me as well :P
Reproposed as https://code.launchpad.net/~3v1n0/unity/spread-title-flicker-fix-7.1/+merge/190766

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'unity-shared/PluginAdapter.cpp'
2--- unity-shared/PluginAdapter.cpp 2013-09-14 09:56:10 +0000
3+++ unity-shared/PluginAdapter.cpp 2013-10-11 17:42:16 +0000
4@@ -972,9 +972,9 @@
5 std::size_t num_windows = windows.size();
6 if (num_windows > 1 || (force && num_windows))
7 {
8+ _spread_windows_state = true;
9 std::string const& match = MatchStringForXids(windows);
10 InitiateScale(match, state);
11- _spread_windows_state = true;
12 return true;
13 }
14 return false;