Merge lp:~3v1n0/unity/quicklist-on-expo-regression-fix.oneiric into lp:unity/4.0

Proposed by Marco Trevisan (Treviño) on 2012-01-11
Status: Merged
Approved by: David Barth on 2012-01-11
Approved revision: 1734
Merged at revision: 1734
Proposed branch: lp:~3v1n0/unity/quicklist-on-expo-regression-fix.oneiric
Merge into: lp:unity/4.0
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/unityshell/src/LauncherIcon.cpp (+1/-1)
To merge this branch: bzr merge lp:~3v1n0/unity/quicklist-on-expo-regression-fix.oneiric
Reviewer Review Type Date Requested Status
David Barth (community) 2012-01-11 Approve on 2012-01-11
Andrea Azzarone (community) 2012-01-11 Approve on 2012-01-11
Review via email: mp+88193@code.launchpad.net

Description of the change

Fixed bug #914251, local variables should be passed by value.

To post a comment you must log in.
Andrea Azzarone (azzar1) wrote :

Works well for me.

review: Approve
David Barth (dbarth) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/LauncherIcon.cpp'
2--- plugins/unityshell/src/LauncherIcon.cpp 2011-12-08 03:49:01 +0000
3+++ plugins/unityshell/src/LauncherIcon.cpp 2012-01-11 12:20:03 +0000
4@@ -601,7 +601,7 @@
5 * shwing the icon quicklist. */
6 if (win_manager->IsExpoActive())
7 {
8- on_expo_terminated_connection = win_manager->terminate_expo.connect([&]() {
9+ on_expo_terminated_connection = win_manager->terminate_expo.connect([&, tip_x, tip_y]() {
10 QuicklistManager::Default()->ShowQuicklist(_quicklist, tip_x, tip_y);
11 on_expo_terminated_connection.disconnect();
12 });

Subscribers

People subscribed via source and target branches