lp:~3v1n0/unity/quicklist-hide-fix

Branch merges

Propose for merging

Merged into lp:unity at revision 1514

Gord Allott (community): Approve on 2011-09-08

Diff: 513 lines (+200/-114)

3 files modified

plugins/unityshell/src/BamfLauncherIcon.cpp (+193/-113)
plugins/unityshell/src/BamfLauncherIcon.h (+4/-1)
plugins/unityshell/src/LauncherIcon.cpp (+3/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #801413: Unity crashes if you open a quicklist and then the corresponding launcher icon closes	Medium	Fix Released
Bug #843425: Quicklist can't be correctly hidden	Low	Fix Released

Link a bug report

Related blueprints

1502. By Marco Trevisan (Treviño) on 2011-09-07

LauncherIcon: Hide a visible quicklist when removing the Icon

If a LauncherIcon has been removed while its quicklist is still showing,
unity crashes since it's still listening for events waiting a click
outside the quicklist. Hiding it before removing the icon fixes it.

This fixes bug #801413

1501. By Marco Trevisan (Treviño) on 2011-09-07

BamfLauncherIcon: Fixed some MenuItems memory leaks

Keeping pointers of all other menu-items we use in the quicklist
to avoid to re-create them on every icon right-click (each time
the quicklist is shown).

All the used menu_items are now also unreferenced when the Launcher Icon
is destructed.

1500. By Marco Trevisan (Treviño) on 2011-09-07

Update .desktop file quicklist on file modification

Monitor for desktop file changes and reload the launcher quicklist
on file edit. Also the monitor is updated when the linked desktop file
changes (that's BAMF responsability).

Plus, don't update the cached desktop file if not needed and always use
DesktopFile() to get it.

1499. By Marco Trevisan (Treviño) on 2011-09-07

BamfLauncherIcon: Don't show quicklist items if they aren't visible.

A quicklist menu or a quicklist menuitem shouldn't be considered if not visible
at all. This would cause to show just a separator leading to bug #843425

1498. By Jason Smith on 2011-09-07

Revert commit 1496, can cause cycling in layouts

1497. By Jay Taoko on 2011-09-06

Round corners in Dash and Alt+Tab

1496. By Robert Carr on 2011-09-06

Merge: lp:~robertcarr/unity/rightalign-filter

1495. By Robert Carr on 2011-09-06

Merge lp:~robertcarr/unity/showdesktop-desktop-focus

1494. By Didier Roche-Tolomelli on 2011-09-06

replace ubuntuonecontrol-panel-gtk with ubuntuone-installer as requested per ubuntuone team

1493. By Alejandro Piñeiro on 2011-09-06

a11y: Adding a missing g_object_ref and some extra NULL checks

Fixes launchpad bug 817477