Merge lp:~3v1n0/unity/panel-shadow-fullscreen-fix into lp:unity

[Marco Trevisan (Treviño)]

UnityWindow: don't draw the panel shadow above a fullscreen window.

Full screen windows occupy the entire output geometry, so we don't ever need to draw the panel shadow above it.

Proposed for trunk as it doesn't interfere with the 100 scopes branch.

[Andrea Azzarone (azzar1)]

Works here.

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-autolanding/23/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-amd64-autolanding/23
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-raring-armhf-autolanding/23/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-i386-autolanding/23

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3311
http://jenkins.qa.ubuntu.com/job/unity-ci/35/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-amd64-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-armhf-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-i386-ci/35

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-ci/35/rebuild

review: Approve (continuous-integration)

=== modified file 'plugins/unityshell/src/unityshell.cpp'
--- plugins/unityshell/src/unityshell.cpp	2013-04-16 22:11:24 +0000
+++ plugins/unityshell/src/unityshell.cpp	2013-04-23 17:13:36 +0000
@@ -2302,8 +2302,6 @@
 
   if (p)
   {
-    MultiActionList expoActions;
-
     for (CompOption& option : p->vTable->getOptions())
     {
       if (option.name() == "close_window_key")
@@ -2624,7 +2622,9 @@
       {
         draw_panel_shadow = DrawPanelShadow::BELOW_WINDOW;
 
-        if (!(window->state() & MAXIMIZE_STATE))
+        if (!(window->state() & CompWindowStateMaximizedVertMask) &&
+            !(window->state() & CompWindowStateFullscreenMask) &&
+            !(window->type() & CompWindowTypeFullscreenMask))
         {
           auto const& output = uScreen->screen->currentOutputDev();