Merge lp:~3v1n0/unity/launcher-dnd-icon-damage-fix-5.0 into lp:unity

Proposed by Marco Trevisan (Treviño)
Status: Superseded
Proposed branch: lp:~3v1n0/unity/launcher-dnd-icon-damage-fix-5.0
Merge into: lp:unity
Diff against target: 14016 lines (+10416/-224) (has conflicts)
107 files modified
AUTHORS (+10/-0)
CMakeLists.txt (+5/-0)
ChangeLog (+2135/-0)
UnityCore/GLibSignal.h (+7/-0)
dash/DashController.cpp (+28/-3)
dash/DashView.cpp (+28/-0)
dash/PlacesGroup.cpp (+6/-0)
dash/ResultViewGrid.cpp (+63/-0)
dash/ResultViewGrid.h (+24/-1)
hud/HudButton.cpp (+41/-0)
hud/HudButton.h (+25/-0)
hud/HudController.cpp (+40/-1)
hud/HudController.h (+24/-6)
hud/HudView.cpp (+73/-7)
hud/HudView.h (+26/-0)
launcher/AbstractLauncherIcon.h (+6/-0)
launcher/BamfLauncherIcon.cpp (+109/-0)
launcher/BamfLauncherIcon.h (+7/-0)
launcher/DeviceLauncherIcon.cpp (+58/-1)
launcher/DeviceLauncherIcon.h (+19/-1)
launcher/DeviceLauncherSection.cpp (+75/-0)
launcher/DeviceLauncherSection.h (+21/-0)
launcher/DndData.cpp (+14/-0)
launcher/EdgeBarrierController.cpp (+38/-1)
launcher/EdgeBarrierController.h (+6/-0)
launcher/Launcher.cpp (+257/-6)
launcher/Launcher.h (+22/-0)
launcher/LauncherController.cpp (+56/-2)
launcher/LauncherIcon.cpp (+50/-10)
launcher/LauncherIcon.h (+8/-0)
launcher/QuicklistView.cpp (+105/-1)
launcher/QuicklistView.h (+5/-0)
launcher/SimpleLauncherIcon.cpp (+12/-0)
launcher/SimpleLauncherIcon.h (+7/-0)
launcher/SoftwareCenterLauncherIcon.cpp (+19/-6)
launcher/StandaloneLauncher.cpp (+17/-0)
launcher/SwitcherController.cpp (+35/-0)
launcher/SwitcherController.h (+5/-0)
launcher/SwitcherView.h (+8/-0)
manual-tests/Dash.txt (+60/-29)
manual-tests/Launcher.txt (+156/-1)
manual-tests/Panel.txt (+17/-0)
manual-tests/ShortcutsOverlay.txt (+1/-0)
manual-tests/SoftwareCenter.txt (+211/-104)
manual-tests/Switcher.txt (+60/-0)
manual-tests/WindowButtons.txt (+14/-0)
manual-tests/WindowManagement.txt (+23/-0)
panel/PanelView.cpp (+10/-0)
plugins/unityshell/src/HudAbstractView.cpp (+33/-0)
plugins/unityshell/src/HudAbstractView.h (+66/-0)
plugins/unityshell/src/LauncherControllerPrivate.h (+160/-0)
plugins/unityshell/src/ScreenEffectFramebufferObject.cpp (+6/-0)
plugins/unityshell/src/UnityGestureBroker.cpp (+247/-0)
plugins/unityshell/src/compizminimizedwindowhandler.h (+10/-0)
plugins/unityshell/src/unityshell.cpp (+263/-0)
plugins/unityshell/src/unityshell.h (+24/-0)
standalone-clients/CMakeLists.txt.OTHER (+574/-0)
tests/CMakeLists.txt (+123/-0)
tests/autopilot/autopilot/emulators/bamf.py.OTHER (+411/-0)
tests/autopilot/autopilot/keybindings.py.OTHER (+259/-0)
tests/autopilot/autopilot/matchers/__init__.py (+31/-0)
tests/autopilot/autopilot/utilities.py.OTHER (+78/-0)
tests/autopilot/unity/emulators/__init__.py (+289/-0)
tests/autopilot/unity/emulators/dash.py (+8/-0)
tests/autopilot/unity/emulators/hud.py (+5/-0)
tests/autopilot/unity/emulators/icons.py (+6/-0)
tests/autopilot/unity/emulators/launcher.py (+54/-1)
tests/autopilot/unity/emulators/tooltip.py (+23/-0)
tests/autopilot/unity/emulators/window_manager.py (+25/-0)
tests/autopilot/unity/tests/__init__.py (+274/-0)
tests/autopilot/unity/tests/test_command_lens.py (+8/-0)
tests/autopilot/unity/tests/test_dash.py (+119/-6)
tests/autopilot/unity/tests/test_home_lens.py (+12/-0)
tests/autopilot/unity/tests/test_hud.py (+148/-0)
tests/autopilot/unity/tests/test_ibus.py (+79/-0)
tests/autopilot/unity/tests/test_launcher.py.OTHER (+999/-0)
tests/autopilot/unity/tests/test_panel.py (+351/-1)
tests/autopilot/unity/tests/test_quicklist.py (+303/-0)
tests/autopilot/unity/tests/test_shortcut_hint.py (+30/-9)
tests/autopilot/unity/tests/test_switcher.py (+24/-0)
tests/test-gestures/CMakeLists.txt (+6/-0)
tests/test-gestures/compiz_mock/core/screen.h (+30/-0)
tests/test-gestures/test_gesture_broker.cpp (+140/-0)
tests/test_hud_button.cpp (+76/-0)
tests/test_hud_controller.cpp (+87/-0)
tests/test_hud_private.cpp (+80/-0)
tests/test_hud_view.cpp (+74/-0)
tests/test_im_text_entry.cpp (+173/-0)
tests/test_launcher_controller.cpp (+205/-0)
tests/test_main.cpp (+9/-0)
tests/test_resultviewgrid.cpp (+103/-0)
tests/test_switcher_controller.cpp (+14/-0)
unity-shared/IMTextEntry.cpp (+81/-0)
unity-shared/IMTextEntry.h (+13/-0)
unity-shared/IconTexture.cpp (+2/-0)
unity-shared/IconTexture.h (+4/-0)
unity-shared/OverlayRenderer.cpp (+10/-0)
unity-shared/PluginAdapterCompiz.cpp (+16/-0)
unity-shared/SearchBar.cpp (+18/-4)
unity-shared/StaticCairoText.cpp (+34/-0)
unity-shared/StaticCairoText.h (+4/-0)
unity-shared/UBusMessages.h (+5/-0)
unity-shared/UScreen.cpp (+82/-8)
unity-shared/UScreen.h (+19/-0)
unity-shared/UnityWindowView.h (+5/-0)
unity-shared/WindowManager.cpp (+32/-15)
unity-shared/WindowManager.h (+6/-0)
Text conflict in AUTHORS
Text conflict in CMakeLists.txt
Text conflict in ChangeLog
Text conflict in UnityCore/GLibSignal.h
Text conflict in dash/DashController.cpp
Text conflict in dash/DashView.cpp
Text conflict in dash/PlacesGroup.cpp
Text conflict in dash/ResultViewGrid.cpp
Text conflict in dash/ResultViewGrid.h
Text conflict in hud/HudButton.cpp
Text conflict in hud/HudButton.h
Text conflict in hud/HudController.cpp
Text conflict in hud/HudController.h
Path conflict: hud/HudPrivate.cpp / plugins/unityshell/src/HudPrivate.cpp
Path conflict: hud/HudPrivate.h / plugins/unityshell/src/HudPrivate.h
Text conflict in hud/HudView.cpp
Text conflict in hud/HudView.h
Text conflict in launcher/AbstractLauncherIcon.h
Text conflict in launcher/BamfLauncherIcon.cpp
Text conflict in launcher/BamfLauncherIcon.h
Text conflict in launcher/DeviceLauncherIcon.cpp
Text conflict in launcher/DeviceLauncherIcon.h
Text conflict in launcher/DeviceLauncherSection.cpp
Text conflict in launcher/DeviceLauncherSection.h
Text conflict in launcher/DndData.cpp
Text conflict in launcher/EdgeBarrierController.cpp
Text conflict in launcher/EdgeBarrierController.h
Text conflict in launcher/Launcher.cpp
Text conflict in launcher/Launcher.h
Text conflict in launcher/LauncherController.cpp
Path conflict: launcher/LauncherControllerPrivate.h / plugins/unityshell/src/LauncherControllerPrivate.h
Text conflict in launcher/LauncherIcon.cpp
Text conflict in launcher/LauncherIcon.h
Text conflict in launcher/QuicklistView.cpp
Text conflict in launcher/QuicklistView.h
Text conflict in launcher/SimpleLauncherIcon.cpp
Text conflict in launcher/SimpleLauncherIcon.h
Text conflict in launcher/SoftwareCenterLauncherIcon.cpp
Text conflict in launcher/StandaloneLauncher.cpp
Text conflict in launcher/SwitcherController.cpp
Text conflict in launcher/SwitcherController.h
Text conflict in launcher/SwitcherView.h
Text conflict in manual-tests/Dash.txt
Text conflict in manual-tests/Launcher.txt
Text conflict in manual-tests/SoftwareCenter.txt
Text conflict in manual-tests/Switcher.txt
Text conflict in manual-tests/WindowButtons.txt
Text conflict in manual-tests/WindowManagement.txt
Text conflict in panel/PanelView.cpp
Text conflict in plugins/unityshell/src/LauncherControllerPrivate.h
Text conflict in plugins/unityshell/src/ScreenEffectFramebufferObject.cpp
Text conflict in plugins/unityshell/src/UnityGestureBroker.cpp
Text conflict in plugins/unityshell/src/compizminimizedwindowhandler.h
Text conflict in plugins/unityshell/src/unityshell.cpp
Text conflict in plugins/unityshell/src/unityshell.h
Conflict adding files to standalone-clients.  Created directory.
Conflict because standalone-clients is not versioned, but has versioned children.  Versioned directory.
Contents conflict in standalone-clients/CMakeLists.txt
Text conflict in tests/CMakeLists.txt
Conflict adding files to tests/autopilot/autopilot.  Created directory.
Conflict because tests/autopilot/autopilot is not versioned, but has versioned children.  Versioned directory.
Conflict adding files to tests/autopilot/autopilot/emulators.  Created directory.
Conflict because tests/autopilot/autopilot/emulators is not versioned, but has versioned children.  Versioned directory.
Contents conflict in tests/autopilot/autopilot/emulators/bamf.py
Contents conflict in tests/autopilot/autopilot/keybindings.py
Contents conflict in tests/autopilot/autopilot/utilities.py
Text conflict in tests/autopilot/unity/emulators/__init__.py
Text conflict in tests/autopilot/unity/emulators/dash.py
Text conflict in tests/autopilot/unity/emulators/hud.py
Text conflict in tests/autopilot/unity/emulators/icons.py
Text conflict in tests/autopilot/unity/emulators/launcher.py
Text conflict in tests/autopilot/unity/emulators/tooltip.py
Text conflict in tests/autopilot/unity/emulators/window_manager.py
Text conflict in tests/autopilot/unity/tests/__init__.py
Text conflict in tests/autopilot/unity/tests/test_command_lens.py
Text conflict in tests/autopilot/unity/tests/test_dash.py
Text conflict in tests/autopilot/unity/tests/test_home_lens.py
Text conflict in tests/autopilot/unity/tests/test_hud.py
Text conflict in tests/autopilot/unity/tests/test_ibus.py
Contents conflict in tests/autopilot/unity/tests/test_launcher.py
Text conflict in tests/autopilot/unity/tests/test_panel.py
Text conflict in tests/autopilot/unity/tests/test_quicklist.py
Text conflict in tests/autopilot/unity/tests/test_shortcut_hint.py
Text conflict in tests/autopilot/unity/tests/test_switcher.py
Text conflict in tests/test-gestures/CMakeLists.txt
Text conflict in tests/test-gestures/compiz_mock/core/screen.h
Text conflict in tests/test-gestures/test_gesture_broker.cpp
Text conflict in tests/test_hud_button.cpp
Conflict adding file tests/test_hud_controller.cpp.  Moved existing file to tests/test_hud_controller.cpp.moved.
Text conflict in tests/test_hud_private.cpp
Conflict adding file tests/test_hud_view.cpp.  Moved existing file to tests/test_hud_view.cpp.moved.
Text conflict in tests/test_im_text_entry.cpp
Text conflict in tests/test_launcher_controller.cpp
Text conflict in tests/test_main.cpp
Conflict adding file tests/test_resultviewgrid.cpp.  Moved existing file to tests/test_resultviewgrid.cpp.moved.
Text conflict in tests/test_switcher_controller.cpp
Text conflict in unity-shared/IMTextEntry.cpp
Text conflict in unity-shared/IMTextEntry.h
Text conflict in unity-shared/IconTexture.h
Text conflict in unity-shared/OverlayRenderer.cpp
Text conflict in unity-shared/PluginAdapterCompiz.cpp
Text conflict in unity-shared/SearchBar.cpp
Text conflict in unity-shared/StaticCairoText.cpp
Text conflict in unity-shared/StaticCairoText.h
Text conflict in unity-shared/UBusMessages.h
Text conflict in unity-shared/UScreen.cpp
Text conflict in unity-shared/UScreen.h
Text conflict in unity-shared/UnityWindowView.h
Text conflict in unity-shared/WindowManager.cpp
Text conflict in unity-shared/WindowManager.h
To merge this branch: bzr merge lp:~3v1n0/unity/launcher-dnd-icon-damage-fix-5.0
Reviewer Review Type Date Requested Status
Unity Team Pending
Review via email: mp+118145@code.launchpad.net

This proposal has been superseded by a proposal from 2012-08-03.

Commit message

unityshell: correctly damage the LauncherDragWindow region

Description of the change

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'AUTHORS'
2--- AUTHORS 2012-07-09 07:51:54 +0000
3+++ AUTHORS 2012-08-03 16:26:24 +0000
4@@ -24,9 +24,13 @@
5 Brandon Schaefer <brandontschaefer@gmail.com>, Thomi Richards <thomi.richards@canonical.com>
6 Brandon Schaefer <schbra02@evergreen.edu>
7 Chase Douglas <chase.douglas@canonical.com>
8+<<<<<<< TREE
9 Christopher James Halse Rogers <raof@ubuntu.com>
10 Christopher Lee <chris.lee@canonical.com>
11 Christopher Lee <veebers@gmail.com>
12+=======
13+ Christopher James Halse Rogers <raof@ubuntu.com>
14+>>>>>>> MERGE-SOURCE
15 Chris Coulson <chris.coulson@canonical.com>
16 Daniel d'Andrada <daniel.dandrada@canonical.com>
17 Daniel van Vugt <vanvugt@gmail.com>
18@@ -37,6 +41,7 @@
19 Didier Roche <didrocks@ubuntu.com>
20 foxoman <foxoman.u@gmail.com>
21 Gabor Kelemen <kelemeng@ubuntu.com>
22+ Gary Lasker <gary.lasker@canonical.com>
23 Gordon Allott <gord.allott@canonical.com>
24 Henri De Veene <henri.deveene@gmail.com>
25 Jani Monoses <jani.monoses@canonical.com>
26@@ -111,9 +116,14 @@
27 Thomi Richards <thomir@gmail.com>, Alex Launi <alex.launi@canonical.com>
28 Thomi Richards <thomir@gmail.com>, Thomi Richards <thomi.richards@canonical.com>
29 Thomi Richards <thomi.richards@canonical.com>
30+<<<<<<< TREE
31 Thomi Richards <thomi.richards@canonical.com>, Albert Astals <albert.astals@canonical.com>
32 Thomi Richards <thomi.richards@canonical.com>, Alex Launi <alex.launi@canonical.com>
33 Thomi Richards <thomi.richards@canonical.com>, Brandon Schaefer <brandontschaefer@gmail.com>
34+=======
35+ Thomi Richards <thomi.richards@canonical.com>, Alex Launi <alex.launi@canonical.com>
36+ Thomi Richards <thomi.richards@canonical.com>, Brandon Schaefer <brandontschaefer@gmail.com>
37+>>>>>>> MERGE-SOURCE
38 Thomi Richards <thomi.richards@canonical.com>, Gordon Allott <gord.allott@canonical.com>
39 Thomi Richards <thomi.richards@canonical.com>, Jason Smith <jason.smith@canonical.com>
40 Thomi Richards <thomi.richards@canonical.com>, Miklos Juhasz <juhasz.miklos.1@gmail.com>
41
42=== modified file 'CMakeLists.txt'
43--- CMakeLists.txt 2012-08-03 12:51:02 +0000
44+++ CMakeLists.txt 2012-08-03 16:26:24 +0000
45@@ -7,8 +7,13 @@
46 # Base bits
47 #
48 set (PROJECT_NAME "unity")
49+<<<<<<< TREE
50 set (UNITY_MAJOR 6)
51 set (UNITY_MINOR 0)
52+=======
53+set (UNITY_MAJOR 5)
54+set (UNITY_MINOR 14)
55+>>>>>>> MERGE-SOURCE
56 set (UNITY_MICRO 0)
57 set (UNITY_VERSION "${UNITY_MAJOR}.${UNITY_MINOR}.${UNITY_MICRO}")
58 set (UNITY_API_VERSION "6.0")
59
60=== modified file 'ChangeLog'
61--- ChangeLog 2012-07-09 07:51:54 +0000
62+++ ChangeLog 2012-08-03 16:26:24 +0000
63@@ -1,3 +1,4 @@
64+<<<<<<< TREE
65 2012-07-09 Thomi Richards <thomi.richards@canonical.com>
66
67 Fix several intermittently failing tests.. Fixes: . Approved by Tim Penhey.
68@@ -5080,6 +5081,2140 @@
69
70 Release\ 5.10.0
71
72+=======
73+2012-07-18 Gary Lasker <gary.lasker@canonical.com>
74+
75+ manual-tests/SoftwareCenter.txt: added tests for Ubuntu Software Center/Unity launcher integration feature. Fixes: . Approved by Marco Trevisan (Treviño), Brandon Schaefer, Christopher Lee.
76+
77+2012-07-12 Gary Lasker <gary.lasker@canonical.com>
78+
79+ clarify the steps for selecting a game (many thanks Christopher Lee)
80+
81+2012-07-10 Gary Lasker <gary.lasker@canonical.com>
82+
83+ targeted to the 5.0 series branch, update Unity launcher Software Center integration manual tests and provide additional important test cases to thoroughly test the full set of integration details, including all of the bug fixes for Unity branch https://code.launchpad.net/~bilalakhtar/unity/5.0series-sru-software-center-integration-fixes/+merge/110214 and the corresponding Software Center branch https://code.launchpad.net/~gary-lasker/software-center/unity-launcher-integration-fixes
84+
85+2012-07-17 Andrea Azzarone <azzaronea@gmail.com>
86+
87+ Backport lp:~thomir/unity/fix-for-754565. Fixes: https://bugs.launchpad.net/bugs/754565. Approved by Marco Trevisan (Treviño).
88+
89+2012-07-16 Andrea Azzarone <azzaronea@gmail.com>
90+
91+ Minor changes.
92+
93+2012-07-16 Andrea Azzarone <azzaronea@gmail.com>
94+
95+ Backport AP test.
96+
97+2012-07-16 Andrea Azzarone <azzaronea@gmail.com>
98+
99+ Backport lp:~yeganeh/unity/fix-for-754565.
100+
101+2011-09-30 Zaid Yeganeh <zaid.yeganeh@gmail.com>
102+
103+ [unityshell] Added key modifier/flags to the mouse events of launcher icons, and added logic for shift+click = new instance
104+
105+ modified:
106+ plugins/unityshell/src/AbstractLauncherIcon.h
107+ - Added flags to the mouse events
108+
109+ plugins/unityshell/src/Launcher.cpp
110+ - Pass through key flags to launcher icons
111+
112+ plugins/unityshell/src/LauncherIcon.cpp
113+ - Logic added for shift click based on flag state
114+
115+ plugins/unityshell/src/LauncherIcon.h
116+ plugins/unityshell/src/SimpleLauncherIcon.cpp
117+ plugins/unityshell/src/SimpleLauncherIcon.h
118+ - Changed interfaces based on the AbstractLauncherIcon
119+
120+2012-07-17 Bilal Akhtar <bilalakhtar@ubuntu.com>
121+
122+ SoftwareCenterLauncherIcon: avoid the "Waiting to Install" tooltip to stay after installation
123+
124+ Be consistent with auto-hiding launcher.. Fixes: https://bugs.launchpad.net/bugs/925014, https://bugs.launchpad.net/bugs/1002440, https://bugs.launchpad.net/bugs/1012896. Approved by Marco Trevisan (Treviño), Brandon Schaefer, Thomi Richards.
125+
126+2012-06-27 Bilal Akhtar <bilalakhtar@ubuntu.com>
127+
128+ Merge from 5.0 branch
129+
130+2012-06-27 Bilal Akhtar <bilalakhtar@ubuntu.com>
131+
132+ Added test, need to probably fix it though
133+
134+2012-06-20 Bilal Akhtar <bilalakhtar@ubuntu.com>
135+
136+ Fix urgent quirk after installation of paid app
137+
138+2012-06-17 Bilal Akhtar <bilalakhtar@ubuntu.com>
139+
140+ Fixed string comparison, thanks Tim
141+
142+2012-06-13 Bilal Akhtar <bilalakhtar@ubuntu.com>
143+
144+ Fix the delay in adding launcher icons to the launcher by ensuring a redraw takes place (bug #1012896) and also fix the string comparison of desktop file with software-center-agent.
145+
146+2012-06-13 Bilal Akhtar <bilalakhtar@ubuntu.com>
147+
148+ Fix bug #925014 on the Unity side. Check if an aptdaemon task was specified. If not, then the icon tooltip will stay the same (i.e. the app name, rather than Waiting to install)
149+
150+2012-06-13 Bilal Akhtar <bilalakhtar@ubuntu.com>
151+
152+ Fix bug #1002440, by not creating SC launcher icon if the desktop file was unspecified or set to SC's agent, as in the case of paid apps. Instead, the icon will be added at the end of the install
153+
154+2012-07-17 Andrea Azzarone <azzaronea@gmail.com>
155+
156+ Backport lp:~andyrock/unity/fix-987955. Fixes: https://bugs.launchpad.net/bugs/987955. Approved by Marco Trevisan (Treviño).
157+
158+2012-07-03 Andrea Azzarone <azzaronea@gmail.com>
159+
160+ Backport lp:~andyrock/unity/fix-987955.
161+
162+2012-07-16 Brandon Schaefer <brandontschaefer@gmail.com>
163+
164+ Scale mode now does not skip the first super to open the dash.. Fixes: https://bugs.launchpad.net/bugs/1023811. Approved by Marco Trevisan (Treviño).
165+
166+2012-07-13 Brandon Schaefer <brandontschaefer@gmail.com>
167+
168+ * fixes launcher -> scale mode -> dash problem
169+
170+2012-07-13 Andrea Azzarone <azzaronea@gmail.com>
171+
172+ Backport lp:~andyrock/unity/fix-772445. Fixes: https://bugs.launchpad.net/bugs/772445. Approved by Marco Trevisan (Treviño).
173+
174+2012-07-13 Andrea Azzarone <azzaronea@gmail.com>
175+
176+ Minor changes.
177+
178+2012-07-13 Andrea Azzarone <azzaronea@gmail.com>
179+
180+ Merge trunk.
181+
182+2012-07-13 Andrea Azzarone <azzaronea@gmail.com>
183+
184+ Backport lp:~andyrock/unity/fix-772445
185+
186+2012-07-13 Andrea Azzarone <azzaronea@gmail.com>
187+
188+ Backport branch lp:~andyrock/unity/fix-839717. Fixes: https://bugs.launchpad.net/bugs/839717. Approved by Marco Trevisan (Treviño).
189+
190+2012-07-13 Andrea Azzarone <azzaronea@gmail.com>
191+
192+ Backport lp:~andyrock/unity/fix-839717.
193+
194+2012-07-09 Marco Trevisan (Treviño) <mail@3v1n0.net>
195+
196+ KeyboardUtil: fix possible crash if XkbGetKeyboard returns null
197+
198+ Also use initializer list. Fixes: https://bugs.launchpad.net/bugs/920258. Approved by Gord Allott.
199+
200+2012-07-06 Marco Trevisan (Treviño) <mail@3v1n0.net>
201+
202+ KeyboardUtil: fix typo
203+
204+2012-07-06 Marco Trevisan (Treviño) <mail@3v1n0.net>
205+
206+ KeyboardUtil: oops, fix return value.
207+
208+2012-07-06 Marco Trevisan (Treviño) <mail@3v1n0.net>
209+
210+ KeyboardUtil: fix possible crash if XkbGetKeyboard returns null
211+
212+ Also use initializer list
213+
214+2012-07-04 Andrea Azzarone <azzaronea@gmail.com>
215+
216+ Backport lp:~andyrock/unity/fix-932531. Fixes: https://bugs.launchpad.net/bugs/932531. Approved by Tim Penhey.
217+
218+2012-07-03 Andrea Azzarone <azzaronea@gmail.com>
219+
220+ Backport lp:~andyrock/unity/fix-932531.
221+
222+2012-07-04 Andrea Azzarone <azzaronea@gmail.com>
223+
224+ Backport lp:~andyrock/unity/fix-bug-955158. Fixes: https://bugs.launchpad.net/bugs/955158. Approved by Tim Penhey.
225+
226+2012-07-04 Andrea Azzarone <azzaronea@gmail.com>
227+
228+ Remove default_item_layout/list.
229+
230+2012-07-03 Andrea Azzarone <azzaronea@gmail.com>
231+
232+ Backport lp:~andyrock/unity/fix-bug-955158.
233+
234+2012-07-03 Andrea Azzarone <azzaronea@gmail.com>
235+
236+ Backport lp:~andyrock/unity/fix-934062. Fixes: https://bugs.launchpad.net/bugs/934062. Approved by Marco Trevisan (Treviño).
237+
238+2012-07-03 Andrea Azzarone <azzaronea@gmail.com>
239+
240+ Backport lp:~andyrock/unity/fix-934062.
241+
242+2012-07-02 Andrea Azzarone <azzaronea@gmail.com>
243+
244+ Backport lp:~andyrock/unity/fix-851982.. Fixes: https://bugs.launchpad.net/bugs/851982. Approved by Brandon Schaefer.
245+
246+2012-07-02 Andrea Azzarone <azzaronea@gmail.com>
247+
248+ Backport lp:~andyrock/unity/fix-851982
249+
250+2012-06-29 Marco Trevisan (Treviño) <mail@3v1n0.net>
251+
252+ PluginAdapterCompiz: ignore offscreen windows when looking for the top one. Fixes: https://bugs.launchpad.net/bugs/996604. Approved by Brandon Schaefer.
253+
254+2012-06-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
255+
256+ test_launcher: add autopilot test to check spread initialization on double click
257+
258+2012-06-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
259+
260+ PluginAdapterCompiz: ignore offscreen windows when looking for the top one
261+
262+2012-06-29 Didier Roche <didier.roche@canonical.com>
263+
264+ Fix a crash when a GError exception is triggered. Fixes: https://bugs.launchpad.net/bugs/778470. Approved by Sam Spilsbury.
265+
266+2012-06-28 Didier Roche <didier.roche@canonical.com>
267+
268+ import glib for handling the GError (LP: #778470)
269+
270+2012-06-28 Marco Trevisan (Treviño) <mail@3v1n0.net>
271+
272+ DashView: filter out the unprintable keys when focusing the search bar
273+
274+ The search bar can't be focused when invalid keys (such as shift, ctrl, F1...) are pressed.. Fixes: https://bugs.launchpad.net/bugs/931393. Approved by Andrea Azzarone.
275+
276+2012-06-28 Marco Trevisan (Treviño) <mail@3v1n0.net>
277+
278+ DashView: filter out the unprintable keys when focusing the search bar
279+
280+ The search bar can't be focused when invalid keys (such as shift, ctrl, F1...) are pressed...
281+
282+2012-06-28 Andrea Azzarone <azzaronea@gmail.com>
283+
284+ Backport lp:~andyrock/unity/fix-1016239. Fixes: https://bugs.launchpad.net/bugs/1016239. Approved by Marco Trevisan (Treviño).
285+
286+2012-06-27 Andrea Azzarone <azzaronea@gmail.com>
287+
288+ Backport lp:~andyrock/unity/fix-1016239
289+
290+2012-06-27 Brandon Schaefer <brandontschaefer@gmail.com>
291+
292+ The dash will now open when invoked while in spread/scale mode.. Fixes: https://bugs.launchpad.net/bugs/944033. Approved by Thomi Richards.
293+
294+2012-06-26 Brandon Schaefer <brandontschaefer@gmail.com>
295+
296+ * Fixes opening the dash when in scale mode
297+
298+2012-06-25 Brandon Schaefer <brandontschaefer@gmail.com>
299+
300+ The switcher now focuses it's own window, instead of leaving it to the current one. Now Alt+F4 does not work while the switcher is active.. Fixes: . Approved by Thomi Richards.
301+
302+2012-06-25 Brandon Schaefer <brandontschaefer@gmail.com>
303+
304+ * SRU fix for alt+f4 re opening a program while using the switcher.
305+
306+2012-06-25 Brandon Schaefer <brandontschaefer@gmail.com>
307+
308+ Fixes closing the shurnk Hud when clicking outside it's geometry.. Fixes: https://bugs.launchpad.net/bugs/962651. Approved by Thomi Richards.
309+
310+2012-06-25 Brandon Schaefer <brandontschaefer@gmail.com>
311+
312+ * switched close and it...
313+
314+2012-06-25 Brandon Schaefer <brandontschaefer@gmail.com>
315+
316+ * ap and minor fixes
317+
318+2012-06-22 Brandon Schaefer <brandontschaefer@gmail.com>
319+
320+ * Hud will close when clicking anywhere outside of it's current geo (including being shrunk)
321+
322+2012-06-25 Andrea Azzarone <azzaronea@gmail.com>
323+
324+ Backport lp:~andyrock/unity/fix-994163. Fixes: https://bugs.launchpad.net/bugs/994163. Approved by Łukasz Zemczak.
325+
326+2012-06-22 Andrea Azzarone <azzaronea@gmail.com>
327+
328+ Backport lp:~andyrock/unity/fix-994163.
329+
330+2012-06-22 Brandon Schaefer <brandontschaefer@gmail.com>
331+
332+ Fixes AP test, get_compiz_option wasn't included in utilities.. Fixes: . Approved by Thomi Richards.
333+
334+2012-06-21 Brandon Schaefer <brandontschaefer@gmail.com>
335+
336+ * fixes ap test get_compiz_option wasn't in 5.0
337+
338+2012-06-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
339+
340+ IMTextEntry: don't ingore ctrl/alt keypress to make ibus still working. Fixes: . Approved by Brandon Schaefer.
341+
342+2012-06-22 Marco Trevisan (Treviño) <mail@3v1n0.net>
343+
344+ IMTextEntry: don't ingore ctrl/alt keypress to make ibus still working
345+
346+2012-06-21 Brandon Schaefer <brandontschaefer@gmail.com>
347+
348+ Fixes focus problem when entering expo mode from KeyNav(Alt+F1).. Fixes: https://bugs.launchpad.net/bugs/962408. Approved by Marco Trevisan (Treviño).
349+
350+2012-06-21 Brandon Schaefer <brandontschaefer@gmail.com>
351+
352+ * Fixes going into expo mode from key nav mode (alt+f1)
353+
354+2012-06-21 Brandon Schaefer <brandontschaefer@gmail.com>
355+
356+ Documents and files now dragged from the Dash to the Launcher into an application will close the dash.. Fixes: https://bugs.launchpad.net/bugs/865168. Approved by Marco Trevisan (Treviño).
357+
358+2012-06-21 Brandon Schaefer <brandontschaefer@gmail.com>
359+
360+ * Dragging documents and files to an app on the launcher closes the dash.
361+
362+2012-06-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
363+
364+ IMTextEntry: ignore invalid keypress when using modifiers keys.
365+
366+ All the key pressure when pressing the Alt or Super key should be ignored.
367+ When pressing Ctrl key we should only allow: A key, arrow keys, Backspace or Delete keys and Home or Delete keys.. Fixes: https://bugs.launchpad.net/bugs/1013751. Approved by .
368+
369+2012-06-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
370+
371+ test_im_text_entry: fix the IMTextEntry inclusion
372+
373+2012-06-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
374+
375+ IMTextEntry: ignore invalid keypress when using modifiers keys.
376+
377+ All the key pressure when pressing the Alt or Super key should be ignored.
378+ When pressing Ctrl key we should only allow: A key, arrow keys, Backspace or
379+ Delete keys and Home or Delete keys.
380+
381+2012-06-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
382+
383+ DashController / HudController: hide the overlay when the spread is initiated. Fixes: https://bugs.launchpad.net/bugs/870284. Approved by .
384+
385+2012-06-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
386+
387+ autopilot, added tests for Dash and Hud on spread
388+
389+2012-06-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
390+
391+ HudController: hide the HUD when the spread is initiated
392+
393+2012-06-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
394+
395+ DashController: hide the dash when spread is initiated
396+
397+2012-06-19 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
398+
399+ Cherry-picked from unity trunk (rev2407):
400+ Launcher: Fix dragging to the last position when out of the launcher. Fixes: https://bugs.launchpad.net/bugs/971421. Approved by Marco Trevisan (Treviño).
401+
402+2012-06-18 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
403+
404+ Cherry-picked from unity trunk (rev2407):
405+ Launcher: Fix dragging to the last position when out of the launcher
406+
407+2012-06-17 Andrea Azzarone <azzaronea@gmail.com>
408+
409+ Backport lp:~andyrock/unity/fix-987674. Fixes: https://bugs.launchpad.net/bugs/987674. Approved by Tim Penhey.
410+
411+2012-06-15 Andrea Azzarone <azzaronea@gmail.com>
412+
413+ Fix bug 987674.
414+
415+2012-06-17 Andrea Azzarone <azzaronea@gmail.com>
416+
417+ Backport lp:~andyrock/unity/hud-reset
418+ . Fixes: https://bugs.launchpad.net/bugs/1011507. Approved by Tim Penhey.
419+
420+2012-06-15 Andrea Azzarone <azzaronea@gmail.com>
421+
422+ Add missing files.
423+
424+2012-06-15 Andrea Azzarone <azzaronea@gmail.com>
425+
426+ Backport lp:~andyrock/unity/hud-reset.
427+
428+2012-06-06 Andrea Azzarone <azzaronea@gmail.com>
429+
430+ Backport lp:~andyrock/unity/fix-1008656.. Fixes: https://bugs.launchpad.net/bugs/1008656. Approved by Łukasz Zemczak.
431+
432+2012-06-06 Andrea Azzarone <azzaronea@gmail.com>
433+
434+ Backport lp:~andyrock/unity/fix-1008656.
435+
436+2012-06-06 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
437+
438+ Back-porting fix from unity trunk.
439+ When dragging a non-application, do not saturate all icons automatically, but only those that are needed.
440+
441+ Eliminates flickering before 'prelighting' the Launcher icons that can handle the current drag-and-drop (LP #863230).. Fixes: https://bugs.launchpad.net/bugs/863230. Approved by .
442+
443+2012-06-06 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
444+
445+ When dragging a non-application, do not saturate all icons automatically, but only those that are needed.
446+
447+ Eliminates flickering before 'prelighting' the Launcher icons that can handle the current drag-and-drop (LP #863230)
448+
449+2012-06-06 Andrea Azzarone <azzaronea@gmail.com>
450+
451+ Draw the result grid in proximity of the search entry. Backport lp:~andyrock/unity/fix-1008603. Fixes: https://bugs.launchpad.net/bugs/1008603. Approved by Łukasz Zemczak.
452+
453+2012-06-06 Andrea Azzarone <azzaronea@gmail.com>
454+
455+ Backport lp:~andyrock/unity/fix-1008603
456+
457+2012-06-06 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
458+
459+ Back-porting fix from unity trunk.
460+ Don't show the switcher window during constructing the view. Wait for the ShowView timeout.. Fixes: https://bugs.launchpad.net/bugs/987156. Approved by Tim Penhey.
461+
462+2012-06-05 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
463+
464+ Added two manual-tests for testing the fixed behavior. Better have everything well tested.
465+
466+2012-06-05 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
467+
468+ Added a unit test for the switcher show functionality. The same as in the previous proposition.
469+
470+2012-06-05 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
471+
472+ Don't show the switcher window during constructing the view. Wait for the show timeout.
473+
474+2012-06-04 Andrea Azzarone <azzaronea@gmail.com>
475+
476+ Backports branch lp:~andyrock/unity/hud-text.. Fixes: https://bugs.launchpad.net/bugs/939436. Approved by Tim Penhey.
477+
478+2012-05-31 Andrea Azzarone <azzaronea@gmail.com>
479+
480+ Backport lp:~andyrock/unity/hud-text.
481+
482+2012-05-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
483+
484+ BamfLauncherIcon: Unset the BamfApplication when removing the icon.
485+
486+ Doing this manually, we prevent that a duplicated application can be added between the removal of the BamfLauncherIcon and the effective destruction (that is controlled by a timeout in LauncherModel).. Fixes: https://bugs.launchpad.net/bugs/1003574. Approved by .
487+
488+2012-05-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
489+
490+ LauncherController: use glib::Signal to handle the Bamf matcher signal.
491+
492+2012-05-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
493+
494+ BamfLauncherIcon: Disconnect all the _bamf_app signals at once on removal.
495+
496+2012-05-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
497+
498+ GLib::SignalManager: allow to disconnect all the signals for a given Object.
499+
500+ When the signal string name is empty, we disconnect all the sigals
501+ for the given object.
502+
503+2012-05-24 Gord Allott <gord.allott@canonical.com>
504+
505+ * Capture information about the icon of the application to be installed from the software center. Re-use it when rendering the launcher interface.
506+ * Fix bug #981168. Fixes: https://bugs.launchpad.net/bugs/981168. Approved by Gord Allott.
507+
508+2012-05-24 Gord Allott <gord.allott@canonical.com>
509+
510+ fixed up memory leaks
511+
512+2012-04-17 Jay Taoko <jay.taoko@canonical.com>
513+
514+ * Capture information about the icon of the application to be installed from the software center. Re-use it when rendering the launcher interface.
515+
516+2012-04-16 Jay Taoko <jay.taoko@canonical.com>
517+
518+ * Capture part of the content of Launcher::handle_dbus_method_call into a lambda call.
519+
520+2012-05-23 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
521+
522+ Backported andyrock's fix from lp:unity/6.0 - Unmute launcher (LP: #949448).. Fixes: https://bugs.launchpad.net/bugs/949448. Approved by Andrea Azzarone.
523+
524+2012-05-23 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
525+
526+ Backported andyrock's fix for LP: #949448 from lp:unity/6.0.
527+
528+2012-05-23 Andrea Azzarone <azzaronea@gmail.com>
529+
530+ Backports lp:~andyrock/unity/queue-draw-result-view-grid from lp:unity/6.0.. Fixes: . Approved by Andrea Azzarone, Łukasz Zemczak.
531+
532+2012-05-23 Andrea Azzarone <azzaronea@gmail.com>
533+
534+ Backports branch lp:~andyrock/unity/queue-draw-result-view-grid.
535+
536+2012-05-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
537+
538+ UnityScreen: reduce the BGHash::RefreshColor() calls
539+
540+ Don't call BGHash::RefreshColor() every atom on the XRoot window changes,
541+ do it only when the target one changes. Fixes: . Approved by Andrea Azzarone.
542+
543+2012-05-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
544+
545+ UnityScreen: reduce the BGHash::RefreshColor() calls
546+
547+ Don't call BGHash::RefreshColor() every atom on the XRoot window changes,
548+ do it only when the target one changes.
549+
550+2012-05-23 Andrea Azzarone <azzaronea@gmail.com>
551+
552+ Backports branch lp:~vanvugt/unity/fix-987304.. Fixes: https://bugs.launchpad.net/bugs/987304. Approved by Marco Trevisan (Treviño).
553+
554+2012-05-23 Andrea Azzarone <azzaronea@gmail.com>
555+
556+ Backports branch lp:~vanvugt/unity/fix-987304.
557+
558+2012-05-23 Andrea Azzarone <azzaronea@gmail.com>
559+
560+ Backported fix from lp:unity/6.0 - Dash - search field is hidden by tooltips (LP: #978030).. Fixes: https://bugs.launchpad.net/bugs/978030. Approved by Andrea Azzarone, Łukasz Zemczak.
561+
562+2012-05-23 Andrea Azzarone <azzaronea@gmail.com>
563+
564+ Backports branch lp:~andyrock/unity/fix-978030.
565+
566+2012-04-27 Andrea Azzarone <azzaronea@gmail.com>
567+
568+ Add AP tests.
569+
570+2012-04-27 Andrea Azzarone <azzaronea@gmail.com>
571+
572+ Disable the bfb/hudlaunchericon tooltip when the dash/hud is open.
573+ Hide a launcher icon tooltip as soon as the dash/hud is shown.
574+
575+2012-05-23 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
576+
577+ Backported andyrock's fix from trunk - fix UnityViewWindow background when blur is disabled.. Fixes: . Approved by Gord Allott.
578+
579+2012-05-23 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
580+
581+ Backported andyrock's fix for LP: #989291. Fix UnityViewWindow background when blur is disabled.
582+
583+2012-05-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
584+
585+ Merged branches lp:~3v1n0/unity/launcher-double-icons-tests and lp:~3v1n0/unity/quick-app-reopen-icon-fix. Fixes: https://bugs.launchpad.net/bugs/772063, https://bugs.launchpad.net/bugs/995916, https://bugs.launchpad.net/bugs/999820. Approved by .
586+
587+2012-05-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
588+
589+ Merging fix for "Missing GIMP icon bug"
590+
591+2012-05-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
592+
593+ Merging single-icon AP tests.
594+
595+2012-04-27 Didier Roche <didier.roche@canonical.com>
596+
597+ Release\ 5.12.0
598+
599+2012-04-26 Sebastien Bacher <seb128@ubuntu.com>
600+
601+ Revert r2331, it's creating hang issues on start.. Fixes: . Approved by Didier Roche.
602+
603+2012-04-26 Sebastien Bacher <seb128@ubuntu.com>
604+
605+ Revert r2331, it's creating hang issues on start. The commit is not fixing any
606+ important issue and not needed in the SRU, it can come once the problems have
607+ been resolved.
608+
609+2012-04-26 Michael Vogt <michael.vogt@ubuntu.com>
610+
611+ Check for "exit_state" on the install-finished signal from aptdaemon (LP: #982921) and remove launcher icon again on failure.. Fixes: https://bugs.launchpad.net/bugs/982921. Approved by Tim Penhey.
612+
613+2012-04-26 Michael Vogt <michael.vogt@ubuntu.com>
614+
615+ manual-tests/SoftwareCenter.txt: add manual test for the launcher integration cancel
616+
617+2012-04-17 Michael Vogt <michael.vogt@ubuntu.com>
618+
619+ remove USC launcher again from unity on download/install failure or cancel
620+
621+2012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
622+
623+ We need to flag a bamf view that we control using an icon using the "unity-seen" qdata, or unity will duplicate it on bamfdaemon respawn. (LP: #928912). Fixes: https://bugs.launchpad.net/bugs/928912. Approved by Michal Hruby, Tim Penhey.
624+
625+2012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
626+
627+ autopilot, test_launcher: removed the xclock test... We'll put it back soon.
628+
629+2012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
630+
631+ Merging thomi's fixes
632+
633+2012-04-26 Thomi Richards <thomi.richards@canonical.com>
634+
635+ Added xclock.
636+
637+2012-04-26 Thomi Richards <thomi.richards@canonical.com>
638+
639+ Renamed test methods.
640+
641+2012-04-26 Thomi Richards <thomi.richards@canonical.com>
642+
643+ Removed tautology from the test.
644+
645+2012-04-26 Thomi Richards <thomi.richards@canonical.com>
646+
647+ CLeaned up test.
648+
649+2012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
650+
651+ autopilot, use kill instead of pkill to close applications
652+
653+2012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
654+
655+ BamfLauncherIcon: export the application ID for introspection
656+
657+2012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
658+
659+ autopilot, test_launcher: added test to check the launcher status after bamfdaemon killing
660+
661+2012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
662+
663+ LauncherController: set the "unity-seen" qdata to all the BamfApplications we have
664+
665+ This avoid that we create two icons for the same application instance.
666+ Moving to the safer GUINT...
667+
668+2012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
669+
670+ BamfLauncherIcon: Focus an application if no child window is actually on top of the stack. Raises all urgent windows.
671+
672+ This fixes bug #802816 that happens when an application raises a window on the top of the stack but the focus doesn't change.
673+
674+ Plus, don't perform unneeded checks when focusing non-active applications.. Fixes: https://bugs.launchpad.net/bugs/802816, https://bugs.launchpad.net/bugs/986443. Approved by Tim Penhey.
675+
676+2012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
677+
678+ Merging with trunk.
679+
680+2012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
681+
682+ manual test: updated.
683+
684+2012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
685+
686+ Merge with trunk
687+
688+2012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
689+
690+ manual-tests, Launcher: added a test for non top non-focused windows
691+
692+2012-04-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
693+
694+ BamfLauncherIcon: raise all the urgent windows, if there are any
695+
696+2012-04-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
697+
698+ BamfLauncherIcon: focus an application if no child window is actually on top of the stack.
699+
700+ This fixes bug #802816 that happens when an application raises a window on the top of the stack but the
701+ focus doesn't change.
702+
703+ Plus, don't perform unneeded checks for non-active applications.
704+
705+2012-04-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
706+
707+ WindowManager: add method to get if a window is on top.
708+
709+ Top window is a window that is on top of the stack, excluding invisible, not mapped,
710+ minimized, set "above" and unity windows.
711+
712+2012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
713+
714+ manual-test, Launcher: added manual test for the Chromium web applications. Fixes: . Approved by Tim Penhey.
715+
716+2012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
717+
718+ manual-test, Launcher: added manual test for the Chromium web applications
719+
720+2012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
721+
722+ BamfLauncherIcon: activate the icon using the quicklist item using an Idle.
723+
724+ This fixes the bug #986461 that caused the spread not to initiate clicking on the quicklist application name.. Fixes: https://bugs.launchpad.net/bugs/986461. Approved by Thomi Richards.
725+
726+2012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
727+
728+ WindowManager: removed the g_debug("%s", G_STRFUNC); from AddProperties dummy implementation
729+
730+2012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
731+
732+ autopilot, test_quicklist: add a test to check that spread works when initiated by quicklist
733+
734+2012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
735+
736+ autopilot, keybindings: include spread keybindings
737+
738+2012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
739+
740+ autopilot, add WindowManager emulator
741+
742+2012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
743+
744+ test_quicklist: added test to check if the application label works
745+
746+2012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
747+
748+ unityshell: set PluginAdapter as introspectable child
749+
750+2012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
751+
752+ WindowManager: make it introspectable, implementation in PluginAdapter.
753+
754+2012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
755+
756+ Merge with trunk
757+
758+2012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
759+
760+ BamfLauncherIcon: remove the _quicklist_activated_id related source on destruction
761+
762+2012-04-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
763+
764+ BamfLauncherIcon: activate the icon using the quicklist item using an Idle.
765+
766+ This fixes the bug #986461 that caused the spread not to initiate clicking on the quicklist
767+ application name.
768+
769+2012-04-25 Michal Hruby <michal.mhr@gmail.com>
770+
771+ Fix scale inversion when processing non-rect tile textures. Fixes: https://bugs.launchpad.net/bugs/988338. Approved by Gord Allott.
772+
773+2012-04-25 Michal Hruby <michal.mhr@gmail.com>
774+
775+ Fix scale inversion when processing non-rect tile textures
776+
777+2012-04-25 Andrea Azzarone <azzaronea@gmail.com>
778+
779+ Don't crop the bottom of results in card view when a category is not expanded.. Fixes: https://bugs.launchpad.net/bugs/975003. Approved by Marco Trevisan (Treviño).
780+
781+2012-04-25 Andrea Azzarone <azzaronea@gmail.com>
782+
783+ Fixes LP bug #975003.
784+
785+2012-04-25 Michal Hruby <michal.mhr@gmail.com>
786+
787+ Destroy lens views before destroying lens models. Fixes: . Approved by Gord Allott, Sam Spilsbury.
788+
789+2012-04-24 Michal Hruby <michal.mhr@gmail.com>
790+
791+ Add a comment
792+
793+2012-04-24 Michal Hruby <michal.mhr@gmail.com>
794+
795+ Destroy lens views before destroying lens models
796+
797+2012-04-25 Michal Hruby <michal.mhr@gmail.com>
798+
799+ Make sure hud's spinner stops spinning after hud service returns reply. Fixes: https://bugs.launchpad.net/bugs/987781. Approved by Gord Allott, Marco Trevisan (Treviño).
800+
801+2012-04-24 Michal Hruby <michal.mhr@gmail.com>
802+
803+ Make sure hud's spinner stops spinning after hud service returns reply
804+
805+2012-04-25 Brandon Schaefer <brandontschaefer@gmail.com>
806+
807+ Shorten the press/release time of the Ctrl+Space for the IBus AP tests.. Fixes: . Approved by Thomi Richards.
808+
809+2012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
810+
811+ * Shortens the press/release time for Ctrl+Space as jenkins is a little slow
812+
813+2012-04-24 Andrea Azzarone <azzaronea@gmail.com>
814+
815+ Enable dnd for all launcher icons (and not just the ones matching the type).. Fixes: https://bugs.launchpad.net/bugs/880798. Approved by Marco Trevisan (Treviño).
816+
817+2012-04-25 Andrea Azzarone <azzaronea@gmail.com>
818+
819+ Fix typo.
820+
821+2012-04-25 Andrea Azzarone <azzaronea@gmail.com>
822+
823+ Fixes.
824+
825+2012-04-25 Andrea Azzarone <azzaronea@gmail.com>
826+
827+ Add a manual test.
828+
829+2012-04-25 Andrea Azzarone <azzaronea@gmail.com>
830+
831+ Fixes bug #880798.
832+
833+2012-04-24 Andrea Azzarone <azzaronea@gmail.com>
834+
835+ Set a shortcut for the new apps on the launcher too.. Fixes: https://bugs.launchpad.net/bugs/778499. Approved by Marco Trevisan (Treviño).
836+
837+2012-04-24 Andrea Azzarone <azzaronea@gmail.com>
838+
839+ Fix.
840+
841+2012-04-24 Andrea Azzarone <azzaronea@gmail.com>
842+
843+ Merge trunk.
844+
845+2012-04-23 Andrea Azzarone <azzaronea@gmail.com>
846+
847+ Adds AP test.
848+
849+2012-04-23 Andrea Azzarone <azzaronea@gmail.com>
850+
851+ Fixes bug #778499.
852+
853+2012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
854+
855+ DeviceLauncherSection: updated to use glib::SignalManager and glib::Object
856+
857+ This allow to be more safe; it fixes also some crashes caused by the fact that DeviceLauncherIcon didn't own the GVolume* object. Now it uses glib::Object completely, so we can automagically ref/unref the volume when the icon is created/removed.. Fixes: https://bugs.launchpad.net/bugs/918548, https://bugs.launchpad.net/bugs/977762. Approved by Andrea Azzarone.
858+
859+2012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
860+
861+ DeviceLauncherSection: use glib::SignalManager
862+
863+2012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
864+
865+ DeviceLauncherIcon: use a glib::Object to handle the volume.
866+
867+ So we can be safe about reference. This will automagically add
868+ and remove a reference when needed.
869+
870+2012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
871+
872+ UnityScreen: use smart_pointers correctly, destruct items in correct order. Fixes: https://bugs.launchpad.net/bugs/987932. Approved by Marco Trevisan (Treviño).
873+
874+2012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
875+
876+ * Remove useless namespace
877+
878+2012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
879+
880+ * Fixed spacing issue
881+
882+2012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
883+
884+ * Some fixes, also added some comments about the ordering (was causing the crashes)
885+
886+2012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
887+
888+ * Changed WindowThread to use a unique ptr
889+ * Also fixed a memory leak with the debugger
890+ * Some cleaning up also
891+ * Thanks Treviño for the information :)
892+
893+2012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
894+
895+ UnityScreen: destroy the controllers before the window thread
896+
897+ Fixes crashes enabling/disabling plugins in CCSM. Fixes: https://bugs.launchpad.net/bugs/931201, https://bugs.launchpad.net/bugs/942286, https://bugs.launchpad.net/bugs/947844, https://bugs.launchpad.net/bugs/952378. Approved by Marco Trevisan (Treviño).
898+
899+2012-04-23 Brandon Schaefer <brandontschaefer@gmail.com>
900+
901+ * Fixes some crashes with the ccsm and plugins
902+ * There still seems to be a crash, but it looks to be in bamf
903+
904+2012-04-24 Michal Hruby <michal.mhr@gmail.com>
905+
906+ GLibDBusProxy: Remove 1 second timeout we used before connecting to dbus proxies. Fixes: . Approved by Marco Trevisan (Treviño).
907+
908+2012-04-24 Michal Hruby <michal.mhr@gmail.com>
909+
910+ Remove 1 second timeout we used before connecting to dbus proxies
911+
912+2012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
913+
914+ HudLauncherIcon: close the HUD when activating the icon
915+
916+ As design requested in bug #963918. Fixes: https://bugs.launchpad.net/bugs/963918. Approved by Gord Allott.
917+
918+2012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
919+
920+ HudLauncherIcon: removed unneeded space.
921+
922+2012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
923+
924+ autopilot, test_hud: add test to check if clicking over the HUD icon closes it.
925+
926+2012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
927+
928+ HudLauncherIcon: close the HUD when activating the icon
929+
930+ As design requested in bug #963918
931+
932+2012-04-24 smspillaz <sam.spilsbury@canonical.com>
933+
934+ See Bug 880449 : Minimized windows were being considered for showdesktop and had their input shape removed twice.
935+
936+ 1) Never allow different entities to fight over the input shape of the window. Have one shared interface between them with RAII semantics
937+ 2) Don't allow minimized windows to enter showdesktop mode. Fixes: . Approved by Gord Allott.
938+
939+2012-04-23 smspillaz <sam.spilsbury@canonical.com>
940+
941+ Fix style, use <memory>
942+
943+2012-04-18 smspillaz <sam.spilsbury@canonical.com>
944+
945+ Don't showdesktop minimized windows
946+
947+2012-04-18 smspillaz <sam.spilsbury@canonical.com>
948+
949+ Make the minimize handler use the same mechanism
950+
951+2012-04-18 smspillaz <sam.spilsbury@canonical.com>
952+
953+ Acquire input shape removal through RAII semantics
954+
955+2012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
956+
957+ Hud: update the icon size to match the launcher icon size when in auto-hide mode
958+
959+ Plus prevent a couple of crashes. Fixes: https://bugs.launchpad.net/bugs/921506, https://bugs.launchpad.net/bugs/983646. Approved by Tim Penhey.
960+
961+2012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
962+
963+ HudView: Set the minimum icon height to match the content_layout
964+
965+ So the icon is vertically centered to the hud search (minimal) layout if needed.
966+
967+2012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
968+
969+ HudIcon: use unsigned integer for padding.
970+
971+2012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
972+
973+ HudView: remove space
974+
975+2012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
976+
977+ HudIcon: Fix the icon position to be relative to size, add a minimum vertical padding
978+
979+ This makes the icon draw correctly when it's big, also it makes the view to increas its
980+ vertical size slightly to use some padding if needed.
981+
982+2012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
983+
984+ HudView: fix the geometry not to change when the icon size changes
985+
986+2012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
987+
988+ HudController: add SetIcon function that removes some code duplication
989+
990+2012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
991+
992+ IconTexture: be more safe when handling _pixbuf_cached
993+
994+ Set it to null when invalid and during initialization
995+
996+2012-04-22 Marco Trevisan (Treviño) <mail@3v1n0.net>
997+
998+ Merging with trunk (window button fixes)
999+
1000+2012-04-22 Marco Trevisan (Treviño) <mail@3v1n0.net>
1001+
1002+ Merging with trunk
1003+
1004+2012-04-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
1005+
1006+ Hud: update the icon size to match the launcher icon size.
1007+
1008+2012-04-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
1009+
1010+ Merging with icon fixes branch
1011+
1012+2012-04-23 Andrea Azzarone <azzaronea@gmail.com>
1013+
1014+ Use 2 columns in the card view in desktop mode when filters are opened.. Fixes: https://bugs.launchpad.net/bugs/977817. Approved by Mirco Müller, Marco Trevisan (Treviño), Andrea Cimitan.
1015+
1016+2012-04-20 Andrea Azzarone <azzaronea@gmail.com>
1017+
1018+ Fix bug #977817.
1019+
1020+2012-04-20 Andrea Azzarone <azzaronea@gmail.com>
1021+
1022+ Merge trunk.
1023+
1024+2012-04-21 Michael Rawson <michaelrawson76@gmail.com>
1025+
1026+ Fixes position of "show desktop" icon-LP:964073. Fixes: https://bugs.launchpad.net/bugs/964073. Approved by Marco Trevisan (Treviño).
1027+
1028+2012-04-18 Michael Rawson <michaelrawson76@gmail.com>
1029+
1030+ Fixed braces
1031+
1032+2012-04-17 Michael Rawson <michaelrawson76@gmail.com>
1033+
1034+ Fixed indentation
1035+
1036+2012-04-15 Michael Rawson <michaelrawson76@gmail.com>
1037+
1038+ Fixed ccsm problem
1039+
1040+2012-04-15 Michael Rawson <michaelrawson76@gmail.com>
1041+
1042+ Removed excess DesktopLauncherIcons()
1043+
1044+2012-04-14 Michael Rawson <michaelrawson76@gmail.com>
1045+
1046+ Re-added code
1047+
1048+2012-04-14 Michael Rawson <michaelrawson76@gmail.com>
1049+
1050+ Made fix more explicit-thanks Marco
1051+
1052+2012-04-13 Michael Rawson <michaelrawson76@gmail.com>
1053+
1054+ Moved show desktop icon to intended position
1055+
1056+2012-04-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
1057+
1058+ WindowButtons: avoid to disable the Overlay close button.
1059+
1060+ This fixes a regression I probabily introduced (sorry).. Fixes: https://bugs.launchpad.net/bugs/986264. Approved by Andrea Azzarone.
1061+
1062+2012-04-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
1063+
1064+ WindowButtons: remove extra space, and be more crash-safe
1065+
1066+2012-04-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
1067+
1068+ WindowButtons: avoid to disable the Overlay close button.
1069+
1070+ This fixes a regression I probabily introduced (sorry).
1071+
1072+2012-04-20 Andrea Azzarone <azzaronea@gmail.com>
1073+
1074+ Don't activate "home.lens" during dash closing.. Fixes: https://bugs.launchpad.net/bugs/914785. Approved by Michal Hruby, Marco Trevisan (Treviño).
1075+
1076+2012-04-20 Andrea Azzarone <azzaronea@gmail.com>
1077+
1078+ Merge trunk.
1079+
1080+2012-04-20 Andrea Azzarone <azzaronea@gmail.com>
1081+
1082+ Don't activate the home lens during the dash closing.
1083+
1084+2012-04-20 Thomi Richards <thomi.richards@canonical.com>
1085+
1086+ Update IBus tests to only set the IME once per test case class.. Fixes: . Approved by Brandon Schaefer, Thomi Richards.
1087+
1088+2012-04-20 Thomi Richards <thomi.richards@canonical.com>
1089+
1090+ Use a single setUpClass method.
1091+
1092+2012-04-20 Brandon Schaefer <brandontschaefer@gmail.com>
1093+
1094+ * setUpClass, not tearDownClass
1095+
1096+2012-04-20 Brandon Schaefer <brandontschaefer@gmail.com>
1097+
1098+ * Removed param, as it is no longer needed
1099+
1100+2012-04-20 Brandon Schaefer <brandontschaefer@gmail.com>
1101+
1102+ * Now the ibus only reset the context when it changes test engines
1103+
1104+2012-04-19 Brandon Schaefer <brandontschaefer@gmail.com>
1105+
1106+ * Changed to deactivate to an explicit call
1107+
1108+2012-04-20 Chase Douglas <chase.douglas@ubuntu.com>
1109+
1110+ Fix potential pointer lockup on initial drag gesture.. Fixes: https://bugs.launchpad.net/bugs/979418. Approved by Marco Trevisan (Treviño), Alex Launi.
1111+
1112+2012-04-12 Chase Douglas <chase.douglas@ubuntu.com>
1113+
1114+ Add test comment
1115+
1116+2012-04-11 Chase Douglas <chase.douglas@ubuntu.com>
1117+
1118+ Fix pointer locking up after three touch window drag
1119+
1120+ GestureEngine::EndDrag() checks if a drag gesture was performed before
1121+ ungrabbing the pointer. Unfortunately, it checks if the gesture ID is
1122+ non-zero, but a zero ID is valid. We don't need to check the gesture ID
1123+ at all since the drag window is maintained properly.
1124+
1125+2012-04-11 Chase Douglas <chase.douglas@ubuntu.com>
1126+
1127+ Add regression test for drag gesture pointer grabs not being removed
1128+
1129+2012-04-11 Chase Douglas <chase.douglas@ubuntu.com>
1130+
1131+ Add grab counting in compiz screen mock
1132+
1133+2012-04-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1134+
1135+ WindowButtons: disable the close button if the controlled window is not closable
1136+
1137+ Added support to WindowManager to get if a window is closable and maximizable, then used the IsWindowClosable method to enable or disable the close window button.. Fixes: https://bugs.launchpad.net/bugs/981196. Approved by Thomi Richards, Brandon Schaefer.
1138+
1139+2012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
1140+
1141+ manual-tests: WindowButtons, added test case for disabled close button
1142+
1143+2012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
1144+
1145+ WindowButtons: disable the close button if the controlled window is not closable
1146+
1147+2012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
1148+
1149+ WindowManager: add functions to get if a window is maximizable and closable
1150+
1151+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1152+
1153+ IBus autopilot tests now wait for input method context to be created before typing characters.. Fixes: . Approved by Brandon Schaefer.
1154+
1155+2012-04-20 Thomi Richards <thomi.richards@canonical.com>
1156+
1157+ ibus tests now wait for ibus to be activated in the target widget. This removes the need for sleep statements alltogether.
1158+
1159+2012-04-20 Thomi Richards <thomi.richards@canonical.com>
1160+
1161+ IBus tests now wait until the im_active property on the SearchBar is set to true.
1162+
1163+2012-04-20 Thomi Richards <thomi.richards@canonical.com>
1164+
1165+ First pass at fixing the ibus tests.
1166+
1167+2012-04-20 Thomi Richards <thomi.richards@canonical.com>
1168+
1169+ Merged launcher tests fix, needed by this branch.
1170+
1171+2012-04-19 Andrea Azzarone <azzaronea@gmail.com>
1172+
1173+ Add a sanity check to avoid crashes.. Fixes: https://bugs.launchpad.net/bugs/982730. Approved by Marco Trevisan (Treviño).
1174+
1175+2012-04-20 Andrea Azzarone <azzaronea@gmail.com>
1176+
1177+ Adds a sanity check to avoid crashes.
1178+
1179+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1180+
1181+ Fixes autopilot launcher test.. Fixes: . Approved by Alex Launi.
1182+
1183+2012-04-20 Thomi Richards <thomi.richards@canonical.com>
1184+
1185+ Fixed launcher emulator and tests.
1186+
1187+2012-04-19 Michal Hruby <michal.mhr@gmail.com>
1188+
1189+ Finetune priorities when updating dash results, prevents flickering. Fixes: https://bugs.launchpad.net/bugs/961979. Approved by Gord Allott.
1190+
1191+2012-04-19 Michal Hruby <michal.mhr@gmail.com>
1192+
1193+ Finetune priorities when updating dash results, prevents flickering
1194+
1195+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1196+
1197+ Shortcut hint tests now all pass.. Fixes: . Approved by Alex Launi.
1198+
1199+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1200+
1201+ Fixed shortcut hint tests, cleaned up the shortcut hint controller, and made tests use the new Eventually() matcher, which eliminates the need for many sleep() statements.
1202+
1203+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1204+
1205+ Fixed two failing tests.
1206+
1207+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1208+
1209+ Improve autopilot assertion messages inside the new wait_for method.. Fixes: . Approved by Alex Launi.
1210+
1211+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1212+
1213+ Autopilot wait_for assertions have a slightly better error message.
1214+
1215+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1216+
1217+ Fixed failing panel autopilot tests.. Fixes: . Approved by Brandon Schaefer.
1218+
1219+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1220+
1221+ Fixed two failing panel tests.
1222+
1223+2012-04-19 Brandon Schaefer <brandontschaefer@gmail.com>
1224+
1225+ HudIcon now filters out windows on different workspaces and windows that are hidden.. Fixes: . Approved by Marco Trevisan (Treviño).
1226+
1227+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1228+
1229+ * changed xid back to a 0, not a pointer
1230+
1231+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1232+
1233+ * Fixed ap test
1234+ * Uses nullptr now
1235+
1236+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1237+
1238+ * remove debug include
1239+
1240+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1241+
1242+ * Fixed the ? icon appearing.
1243+
1244+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1245+
1246+ * Added ap test
1247+
1248+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1249+
1250+ * Now the hud filters out windows on different workspaces for the HudIcon.
1251+
1252+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1253+
1254+ Fixed a failing test in the command_lens test suite.. Fixes: . Approved by Brandon Schaefer.
1255+
1256+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1257+
1258+ Fixed a failing command lens test. Somehow the assertion got inverted in the porting process.
1259+
1260+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1261+
1262+ Hud autopilot tests use the new Eventually autopilot matcher to reduce the number of test failures due to timing issues.. Fixes: . Approved by Thomi Richards.
1263+
1264+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1265+
1266+ Merged trunk, resolved conflicts.
1267+
1268+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1269+
1270+ * Fixed indent error
1271+
1272+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1273+
1274+ * Fixed the dash test that was removed
1275+
1276+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1277+
1278+ * uses properties
1279+
1280+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1281+
1282+ * merged trunk, fixed conflicts* merged trunk, fixed conflicts* merged trunk, fixed conflicts* merged trunk, fixed conflicts* merged trunk, fixed conflicts* merged trunk, fixed conflicts* merged trunk, fixed conflicts* merged trunk, fixed conflicts
1283+
1284+2012-04-17 Brandon Schaefer <brandontschaefer@gmail.com>
1285+
1286+ * Fixed 2 ap fails
1287+
1288+2012-04-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
1289+
1290+ QuicklistView: fixed the quicklist key navigation, to make it consistent with Gtk menus navigation.
1291+
1292+ The prelight of the items is now completely controlled by QuicklistView and never by QuicklistMenuItem, the children can define now when they are slectable.. Fixes: https://bugs.launchpad.net/bugs/911561, https://bugs.launchpad.net/bugs/978926, https://bugs.launchpad.net/bugs/979096. Approved by Thomi Richards.
1293+
1294+2012-04-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1295+
1296+ autopilot, test_quicklist: cyclic keynav docstring fixes
1297+
1298+2012-04-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1299+
1300+ autopilot, test_quicklist: use the Eventually matcher to avoid false-negatives
1301+
1302+2012-04-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1303+
1304+ Merging with trunk
1305+
1306+2012-04-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1307+
1308+ autopilot: quicklist emulator, applying Thomi's fixes.
1309+
1310+2012-04-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
1311+
1312+ autopilot, test_quicklist: docstrings updated.
1313+
1314+2012-04-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
1315+
1316+ autopilot: quicklist, use only properties
1317+
1318+2012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
1319+
1320+ TestQuicklistMenuitems: added GetSelectable tests
1321+
1322+2012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
1323+
1324+ autopilot, quicklist: added other tests to check the cyclic key-navigation
1325+
1326+ Also the quicklist emulator now includes the selectable_items property
1327+
1328+2012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
1329+
1330+ autopilot, quicklist: use the new selectable item property instead of computing it
1331+
1332+2012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
1333+
1334+ QuicklistMenuItem: add GetSelectable virtual method
1335+
1336+ So each item can define when it's possible to select them, by default all
1337+ the items are selectable when visible and enabled, while the Separator
1338+ item can never be selected.
1339+
1340+2012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
1341+
1342+ autopilot, quicklist: add more last/first tests
1343+
1344+2012-04-12 Marco Trevisan (Treviño) <mail@3v1n0.net>
1345+
1346+ autopilot, test_quicklist: added first bunch of key navigation tests
1347+
1348+2012-04-12 Marco Trevisan (Treviño) <mail@3v1n0.net>
1349+
1350+ QuicklistView, QuicklistMenuItem: export absolute geometries for introspection
1351+
1352+2012-04-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
1353+
1354+ QuicklistView: add support to Home/End Page up/down buttons to select items
1355+
1356+2012-04-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
1357+
1358+ QuicklistView: use the new SelectItem into RecvItemMouseDrag
1359+
1360+2012-04-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
1361+
1362+ QuicklistMenuItem: don't change the focus on move, only on enter/leave
1363+
1364+ This to keep the consistency with GTK menus.
1365+ Also when leaving an unselected entry, we shouldn't unselect all.
1366+
1367+2012-04-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
1368+
1369+ QuicklistMenuItem: make the introspection prelight name more explicit
1370+
1371+2012-04-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
1372+
1373+ QuicklistView: enhance the key navigation to follow the same menus behavior
1374+
1375+ 1) When no item is selected pressing the Down arrow key should
1376+ select the first item (from top)
1377+ 2) When no item is selected pressing the Up arrow key should
1378+ select the last item (from top)
1379+ 3) When the last item is selected, pressing the Down arrow key
1380+ should select the first item
1381+ 4) When the first item is selected, pressing the Up arrow key
1382+ should select the last item
1383+
1384+ All these cases assume that the mouse pointer is outside the
1385+ quicklist or over an item and not moving, in the case that the
1386+ mouse pointer is moved over an unselected item, the focus should
1387+ be moved to that item.
1388+
1389+2012-04-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
1390+
1391+ QuicklistView: manage the prelight item status, avoid double-selected items
1392+
1393+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1394+
1395+ Update HUD tests to use the new Eventually() matcher.. Fixes: . Approved by Brandon Schaefer.
1396+
1397+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1398+
1399+ Removed unused import, fixed reference to property being treated as a function.
1400+
1401+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1402+
1403+ Merged trunk.
1404+
1405+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1406+
1407+ Cleaned up code after review.
1408+
1409+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1410+
1411+ Merged home-lens-tests-to-wait_for-feature into hud-tests-to-wait_for-feature.
1412+
1413+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1414+
1415+ Merged home-lens-tests-to-wait_for-feature into hud-tests-to-wait_for-feature.
1416+
1417+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1418+
1419+ Hud tests now use Eventually() matcher object instead of wait_for.
1420+
1421+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1422+
1423+ Fixed going from the Hud to the Dash forgetting window focus when exiting from the Dash.. Fixes: https://bugs.launchpad.net/bugs/984639. Approved by Andrea Azzarone, Thomi Richards.
1424+
1425+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1426+
1427+ * Use the correct assert
1428+
1429+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1430+
1431+ * removed sleep
1432+
1433+2012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
1434+
1435+ * Fixes Hud to Dash not restoring window focus
1436+ * Also fixes a Dash ap test failing
1437+
1438+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1439+
1440+ Home lens tests use wait_for instead of explicit sleep statements.. Fixes: . Approved by Brandon Schaefer, Alex Launi, Thomi Richards.
1441+
1442+2012-04-19 Thomi Richards <thomi.richards@canonical.com>
1443+
1444+ Merged trunk, reso;lved conflicts.
1445+
1446+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1447+
1448+ Merged dash-tests-to-wait_for-feature into home-lens-tests-to-wait_for-feature.
1449+
1450+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1451+
1452+ Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
1453+
1454+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1455+
1456+ Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
1457+
1458+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1459+
1460+ Merged dash-tests-to-wait_for-feature into home-lens-tests-to-wait_for-feature.
1461+
1462+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1463+
1464+ Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
1465+
1466+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1467+
1468+ Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
1469+
1470+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1471+
1472+ Home lens tests now use the Eventually() syntax.
1473+
1474+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1475+
1476+ IBus tests use new Eventually matcher.. Fixes: . Approved by Thomi Richards.
1477+
1478+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1479+
1480+ IBus tests now use the Eventually() matcher instead of wait_for.
1481+
1482+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1483+
1484+ Don't close the dash if the click is inside the desktop dash border.. Fixes: https://bugs.launchpad.net/bugs/839472. Approved by Tim Penhey.
1485+
1486+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1487+
1488+ Merge trunk.
1489+
1490+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1491+
1492+ Fix AP test.
1493+
1494+2012-04-17 Andrea Azzarone <azzaronea@gmail.com>
1495+
1496+ Fixes typo. Adds AP test.
1497+
1498+2012-04-17 Andrea Azzarone <azzaronea@gmail.com>
1499+
1500+ Clicking on the desktop dash border should do nothing, *NOT* close the dash.
1501+
1502+2012-04-18 Michal Hruby <michal.mhr@gmail.com>
1503+
1504+ Make sure we don't try to remove sources that were already removed.. Fixes: . Approved by Marco Trevisan (Treviño), Andrea Azzarone.
1505+
1506+2012-04-18 Michal Hruby <michal.mhr@gmail.com>
1507+
1508+ Don't remove invalid sources
1509+
1510+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1511+
1512+ Fixes bug #980924.. Fixes: https://bugs.launchpad.net/bugs/980924. Approved by Gord Allott, Marco Trevisan (Treviño).
1513+
1514+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1515+
1516+ Remove unneeded code.
1517+
1518+2012-04-17 Andrea Azzarone <azzaronea@gmail.com>
1519+
1520+ Fixes LP bug #980924.
1521+
1522+2012-04-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
1523+
1524+ UScreen: code updated to be more C++ friendly.
1525+
1526+ Also moved into the unity namespace.. Fixes: . Approved by Andrea Azzarone.
1527+
1528+2012-04-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
1529+
1530+ UScreen: ref the GdkScreen object we own.
1531+
1532+2012-04-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
1533+
1534+ UScreen: code updated to be more C++ friendly.
1535+
1536+ Also moved into the unity namespace.
1537+
1538+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1539+
1540+ Fix compilation of standalone launcher.. Fixes: https://bugs.launchpad.net/bugs/983989. Approved by Marco Trevisan (Treviño), Sam Spilsbury.
1541+
1542+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1543+
1544+ Fix standalone launcher.
1545+
1546+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1547+
1548+ Use std::shared_ptr::reset instead of = some::Ptr(new...) for UScreen::proxy_. Fixes: . Approved by Marco Trevisan (Treviño).
1549+
1550+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1551+
1552+ Revert prev commit. Use std::shared_ptr::reset.
1553+
1554+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1555+
1556+ Makes UScreen::proxy_ a unity::glib::DBusProxy.
1557+
1558+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1559+
1560+ Fix bug #977922.. Fixes: https://bugs.launchpad.net/bugs/977922. Approved by Tim Penhey.
1561+
1562+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1563+
1564+ Fix.
1565+
1566+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1567+
1568+ Fix bug #977922.
1569+
1570+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1571+
1572+ Fix the switcher so it displays the full title of apps in Chinese. Fixes: https://bugs.launchpad.net/bugs/830801. Approved by Tim Penhey.
1573+
1574+2012-04-18 Andrea Azzarone <azzaronea@gmail.com>
1575+
1576+ Merge trunk
1577+
1578+2012-04-16 Andrea Azzarone <azzaronea@gmail.com>
1579+
1580+ Add a manual test.
1581+
1582+2012-04-14 Andrea Azzarone <azzaronea@gmail.com>
1583+
1584+ Fix bug #830801.
1585+
1586+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1587+
1588+ Launcher tests use Eventually() matcher.. Fixes: . Approved by Thomi Richards.
1589+
1590+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1591+
1592+ Launcher emulator now uses wait_for to block until the action has been performed. Reduces the need for sleep() statements inside tests.
1593+
1594+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1595+
1596+ Launcher tests now use Eventually() matcher. Also removed some cruft from the launcher emulators.
1597+
1598+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1599+
1600+ Merged ibus-test-to-wait_for-feature into launcher-tests-pep8-whitespace-fixes.
1601+
1602+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1603+
1604+ Merged hud-tests-to-wait_for-feature into ibus-test-to-wait_for-feature.
1605+
1606+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1607+
1608+ Merged home-lens-tests-to-wait_for-feature into hud-tests-to-wait_for-feature.
1609+
1610+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1611+
1612+ Merged dash-tests-to-wait_for-feature into home-lens-tests-to-wait_for-feature.
1613+
1614+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1615+
1616+ Merged ibus-test-to-wait_for-feature into launcher-tests-pep8-whitespace-fixes.
1617+
1618+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1619+
1620+ Merged hud-tests-to-wait_for-feature into ibus-test-to-wait_for-feature.
1621+
1622+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1623+
1624+ Merged home-lens-tests-to-wait_for-feature into hud-tests-to-wait_for-feature.
1625+
1626+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1627+
1628+ Merged dash-tests-to-wait_for-feature into home-lens-tests-to-wait_for-feature.
1629+
1630+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1631+
1632+ Merged ibus-test-to-wait_for-feature into launcher-tests-pep8-whitespace-fixes.
1633+
1634+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1635+
1636+ Merged hud-tests-to-wait_for-feature into ibus-test-to-wait_for-feature.
1637+
1638+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1639+
1640+ Merged home-lens-tests-to-wait_for-feature into hud-tests-to-wait_for-feature.
1641+
1642+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1643+
1644+ Merged dash-tests-to-wait_for-feature into home-lens-tests-to-wait_for-feature.
1645+
1646+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1647+
1648+ Fixes PEP8 and whitespace issues.
1649+
1650+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1651+
1652+ IBUs tests now make use of the wait_for attribute feature. Also refactored the ibus tests so many of them are only a few lines long, and reduced the amount of duplicated code.
1653+
1654+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1655+
1656+ Merged home-lens-tests-to-wait_for-feature into hud-tests-to-wait_for-feature.
1657+
1658+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1659+
1660+ Merged dash-tests-to-wait_for-feature into home-lens-tests-to-wait_for-feature.
1661+
1662+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1663+
1664+ Fixes several timing issues. Unity exports some properties in arrays, which makes it slightly tricky to use the wait_for feature.
1665+
1666+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1667+
1668+ More hud test changes.
1669+
1670+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1671+
1672+ Hud test changes first pass merge.
1673+
1674+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1675+
1676+ Home lens uses wait_for instead of explicit sleeps.
1677+
1678+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1679+
1680+ Dash autopilot tests use the new autopilot wait_for feature.. Fixes: . Approved by Brandon Schaefer, Tim Penhey.
1681+
1682+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1683+
1684+ Missed one spot.
1685+
1686+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1687+
1688+ Dash tests changed to use Eventually matcher.
1689+
1690+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1691+
1692+ Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
1693+
1694+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1695+
1696+ Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
1697+
1698+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1699+
1700+ Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
1701+
1702+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1703+
1704+ Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
1705+
1706+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1707+
1708+ fixed code after code review.
1709+
1710+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1711+
1712+ Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
1713+
1714+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1715+
1716+ More fixes.
1717+
1718+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1719+
1720+ Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
1721+
1722+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1723+
1724+ Merged in code to fix up the dash tests.
1725+
1726+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1727+
1728+ Command lens uses Eventually() autopilot matcher to eliminate the need for sleep() statements in autopilot tests.. Fixes: . Approved by Brandon Schaefer, Tim Penhey.
1729+
1730+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1731+
1732+ Updated to use the Eventually matcher.
1733+
1734+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1735+
1736+ Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
1737+
1738+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1739+
1740+ Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
1741+
1742+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1743+
1744+ Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
1745+
1746+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1747+
1748+ Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
1749+
1750+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1751+
1752+ Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
1753+
1754+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1755+
1756+ Removed unused import
1757+
1758+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1759+
1760+ Command lens tests updated to use the new wait_for feature, and various other API fixes.
1761+
1762+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1763+
1764+ Cleaned up docstrings and whitespace in autopilot panel tests.. Fixes: . Approved by Tim Penhey.
1765+
1766+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1767+
1768+ Whitespace, PEP8 and PEP257 fixes for the panel tests.
1769+
1770+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1771+
1772+ Adds an Eventually() matcher that allows us to block a while until a unity attribute matches a testtools match object.. Fixes: . Approved by Tim Penhey, Thomi Richards.
1773+
1774+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1775+
1776+ Check match and wait_for attribute are callables.:
1777+
1778+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1779+
1780+ Fixed code from review.
1781+
1782+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1783+
1784+ Fixed code from review.
1785+
1786+2012-04-17 Andrea Azzarone <azzaronea@gmail.com>
1787+
1788+ Fix some uninitialized variables.. Fixes: https://bugs.launchpad.net/bugs/983333. Approved by Tim Penhey.
1789+
1790+2012-04-16 Andrea Azzarone <azzaronea@gmail.com>
1791+
1792+ Fix bug #983333
1793+
1794+2012-04-17 Andrea Azzarone <azzaronea@gmail.com>
1795+
1796+ Fixes bug #983268. Fixes: https://bugs.launchpad.net/bugs/983268. Approved by Thomi Richards.
1797+
1798+2012-04-17 Andrea Azzarone <azzaronea@gmail.com>
1799+
1800+ Fixes bug #983268.
1801+
1802+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1803+
1804+ Extend the autopilot wait_for feature to use testtools matcher instances as well as ordinary values. Also added an 'Eventually' matcher which makes tests more explicit.. Fixes: . Approved by Alex Launi.
1805+
1806+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1807+
1808+ Fixed typo
1809+
1810+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1811+
1812+ Added 'Eventually' autopilot matcher.
1813+
1814+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1815+
1816+ Extend the autopilot wait_for feature to use testtools matcher instances as well as ordinary values.. Fixes: . Approved by Alex Launi.
1817+
1818+2012-04-18 Thomi Richards <thomi.richards@canonical.com>
1819+
1820+ Don't use hasattr,
1821+
1822+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1823+
1824+ Cleaned up code after code review.
1825+
1826+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1827+
1828+ wait_for now deals with attributes that have a '-' in them correctly.
1829+
1830+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1831+
1832+ wait_for attribute now accept testtools matchers.
1833+
1834+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1835+
1836+ Attribute wait_for feature now raises an AssertionError instead of a RuntimeError. THis will make unit tests FAIL instead of ERRORing when wa wait_for call fails.
1837+
1838+2012-04-17 Andrea Cimitan <andrea.cimitan@canonical.com>
1839+
1840+ Fix transparent panel in non-GLSL hardware, and use bool 'false' instead 'FALSE'. Fixes: https://bugs.launchpad.net/bugs/965323. Approved by Robert Carr, Michal Hruby.
1841+
1842+2012-04-17 Andrea Cimitan <andrea.cimitan@canonical.com>
1843+
1844+ Correct fix for 965323
1845+
1846+2012-04-17 Andrea Cimitan <andrea.cimitan@canonical.com>
1847+
1848+ Use false as boolean instead FALSE, whitespaces
1849+
1850+2012-04-17 Andrea Cimitan <andrea.cimitan@canonical.com>
1851+
1852+ Attempt to fix 965323
1853+
1854+2012-04-17 Thomi Richards <thomi.richards@canonical.com>
1855+
1856+ Added the autopilot wait_for attribute feature.. Fixes: . Approved by Marco Trevisan (Treviño), Brandon Schaefer.
1857+
1858+2012-04-13 Thomi Richards <thomi.richards@canonical.com>
1859+
1860+ Dash and hud emulators use new wait_for attribute feature.
1861+
1862+2012-04-13 Thomi Richards <thomi.richards@canonical.com>
1863+
1864+ Merged autopilot-attribute-feature into convert-to-use-wait_for.
1865+
1866+2012-04-13 Thomi Richards <thomi.richards@canonical.com>
1867+
1868+ Don't change dash in this pipeline.
1869+
1870+2012-04-13 Thomi Richards <thomi.richards@canonical.com>
1871+
1872+ Merged branch that fixes the multi key code.
1873+
1874+2012-04-12 Thomi Richards <thomi.richards@canonical.com>
1875+
1876+ Cleaned up gsettings calling code. Don't want to run command through a shell, and removed extra quotes.
1877+
1878+2012-04-11 Alex Launi <alex.launi@canonical.com>
1879+
1880+ Small fixes for compose key tests
1881+
1882+2012-04-11 Alex Launi <alex.launi@canonical.com>
1883+
1884+ Args should be a list not a tuple
1885+
1886+2012-04-13 Thomi Richards <thomi.richards@canonical.com>
1887+
1888+ Merged trunk.
1889+
1890+2012-04-13 Thomi Richards <thomi.richards@canonical.com>
1891+
1892+ Dash tests now use new autopilot wait_for mechanism.
1893+
1894+2012-04-13 Thomi Richards <thomi.richards@canonical.com>
1895+
1896+ Fix unity logging reset.
1897+
1898+2012-04-11 Thomi Richards <thomi.richards@canonical.com>
1899+
1900+ Feature seems to work. Trying it out on the dash tests.
1901+
1902+2012-04-11 Thomi Richards <thomi.richards@canonical.com>
1903+
1904+ Removed old code, added special sauce.
1905+
1906+2012-04-17 Lars Uebernickel <lars.uebernickel@canonical.com>
1907+
1908+ Force menu reposition on popup in case its contents have changed.
1909+
1910+ Fixes bug 883317.. Fixes: https://bugs.launchpad.net/bugs/883317. Approved by Marco Trevisan (Treviño).
1911+
1912+2012-04-13 Lars Uebernickel <lars.uebernickel@canonical.com>
1913+
1914+ Force menu reposition on popup in case its contents have changed
1915+
1916+2012-04-17 Michal Hruby <michal.mhr@gmail.com>
1917+
1918+ Fix a couple of wrong reference/memory management issues. Fixes: https://bugs.launchpad.net/bugs/979429. Approved by Marco Trevisan (Treviño).
1919+
1920+2012-04-16 Michal Hruby <michal.mhr@gmail.com>
1921+
1922+ Fix possible signal disconnection on already dead object
1923+
1924+2012-04-16 Michal Hruby <michal.mhr@gmail.com>
1925+
1926+ Fix incorrect string freeing in Hud
1927+
1928+2012-04-16 Michal Hruby <michal.mhr@gmail.com>
1929+
1930+ Fix wrong unref in DebugInterface
1931+
1932+2012-04-17 Gord Allott <gord.allott@canonical.com>
1933+
1934+ Small fix for the unity cmake, depend on unity core was missing from a test. Fixes: . Approved by Michal Hruby.
1935+
1936+2012-04-17 Gord Allott <gord.allott@canonical.com>
1937+
1938+ fixes small cmake depends issue
1939+
1940+2012-04-16 Andrea Azzarone <azzaronea@gmail.com>
1941+
1942+ The shortcut keys in workspace section of the shortcut overlay aren't translated.. Fixes: https://bugs.launchpad.net/bugs/980828. Approved by Didier Roche.
1943+
1944+2012-04-13 Andrea Azzarone <azzaronea@gmail.com>
1945+
1946+ Fixes bug #980828.
1947+
1948+2012-04-16 Marco Trevisan (Treviño) <mail@3v1n0.net>
1949+
1950+ Fix the behaviour of alt-tab and clicking on the launcher icon to just raise the most recently used window, not all for that app.
1951+
1952+
1953+ BamfLauncherIcon's activation related code has been updated to be more multimonitor aware (for free I've fixed also some bugs that caused the windows not to be put in spread mode in multi-monitor), and to support both the "Launcher only on Primary Monitor" and "Launcher on all monitors" options.
1954+
1955+ PluginAdapter's FocusWindowGroup method has been updated to optionally only unminimize / raise and activate only the top window. This code would have been more optimized using a reverse iterator to fetch the top_window, but not to change the whole logic and to allow to keep the previous behavior (that initially we wanted for "long alt+tab") without duplicating code, I've just hacked that.
1956+ Implemented also GetWindowMonitor to workaround the mismatch we had with the compiz' window->outputDevice() and the UScreen values that now we use in the whole unity.
1957+
1958+ Screencast of the fixed version: http://ubuntuone.com/7YaWciQnaZHfzr35asSz0N. Fixes: https://bugs.launchpad.net/bugs/861250, https://bugs.launchpad.net/bugs/959339, https://bugs.launchpad.net/bugs/981795. Approved by Thomi Richards, Tim Penhey.
1959+
1960+2012-04-16 Tim Penhey <tim.penhey@canonical.com>
1961+
1962+ Test the alt-tab appears on the monitor that has window focus.
1963+
1964+2012-04-16 Tim Penhey <tim.penhey@canonical.com>
1965+
1966+ Add window stack assertions to the switcher tests.
1967+
1968+2012-04-16 Tim Penhey <tim.penhey@canonical.com>
1969+
1970+ Assert that the visible window stack is what we expect.
1971+
1972+2012-04-16 Tim Penhey <tim.penhey@canonical.com>
1973+
1974+ More AP test tweaks.
1975+
1976+2012-04-16 Tim Penhey <tim.penhey@canonical.com>
1977+
1978+ Tweaks to the test.
1979+
1980+2012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
1981+
1982+ PluginAdapter: avoid to raise and unminimize top_window if already done
1983+
1984+2012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
1985+
1986+ Launcher: be more clear in comment (yeah?)
1987+
1988+2012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
1989+
1990+ UScreen: use GetMonitorAtPosition in GetMonitorWithMouse
1991+
1992+2012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
1993+
1994+ WindowManager, BamfLauncherIcon: some code cleanup
1995+
1996+2012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
1997+
1998+ autopilot, test_launcher: updated click test to check minimized windows too
1999+
2000+ Removed debug data
2001+
2002+2012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
2003+
2004+ autopilot, test_switcher: updated against new updates
2005+
2006+2012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
2007+
2008+ unityshell: show the Alt+Tab window in the monitor where is the active window
2009+
2010+ As per design.
2011+
2012+2012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
2013+
2014+ WindowManager: add method to get the active window.
2015+
2016+2012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
2017+
2018+ PluginAdapter: removing debugging bits
2019+
2020+2012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2021+
2022+ Merging with branch changes
2023+
2024+2012-04-14 Brandon Schaefer <brandontschaefer@gmail.com>
2025+
2026+ * removed something that got added somehow
2027+
2028+2012-04-14 Brandon Schaefer <brandontschaefer@gmail.com>
2029+
2030+ * Added an AP test for the new design changes.
2031+
2032+2012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2033+
2034+ SwitcherController: Removing the code for the Quick Alt+Tab, it should behave always at the same way
2035+
2036+ 19:11:04 <JohnLea> so to summarize the above, when a app icon is selected
2037+ in Alt-Tab, the most recently focused window (on any monitor, but only in
2038+ the current workspace) of that application which is not minimised
2039+ should be focused
2040+
2041+2012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2042+
2043+ autopilot: fixed the AP test
2044+
2045+2012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2046+
2047+ BamfLauncherIcon: Also invisible windows shouldn't be counted as available in monitor
2048+
2049+ Now the spread works as expected, clicking on each monitor's panel! ;)
2050+
2051+2012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2052+
2053+ BamfLauncherIcon: don't consider an unmapped window as one in monitor
2054+
2055+2012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2056+
2057+ BamfLauncherIcon: focus a window if the application is not active on the current monitor
2058+
2059+2012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2060+
2061+ Launcher: if the current launcher is used for all the monitors, don't filter windows per monitor
2062+
2063+2012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2064+
2065+ SwitcherController: include the switcher monitor when activating a group
2066+
2067+2012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2068+
2069+ WindowManager: add GetWindowMonitor method, and use UScreen to fetch it
2070+
2071+ This now used in PluginAdapter not to have inconsistences.
2072+
2073+2012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2074+
2075+ UScreen: allow to get the monitor for a given point
2076+
2077+2012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2078+
2079+ unityshell: switcher, use UScreen to get the monitor value.
2080+
2081+ Not using this can cause inconsistences, due to the fact that compiz
2082+ numbers the devices in a different way.
2083+
2084+2012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2085+
2086+ PluginAdapter::FocusWindowGroup: add a parameter to define if focusing the on-top window only
2087+
2088+ This allow to be more monitor/VP safe
2089+
2090+2012-04-12 Brandon Schaefer <brandontschaefer@gmail.com>
2091+
2092+ * remove extra line
2093+
2094+2012-04-12 Brandon Schaefer <brandontschaefer@gmail.com>
2095+
2096+ * Fixed the No new line error diff was reporting
2097+
2098+2012-04-12 Brandon Schaefer <brandontschaefer@gmail.com>
2099+
2100+ * merged trunk
2101+
2102+2012-04-12 Brandon Schaefer <brandontschaefer@gmail.com>
2103+
2104+ * removed random dash '-'
2105+
2106+2012-04-12 Brandon Schaefer <brandontschaefer@gmail.com>
2107+
2108+ * Add autopilot test for both bugs!
2109+
2110+2012-04-12 Brandon Schaefer <brandontschaefer@gmail.com>
2111+
2112+ * Added more autopilot test for quick alt+tab
2113+
2114+2012-04-11 Brandon Schaefer <brandontschaefer@gmail.com>
2115+
2116+ * merged trunk
2117+
2118+2012-04-09 Brandon Schaefer <brandontschaefer@gmail.com>
2119+
2120+ * merged trunk
2121+
2122+2012-04-06 Brandon Schaefer <brandontschaefer@gmail.com>
2123+
2124+ * Added 2 autopilot test showing quick tab is true when pressed fast enough
2125+
2126+2012-04-06 Brandon Schaefer <brandontschaefer@gmail.com>
2127+
2128+ * fixed manual test I messed up
2129+
2130+2012-04-06 Brandon Schaefer <brandontschaefer@gmail.com>
2131+
2132+ * Added a timer for quick tab
2133+
2134+2012-04-06 Brandon Schaefer <brandontschaefer@gmail.com>
2135+
2136+ * Merged trunk
2137+
2138+2012-04-05 Brandon Schaefer <brandontschaefer@gmail.com>
2139+
2140+ * Added another manual test
2141+ * Fixes
2142+
2143+2012-04-04 Brandon Schaefer <brandontschaefer@gmail.com>
2144+
2145+ * Fixed tabbing issues
2146+
2147+2012-04-04 Brandon Schaefer <brandontschaefer@gmail.com>
2148+
2149+ * Merged with trunk, fixed conficts
2150+
2151+2011-12-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
2152+
2153+ BamfLauncherIcon: don't include dialog windows on Alt+Tab.
2154+
2155+2011-12-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2156+
2157+ manual-tests: Added test for QuickAltTab
2158+
2159+2011-12-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2160+
2161+ PluginAdapter: Add support for the FocusVisibility::OnlyVisibleOnTop on FocusWindowGroup
2162+
2163+ When a group is asked to focus with OnlyVisibleOnTop, we look for the
2164+ first non-minimized window on top of the stack and we raise and activate it.
2165+
2166+ Code indentation fixes included.
2167+
2168+2011-12-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2169+
2170+ BamfLauncherIcon: when we receive a "quick" activate, use the OnlyVisibleOnTop focus visbility
2171+
2172+ Defined a new FocusVisibility called OnlyVisibleOnTop that is meant
2173+ to only focus the first application window on top of the stack.
2174+ That is used when we receive a Switcher activate with a button != 0.
2175+
2176+2011-12-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
2177+
2178+ SwitcherController: use the button value of ActionArg to indicate the switch type
2179+
2180+ Instead of defining another type of ActionArg, I've used the button value
2181+ of ActionArg to define if we're currently performing a quick-alt+tab or
2182+ a standard switch.
2183+ Basically:
2184+
2185+2012-04-16 Alexandros Frantzis <alexandros.frantzis@linaro.org>
2186+
2187+ Fix compilation with OpenGL ES 2.0.. Fixes: . Approved by Sam Spilsbury.
2188+
2189+2012-04-06 Alexandros Frantzis <alexandros.frantzis@linaro.org>
2190+
2191+ Fix compilation with OpenGL ES 2.0.
2192+
2193+2012-04-12 Gord Allott <gord.allott@canonical.com >
2194+
2195+ fixes an uninitalised variable in the dashview code
2196+
2197+2012-04-12 Gord Allott <gord.allott@canonical.com>
2198+
2199+ fixed uninitalised value
2200+
2201+2012-04-12 Didier Roche <didier.roche@canonical.com>
2202+
2203+ Release\ 5.10.0
2204+
2205+>>>>>>> MERGE-SOURCE
2206 2012-04-12 Michal Hruby <michal.mhr@gmail.com>
2207
2208 Make sure the lenses search for things we want on startup. Fixes: https://bugs.launchpad.net/bugs/979799. Approved by Gord Allott.
2209
2210=== modified file 'UnityCore/GLibSignal.cpp'
2211=== modified file 'UnityCore/GLibSignal.h'
2212--- UnityCore/GLibSignal.h 2012-07-16 11:03:32 +0000
2213+++ UnityCore/GLibSignal.h 2012-08-03 16:26:24 +0000
2214@@ -86,6 +86,7 @@
2215 public:
2216 SignalManager();
2217 void Add(SignalBase* signal);
2218+<<<<<<< TREE
2219 void Add(SignalBase::Ptr const& signal);
2220 template <typename R, typename G, typename... Ts>
2221 void Add(G object, std::string const& signal_name, typename Signal<R, G, Ts...>::SignalCallback const& callback)
2222@@ -97,6 +98,12 @@
2223
2224 protected:
2225 std::vector<SignalBase::Ptr> connections_;
2226+=======
2227+ void Disconnect(void* object, std::string const& signal_name = "");
2228+
2229+private:
2230+ ConnectionVector connections_;
2231+>>>>>>> MERGE-SOURCE
2232 };
2233
2234 }
2235
2236=== modified file 'dash/DashController.cpp'
2237--- dash/DashController.cpp 2012-06-27 05:03:08 +0000
2238+++ dash/DashController.cpp 2012-08-03 16:26:24 +0000
2239@@ -67,9 +67,30 @@
2240 nux::GetWindowCompositor().SetKeyFocusArea(view_->default_focus());
2241 }
2242 });
2243-
2244- auto spread_cb = sigc::bind(sigc::mem_fun(this, &Controller::HideDash), true);
2245- PluginAdapter::Default()->initiate_spread.connect(spread_cb);
2246+<<<<<<< TREE
2247+=======
2248+
2249+ auto spread_cb = sigc::bind(sigc::mem_fun(this, &Controller::HideDash), true);
2250+ PluginAdapter::Default()->initiate_spread.connect(spread_cb);
2251+}
2252+>>>>>>> MERGE-SOURCE
2253+
2254+<<<<<<< TREE
2255+ auto spread_cb = sigc::bind(sigc::mem_fun(this, &Controller::HideDash), true);
2256+ PluginAdapter::Default()->initiate_spread.connect(spread_cb);
2257+=======
2258+Controller::~Controller()
2259+{
2260+ if (window_)
2261+ window_->UnReference();
2262+ window_ = 0;
2263+
2264+ if (timeline_id_)
2265+ g_source_remove(timeline_id_);
2266+
2267+ if (ensure_id_)
2268+ g_source_remove(ensure_id_);
2269+>>>>>>> MERGE-SOURCE
2270 }
2271
2272 void Controller::SetupWindow()
2273@@ -258,6 +279,10 @@
2274 need_show_ = true;
2275 return;
2276 }
2277+<<<<<<< TREE
2278+=======
2279+
2280+>>>>>>> MERGE-SOURCE
2281 view_->AboutToShow();
2282
2283 window_->ShowWindow(true);
2284
2285=== modified file 'dash/DashView.cpp'
2286--- dash/DashView.cpp 2012-07-10 03:27:49 +0000
2287+++ dash/DashView.cpp 2012-08-03 16:26:24 +0000
2288@@ -29,10 +29,17 @@
2289 #include <UnityCore/GLibWrapper.h>
2290 #include <UnityCore/RadioOptionFilter.h>
2291
2292+<<<<<<< TREE
2293 #include "unity-shared/DashStyle.h"
2294 #include "unity-shared/KeyboardUtil.h"
2295 #include "unity-shared/UnitySettings.h"
2296 #include "unity-shared/UBusMessages.h"
2297+=======
2298+#include "DashStyle.h"
2299+#include "DashSettings.h"
2300+#include "UBusMessages.h"
2301+#include "KeyboardUtil.h"
2302+>>>>>>> MERGE-SOURCE
2303
2304 namespace unity
2305 {
2306@@ -105,9 +112,20 @@
2307
2308 DashView::~DashView()
2309 {
2310+<<<<<<< TREE
2311 // Do this explicitely, otherwise dee will complain about invalid access
2312 // to the lens models
2313 RemoveLayout();
2314+=======
2315+ if (searching_timeout_id_)
2316+ g_source_remove (searching_timeout_id_);
2317+ if (hide_message_delay_id_)
2318+ g_source_remove(hide_message_delay_id_);
2319+
2320+ // Do this explicitely, otherwise dee will complain about invalid access
2321+ // to the lens models
2322+ RemoveLayout ();
2323+>>>>>>> MERGE-SOURCE
2324 }
2325
2326 void DashView::SetMonitorOffset(int x, int y)
2327@@ -762,9 +780,15 @@
2328 ubus_manager_.SendMessage(UBUS_PLACE_VIEW_CLOSE_REQUEST);
2329 }
2330
2331+<<<<<<< TREE
2332 nux::Area* DashView::FindKeyFocusArea(unsigned int key_symbol,
2333 unsigned long x11_key_code,
2334 unsigned long special_keys_state)
2335+=======
2336+Area* DashView::FindKeyFocusArea(unsigned int key_symbol,
2337+ unsigned long x11_key_code,
2338+ unsigned long special_keys_state)
2339+>>>>>>> MERGE-SOURCE
2340 {
2341 // Only care about states of Alt, Ctrl, Super, Shift, not the lock keys
2342 special_keys_state &= (nux::NUX_STATE_ALT | nux::NUX_STATE_CTRL |
2343@@ -773,8 +797,12 @@
2344 // Do what nux::View does, but if the event isn't a key navigation,
2345 // designate the text entry to process it.
2346
2347+<<<<<<< TREE
2348 using namespace nux;
2349 nux::KeyNavDirection direction = KEY_NAV_NONE;
2350+=======
2351+ nux::KeyNavDirection direction = KEY_NAV_NONE;
2352+>>>>>>> MERGE-SOURCE
2353 bool ctrl = (special_keys_state & NUX_STATE_CTRL);
2354
2355 switch (x11_key_code)
2356
2357=== modified file 'dash/LensBar.cpp'
2358=== modified file 'dash/LensBarIcon.cpp'
2359=== modified file 'dash/PlacesGroup.cpp'
2360--- dash/PlacesGroup.cpp 2012-06-18 02:57:23 +0000
2361+++ dash/PlacesGroup.cpp 2012-08-03 16:26:24 +0000
2362@@ -340,11 +340,17 @@
2363 void
2364 PlacesGroup::Relayout()
2365 {
2366+<<<<<<< TREE
2367 if (_relayout_idle)
2368 return;
2369
2370 _relayout_idle.reset(new glib::Idle(glib::Source::Priority::HIGH));
2371 _relayout_idle->Run(sigc::mem_fun(this, &PlacesGroup::OnIdleRelayout));
2372+=======
2373+ if (_idle_id == 0)
2374+ _idle_id = g_idle_add_full(G_PRIORITY_HIGH,
2375+ (GSourceFunc)OnIdleRelayout, this, NULL);
2376+>>>>>>> MERGE-SOURCE
2377 }
2378
2379 bool
2380
2381=== modified file 'dash/ResultRendererTile.cpp'
2382=== modified file 'dash/ResultView.cpp'
2383=== modified file 'dash/ResultViewGrid.cpp'
2384--- dash/ResultViewGrid.cpp 2012-07-30 16:24:18 +0000
2385+++ dash/ResultViewGrid.cpp 2012-08-03 16:26:24 +0000
2386@@ -52,7 +52,14 @@
2387 , mouse_over_index_(-1)
2388 , active_index_(-1)
2389 , selected_index_(-1)
2390+<<<<<<< TREE
2391 , last_lazy_loaded_result_(0)
2392+=======
2393+ , preview_row_(0)
2394+ , last_lazy_loaded_result_ (0)
2395+ , lazy_load_handle_(0)
2396+ , view_changed_handle_(0)
2397+>>>>>>> MERGE-SOURCE
2398 , last_mouse_down_x_(-1)
2399 , last_mouse_down_y_(-1)
2400 , recorded_dash_width_(-1)
2401@@ -63,7 +70,15 @@
2402 {
2403 SetAcceptKeyNavFocusOnMouseDown(false);
2404
2405+<<<<<<< TREE
2406 auto needredraw_lambda = [&](int value) { NeedRedraw(); };
2407+=======
2408+ auto needredraw_lambda = [&](int value)
2409+ {
2410+ NeedRedraw();
2411+ };
2412+
2413+>>>>>>> MERGE-SOURCE
2414 horizontal_spacing.changed.connect(needredraw_lambda);
2415 vertical_spacing.changed.connect(needredraw_lambda);
2416 padding.changed.connect(needredraw_lambda);
2417@@ -98,6 +113,26 @@
2418 });
2419
2420 SetDndEnabled(true, false);
2421+<<<<<<< TREE
2422+=======
2423+}
2424+
2425+ResultViewGrid::~ResultViewGrid()
2426+{
2427+ if (lazy_load_handle_)
2428+ g_source_remove(lazy_load_handle_);
2429+
2430+ if (view_changed_handle_)
2431+ g_source_remove(view_changed_handle_);
2432+}
2433+
2434+gboolean ResultViewGrid::OnLazyLoad (gpointer data)
2435+{
2436+ ResultViewGrid *self = (ResultViewGrid*)data;
2437+ self->lazy_load_handle_ = 0;
2438+ self->DoLazyLoad();
2439+ return FALSE;
2440+>>>>>>> MERGE-SOURCE
2441 }
2442
2443 void ResultViewGrid::QueueLazyLoad()
2444@@ -107,6 +142,7 @@
2445 last_lazy_loaded_result_ = 0; // we always want to reset the lazy load index here
2446 }
2447
2448+<<<<<<< TREE
2449 void ResultViewGrid::QueueViewChanged()
2450 {
2451 if (!view_changed_idle_)
2452@@ -126,6 +162,28 @@
2453
2454 bool ResultViewGrid::DoLazyLoad()
2455 {
2456+=======
2457+void ResultViewGrid::QueueViewChanged()
2458+{
2459+ if (view_changed_handle_ == 0)
2460+ {
2461+ // using G_PRIORITY_HIGH because this needs to happen *before* next draw
2462+ view_changed_handle_ = g_idle_add_full (G_PRIORITY_HIGH,
2463+ [](gpointer data) -> gboolean
2464+ {
2465+ ResultViewGrid *self = (ResultViewGrid*)data;
2466+ self->SizeReallocate();
2467+ self->last_lazy_loaded_result_ = 0; // reset the lazy load index
2468+ self->DoLazyLoad(); // also calls QueueDraw
2469+ self->view_changed_handle_ = 0;
2470+ return FALSE;
2471+ }, this, NULL);
2472+ }
2473+}
2474+
2475+void ResultViewGrid::DoLazyLoad()
2476+{
2477+>>>>>>> MERGE-SOURCE
2478 // FIXME - so this code was nice, it would only load the visible entries on the screen
2479 // however nux does not give us a good enough indicator right now that we are scrolling,
2480 // thus if you scroll more than a screen in one frame, you will end up with at least one frame where
2481@@ -472,8 +530,13 @@
2482 {
2483 SizeReallocate();
2484 QueueLazyLoad();
2485+<<<<<<< TREE
2486
2487 return ResultView::ComputeContentSize();
2488+=======
2489+ long ret = ResultView::ComputeContentSize();
2490+ return ret;
2491+>>>>>>> MERGE-SOURCE
2492 }
2493
2494
2495
2496=== modified file 'dash/ResultViewGrid.h'
2497--- dash/ResultViewGrid.h 2012-06-18 02:57:23 +0000
2498+++ dash/ResultViewGrid.h 2012-08-03 16:26:24 +0000
2499@@ -79,19 +79,42 @@
2500 typedef std::tuple <int, int> ResultListBounds;
2501 ResultListBounds GetVisableResults();
2502
2503+<<<<<<< TREE
2504+=======
2505+ static gboolean OnLazyLoad(gpointer data);
2506+>>>>>>> MERGE-SOURCE
2507 void QueueLazyLoad();
2508+<<<<<<< TREE
2509 void QueueViewChanged();
2510 bool DoLazyLoad();
2511+=======
2512+ void QueueViewChanged();
2513+ void DoLazyLoad();
2514+>>>>>>> MERGE-SOURCE
2515
2516 int GetItemsPerRow();
2517 void SizeReallocate();
2518+<<<<<<< TREE
2519+=======
2520+ void PositionPreview();
2521+>>>>>>> MERGE-SOURCE
2522
2523 uint mouse_over_index_;
2524 int active_index_;
2525- nux::Property<int> selected_index_;
2526+<<<<<<< TREE
2527+ nux::Property<int> selected_index_;
2528+=======
2529+ nux::Property<int> selected_index_;
2530+ uint preview_row_;
2531+>>>>>>> MERGE-SOURCE
2532 std::string focused_uri_;
2533
2534 int last_lazy_loaded_result_;
2535+<<<<<<< TREE
2536+=======
2537+ unsigned lazy_load_handle_;
2538+ unsigned view_changed_handle_;
2539+>>>>>>> MERGE-SOURCE
2540 int last_mouse_down_x_;
2541 int last_mouse_down_y_;
2542 std::string current_drag_uri_;
2543
2544=== modified file 'hud/HudButton.cpp'
2545--- hud/HudButton.cpp 2012-07-04 02:37:23 +0000
2546+++ hud/HudButton.cpp 2012-08-03 16:26:24 +0000
2547@@ -33,8 +33,13 @@
2548 #include <UnityCore/GLibWrapper.h>
2549 #include <UnityCore/Variant.h>
2550
2551+<<<<<<< TREE
2552 #include "unity-shared/DashStyle.h"
2553 #include "unity-shared/StaticCairoText.h"
2554+=======
2555+#include "DashStyle.h"
2556+#include "StaticCairoText.h"
2557+>>>>>>> MERGE-SOURCE
2558
2559 #include "HudButton.h"
2560 #include "HudPrivate.h"
2561@@ -52,6 +57,7 @@
2562 namespace hud
2563 {
2564
2565+<<<<<<< TREE
2566 NUX_IMPLEMENT_OBJECT_TYPE(HudButton);
2567
2568 HudButton::HudButton(NUX_FILE_LINE_DECL)
2569@@ -64,6 +70,20 @@
2570 hlayout_->SetLeftAndRightPadding(hlayout_left_padding, -1);
2571 SetLayout(hlayout_);
2572
2573+=======
2574+NUX_IMPLEMENT_OBJECT_TYPE(HudButton);
2575+
2576+HudButton::HudButton (NUX_FILE_LINE_DECL)
2577+ : nux::Button (NUX_FILE_LINE_PARAM)
2578+ , is_rounded(false)
2579+ , is_focused_(false)
2580+ , skip_draw_(true)
2581+{
2582+ hlayout_ = new nux::HLayout(NUX_TRACKER_LOCATION);
2583+ hlayout_->SetLeftAndRightPadding(hlayout_left_padding, -1);
2584+ SetLayout(hlayout_);
2585+
2586+>>>>>>> MERGE-SOURCE
2587 InitTheme();
2588
2589 key_nav_focus_change.connect([&](nux::Area*, bool, nux::KeyNavDirection)
2590@@ -77,6 +97,9 @@
2591 });
2592 }
2593
2594+HudButton::~HudButton() {
2595+}
2596+
2597 void HudButton::InitTheme()
2598 {
2599 is_rounded.changed.connect([&](bool)
2600@@ -198,6 +221,7 @@
2601 {
2602 query_ = query;
2603 label = query->formatted_text;
2604+<<<<<<< TREE
2605
2606 auto items(impl::RefactorText(label));
2607
2608@@ -209,6 +233,19 @@
2609 text->SetFont(button_font);
2610 hlayout_->AddView(text, 0, nux::MINOR_POSITION_CENTER, nux::MINOR_SIZE_FULL);
2611 }
2612+=======
2613+
2614+ auto items(impl::RefactorText(label()));
2615+
2616+ hlayout_->Clear();
2617+ for (auto item : items)
2618+ {
2619+ nux::StaticCairoText* text = new nux::StaticCairoText(item.first);
2620+ text->SetTextColor(nux::Color(1.0f, 1.0f, 1.0f, item.second ? 1.0f : 0.5f));
2621+ text->SetFont(button_font);
2622+ hlayout_->AddView(text, 0, nux::MINOR_POSITION_CENTER, nux::MINOR_SIZE_FULL);
2623+ }
2624+>>>>>>> MERGE-SOURCE
2625 }
2626
2627 Query::Ptr HudButton::GetQuery()
2628@@ -231,8 +268,12 @@
2629 void HudButton::AddProperties(GVariantBuilder* builder)
2630 {
2631 variant::BuilderWrapper(builder)
2632+<<<<<<< TREE
2633 .add("label", label())
2634 .add("focused", fake_focused());
2635+=======
2636+ .add("label", label());
2637+>>>>>>> MERGE-SOURCE
2638 }
2639
2640 } // namespace hud
2641
2642=== modified file 'hud/HudButton.h'
2643--- hud/HudButton.h 2012-06-27 21:32:48 +0000
2644+++ hud/HudButton.h 2012-08-03 16:26:24 +0000
2645@@ -27,6 +27,7 @@
2646 #include <Nux/Button.h>
2647 #include <Nux/TextureArea.h>
2648 #include <UnityCore/Hud.h>
2649+<<<<<<< TREE
2650 #include "unity-shared/Introspectable.h"
2651
2652 namespace nux { class HLayout; }
2653@@ -36,15 +37,34 @@
2654 namespace hud
2655 {
2656
2657+=======
2658+
2659+#include "Introspectable.h"
2660+
2661+namespace nux { class HLayout; }
2662+
2663+namespace unity
2664+{
2665+namespace hud
2666+{
2667+
2668+>>>>>>> MERGE-SOURCE
2669 class HudButton : public nux::Button, public unity::debug::Introspectable
2670 {
2671 NUX_DECLARE_OBJECT_TYPE(HudButton, nux::Button);
2672
2673 public:
2674 typedef nux::ObjectPtr<HudButton> Ptr;
2675+<<<<<<< TREE
2676
2677 HudButton(NUX_FILE_LINE_PROTO);
2678
2679+=======
2680+
2681+ HudButton (NUX_FILE_LINE_PROTO);
2682+ virtual ~HudButton();
2683+
2684+>>>>>>> MERGE-SOURCE
2685 void SetQuery(Query::Ptr query);
2686 std::shared_ptr<Query> GetQuery();
2687
2688@@ -62,8 +82,13 @@
2689
2690 std::string GetName() const;
2691 void AddProperties(GVariantBuilder* builder);
2692+<<<<<<< TREE
2693
2694 void InitTheme();
2695+=======
2696+
2697+ void InitTheme();
2698+>>>>>>> MERGE-SOURCE
2699 void RedrawTheme(nux::Geometry const& geom, cairo_t* cr, nux::ButtonVisualState faked_state);
2700
2701 private:
2702
2703=== modified file 'hud/HudController.cpp'
2704--- hud/HudController.cpp 2012-06-26 02:22:44 +0000
2705+++ hud/HudController.cpp 2012-08-03 16:26:24 +0000
2706@@ -16,11 +16,14 @@
2707 * Authored by: Gord Allott <gord.allott@canonical.com>
2708 */
2709
2710+#include <config.h>
2711+
2712 #include "HudController.h"
2713
2714 #include <NuxCore/Logger.h>
2715 #include <Nux/HLayout.h>
2716 #include <UnityCore/Variant.h>
2717+<<<<<<< TREE
2718
2719 #include "unity-shared/WindowManager.h"
2720 #include "unity-shared/PanelStyle.h"
2721@@ -28,6 +31,13 @@
2722 #include "unity-shared/UScreen.h"
2723
2724 #include "config.h"
2725+=======
2726+#include "WindowManager.h"
2727+#include "PanelStyle.h"
2728+#include "UBusMessages.h"
2729+#include "UScreen.h"
2730+
2731+>>>>>>> MERGE-SOURCE
2732 #include <libbamf/libbamf.h>
2733
2734 namespace unity
2735@@ -50,7 +60,12 @@
2736 , timeline_animator_(90)
2737 , view_(nullptr)
2738 , monitor_index_(0)
2739- , view_function_(function)
2740+<<<<<<< TREE
2741+ , view_function_(function)
2742+=======
2743+ , type_wait_handle_(0)
2744+ , view_function_(function)
2745+>>>>>>> MERGE-SOURCE
2746 {
2747 LOG_DEBUG(logger) << "hud startup";
2748 SetupWindow();
2749@@ -85,6 +100,25 @@
2750 EnsureHud();
2751 }
2752
2753+<<<<<<< TREE
2754+=======
2755+Controller::~Controller()
2756+{
2757+ if (window_)
2758+ window_->UnReference();
2759+ window_ = 0;
2760+
2761+ if (timeline_id_)
2762+ g_source_remove(timeline_id_);
2763+
2764+ if (ensure_id_)
2765+ g_source_remove(ensure_id_);
2766+
2767+ if (type_wait_handle_)
2768+ g_source_remove(type_wait_handle_);
2769+}
2770+
2771+>>>>>>> MERGE-SOURCE
2772 void Controller::SetupWindow()
2773 {
2774 window_.Adopt(new nux::BaseWindow("Hud"));
2775@@ -412,8 +446,13 @@
2776 {
2777 if (!visible_)
2778 {
2779+<<<<<<< TREE
2780 window_->ShowWindow(false);
2781 view_->ResetToDefault();
2782+=======
2783+ self->window_->ShowWindow(false);
2784+ self->view_->ResetToDefault();
2785+>>>>>>> MERGE-SOURCE
2786 }
2787 else
2788 {
2789
2790=== modified file 'hud/HudController.h'
2791--- hud/HudController.h 2012-06-18 02:57:23 +0000
2792+++ hud/HudController.h 2012-08-03 16:26:24 +0000
2793@@ -44,7 +44,12 @@
2794 public:
2795 typedef std::shared_ptr<Controller> Ptr;
2796
2797- Controller(std::function<AbstractView*(void)> const& function = []() { return new View; });
2798+<<<<<<< TREE
2799+ Controller(std::function<AbstractView*(void)> const& function = []() { return new View; });
2800+=======
2801+ Controller(std::function<AbstractView*(void)> const& function = []() { return new View; });
2802+ ~Controller();
2803+>>>>>>> MERGE-SOURCE
2804
2805 nux::BaseWindow* window() const;
2806
2807@@ -104,7 +109,12 @@
2808
2809 Animator timeline_animator_;
2810
2811- AbstractView* view_;
2812+<<<<<<< TREE
2813+ AbstractView* view_;
2814+=======
2815+ AbstractView* view_;
2816+ guint ensure_id_;
2817+>>>>>>> MERGE-SOURCE
2818 std::string focused_app_icon_;
2819 nux::Layout* layout_;
2820 uint monitor_index_;
2821@@ -113,7 +123,15 @@
2822 std::function<AbstractView*(void)> view_function_;
2823 };
2824
2825-} // namespace hud
2826-} // namespace unity
2827-
2828-#endif // UNITYSHELL_HUD_CONTROLLER_H
2829+<<<<<<< TREE
2830+} // namespace hud
2831+} // namespace unity
2832+
2833+#endif // UNITYSHELL_HUD_CONTROLLER_H
2834+=======
2835+} // namespace hud
2836+} // namespace unity
2837+
2838+#endif // UNITYSHELL_HUD_CONTROLLER_H
2839+
2840+>>>>>>> MERGE-SOURCE
2841
2842=== modified file 'hud/HudIcon.h'
2843=== modified file 'hud/HudView.cpp'
2844--- hud/HudView.cpp 2012-07-10 03:27:49 +0000
2845+++ hud/HudView.cpp 2012-08-03 16:26:24 +0000
2846@@ -25,12 +25,19 @@
2847 #include <UnityCore/GLibWrapper.h>
2848 #include <UnityCore/Variant.h>
2849 #include <Nux/HLayout.h>
2850+<<<<<<< TREE
2851 #include <Nux/VLayout.h>
2852
2853 #include "unity-shared/Introspectable.h"
2854
2855 #include "unity-shared/UBusMessages.h"
2856 #include "unity-shared/DashStyle.h"
2857+=======
2858+#include <Nux/VLayout.h>
2859+
2860+#include "UBusMessages.h"
2861+#include "DashStyle.h"
2862+>>>>>>> MERGE-SOURCE
2863
2864 namespace unity
2865 {
2866@@ -58,8 +65,14 @@
2867 NUX_IMPLEMENT_OBJECT_TYPE(View);
2868
2869 View::View()
2870+<<<<<<< TREE
2871 : AbstractView()
2872 , button_views_(nullptr)
2873+=======
2874+ : AbstractView()
2875+ , button_views_(NULL)
2876+ , timeline_id_(0)
2877+>>>>>>> MERGE-SOURCE
2878 , start_time_(0)
2879 , last_known_height_(0)
2880 , current_height_(0)
2881@@ -118,6 +131,16 @@
2882
2883 View::~View()
2884 {
2885+<<<<<<< TREE
2886+=======
2887+ for (auto button = buttons_.begin(); button != buttons_.end(); button++)
2888+ {
2889+ RemoveChild((*button).GetPointer());
2890+ }
2891+
2892+ if (timeline_id_)
2893+ g_source_remove(timeline_id_);
2894+>>>>>>> MERGE-SOURCE
2895 }
2896
2897 void View::ProcessGrowShrink()
2898@@ -166,9 +189,15 @@
2899
2900 void View::ResetToDefault()
2901 {
2902+<<<<<<< TREE
2903 SetQueries(Hud::Queries());
2904 current_height_ = content_layout_->GetBaseHeight();;
2905
2906+=======
2907+ SetQueries(Hud::Queries());
2908+ current_height_ = content_layout_->GetBaseHeight();
2909+
2910+>>>>>>> MERGE-SOURCE
2911 search_bar_->search_string = "";
2912 search_bar_->search_hint = _("Type your command");
2913 }
2914@@ -211,11 +240,20 @@
2915 return search_bar_->text_entry();
2916 }
2917
2918-std::list<HudButton::Ptr> const& View::buttons() const
2919-{
2920- return buttons_;
2921-}
2922-
2923+<<<<<<< TREE
2924+std::list<HudButton::Ptr> const& View::buttons() const
2925+{
2926+ return buttons_;
2927+}
2928+
2929+=======
2930+std::list<HudButton::Ptr> const& View::buttons() const
2931+{
2932+ return buttons_;
2933+}
2934+
2935+
2936+>>>>>>> MERGE-SOURCE
2937 void View::SetQueries(Hud::Queries queries)
2938 {
2939 // early exit, if the user is key navigating on the hud, we don't want to set new
2940@@ -255,7 +293,11 @@
2941 query_activated.emit(dynamic_cast<HudButton*>(area)->GetQuery());
2942 });
2943
2944+<<<<<<< TREE
2945 button->key_nav_focus_change.connect([&](nux::Area* area, bool recieving, nux::KeyNavDirection direction){
2946+=======
2947+ button->key_nav_focus_change.connect([&](nux::Area* area, bool recieving, KeyNavDirection direction){
2948+>>>>>>> MERGE-SOURCE
2949 if (recieving)
2950 query_selected.emit(dynamic_cast<HudButton*>(area)->GetQuery());
2951 });
2952@@ -268,7 +310,12 @@
2953 buttons_.front()->is_rounded = true;
2954 buttons_.back()->fake_focused = true;
2955 selected_button_ = 1;
2956- }
2957+<<<<<<< TREE
2958+ }
2959+=======
2960+ }
2961+
2962+>>>>>>> MERGE-SOURCE
2963
2964 QueueRelayout();
2965 QueueDraw();
2966@@ -397,12 +444,21 @@
2967 {
2968 LOG_DEBUG(logger) << "got search change";
2969 search_changed.emit(search_string);
2970+<<<<<<< TREE
2971
2972 for(auto button : buttons_)
2973 {
2974 button->fake_focused = false;
2975 }
2976
2977+=======
2978+
2979+ for (auto button : buttons_)
2980+ {
2981+ button->fake_focused = false;
2982+ }
2983+
2984+>>>>>>> MERGE-SOURCE
2985 if (!buttons_.empty())
2986 buttons_.back()->fake_focused = true;
2987 }
2988@@ -477,11 +533,21 @@
2989
2990 if (timeline_need_more_draw_ && !timeline_idle_)
2991 {
2992+<<<<<<< TREE
2993 timeline_idle_.reset(new glib::Idle([&] () {
2994 QueueDraw();
2995 timeline_idle_.reset();
2996 return false;
2997 }));
2998+=======
2999+ timeline_id_ = g_idle_add([] (gpointer data) -> gboolean
3000+ {
3001+ View *self = static_cast<View*>(data);
3002+ self->QueueDraw();
3003+ self->timeline_id_ = 0;
3004+ return FALSE;
3005+ }, this);
3006+>>>>>>> MERGE-SOURCE
3007 }
3008 }
3009
3010@@ -501,7 +567,7 @@
3011 {
3012 unsigned num_buttons = buttons_.size();
3013 variant::BuilderWrapper(builder)
3014- .add(GetGeometry())
3015+ .add(content_geo_)
3016 .add("selected_button", selected_button_)
3017 .add("num_buttons", num_buttons);
3018 }
3019
3020=== modified file 'hud/HudView.h'
3021--- hud/HudView.h 2012-07-04 02:37:23 +0000
3022+++ hud/HudView.h 2012-08-03 16:26:24 +0000
3023@@ -23,14 +23,25 @@
3024
3025 #include <Nux/Nux.h>
3026 #include <Nux/VLayout.h>
3027+<<<<<<< TREE
3028 #include <UnityCore/GLibSource.h>
3029
3030+=======
3031+
3032+#include "HudAbstractView.h"
3033+>>>>>>> MERGE-SOURCE
3034 #include "HudIcon.h"
3035 #include "HudButton.h"
3036+<<<<<<< TREE
3037 #include "HudAbstractView.h"
3038 #include "unity-shared/SearchBar.h"
3039 #include "unity-shared/OverlayRenderer.h"
3040 #include "unity-shared/UBusWrapper.h"
3041+=======
3042+#include "SearchBar.h"
3043+#include "OverlayRenderer.h"
3044+#include "UBusWrapper.h"
3045+>>>>>>> MERGE-SOURCE
3046
3047 namespace unity
3048 {
3049@@ -39,8 +50,13 @@
3050
3051 class View : public AbstractView
3052 {
3053+<<<<<<< TREE
3054 NUX_DECLARE_OBJECT_TYPE(View, AbstractView);
3055 public:
3056+=======
3057+ NUX_DECLARE_OBJECT_TYPE(HudView, AbstractView);
3058+public:
3059+>>>>>>> MERGE-SOURCE
3060 typedef nux::ObjectPtr<View> Ptr;
3061
3062 View();
3063@@ -61,7 +77,11 @@
3064 void AboutToHide();
3065
3066 void SetWindowGeometry(nux::Geometry const& absolute_geo, nux::Geometry const& geo);
3067+<<<<<<< TREE
3068
3069+=======
3070+
3071+>>>>>>> MERGE-SOURCE
3072 protected:
3073 virtual Area* FindKeyFocusArea(unsigned int event_type,
3074 unsigned long x11_key_code,
3075@@ -118,8 +138,14 @@
3076 bool activated_signal_sent_;
3077 };
3078
3079+} // namespace hud
3080+} // namespace unity
3081
3082+<<<<<<< TREE
3083 } // namespace hud
3084 } // namespace unity
3085+=======
3086+#endif // UNITYSHELL_HUD_VIEW_H
3087+>>>>>>> MERGE-SOURCE
3088
3089 #endif // UNITYSHELL_HUD_VIEW_H
3090
3091=== modified file 'launcher/AbstractLauncherIcon.h'
3092--- launcher/AbstractLauncherIcon.h 2012-06-14 09:48:15 +0000
3093+++ launcher/AbstractLauncherIcon.h 2012-08-03 16:26:24 +0000
3094@@ -210,9 +210,15 @@
3095
3096 virtual void UnStick() = 0;
3097
3098+<<<<<<< TREE
3099 sigc::signal<void, int, int, unsigned long> mouse_down;
3100 sigc::signal<void, int, int, unsigned long> mouse_up;
3101 sigc::signal<void, int, int, unsigned long> mouse_click;
3102+=======
3103+ sigc::signal<void, int, unsigned long, int> mouse_down;
3104+ sigc::signal<void, int, unsigned long, int> mouse_up;
3105+ sigc::signal<void, int, unsigned long, int> mouse_click;
3106+>>>>>>> MERGE-SOURCE
3107 sigc::signal<void, int> mouse_enter;
3108 sigc::signal<void, int> mouse_leave;
3109
3110
3111=== modified file 'launcher/BFBLauncherIcon.cpp'
3112=== modified file 'launcher/BamfLauncherIcon.cpp'
3113--- launcher/BamfLauncherIcon.cpp 2012-07-10 22:18:50 +0000
3114+++ launcher/BamfLauncherIcon.cpp 2012-08-03 16:26:24 +0000
3115@@ -115,7 +115,16 @@
3116 {
3117 EnsureWindowState();
3118 UpdateIconGeometries(GetCenters());
3119+<<<<<<< TREE
3120 _source_manager.Remove(ICON_REMOVE_TIMEOUT);
3121+=======
3122+
3123+ if (_remove_timeout_id)
3124+ {
3125+ g_source_remove(_remove_timeout_id);
3126+ _remove_timeout_id = 0;
3127+ }
3128+>>>>>>> MERGE-SOURCE
3129 }
3130 });
3131 _gsignals.Add(sig);
3132@@ -130,6 +139,7 @@
3133 sig = new glib::Signal<void, BamfView*>(bamf_view, "closed",
3134 [&] (BamfView*) {
3135 if (!IsSticky())
3136+<<<<<<< TREE
3137 {
3138 SetQuirk(QUIRK_VISIBLE, false);
3139
3140@@ -144,6 +154,25 @@
3141 return false;
3142 }, ICON_REMOVE_TIMEOUT);
3143 }
3144+=======
3145+ {
3146+ /* Use a timeout to remove the icon, this avoids
3147+ * that we remove an application that is going
3148+ * to be reopened soon. So applications that
3149+ * have a splash screen won't be removed from
3150+ * the launcher while the splash is closed and
3151+ * a new window is opened. */
3152+ if (_remove_timeout_id)
3153+ g_source_remove(_remove_timeout_id);
3154+
3155+ _remove_timeout_id = g_timeout_add_seconds(1, [] (gpointer data) -> gboolean {
3156+ auto self = static_cast<BamfLauncherIcon*>(data);
3157+ self->Remove();
3158+ self->_remove_timeout_id = 0;
3159+ return false;
3160+ }, this);
3161+ }
3162+>>>>>>> MERGE-SOURCE
3163 });
3164 _gsignals.Add(sig);
3165
3166@@ -180,6 +209,40 @@
3167 * we make sure that this icon won't be reused (no duplicated icon). */
3168 _gsignals.Disconnect(_bamf_app);
3169 g_object_set_qdata(G_OBJECT(_bamf_app.RawPtr()),
3170+<<<<<<< TREE
3171+ g_quark_from_static_string("unity-seen"), nullptr);
3172+ _bamf_app = nullptr;
3173+
3174+ SimpleLauncherIcon::Remove();
3175+=======
3176+ g_quark_from_static_string("unity-seen"), nullptr);
3177+
3178+ if (_remove_timeout_id != 0)
3179+ g_source_remove(_remove_timeout_id);
3180+
3181+ if (_fill_supported_types_id != 0)
3182+ g_source_remove(_fill_supported_types_id);
3183+
3184+ if (_quicklist_activated_id != 0)
3185+ g_source_remove(_quicklist_activated_id);
3186+
3187+ if (_window_moved_id != 0)
3188+ g_source_remove(_window_moved_id);
3189+
3190+ if (_dnd_hover_timer != 0)
3191+ g_source_remove(_dnd_hover_timer);
3192+>>>>>>> MERGE-SOURCE
3193+}
3194+
3195+void BamfLauncherIcon::Remove()
3196+{
3197+ /* Removing the unity-seen flag to the wrapped bamf application, on remove
3198+ * request we make sure that if the bamf application is re-opened while
3199+ * the removal process is still ongoing, the application will be shown
3200+ * on the launcher. Disconnecting from signals and nullifying the _bamf_app
3201+ * we make sure that this icon won't be reused (no duplicated icon). */
3202+ _gsignals.Disconnect(_bamf_app);
3203+ g_object_set_qdata(G_OBJECT(_bamf_app.RawPtr()),
3204 g_quark_from_static_string("unity-seen"), nullptr);
3205 _bamf_app = nullptr;
3206
3207@@ -1044,10 +1107,20 @@
3208
3209 _gsignals.Add(new glib::Signal<void, DbusmenuMenuitem*, int>(item, DBUSMENU_MENUITEM_SIGNAL_ITEM_ACTIVATED,
3210 [&] (DbusmenuMenuitem*, int) {
3211+<<<<<<< TREE
3212 _source_manager.AddIdle([&] {
3213 ActivateLauncherIcon(ActionArg());
3214 return false;
3215 });
3216+=======
3217+ _quicklist_activated_id =
3218+ g_idle_add([] (gpointer data) -> gboolean {
3219+ auto self = static_cast<BamfLauncherIcon*>(data);
3220+ self->ActivateLauncherIcon(ActionArg());
3221+ self->_quicklist_activated_id = 0;
3222+ return FALSE;
3223+ }, this);
3224+>>>>>>> MERGE-SOURCE
3225 }));
3226
3227 _menu_items_extra["AppName"] = glib::Object<DbusmenuMenuitem>(item);
3228@@ -1191,6 +1264,7 @@
3229
3230 void BamfLauncherIcon::OnDndLeave()
3231 {
3232+<<<<<<< TREE
3233 /* Disabled, since the DND code is currently disabled as well.
3234 _source_manager.Remove(ICON_DND_OVER_TIMEOUT);
3235 */
3236@@ -1222,6 +1296,41 @@
3237 }
3238
3239 nux::DndAction BamfLauncherIcon::OnQueryAcceptDrop(DndData const& dnd_data)
3240+=======
3241+ _dnd_hovered = false;
3242+
3243+ if (_dnd_hover_timer)
3244+ g_source_remove(_dnd_hover_timer);
3245+ _dnd_hover_timer = 0;
3246+}
3247+
3248+bool BamfLauncherIcon::OnShouldHighlightOnDrag(DndData const& dnd_data)
3249+{
3250+ bool is_home_launcher = boost::algorithm::ends_with(DesktopFile(), "nautilus-home.desktop") ||
3251+ boost::algorithm::ends_with(DesktopFile(), "nautilus.desktop");
3252+
3253+ if (is_home_launcher)
3254+ {
3255+ return true;
3256+ }
3257+
3258+ for (auto type : dnd_data.Types())
3259+ {
3260+ for (auto supported_type : GetSupportedTypes())
3261+ {
3262+ if (g_content_type_is_a(type.c_str(), supported_type.c_str()))
3263+ {
3264+ if (!dnd_data.UrisByType(type).empty())
3265+ return true;
3266+ }
3267+ }
3268+ }
3269+
3270+ return false;
3271+}
3272+
3273+nux::DndAction BamfLauncherIcon::OnQueryAcceptDrop(DndData const& dnd_data)
3274+>>>>>>> MERGE-SOURCE
3275 {
3276 return ValidateUrisForLaunch(dnd_data).empty() ? nux::DNDACTION_NONE : nux::DNDACTION_COPY;
3277 }
3278
3279=== modified file 'launcher/BamfLauncherIcon.h'
3280--- launcher/BamfLauncherIcon.h 2012-07-04 07:02:00 +0000
3281+++ launcher/BamfLauncherIcon.h 2012-08-03 16:26:24 +0000
3282@@ -124,6 +124,13 @@
3283
3284 glib::Object<BamfApplication> _bamf_app;
3285 bool _supported_types_filled;
3286+<<<<<<< TREE
3287+=======
3288+ guint _remove_timeout_id;
3289+ guint _fill_supported_types_id;
3290+ guint _window_moved_id;
3291+ guint _quicklist_activated_id;
3292+>>>>>>> MERGE-SOURCE
3293
3294 std::string _remote_uri;
3295 std::string _desktop_file;
3296
3297=== modified file 'launcher/DesktopLauncherIcon.cpp'
3298=== modified file 'launcher/DeviceLauncherIcon.cpp'
3299--- launcher/DeviceLauncherIcon.cpp 2012-06-21 06:55:53 +0000
3300+++ launcher/DeviceLauncherIcon.cpp 2012-08-03 16:26:24 +0000
3301@@ -40,7 +40,12 @@
3302
3303 nux::logging::Logger logger("unity.launcher");
3304
3305-const unsigned int volume_changed_timeout = 500;
3306+<<<<<<< TREE
3307+const unsigned int volume_changed_timeout = 500;
3308+=======
3309+GduDevice* get_device_for_device_file (const gchar *device_file);
3310+const unsigned int volume_changed_timeout = 500;
3311+>>>>>>> MERGE-SOURCE
3312
3313 }
3314
3315@@ -63,6 +68,7 @@
3316 UpdateVisibility();
3317 }
3318
3319+<<<<<<< TREE
3320 void DeviceLauncherIcon::OnVolumeChanged(GVolume* volume)
3321 {
3322 if (!G_IS_VOLUME(volume))
3323@@ -99,6 +105,57 @@
3324 }
3325 }
3326
3327+=======
3328+DeviceLauncherIcon::~DeviceLauncherIcon()
3329+{
3330+ if (changed_timeout_ > 0)
3331+ g_source_remove(changed_timeout_);
3332+}
3333+
3334+void DeviceLauncherIcon::OnVolumeChanged(GVolume* volume)
3335+{
3336+ if (!G_IS_VOLUME(volume))
3337+ return;
3338+
3339+ if (changed_timeout_ > 0)
3340+ g_source_remove(changed_timeout_);
3341+ changed_timeout_ = g_timeout_add(volume_changed_timeout, &DeviceLauncherIcon::OnVolumeChangedTimeout, this);
3342+}
3343+
3344+gboolean DeviceLauncherIcon::OnVolumeChangedTimeout(gpointer data)
3345+{
3346+ DeviceLauncherIcon* self = static_cast<DeviceLauncherIcon*>(data);
3347+
3348+ self->UpdateDeviceIcon();
3349+ self->UpdateVisibility();
3350+ return FALSE;
3351+}
3352+
3353+void DeviceLauncherIcon::UpdateVisibility()
3354+{
3355+ switch (DevicesSettings::GetDefault().GetDevicesOption())
3356+ {
3357+ case DevicesSettings::NEVER:
3358+ SetQuirk(QUIRK_VISIBLE, false);
3359+ break;
3360+ case DevicesSettings::ONLY_MOUNTED:
3361+ if (keep_in_launcher_)
3362+ {
3363+ SetQuirk(QUIRK_VISIBLE, true);
3364+ }
3365+ else
3366+ {
3367+ glib::Object<GMount> mount(g_volume_get_mount(volume_));
3368+ SetQuirk(QUIRK_VISIBLE, mount);
3369+ }
3370+ break;
3371+ case DevicesSettings::ALWAYS:
3372+ SetQuirk(QUIRK_VISIBLE, true);
3373+ break;
3374+ }
3375+}
3376+
3377+>>>>>>> MERGE-SOURCE
3378 void DeviceLauncherIcon::UpdateDeviceIcon()
3379 {
3380 name_ = glib::String(g_volume_get_name(volume_)).Str();
3381
3382=== modified file 'launcher/DeviceLauncherIcon.h'
3383--- launcher/DeviceLauncherIcon.h 2012-07-18 16:06:32 +0000
3384+++ launcher/DeviceLauncherIcon.h 2012-08-03 16:26:24 +0000
3385@@ -34,10 +34,16 @@
3386 class DeviceLauncherIcon : public SimpleLauncherIcon
3387 {
3388 public:
3389+<<<<<<< TREE
3390 typedef nux::ObjectPtr<DeviceLauncherIcon> Ptr;
3391
3392 DeviceLauncherIcon(glib::Object<GVolume> const& volume);
3393
3394+=======
3395+ DeviceLauncherIcon(glib::Object<GVolume> const& volume);
3396+ ~DeviceLauncherIcon();
3397+
3398+>>>>>>> MERGE-SOURCE
3399 void OnRemoved();
3400 bool CanEject();
3401 void Eject();
3402@@ -62,15 +68,27 @@
3403 static void OnEjectReady(GObject* object, GAsyncResult* result, DeviceLauncherIcon* self);
3404 static void OnUnmountReady(GObject* object, GAsyncResult* result, DeviceLauncherIcon* self);
3405 static void OnDriveStop(DbusmenuMenuitem* item, int time, DeviceLauncherIcon* self);
3406- void OnVolumeChanged(GVolume* volume);
3407+<<<<<<< TREE
3408+ void OnVolumeChanged(GVolume* volume);
3409+=======
3410+ static gboolean OnVolumeChangedTimeout(gpointer data);
3411+ void OnVolumeChanged(GVolume* volume);
3412+>>>>>>> MERGE-SOURCE
3413 void OnSettingsChanged();
3414 void ShowNotification(std::string const&, unsigned, glib::Object<GdkPixbuf> const&, std::string const&);
3415
3416 private:
3417+<<<<<<< TREE
3418 glib::Signal<void, GVolume*> signal_volume_changed_;
3419 glib::Source::UniquePtr changed_timeout_;
3420 glib::Object<GVolume> volume_;
3421
3422+=======
3423+ glib::Signal<void, GVolume*> signal_volume_changed_;
3424+ guint changed_timeout_;
3425+ glib::Object<GVolume> volume_;
3426+ glib::String device_file_;
3427+>>>>>>> MERGE-SOURCE
3428 std::string name_;
3429 bool keep_in_launcher_;
3430 };
3431
3432=== modified file 'launcher/DeviceLauncherSection.cpp'
3433--- launcher/DeviceLauncherSection.cpp 2012-07-18 17:51:56 +0000
3434+++ launcher/DeviceLauncherSection.cpp 2012-08-03 16:26:24 +0000
3435@@ -24,6 +24,7 @@
3436 namespace launcher
3437 {
3438
3439+<<<<<<< TREE
3440 DeviceLauncherSection::DeviceLauncherSection(AbstractVolumeMonitorWrapper::Ptr volume_monitor)
3441 : monitor_(volume_monitor)
3442 {
3443@@ -39,7 +40,36 @@
3444 void DeviceLauncherSection::PopulateEntries()
3445 {
3446 for (auto volume : monitor_->GetVolumes())
3447+=======
3448+DeviceLauncherSection::DeviceLauncherSection()
3449+ : monitor_(g_volume_monitor_get())
3450+{
3451+ typedef glib::Signal<void, GVolumeMonitor*, GVolume*> VolumeSignal;
3452+ sig_manager_.Add(new VolumeSignal(monitor_, "volume-added", sigc::mem_fun(this, &DeviceLauncherSection::OnVolumeAdded)));
3453+ sig_manager_.Add(new VolumeSignal(monitor_, "volume-removed", sigc::mem_fun(this, &DeviceLauncherSection::OnVolumeRemoved)));
3454+
3455+ on_device_populate_entry_id_ = g_idle_add([] (gpointer data) {
3456+ auto self = static_cast<DeviceLauncherSection*>(data);
3457+ self->PopulateEntries();
3458+ self->on_device_populate_entry_id_ = 0;
3459+ return FALSE;
3460+ }, this);
3461+}
3462+
3463+DeviceLauncherSection::~DeviceLauncherSection()
3464+{
3465+ if (on_device_populate_entry_id_)
3466+ g_source_remove(on_device_populate_entry_id_);
3467+}
3468+
3469+void DeviceLauncherSection::PopulateEntries()
3470+{
3471+ GList* volumes = g_volume_monitor_get_volumes(monitor_);
3472+
3473+ for (GList* v = volumes; v; v = v->next)
3474+>>>>>>> MERGE-SOURCE
3475 {
3476+<<<<<<< TREE
3477 // Sanity check. Avoid duplicates.
3478 if (map_.find(volume) != map_.end())
3479 continue;
3480@@ -48,15 +78,37 @@
3481
3482 map_[volume] = icon;
3483 IconAdded.emit(icon);
3484+=======
3485+ if (!G_IS_VOLUME(v->data))
3486+ continue;
3487+
3488+ // This will unref the volume, since the list entries needs that.
3489+ // We'll keep a reference in the icon.
3490+ glib::Object<GVolume> volume(G_VOLUME(v->data));
3491+ DeviceLauncherIcon* icon = new DeviceLauncherIcon(volume);
3492+
3493+ map_[volume] = icon;
3494+ IconAdded.emit(AbstractLauncherIcon::Ptr(icon));
3495+>>>>>>> MERGE-SOURCE
3496 }
3497+<<<<<<< TREE
3498+=======
3499+
3500+ g_list_free(volumes);
3501+>>>>>>> MERGE-SOURCE
3502 }
3503
3504 /* Uses a std::map to track all the volume icons shown and not shown.
3505 * Keep in mind: when "volume-removed" is recevied we should erase
3506 * the pair (GVolume - DeviceLauncherIcon) from the std::map to avoid leaks
3507 */
3508+<<<<<<< TREE
3509 void DeviceLauncherSection::OnVolumeAdded(glib::Object<GVolume> const& volume)
3510+=======
3511+void DeviceLauncherSection::OnVolumeAdded(GVolumeMonitor* monitor, GVolume* volume)
3512+>>>>>>> MERGE-SOURCE
3513 {
3514+<<<<<<< TREE
3515 // Sanity check. Avoid duplicates.
3516 if (map_.find(volume) != map_.end())
3517 return;
3518@@ -65,10 +117,24 @@
3519
3520 map_[volume] = icon;
3521 IconAdded.emit(icon);
3522+=======
3523+ // This just wraps the volume in a glib::Object, global ref_count is only
3524+ // temporary changed.
3525+ glib::Object<GVolume> gvolume(volume, glib::AddRef());
3526+ DeviceLauncherIcon* icon = new DeviceLauncherIcon(gvolume);
3527+
3528+ map_[gvolume] = icon;
3529+ IconAdded.emit(AbstractLauncherIcon::Ptr(icon));
3530+>>>>>>> MERGE-SOURCE
3531 }
3532
3533+<<<<<<< TREE
3534 void DeviceLauncherSection::OnVolumeRemoved(glib::Object<GVolume> const& volume)
3535+=======
3536+void DeviceLauncherSection::OnVolumeRemoved(GVolumeMonitor* monitor, GVolume* volume)
3537+>>>>>>> MERGE-SOURCE
3538 {
3539+<<<<<<< TREE
3540 auto volume_it = map_.find(volume);
3541
3542 // Sanity check
3543@@ -76,6 +142,15 @@
3544 {
3545 volume_it->second->OnRemoved();
3546 map_.erase(volume_it);
3547+=======
3548+ auto volume_it = map_.find(volume);
3549+
3550+ // It should not happen! Let me do the check anyway.
3551+ if (volume_it != map_.end())
3552+ {
3553+ volume_it->second->OnRemoved();
3554+ map_.erase(volume_it);
3555+>>>>>>> MERGE-SOURCE
3556 }
3557 }
3558
3559
3560=== modified file 'launcher/DeviceLauncherSection.h'
3561--- launcher/DeviceLauncherSection.h 2012-07-18 17:51:56 +0000
3562+++ launcher/DeviceLauncherSection.h 2012-08-03 16:26:24 +0000
3563@@ -22,7 +22,15 @@
3564
3565 #include <map>
3566
3567+<<<<<<< TREE
3568 #include <UnityCore/GLibSource.h>
3569+=======
3570+#include <gio/gio.h>
3571+#include <sigc++/sigc++.h>
3572+#include <sigc++/signal.h>
3573+#include <UnityCore/GLibWrapper.h>
3574+#include <UnityCore/GLibSignal.h>
3575+>>>>>>> MERGE-SOURCE
3576
3577 #include "DeviceLauncherIcon.h"
3578 #include "AbstractVolumeMonitorWrapper.h"
3579@@ -40,6 +48,7 @@
3580 sigc::signal<void, AbstractLauncherIcon::Ptr> IconAdded;
3581
3582 private:
3583+<<<<<<< TREE
3584 void PopulateEntries();
3585 void OnVolumeAdded(glib::Object<GVolume> const& volume);
3586 void OnVolumeRemoved(glib::Object<GVolume> const& volume);
3587@@ -47,6 +56,18 @@
3588 std::map<GVolume*, DeviceLauncherIcon::Ptr> map_;
3589 AbstractVolumeMonitorWrapper::Ptr monitor_;
3590 glib::Idle device_populate_idle_;
3591+=======
3592+ void PopulateEntries();
3593+
3594+ void OnVolumeAdded(GVolumeMonitor* monitor, GVolume* volume);
3595+ void OnVolumeRemoved(GVolumeMonitor* monitor, GVolume* volume);
3596+
3597+private:
3598+ glib::SignalManager sig_manager_;
3599+ glib::Object<GVolumeMonitor> monitor_;
3600+ std::map<GVolume*, DeviceLauncherIcon*> map_;
3601+ gulong on_device_populate_entry_id_;
3602+>>>>>>> MERGE-SOURCE
3603 };
3604
3605 }
3606
3607=== modified file 'launcher/DndData.cpp'
3608--- launcher/DndData.cpp 2012-07-09 14:11:06 +0000
3609+++ launcher/DndData.cpp 2012-08-03 16:26:24 +0000
3610@@ -35,16 +35,30 @@
3611 char* pch = strtok (uris, "\r\n");
3612 while (pch)
3613 {
3614+<<<<<<< TREE
3615 glib::String content_type(g_content_type_guess(pch,
3616 nullptr,
3617 0,
3618 nullptr));
3619
3620 if (content_type)
3621+=======
3622+ glib::String content_type(g_content_type_guess(pch, nullptr, 0, nullptr));
3623+
3624+ if (content_type)
3625+>>>>>>> MERGE-SOURCE
3626 {
3627+<<<<<<< TREE
3628 types_.insert(content_type.Str());
3629 uris_to_types_[pch] = content_type.Str();
3630 types_to_uris_[content_type.Str()].insert(pch);
3631+=======
3632+ std::string const& content_type_str = content_type.Str();
3633+
3634+ types_.insert(content_type_str);
3635+ uris_to_types_[pch] = content_type_str;
3636+ types_to_uris_[content_type_str].insert(pch);
3637+>>>>>>> MERGE-SOURCE
3638 }
3639
3640 uris_.insert(pch);
3641
3642=== modified file 'launcher/EdgeBarrierController.cpp'
3643--- launcher/EdgeBarrierController.cpp 2012-07-26 10:41:51 +0000
3644+++ launcher/EdgeBarrierController.cpp 2012-08-03 16:26:24 +0000
3645@@ -65,7 +65,7 @@
3646 {
3647 UScreen *uscreen = UScreen::GetDefault();
3648
3649- auto monitors = uscreen->GetMonitors();
3650+ auto const& monitors = uscreen->GetMonitors();
3651 ResizeBarrierList(monitors);
3652
3653 uscreen->changed.connect([&](int primary, std::vector<nux::Geometry>& layout) {
3654@@ -147,15 +147,24 @@
3655 }
3656
3657 float decay_responsiveness_mult = ((parent_->options()->edge_responsiveness() - 1) * .3f) + 1;
3658+<<<<<<< TREE
3659 decaymulator_.rate_of_decay = parent_->options()->edge_decay_rate() * decay_responsiveness_mult;
3660
3661+=======
3662+ decaymulator_->rate_of_decay = parent_->options()->edge_decay_rate() * decay_responsiveness_mult;
3663+
3664+>>>>>>> MERGE-SOURCE
3665 float overcome_responsiveness_mult = ((parent_->options()->edge_responsiveness() - 1) * 1.0f) + 1;
3666 edge_overcome_pressure_ = parent_->options()->edge_overcome_pressure() * overcome_responsiveness_mult;
3667 }
3668
3669 void EdgeBarrierController::Impl::OnPointerBarrierEvent(PointerBarrierWrapper* owner, BarrierEvent::Ptr event)
3670 {
3671+<<<<<<< TREE
3672 unsigned int monitor = owner->index;
3673+=======
3674+ unsigned monitor = owner->index;
3675+>>>>>>> MERGE-SOURCE
3676 bool process = true;
3677
3678 if (monitor < subscribers_.size())
3679@@ -166,6 +175,7 @@
3680 process = false;
3681 }
3682
3683+<<<<<<< TREE
3684 if (process && owner->released)
3685 {
3686 BarrierRelease(owner, event->event_id);
3687@@ -175,6 +185,12 @@
3688 decaymulator_.value = decaymulator_.value + event->velocity;
3689
3690 if (decaymulator_.value > edge_overcome_pressure_ || (!parent_->sticky_edges() && !subscribers_[monitor]))
3691+=======
3692+ if (process && owner->x1 > 0)
3693+ {
3694+ decaymulator_->value = decaymulator_->value + event->velocity;
3695+ if (decaymulator_->value > edge_overcome_pressure_ || (!parent_->options()->edge_resist() && !subscribers_[monitor]))
3696+>>>>>>> MERGE-SOURCE
3697 {
3698 BarrierRelease(owner, event->event_id);
3699 }
3700@@ -199,8 +215,14 @@
3701 }
3702
3703 EdgeBarrierController::EdgeBarrierController()
3704+<<<<<<< TREE
3705 : pimpl(new Impl(this))
3706 {}
3707+=======
3708+ : sticky_edges(false)
3709+ , pimpl(new Impl(this))
3710+{}
3711+>>>>>>> MERGE-SOURCE
3712
3713 EdgeBarrierController::~EdgeBarrierController()
3714 {}
3715@@ -223,6 +245,7 @@
3716
3717 auto const& monitors = UScreen::GetDefault()->GetMonitors();
3718 pimpl->subscribers_[monitor] = nullptr;
3719+<<<<<<< TREE
3720 pimpl->ResizeBarrierList(monitors);
3721 pimpl->SetupBarriers(monitors);
3722 }
3723@@ -239,6 +262,20 @@
3724 {
3725 pimpl->OnPointerBarrierEvent(owner, event);
3726 }
3727+=======
3728+ pimpl->ResizeBarrierList(monitors);
3729+ pimpl->SetupBarriers(monitors);
3730+}
3731+
3732+EdgeBarrierSubscriber* EdgeBarrierController::GetSubscriber(unsigned int monitor)
3733+{
3734+ if (monitor >= pimpl->subscribers_.size())
3735+ return nullptr;
3736+
3737+ return pimpl->subscribers_[monitor];
3738+}
3739+
3740+>>>>>>> MERGE-SOURCE
3741
3742 }
3743 }
3744
3745=== modified file 'launcher/EdgeBarrierController.h'
3746--- launcher/EdgeBarrierController.h 2012-07-25 23:18:17 +0000
3747+++ launcher/EdgeBarrierController.h 2012-08-03 16:26:24 +0000
3748@@ -41,12 +41,18 @@
3749 nux::RWProperty<bool> sticky_edges;
3750 nux::Property<launcher::Options::Ptr> options;
3751
3752+<<<<<<< TREE
3753 void Subscribe(EdgeBarrierSubscriber* subscriber, unsigned int monitor);
3754 void Unsubscribe(EdgeBarrierSubscriber* subscriber, unsigned int monitor);
3755 EdgeBarrierSubscriber* GetSubscriber(unsigned int monitor);
3756
3757 protected:
3758 void ProcessBarrierEvent(PointerBarrierWrapper* owner, BarrierEvent::Ptr event);
3759+=======
3760+ void Subscribe(EdgeBarrierSubscriber* subscriber, unsigned int monitor);
3761+ void Unsubscribe(EdgeBarrierSubscriber* subscriber, unsigned int monitor);
3762+ EdgeBarrierSubscriber* GetSubscriber(unsigned int monitor);
3763+>>>>>>> MERGE-SOURCE
3764
3765 private:
3766 struct Impl;
3767
3768=== modified file 'launcher/HudLauncherIcon.cpp'
3769=== modified file 'launcher/Launcher.cpp'
3770--- launcher/Launcher.cpp 2012-08-03 13:43:50 +0000
3771+++ launcher/Launcher.cpp 2012-08-03 16:26:24 +0000
3772@@ -216,7 +216,53 @@
3773 launcher_sheen_ = cache.FindTexture("dash_sheen", 0, 0, cb);
3774 launcher_pressure_effect_ = cache.FindTexture("launcher_pressure_effect", 0, 0, cb);
3775
3776+<<<<<<< TREE
3777 options.changed.connect(sigc::mem_fun (this, &Launcher::OnOptionsChanged));
3778+=======
3779+ options.changed.connect (sigc::mem_fun (this, &Launcher::OnOptionsChanged));
3780+
3781+ // icon information from software center
3782+ _sc_icon = NULL;
3783+ _sc_icon_title = NULL;
3784+ _sc_icon_x = 0;
3785+ _sc_icon_y = 0;
3786+ _sc_icon_size = 0;
3787+ _sc_icon_desktop_file = NULL;
3788+ _sc_icon_aptdaemon_task = NULL;
3789+ _sc_anim_icon = false;
3790+}
3791+
3792+Launcher::~Launcher()
3793+{
3794+ g_bus_unown_name(_dbus_owner);
3795+
3796+ if (_dnd_check_handle)
3797+ g_source_remove(_dnd_check_handle);
3798+ if (_autoscroll_handle)
3799+ g_source_remove(_autoscroll_handle);
3800+ if (_start_dragicon_handle)
3801+ g_source_remove(_start_dragicon_handle);
3802+ if (_launcher_animation_timeout > 0)
3803+ g_source_remove(_launcher_animation_timeout);
3804+ if (_strut_hack_handle)
3805+ g_source_remove(_strut_hack_handle);
3806+
3807+ if (_on_data_collected_connection.connected())
3808+ _on_data_collected_connection.disconnect();
3809+
3810+ g_idle_remove_by_data(this);
3811+
3812+ if (_collection_window)
3813+ _collection_window->UnReference();
3814+
3815+ delete _hover_machine;
3816+ delete _hide_machine;
3817+
3818+ g_free(_sc_icon);
3819+ g_free(_sc_icon_title);
3820+ g_free(_sc_icon_desktop_file);
3821+ g_free(_sc_icon_aptdaemon_task);
3822+>>>>>>> MERGE-SOURCE
3823 }
3824
3825 /* Introspection */
3826@@ -279,7 +325,15 @@
3827 .add("hovered", _hovered)
3828 .add("hidemode", options()->hide_mode)
3829 .add("hidden", _hidden)
3830- .add("is_showing", ! _hidden)
3831+<<<<<<< TREE
3832+ .add("is_showing", ! _hidden)
3833+=======
3834+ .add("is_showing", ! _hidden)
3835+ .add("x", abs_geo.x)
3836+ .add("y", abs_geo.y)
3837+ .add("width", abs_geo.width)
3838+ .add("height", abs_geo.height)
3839+>>>>>>> MERGE-SOURCE
3840 .add("monitor", monitor())
3841 .add("quicklist-open", _hide_machine.GetQuirk(LauncherHideMachine::QUICKLIST_OPEN))
3842 .add("hide-quirks", _hide_machine.DebugHideQuirks())
3843@@ -1504,12 +1558,27 @@
3844 }
3845 }
3846
3847+<<<<<<< TREE
3848 nux::ObjectPtr<nux::View> Launcher::GetActiveTooltip() const
3849 {
3850 return _active_tooltip;
3851 }
3852
3853 void Launcher::SetActionState(LauncherActionState actionstate)
3854+=======
3855+nux::ObjectPtr<nux::View> const& Launcher::GetActiveTooltip() const
3856+{
3857+ return _active_tooltip;
3858+}
3859+
3860+nux::ObjectPtr<LauncherDragWindow> const& Launcher::GetDraggedIcon() const
3861+{
3862+ return _drag_window;
3863+}
3864+
3865+void
3866+Launcher::SetActionState(LauncherActionState actionstate)
3867+>>>>>>> MERGE-SOURCE
3868 {
3869 if (_launcher_action_state == actionstate)
3870 return;
3871@@ -1964,6 +2033,16 @@
3872 gPainter.PopBackground(push_count);
3873 GfxContext.PopClippingRectangle();
3874 GfxContext.PopClippingRectangle();
3875+
3876+ if (_sc_anim_icon)
3877+ {
3878+ launcher_addrequest_special.emit(_sc_icon_desktop_file, AbstractLauncherIcon::Ptr(), _sc_icon_aptdaemon_task, _sc_icon, _sc_icon_x, _sc_icon_y, _sc_icon_size);
3879+ g_free(_sc_icon); _sc_icon = NULL;
3880+ g_free(_sc_icon_title); _sc_icon_title = NULL;
3881+ g_free(_sc_icon_desktop_file); _sc_icon_desktop_file = NULL;
3882+ g_free(_sc_icon_aptdaemon_task); _sc_icon_aptdaemon_task = NULL;
3883+ _sc_anim_icon = false;
3884+ }
3885 }
3886
3887 void Launcher::PostDraw(nux::GraphicsEngine& GfxContext, bool force_draw)
3888@@ -2114,6 +2193,7 @@
3889
3890 if (progress >= 1.0f)
3891 _model->ReorderSmart(_drag_icon, hovered_icon, true);
3892+<<<<<<< TREE
3893 else if (progress == 0.0f) {
3894 if (_drag_icon->GetIconType() == hovered_icon->GetIconType()) {
3895 _model->ReorderBefore(_drag_icon, hovered_icon, false);
3896@@ -2144,6 +2224,38 @@
3897 }
3898 }
3899 }
3900+=======
3901+ else if (progress == 0.0f) {
3902+ if (_drag_icon->GetIconType() == hovered_icon->GetIconType()) {
3903+ _model->ReorderBefore(_drag_icon, hovered_icon, false);
3904+ } else {
3905+ // LauncherModel::ReorderBefore does not work on different icon types
3906+ // so if hovered_icon is of a different type than _drag_icon
3907+ // try to use LauncherModel::ReorderAfter with the icon that is before hovered_icon
3908+ AbstractLauncherIcon::Ptr iconBeforeHover;
3909+ LauncherModel::iterator it;
3910+ LauncherModel::iterator prevIt = _model->end();
3911+ for (it = _model->begin(); it != _model->end(); it++)
3912+ {
3913+ if (!(*it)->GetQuirk(AbstractLauncherIcon::QUIRK_VISIBLE) || !(*it)->IsVisibleOnMonitor(monitor))
3914+ continue;
3915+
3916+ if ((*it) == hovered_icon) {
3917+ if (prevIt != _model->end()) {
3918+ iconBeforeHover = *prevIt;
3919+ }
3920+ break;
3921+ }
3922+
3923+ prevIt = it;
3924+ }
3925+
3926+ if (iconBeforeHover && _drag_icon != iconBeforeHover) {
3927+ _model->ReorderAfter(_drag_icon, iconBeforeHover);
3928+ }
3929+ }
3930+ }
3931+>>>>>>> MERGE-SOURCE
3932 }
3933 }
3934 }
3935@@ -2426,7 +2538,11 @@
3936 auto cb_func = sigc::mem_fun(this, &Launcher::StartIconDragTimeout);
3937 sources_.AddTimeout(START_DRAGICON_DURATION, cb_func, START_DRAGICON_TIMEOUT);
3938
3939+<<<<<<< TREE
3940 launcher_icon->mouse_down.emit(nux::GetEventButton(button_flags), monitor, key_flags);
3941+=======
3942+ launcher_icon->mouse_down.emit(nux::GetEventButton(button_flags), key_flags, monitor);
3943+>>>>>>> MERGE-SOURCE
3944 }
3945 }
3946
3947@@ -2440,17 +2556,32 @@
3948
3949 if (_icon_mouse_down && (_icon_mouse_down == launcher_icon))
3950 {
3951+<<<<<<< TREE
3952 _icon_mouse_down->mouse_up.emit(nux::GetEventButton(button_flags), monitor, key_flags);
3953+=======
3954+ _icon_mouse_down->mouse_up.emit(nux::GetEventButton(button_flags), key_flags, monitor);
3955+>>>>>>> MERGE-SOURCE
3956
3957 if (GetActionState() == ACTION_NONE)
3958 {
3959+<<<<<<< TREE
3960 _icon_mouse_down->mouse_click.emit(nux::GetEventButton(button_flags), monitor, key_flags);
3961+=======
3962+
3963+ /* This will inform the icon if the action is valid for all the monitors */
3964+ int action_monitor = options()->show_for_all ? -1 : monitor;
3965+ _icon_mouse_down->mouse_click.emit(nux::GetEventButton(button_flags), key_flags, action_monitor);
3966+>>>>>>> MERGE-SOURCE
3967 }
3968 }
3969
3970 if (launcher_icon && (_icon_mouse_down != launcher_icon))
3971 {
3972+<<<<<<< TREE
3973 launcher_icon->mouse_up.emit(nux::GetEventButton(button_flags), monitor, key_flags);
3974+=======
3975+ launcher_icon->mouse_up.emit(nux::GetEventButton(button_flags), key_flags, monitor);
3976+>>>>>>> MERGE-SOURCE
3977 }
3978
3979 if (GetActionState() == ACTION_DRAG_LAUNCHER)
3980@@ -2570,8 +2701,13 @@
3981 break;
3982 }
3983
3984+<<<<<<< TREE
3985 _hide_machine.SetQuirk(LauncherHideMachine::EXTERNAL_DND_ACTIVE, true);
3986
3987+=======
3988+ _hide_machine->SetQuirk(LauncherHideMachine::EXTERNAL_DND_ACTIVE, true);
3989+
3990+>>>>>>> MERGE-SOURCE
3991 for (auto it : _dnd_data.Uris())
3992 {
3993 if (g_str_has_suffix(it.c_str(), ".desktop"))
3994@@ -2585,16 +2721,31 @@
3995 {
3996 for (auto it : *_model)
3997 {
3998- if (it->ShouldHighlightOnDrag(_dnd_data))
3999- {
4000- it->SetQuirk(AbstractLauncherIcon::QUIRK_DESAT, false);
4001- it->SetQuirk(AbstractLauncherIcon::QUIRK_PRESENTED, true);
4002- }
4003+<<<<<<< TREE
4004+ if (it->ShouldHighlightOnDrag(_dnd_data))
4005+ {
4006+ it->SetQuirk(AbstractLauncherIcon::QUIRK_DESAT, false);
4007+ it->SetQuirk(AbstractLauncherIcon::QUIRK_PRESENTED, true);
4008+ }
4009+=======
4010+ if (it->ShouldHighlightOnDrag(_dnd_data))
4011+ {
4012+ it->SetQuirk(AbstractLauncherIcon::QUIRK_DESAT, false);
4013+ it->SetQuirk(AbstractLauncherIcon::QUIRK_DROP_PRELIGHT, true);
4014+ it->SetQuirk(AbstractLauncherIcon::QUIRK_PRESENTED, true);
4015+ }
4016+>>>>>>> MERGE-SOURCE
4017 else
4018+<<<<<<< TREE
4019 {
4020 it->SetQuirk(AbstractLauncherIcon::QUIRK_DESAT, true);
4021 it->SetQuirk(AbstractLauncherIcon::QUIRK_PRESENTED, false);
4022 }
4023+=======
4024+ {
4025+ it->SetQuirk(AbstractLauncherIcon::QUIRK_DROP_DIM, true);
4026+ }
4027+>>>>>>> MERGE-SOURCE
4028 }
4029 }
4030 else
4031@@ -2624,8 +2775,14 @@
4032
4033 for (auto it : *_model)
4034 {
4035+<<<<<<< TREE
4036 it->SetQuirk(AbstractLauncherIcon::QUIRK_DESAT, is_overlay_open);
4037 it->SetQuirk(AbstractLauncherIcon::QUIRK_PRESENTED, false);
4038+=======
4039+ it->SetQuirk(AbstractLauncherIcon::QUIRK_DROP_PRELIGHT, false);
4040+ it->SetQuirk(AbstractLauncherIcon::QUIRK_DROP_DIM, false);
4041+ it->SetQuirk(AbstractLauncherIcon::QUIRK_PRESENTED, false);
4042+>>>>>>> MERGE-SOURCE
4043 }
4044
4045 DndHoveredIconReset();
4046@@ -2694,8 +2851,13 @@
4047 {
4048 for (auto it : *_model)
4049 {
4050+<<<<<<< TREE
4051 if (it->ShouldHighlightOnDrag(_dnd_data))
4052 it->SetQuirk(AbstractLauncherIcon::QUIRK_DESAT, false);
4053+=======
4054+ if (it->ShouldHighlightOnDrag(_dnd_data))
4055+ it->SetQuirk(AbstractLauncherIcon::QUIRK_DROP_PRELIGHT, true);
4056+>>>>>>> MERGE-SOURCE
4057 else
4058 it->SetQuirk(AbstractLauncherIcon::QUIRK_DESAT, true);
4059 }
4060@@ -2821,9 +2983,15 @@
4061 }
4062 else if (_dnd_hovered_icon && _drag_action != nux::DNDACTION_NONE)
4063 {
4064+<<<<<<< TREE
4065 if (IsOverlayOpen())
4066 ubus_.SendMessage(UBUS_PLACE_VIEW_CLOSE_REQUEST);
4067
4068+=======
4069+ if (IsOverlayOpen())
4070+ ubus.SendMessage(UBUS_PLACE_VIEW_CLOSE_REQUEST);
4071+
4072+>>>>>>> MERGE-SOURCE
4073 _dnd_hovered_icon->AcceptDrop(_dnd_data);
4074 }
4075
4076@@ -2847,6 +3015,89 @@
4077 return _model->Selection();
4078 }
4079
4080+<<<<<<< TREE
4081+=======
4082+/* dbus handlers */
4083+
4084+void
4085+Launcher::handle_dbus_method_call(GDBusConnection* connection,
4086+ const gchar* sender,
4087+ const gchar* object_path,
4088+ const gchar* interface_name,
4089+ const gchar* method_name,
4090+ GVariant* parameters,
4091+ GDBusMethodInvocation* invocation,
4092+ gpointer user_data)
4093+{
4094+ if (g_strcmp0(method_name, "AddLauncherItemFromPosition") == 0)
4095+ {
4096+ Launcher* self = (Launcher*)user_data;
4097+ self->_sc_anim_icon = true;
4098+ g_free(self->_sc_icon);
4099+ g_free(self->_sc_icon_desktop_file);
4100+ g_free(self->_sc_icon_aptdaemon_task);
4101+ g_variant_get(parameters, "(ssiiiss)", &self->_sc_icon_title,
4102+ &self->_sc_icon,
4103+ &self->_sc_icon_x,
4104+ &self->_sc_icon_y,
4105+ &self->_sc_icon_size,
4106+ &self->_sc_icon_desktop_file,
4107+ &self->_sc_icon_aptdaemon_task, NULL);
4108+
4109+ g_dbus_method_invocation_return_value(invocation, nullptr);
4110+
4111+ self->EnsureAnimation();
4112+ }
4113+}
4114+
4115+void
4116+Launcher::OnBusAcquired(GDBusConnection* connection,
4117+ const gchar* name,
4118+ gpointer user_data)
4119+{
4120+ GDBusNodeInfo* introspection_data = g_dbus_node_info_new_for_xml(introspection_xml, NULL);
4121+ guint registration_id;
4122+
4123+ if (!introspection_data)
4124+ {
4125+ LOG_WARNING(logger) << "No introspection data loaded. Won't get dynamic launcher addition.";
4126+ return;
4127+ }
4128+
4129+
4130+
4131+ registration_id = g_dbus_connection_register_object(connection,
4132+ S_DBUS_PATH.c_str(),
4133+ introspection_data->interfaces[0],
4134+ &interface_vtable,
4135+ user_data,
4136+ NULL,
4137+ NULL);
4138+ if (!registration_id)
4139+ {
4140+ LOG_WARNING(logger) << "Object registration failed. Won't get dynamic launcher addition.";
4141+ }
4142+
4143+ g_dbus_node_info_unref(introspection_data);
4144+}
4145+
4146+void
4147+Launcher::OnNameAcquired(GDBusConnection* connection,
4148+ const gchar* name,
4149+ gpointer user_data)
4150+{
4151+ LOG_DEBUG(logger) << "Acquired the name " << name << " on the session bus";
4152+}
4153+
4154+void
4155+Launcher::OnNameLost(GDBusConnection* connection,
4156+ const gchar* name,
4157+ gpointer user_data)
4158+{
4159+ LOG_DEBUG(logger) << "Lost the name " << name << " on the session bus";
4160+}
4161+
4162+>>>>>>> MERGE-SOURCE
4163 //
4164 // Key navigation
4165 //
4166
4167=== modified file 'launcher/Launcher.h'
4168--- launcher/Launcher.h 2012-08-03 09:39:01 +0000
4169+++ launcher/Launcher.h 2012-08-03 16:26:24 +0000
4170@@ -95,8 +95,14 @@
4171 return _parent;
4172 };
4173
4174+<<<<<<< TREE
4175 nux::ObjectPtr<nux::View> GetActiveTooltip() const; // nullptr = no tooltip
4176
4177+=======
4178+ nux::ObjectPtr<nux::View> const& GetActiveTooltip() const;
4179+ nux::ObjectPtr<LauncherDragWindow> const& GetDraggedIcon() const;
4180+
4181+>>>>>>> MERGE-SOURCE
4182 virtual void RecvMouseUp(int x, int y, unsigned long button_flags, unsigned long key_flags);
4183 virtual void RecvMouseDown(int x, int y, unsigned long button_flags, unsigned long key_flags);
4184 virtual void RecvMouseDrag(int x, int y, int dx, int dy, unsigned long button_flags, unsigned long key_flags);
4185@@ -310,12 +316,16 @@
4186
4187 void DndReset();
4188 void DndHoveredIconReset();
4189+<<<<<<< TREE
4190 void DndTimeoutSetup();
4191
4192 LauncherModel::Ptr _model;
4193 nux::BaseWindow* _parent;
4194 nux::ObjectPtr<nux::View> _active_tooltip;
4195 QuicklistView* _active_quicklist;
4196+=======
4197+ nux::ObjectPtr<nux::View> _active_tooltip;
4198+>>>>>>> MERGE-SOURCE
4199
4200 nux::HLayout* m_Layout;
4201
4202@@ -386,9 +396,21 @@
4203
4204 ui::AbstractIconRenderer::Ptr icon_renderer;
4205 BackgroundEffectHelper bg_effect_helper_;
4206+<<<<<<< TREE
4207
4208 UBusManager ubus_;
4209 glib::SourceManager sources_;
4210+=======
4211+
4212+ gchar* _sc_icon;
4213+ gchar* _sc_icon_title;
4214+ gint32 _sc_icon_x;
4215+ gint32 _sc_icon_y;
4216+ gint32 _sc_icon_size;
4217+ gchar* _sc_icon_desktop_file;
4218+ gchar* _sc_icon_aptdaemon_task;
4219+ bool _sc_anim_icon;
4220+>>>>>>> MERGE-SOURCE
4221 };
4222
4223 }
4224
4225=== modified file 'launcher/LauncherController.cpp'
4226--- launcher/LauncherController.cpp 2012-08-03 11:58:29 +0000
4227+++ launcher/LauncherController.cpp 2012-08-03 16:26:24 +0000
4228@@ -26,21 +26,36 @@
4229 #include <Nux/BaseWindow.h>
4230 #include <NuxCore/Logger.h>
4231
4232-#include "LauncherOptions.h"
4233 #include "BamfLauncherIcon.h"
4234+#include "BFBLauncherIcon.h"
4235 #include "DesktopLauncherIcon.h"
4236 #include "DeviceLauncherIcon.h"
4237 #include "FavoriteStore.h"
4238 #include "HudLauncherIcon.h"
4239 #include "LauncherController.h"
4240-#include "LauncherControllerPrivate.h"
4241+<<<<<<< TREE
4242+#include "LauncherControllerPrivate.h"
4243+=======
4244+#include "LauncherControllerPrivate.h"
4245+#include "LauncherOptions.h"
4246+>>>>>>> MERGE-SOURCE
4247 #include "SoftwareCenterLauncherIcon.h"
4248+<<<<<<< TREE
4249 #include "unity-shared/WindowManager.h"
4250+=======
4251+#include "TimeUtil.h"
4252+>>>>>>> MERGE-SOURCE
4253 #include "TrashLauncherIcon.h"
4254+<<<<<<< TREE
4255 #include "BFBLauncherIcon.h"
4256 #include "unity-shared/UScreen.h"
4257 #include "unity-shared/UBusMessages.h"
4258 #include "unity-shared/TimeUtil.h"
4259+=======
4260+#include "UBusMessages.h"
4261+#include "UScreen.h"
4262+#include "WindowManager.h"
4263+>>>>>>> MERGE-SOURCE
4264
4265 namespace unity
4266 {
4267@@ -78,6 +93,7 @@
4268 const int launcher_minimum_show_duration = 1250;
4269 const int shortcuts_show_delay = 750;
4270 const int ignore_repeat_shortcut_duration = 250;
4271+<<<<<<< TREE
4272
4273 const std::string KEYPRESS_TIMEOUT = "keypress-timeout";
4274 const std::string LABELS_TIMEOUT = "label-show-timeout";
4275@@ -90,6 +106,11 @@
4276 GDBusInterfaceVTable Controller::Impl::interface_vtable =
4277 { Controller::Impl::OnDBusMethodCall, NULL, NULL};
4278
4279+=======
4280+}
4281+}
4282+
4283+>>>>>>> MERGE-SOURCE
4284 Controller::Impl::Impl(Display* display, Controller* parent)
4285 : parent_(parent)
4286 , model_(new LauncherModel())
4287@@ -98,7 +119,13 @@
4288 , device_section_(volume_monitor_)
4289 , show_desktop_icon_(false)
4290 , display_(display)
4291+<<<<<<< TREE
4292 , matcher_(bamf_matcher_get_default())
4293+=======
4294+ , launcher_key_press_handler_id_(0)
4295+ , launcher_label_show_handler_id_(0)
4296+ , launcher_hide_handler_id_(0)
4297+>>>>>>> MERGE-SOURCE
4298 {
4299 edge_barriers_.options = parent_->options();
4300
4301@@ -187,7 +214,12 @@
4302 launcher_ptr->GetParent()->UnReference();
4303 }
4304
4305+<<<<<<< TREE
4306 g_bus_unown_name(dbus_owner_);
4307+=======
4308+ if (bamf_timer_handler_id_ != 0)
4309+ g_source_remove(bamf_timer_handler_id_);
4310+>>>>>>> MERGE-SOURCE
4311 }
4312
4313 void Controller::Impl::EnsureLaunchers(int primary, std::vector<nux::Geometry> const& monitors)
4314@@ -266,7 +298,11 @@
4315 launcher->display = display_;
4316 launcher->monitor = monitor;
4317 launcher->options = parent_->options();
4318+<<<<<<< TREE
4319 launcher->SetModel(model_);
4320+=======
4321+ launcher->SetModel(model_.get());
4322+>>>>>>> MERGE-SOURCE
4323
4324 nux::HLayout* layout = new nux::HLayout(NUX_TRACKER_LOCATION);
4325 layout->AddView(launcher, 1);
4326@@ -350,11 +386,19 @@
4327 return;
4328 }
4329
4330+<<<<<<< TREE
4331 // Check if desktop file was supplied, or if it's set to SC's agent
4332 // See https://bugs.launchpad.net/unity/+bug/1002440
4333 if (path.empty() || path == "software-center-agent")
4334 return;
4335
4336+=======
4337+ // Check if desktop file was supplied, or if it's set to SC's agent
4338+ // See https://bugs.launchpad.net/unity/+bug/1002440
4339+ if (path.empty() || path == "software-center-agent")
4340+ return;
4341+
4342+>>>>>>> MERGE-SOURCE
4343 SoftwareCenterLauncherIcon::Ptr result = CreateSCLauncherIcon(path, aptdaemon_trans_id, icon_path);
4344
4345 CurrentLauncher()->ForceReveal(true);
4346@@ -1073,12 +1117,22 @@
4347 }
4348
4349 if (activate)
4350+<<<<<<< TREE
4351 {
4352 pimpl->sources_.AddIdle([this] {
4353 pimpl->model_->Selection()->Activate(ActionArg(ActionArg::LAUNCHER, 0));
4354 return false;
4355 });
4356 }
4357+=======
4358+ {
4359+ g_idle_add([] (gpointer data) -> gboolean {
4360+ Controller *self = (Controller*)data;
4361+ self->pimpl->model_->Selection()->Activate(ActionArg(ActionArg::LAUNCHER, 0));
4362+ return FALSE;
4363+ }, this);
4364+ }
4365+>>>>>>> MERGE-SOURCE
4366
4367 pimpl->launcher_keynav = false;
4368 if (!pimpl->launcher_open)
4369
4370=== modified file 'launcher/LauncherController.h'
4371=== modified file 'launcher/LauncherIcon.cpp'
4372--- launcher/LauncherIcon.cpp 2012-07-10 15:51:59 +0000
4373+++ launcher/LauncherIcon.cpp 2012-08-03 16:26:24 +0000
4374@@ -621,13 +621,21 @@
4375 return true;
4376 }
4377
4378+<<<<<<< TREE
4379 void LauncherIcon::RecvMouseDown(int button, int monitor, unsigned long key_flags)
4380+=======
4381+void LauncherIcon::RecvMouseDown(int button, unsigned long key_flags, int monitor)
4382+>>>>>>> MERGE-SOURCE
4383 {
4384 if (button == 3)
4385 OpenQuicklist();
4386 }
4387
4388+<<<<<<< TREE
4389 void LauncherIcon::RecvMouseUp(int button, int monitor, unsigned long key_flags)
4390+=======
4391+void LauncherIcon::RecvMouseUp(int button, unsigned long key_flags, int monitor)
4392+>>>>>>> MERGE-SOURCE
4393 {
4394 if (button == 3)
4395 {
4396@@ -636,15 +644,25 @@
4397 }
4398 }
4399
4400+<<<<<<< TREE
4401 void LauncherIcon::RecvMouseClick(int button, int monitor, unsigned long key_flags)
4402+=======
4403+void LauncherIcon::RecvMouseClick(int button, unsigned long key_flags, int monitor)
4404+>>>>>>> MERGE-SOURCE
4405 {
4406 ActionArg arg(ActionArg::LAUNCHER, button);
4407 arg.monitor = monitor;
4408-
4409- bool shift_pressed = nux::GetKeyModifierState(key_flags, nux::NUX_STATE_SHIFT);
4410-
4411- // Click without shift
4412- if (button == 1 && !shift_pressed)
4413+ bool shift_pressed = nux::GetKeyModifierState(key_flags, nux::NUX_STATE_SHIFT);
4414+
4415+<<<<<<< TREE
4416+ bool shift_pressed = nux::GetKeyModifierState(key_flags, nux::NUX_STATE_SHIFT);
4417+
4418+ // Click without shift
4419+ if (button == 1 && !shift_pressed)
4420+=======
4421+ // Click without shift
4422+ if (button == 1 && !shift_pressed)
4423+>>>>>>> MERGE-SOURCE
4424 Activate(arg);
4425 // Middle click or click with shift
4426 else if ((button == 2) || (button == 1 && shift_pressed))
4427@@ -852,11 +870,33 @@
4428 UBusServer* ubus = ubus_server_get_default();
4429 ubus_server_send_message(ubus, UBUS_LAUNCHER_ICON_URGENT_CHANGED, g_variant_new_boolean(value));
4430 }
4431-
4432- if (quirk == QUIRK_VISIBLE)
4433- {
4434- visibility_changed.emit();
4435- }
4436+<<<<<<< TREE
4437+
4438+ if (quirk == QUIRK_VISIBLE)
4439+ {
4440+ visibility_changed.emit();
4441+ }
4442+=======
4443+
4444+ if (quirk == QUIRK_VISIBLE)
4445+ {
4446+ visibility_changed.emit();
4447+ }
4448+}
4449+
4450+gboolean
4451+LauncherIcon::OnDelayedUpdateTimeout(gpointer data)
4452+{
4453+ DelayedUpdateArg* arg = (DelayedUpdateArg*) data;
4454+ LauncherIcon* self = arg->self;
4455+
4456+ clock_gettime(CLOCK_MONOTONIC, &(self->_quirk_times[arg->quirk]));
4457+ self->EmitNeedsRedraw();
4458+
4459+ self->_time_delay_handle = 0;
4460+
4461+ return false;
4462+>>>>>>> MERGE-SOURCE
4463 }
4464
4465 void
4466
4467=== modified file 'launcher/LauncherIcon.h'
4468--- launcher/LauncherIcon.h 2012-06-18 02:57:23 +0000
4469+++ launcher/LauncherIcon.h 2012-08-03 16:26:24 +0000
4470@@ -70,11 +70,19 @@
4471
4472 void RecvMouseLeave(int monitor);
4473
4474+<<<<<<< TREE
4475 void RecvMouseDown(int button, int monitor, unsigned long key_flags = 0);
4476
4477 void RecvMouseUp(int button, int monitor, unsigned long key_flags = 0);
4478
4479 void RecvMouseClick(int button, int monitor, unsigned long key_flags = 0);
4480+=======
4481+ void RecvMouseDown(int button, unsigned long key_flags, int monitor);
4482+
4483+ void RecvMouseUp(int button, unsigned long key_flags, int monitor);
4484+
4485+ void RecvMouseClick(int button, unsigned long key_flags, int monitor);
4486+>>>>>>> MERGE-SOURCE
4487
4488 void HideTooltip();
4489
4490
4491=== modified file 'launcher/MockLauncherIcon.h'
4492=== modified file 'launcher/PointerBarrier.h'
4493=== modified file 'launcher/QuicklistMenuItem.cpp'
4494=== modified file 'launcher/QuicklistMenuItem.h'
4495=== modified file 'launcher/QuicklistMenuItemSeparator.cpp'
4496=== modified file 'launcher/QuicklistMenuItemSeparator.h'
4497=== modified file 'launcher/QuicklistView.cpp'
4498--- launcher/QuicklistView.cpp 2012-07-25 16:00:26 +0000
4499+++ launcher/QuicklistView.cpp 2012-08-03 16:26:24 +0000
4500@@ -302,7 +302,14 @@
4501 case NUX_KP_ENTER:
4502 if (IsMenuItemSelectable(_current_item_index))
4503 {
4504+<<<<<<< TREE
4505 ActivateItem(GetNthItems(_current_item_index));
4506+=======
4507+ dbusmenu_menuitem_handle_event(GetNthItems(_current_item_index)->_menuItem,
4508+ "clicked",
4509+ NULL,
4510+ 0);
4511+>>>>>>> MERGE-SOURCE
4512 Hide();
4513 }
4514 break;
4515@@ -314,6 +321,7 @@
4516
4517 QuicklistView::~QuicklistView()
4518 {
4519+<<<<<<< TREE
4520 for (auto item : _item_list)
4521 {
4522 // Remove from introspection
4523@@ -321,6 +329,16 @@
4524 item->UnReference();
4525 }
4526
4527+=======
4528+ std::list<QuicklistMenuItem*>::iterator it;
4529+ for (it = _item_list.begin(); it != _item_list.end(); it++)
4530+ {
4531+ // Remove from introspection
4532+ RemoveChild(*it);
4533+ (*it)->UnReference();
4534+ }
4535+
4536+>>>>>>> MERGE-SOURCE
4537 _item_list.clear();
4538 }
4539
4540@@ -337,7 +355,11 @@
4541
4542 if (!_enable_quicklist_for_testing)
4543 {
4544+<<<<<<< TREE
4545 if (!_item_list.empty())
4546+=======
4547+ if ((_item_list.size() != 0))
4548+>>>>>>> MERGE-SOURCE
4549 {
4550 int offscreen_size = GetBaseY() +
4551 GetBaseHeight() -
4552@@ -418,12 +440,22 @@
4553
4554 gfxContext.PushClippingRectangle(base);
4555
4556+<<<<<<< TREE
4557 for (auto item : _item_list)
4558 {
4559 if (item->GetVisible())
4560 item->ProcessDraw(gfxContext, forceDraw);
4561 }
4562
4563+=======
4564+ std::list<QuicklistMenuItem*>::iterator it;
4565+ for (it = _item_list.begin(); it != _item_list.end(); it++)
4566+ {
4567+ if ((*it)->GetVisible())
4568+ (*it)->ProcessDraw(gfxContext, forceDraw);
4569+ }
4570+
4571+>>>>>>> MERGE-SOURCE
4572 gfxContext.PopClippingRectangle();
4573 }
4574
4575@@ -435,6 +467,7 @@
4576 int MaxItemWidth = 0;
4577 int TotalItemHeight = 0;
4578
4579+<<<<<<< TREE
4580 for (auto item : _item_list)
4581 {
4582 // Make sure item is in layout if it should be
4583@@ -454,6 +487,26 @@
4584 textHeight += QuicklistMenuItem::ITEM_MARGIN * 2;
4585
4586 MaxItemWidth = std::max(MaxItemWidth, textWidth);
4587+=======
4588+ std::list<QuicklistMenuItem*>::iterator it;
4589+ for (it = _item_list.begin(); it != _item_list.end(); it++)
4590+ {
4591+ // Make sure item is in layout if it should be
4592+ if (!(*it)->GetVisible())
4593+ {
4594+ _item_layout->RemoveChildObject(*it);
4595+ continue;
4596+ }
4597+ else if (!(*it)->GetParentObject())
4598+ _item_layout->AddView(*it, 1, nux::eCenter, nux::eFull);
4599+
4600+ int textWidth = 0;
4601+ int textHeight = 0;
4602+ (*it)->GetTextExtents(textWidth, textHeight);
4603+ if (textWidth > MaxItemWidth)
4604+ MaxItemWidth = textWidth;
4605+ textHeight += QuicklistMenuItem::ITEM_MARGIN * 2;
4606+>>>>>>> MERGE-SOURCE
4607 TotalItemHeight += textHeight;
4608 }
4609
4610@@ -492,6 +545,7 @@
4611 UpdateTexture();
4612
4613 int x = _padding + _anchor_width + _corner_radius + _offset_correction;
4614+<<<<<<< TREE
4615 int y = _top_space->GetMinimumHeight();
4616
4617 for (auto item : _item_list)
4618@@ -505,11 +559,28 @@
4619 y += item->GetBaseHeight();
4620 }
4621
4622+=======
4623+ int y = _top_space->GetMinimumHeight();
4624+
4625+ std::list<QuicklistMenuItem*>::iterator it;
4626+ for (it = _item_list.begin(); it != _item_list.end(); it++)
4627+ {
4628+ if (!(*it)->GetVisible())
4629+ continue;
4630+
4631+ (*it)->SetBaseX(x);
4632+ (*it)->SetBaseY(y);
4633+
4634+ y += (*it)->GetBaseHeight();
4635+ }
4636+
4637+>>>>>>> MERGE-SOURCE
4638 // We must correct the width of line separators. The rendering of the separator can be smaller than the width of the
4639 // quicklist. The reason for that is, the quicklist width is determined by the largest entry it contains. That size is
4640 // only after MaxItemWidth is computed in QuicklistView::PreLayoutManagement.
4641 // The setting of the separator width is done here after the Layout cycle for this widget is over. The width of the separator
4642 // has bee set correctly during the layout cycle, but the cairo rendering still need to be adjusted.
4643+<<<<<<< TREE
4644 int separator_width = _item_layout->GetBaseWidth();
4645
4646 for (auto item : _item_list)
4647@@ -521,6 +592,20 @@
4648 }
4649 }
4650
4651+=======
4652+ int separator_width = _item_layout->GetBaseWidth();
4653+
4654+ for (it = _item_list.begin(); it != _item_list.end(); it++)
4655+ {
4656+ QuicklistMenuItem* item = (QuicklistMenuItem*)(*it);
4657+ if (item->GetVisible() && item->CairoSurfaceWidth() != separator_width)
4658+ {
4659+ // Compute textures of the item.
4660+ item->UpdateTexture();
4661+ }
4662+ }
4663+
4664+>>>>>>> MERGE-SOURCE
4665 return result;
4666 }
4667
4668@@ -563,6 +648,7 @@
4669 ActivateItem(item);
4670 }
4671 }
4672+<<<<<<< TREE
4673 }
4674
4675 void QuicklistView::ActivateItem(QuicklistMenuItem* item)
4676@@ -575,6 +661,8 @@
4677
4678 dbusmenu_menuitem_handle_event(item->_menuItem, "clicked", NULL, 0);
4679 }
4680+=======
4681+>>>>>>> MERGE-SOURCE
4682 }
4683
4684 void QuicklistView::RecvItemMouseRelease(QuicklistMenuItem* item, int x, int y)
4685@@ -593,16 +681,29 @@
4686
4687 void QuicklistView::CancelItemsPrelightStatus()
4688 {
4689+<<<<<<< TREE
4690 for (auto item : _item_list)
4691 {
4692 item->_prelight = false;
4693 }
4694+=======
4695+ std::list<QuicklistMenuItem*>::iterator it;
4696+ for (it = _item_list.begin(); it != _item_list.end(); it++)
4697+ {
4698+ (*it)->_prelight = false;
4699+ }
4700+>>>>>>> MERGE-SOURCE
4701 }
4702
4703 void QuicklistView::RecvItemMouseDrag(QuicklistMenuItem* item, int x, int y)
4704 {
4705 nux::Geometry geo;
4706- for (auto it : _item_list)
4707+<<<<<<< TREE
4708+ for (auto it : _item_list)
4709+=======
4710+
4711+ for (auto it : _item_list)
4712+>>>>>>> MERGE-SOURCE
4713 {
4714 int item_index = GetItemIndex(it);
4715
4716@@ -683,7 +784,10 @@
4717 item->UnReference();
4718 }
4719
4720+<<<<<<< TREE
4721
4722+=======
4723+>>>>>>> MERGE-SOURCE
4724 _item_list.clear();
4725
4726 _item_layout->Clear();
4727
4728=== modified file 'launcher/QuicklistView.h'
4729--- launcher/QuicklistView.h 2012-07-11 06:21:46 +0000
4730+++ launcher/QuicklistView.h 2012-08-03 16:26:24 +0000
4731@@ -131,10 +131,15 @@
4732 //! Check the mouse up event sent by an item. Detect the item where the mous is and emit the appropriate signal.
4733 void CheckAndEmitItemSignal(int x, int y);
4734
4735+<<<<<<< TREE
4736 void ActivateItem(QuicklistMenuItem* item);
4737
4738 void SelectItem(int index);
4739 bool IsMenuItemSelectable(int index);
4740+=======
4741+ void SelectItem(int index);
4742+ bool IsMenuItemSelectable(int index);
4743+>>>>>>> MERGE-SOURCE
4744
4745 //nux::CairoGraphics* _cairo_graphics;
4746 int _anchorX;
4747
4748=== modified file 'launcher/SimpleLauncherIcon.cpp'
4749--- launcher/SimpleLauncherIcon.cpp 2012-06-01 04:00:29 +0000
4750+++ launcher/SimpleLauncherIcon.cpp 2012-08-03 16:26:24 +0000
4751@@ -69,6 +69,7 @@
4752 g_signal_handler_disconnect(gtk_icon_theme_get_default(), theme_changed_id_);
4753 }
4754
4755+<<<<<<< TREE
4756 void SimpleLauncherIcon::OnMouseDown(int button, int monitor, unsigned long key_flags)
4757 {
4758 }
4759@@ -78,6 +79,17 @@
4760 }
4761
4762 void SimpleLauncherIcon::OnMouseClick(int button, int monitor, unsigned long key_flags)
4763+=======
4764+void SimpleLauncherIcon::OnMouseDown(int button, unsigned long key_flags, int monitor)
4765+{
4766+}
4767+
4768+void SimpleLauncherIcon::OnMouseUp(int button, unsigned long key_flags, int monitor)
4769+{
4770+}
4771+
4772+void SimpleLauncherIcon::OnMouseClick(int button, unsigned long key_flags, int monitor)
4773+>>>>>>> MERGE-SOURCE
4774 {
4775 }
4776
4777
4778=== modified file 'launcher/SimpleLauncherIcon.h'
4779--- launcher/SimpleLauncherIcon.h 2012-06-01 04:00:29 +0000
4780+++ launcher/SimpleLauncherIcon.h 2012-08-03 16:26:24 +0000
4781@@ -49,11 +49,18 @@
4782 std::string GetName() const;
4783 void AddProperties(GVariantBuilder* builder);
4784
4785+<<<<<<< TREE
4786 virtual void OnMouseDown(int button, int monitor, unsigned long key_flags = 0);
4787 virtual void OnMouseUp(int button, int monitor, unsigned long key_flags = 0);
4788 virtual void OnMouseClick(int button, int monitor, unsigned long key_flags = 0);
4789+=======
4790+ virtual void OnMouseDown(int button, unsigned long key_flags, int monitor);
4791+ virtual void OnMouseUp(int button, unsigned long key_flags, int monitor);
4792+ virtual void OnMouseClick(int button, unsigned long key_flags, int monitor);
4793+>>>>>>> MERGE-SOURCE
4794 virtual void OnMouseEnter(int monitor);
4795 virtual void OnMouseLeave(int monitor);
4796+
4797 virtual void ActivateLauncherIcon(ActionArg arg);
4798
4799 private:
4800
4801=== modified file 'launcher/SoftwareCenterLauncherIcon.cpp'
4802--- launcher/SoftwareCenterLauncherIcon.cpp 2012-07-25 03:11:05 +0000
4803+++ launcher/SoftwareCenterLauncherIcon.cpp 2012-08-03 16:26:24 +0000
4804@@ -47,12 +47,25 @@
4805 {
4806
4807 aptdaemon_trans_.Connect("PropertyChanged", sigc::mem_fun(this, &SoftwareCenterLauncherIcon::OnPropertyChanged));
4808- aptdaemon_trans_.Connect("Finished", sigc::mem_fun(this, &SoftwareCenterLauncherIcon::OnFinished));
4809-
4810- SetIconType(TYPE_APPLICATION);
4811- icon_name = icon_path;
4812- if (!aptdaemon_trans_id_.empty()) // Application is being installed, or hasn't been installed yet
4813- tooltip_text = _("Waiting to install");
4814+<<<<<<< TREE
4815+ aptdaemon_trans_.Connect("Finished", sigc::mem_fun(this, &SoftwareCenterLauncherIcon::OnFinished));
4816+
4817+ SetIconType(TYPE_APPLICATION);
4818+ icon_name = icon_path;
4819+ if (!aptdaemon_trans_id_.empty()) // Application is being installed, or hasn't been installed yet
4820+ tooltip_text = _("Waiting to install");
4821+=======
4822+ aptdaemon_trans_.Connect("Finished", sigc::mem_fun(this, &SoftwareCenterLauncherIcon::OnFinished));
4823+
4824+ SetIconType(TYPE_APPLICATION);
4825+ icon_name = icon_path;
4826+ if (!aptdaemon_trans_id_.empty()) // Application is being installed, or hasn't been installed yet
4827+ tooltip_text = _("Waiting to install");
4828+ else {
4829+ SetQuirk(QUIRK_URGENT, true);
4830+ needs_urgent_ = true;
4831+ }
4832+>>>>>>> MERGE-SOURCE
4833 }
4834
4835 void SoftwareCenterLauncherIcon::Animate(nux::ObjectPtr<Launcher> launcher,
4836
4837=== modified file 'launcher/SoftwareCenterLauncherIcon.h'
4838=== modified file 'launcher/StandaloneLauncher.cpp'
4839--- launcher/StandaloneLauncher.cpp 2012-07-27 20:20:29 +0000
4840+++ launcher/StandaloneLauncher.cpp 2012-08-03 16:26:24 +0000
4841@@ -31,12 +31,22 @@
4842 #include "NuxGraphics/GraphicsEngine.h"
4843 #include <gtk/gtk.h>
4844
4845+<<<<<<< TREE
4846 #include "unity-shared/BackgroundEffectHelper.h"
4847 #include "FavoriteStoreGSettings.h"
4848+=======
4849+#include "BackgroundEffectHelper.h"
4850+#include "FavoriteStoreGSettings.h"
4851+>>>>>>> MERGE-SOURCE
4852 #include "LauncherController.h"
4853 #include "Launcher.h"
4854+<<<<<<< TREE
4855 #include "unity-shared/PanelStyle.h"
4856 #include "unity-shared/UnitySettings.h"
4857+=======
4858+#include "PanelStyle.h"
4859+
4860+>>>>>>> MERGE-SOURCE
4861 #include <dbus/dbus-glib.h>
4862
4863 using namespace unity;
4864@@ -59,10 +69,17 @@
4865
4866 nux::NuxInitialize(0);
4867
4868+<<<<<<< TREE
4869 unity::Settings settings;
4870 panel::Style panel_style;
4871 internal::FavoriteStoreGSettings favorite_store;
4872
4873+=======
4874+ GeisAdapter geis_adapter;
4875+ panel::Style panel_style;
4876+ internal::FavoriteStoreGSettings favorite_store;
4877+
4878+>>>>>>> MERGE-SOURCE
4879 BackgroundEffectHelper::blur_type = BLUR_NONE;
4880 nux::WindowThread* wt = nux::CreateGUIThread(TEXT("Unity Switcher"), 300, 800, 0, &ThreadWidgetInit, 0);
4881
4882
4883=== modified file 'launcher/SwitcherController.cpp'
4884--- launcher/SwitcherController.cpp 2012-08-02 02:14:22 +0000
4885+++ launcher/SwitcherController.cpp 2012-08-03 16:26:24 +0000
4886@@ -154,11 +154,19 @@
4887
4888 ConstructView();
4889
4890+<<<<<<< TREE
4891 ubus_manager_.SendMessage(UBUS_SWITCHER_START, NULL);
4892
4893 if (view_window_) {
4894 view_window_->ShowWindow(true);
4895 view_window_->PushToFront();
4896+=======
4897+ ubus_manager_.SendMessage(UBUS_SWITCHER_START);
4898+
4899+ if (view_window_) {
4900+ view_window_->ShowWindow(true);
4901+ view_window_->PushToFront();
4902+>>>>>>> MERGE-SOURCE
4903 view_window_->SetOpacity(1.0f);
4904 }
4905 }
4906@@ -239,11 +247,21 @@
4907 }
4908 }
4909
4910+<<<<<<< TREE
4911 ubus_manager_.SendMessage(UBUS_SWITCHER_END, g_variant_new_boolean(!accept_state));
4912
4913 sources_.Remove(VIEW_CONSTRUCT_IDLE);
4914 sources_.Remove(SHOW_TIMEOUT);
4915 sources_.Remove(DETAIL_TIMEOUT);
4916+=======
4917+ ubus_manager_.SendMessage(UBUS_SWITCHER_END, g_variant_new_boolean(!accept_state));
4918+
4919+ if (view_idle_timer_)
4920+ {
4921+ g_source_remove(view_idle_timer_);
4922+ view_idle_timer_ = 0;
4923+ }
4924+>>>>>>> MERGE-SOURCE
4925
4926 model_.reset();
4927 visible_ = false;
4928@@ -388,6 +406,7 @@
4929 return view_->ExternalTargets();
4930 }
4931
4932+<<<<<<< TREE
4933 guint Controller::GetSwitcherInputWindowId() const
4934 {
4935 return view_window_->GetInputWindowId();
4936@@ -408,11 +427,19 @@
4937 return (show_desktop_disabled_ ? 0 : 1);
4938 }
4939
4940+=======
4941+guint Controller::GetSwitcherInputWindowId() const
4942+{
4943+ return view_window_->GetInputWindowId();
4944+}
4945+
4946+>>>>>>> MERGE-SOURCE
4947 bool Controller::CompareSwitcherItemsPriority(AbstractLauncherIcon::Ptr first,
4948 AbstractLauncherIcon::Ptr second)
4949 {
4950 if (first->GetIconType() == second->GetIconType())
4951 return first->SwitcherPriority() > second->SwitcherPriority();
4952+<<<<<<< TREE
4953
4954 if (first->GetIconType() == AbstractLauncherIcon::IconType::TYPE_DESKTOP)
4955 return true;
4956@@ -420,6 +447,14 @@
4957 if (second->GetIconType() == AbstractLauncherIcon::IconType::TYPE_DESKTOP)
4958 return false;
4959
4960+=======
4961+
4962+ if (first->GetIconType() == AbstractLauncherIcon::IconType::TYPE_DESKTOP)
4963+ return true;
4964+
4965+ if (second->GetIconType() == AbstractLauncherIcon::IconType::TYPE_DESKTOP)
4966+ return false;
4967+>>>>>>> MERGE-SOURCE
4968 return first->GetIconType() < second->GetIconType();
4969 }
4970
4971
4972=== modified file 'launcher/SwitcherController.h'
4973--- launcher/SwitcherController.h 2012-07-27 01:06:27 +0000
4974+++ launcher/SwitcherController.h 2012-08-03 16:26:24 +0000
4975@@ -90,12 +90,17 @@
4976
4977 ui::LayoutWindowList ExternalRenderTargets ();
4978
4979+<<<<<<< TREE
4980 guint GetSwitcherInputWindowId() const;
4981
4982 bool IsShowDesktopDisabled() const;
4983 void SetShowDesktopDisabled(bool disabled);
4984 int StartIndex() const;
4985
4986+=======
4987+ guint GetSwitcherInputWindowId() const;
4988+
4989+>>>>>>> MERGE-SOURCE
4990 protected:
4991 // Introspectable methods
4992 std::string GetName() const;
4993
4994=== modified file 'launcher/SwitcherView.h'
4995--- launcher/SwitcherView.h 2012-06-18 02:57:23 +0000
4996+++ launcher/SwitcherView.h 2012-08-03 16:26:24 +0000
4997@@ -24,8 +24,16 @@
4998 #include "unity-shared/AbstractIconRenderer.h"
4999 #include "unity-shared/StaticCairoText.h"
5000 #include "LayoutSystem.h"
The diff has been truncated for viewing.