Merge lp:~3v1n0/unity/icon-activation-overlay-focus-fix into lp:unity
Proposed by
Marco Trevisan (Treviño)
Status: | Merged |
---|---|
Approved by: | Brandon Schaefer |
Approved revision: | no longer in the source branch. |
Merged at revision: | 3552 |
Proposed branch: | lp:~3v1n0/unity/icon-activation-overlay-focus-fix |
Merge into: | lp:unity |
Diff against target: |
358 lines (+79/-57) 9 files modified
dash/DashController.cpp (+8/-20) dash/DashController.h (+2/-2) dash/DashView.cpp (+1/-1) hud/HudController.cpp (+12/-28) hud/HudController.h (+1/-1) launcher/SimpleLauncherIcon.cpp (+1/-1) plugins/unityshell/src/unityshell.cpp (+2/-2) tests/autopilot/unity/tests/launcher/test_icon_behavior.py (+32/-2) tests/test_application_launcher_icon.cpp (+20/-0) |
To merge this branch: | bzr merge lp:~3v1n0/unity/icon-activation-overlay-focus-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brandon Schaefer (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
Commit message
SimpleLauncherIcon: we need to restore the focus when closing the Overlay for activation
Description of the change
Always make the Dash/Hud restore the input focus when hidden, also don't
save it when showing it, giving the focus back to the default window
is just enough.
This fixes a focus issue we had when clicking on a launcher icon when
an overlay was opened.
Added both unit and AP tests.
To post a comment you must log in.
PASSED: Continuous integration, rev:3558 jenkins. qa.ubuntu. com/job/ unity-ci/ 417/ jenkins. qa.ubuntu. com/job/ unity-saucy- amd64-ci/ 306 jenkins. qa.ubuntu. com/job/ unity-saucy- armhf-ci/ 304 jenkins. qa.ubuntu. com/job/ unity-saucy- i386-ci/ 305
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ unity-ci/ 417/rebuild
http://