Merge lp:~3v1n0/unity/ibus-press-release-tests into lp:unity

[Marco Trevisan (Treviño)]

Tests ibus: added tests for ibus activation on press and release

These won't pass until lp:~3v1n0/unity/im-textentry-rewrite-ibus-fix is merged.

Added AP tests for ibus activation on keydown and on keyup.

[jenkins (martin-mrazik+qa)]

PASSED: Continuous integration, rev:2445
http://s-jenkins:8080/job/unity-ci/59/

review: Approve (continuous-integration)

[Thomi Richards (thomir-deactivatedaccount)]

Hi,

24 def activate_ibus(self, widget):
25 """Activate IBus, and wait till it's actived on 'widget'"""
26 self.assertThat(widget.im_active, Equals(False))
27 - self.keyboard.press_and_release('Ctrl+Space', 0.05)
28 + self.keyboard.press(self.activate_binding, 0.05)
29 + self.addCleanup(self.keyboard.release, self.activate_binding, 0.05)
30 self.assertThat(widget.im_active, Eventually(Equals(True)))
31 + self.keyboard.release(self.activate_binding, 0.05)
32
33 def deactivate_ibus(self, widget):
34 """Deactivate ibus, and wait till it's inactive on 'widget'"""
35 self.assertThat(widget.im_active, Equals(True))
36 - self.keyboard.press_and_release('Ctrl+Space', 0.05)
37 + self.keyboard.press(self.activate_binding, 0.05)
38 + self.addCleanup(self.keyboard.release, self.activate_binding, 0.05)
39 + self.assertThat(widget.im_active, Eventually(Equals(False)))
40 + self.keyboard.release(self.activate_binding, 0.05)
41 +

Please change these so the keypresses aren't released twice (which will happen currently if the activation is successful).

42 + def activate_ibus_on_release(self, widget):
43 + """Activate IBus, and wait till it's actived on 'widget'"""

50 +
51 + def deactivate_ibus_on_release(self, widget):
52 + """Activate IBus, and wait till it's actived on 'widget'"""

Please update these docstrings - I have no idea what these do currently - how are they different from the regulat activate & deactivate methods, and why are they needed?

review: Needs Fixing (quality)

[jenkins (martin-mrazik+qa)]

FAILED: Continuous integration, rev:2446
http://jenkins.qa.ubuntu.com/job/unity-ci/89/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-ci/./distribution=quantal,flavor=amd64/89/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-ci/./distribution=quantal,flavor=i386/89/console

review: Needs Fixing (continuous-integration)

=== modified file 'tests/autopilot/unity/tests/test_ibus.py'
--- tests/autopilot/unity/tests/test_ibus.py	2012-05-16 02:57:25 +0000
+++ tests/autopilot/unity/tests/test_ibus.py	2012-07-17 23:38:20 +0000
@@ -18,6 +18,8 @@
 from autopilot.matchers import Eventually
 from autopilot.testcase import multiply_scenarios
 from testtools.matchers import Equals, NotEquals
+from unity.emulators.dash import Dash
+from unity.emulators.hud import Hud
 
 from unity.tests import UnityTestCase
 
@@ -25,7 +27,24 @@
 class IBusTests(UnityTestCase):
     """Base class for IBus tests."""
 
+    scenarios = [
+        ('dash', {'widget': Dash()}),
+        ('hud', {'widget': Hud()})
+    ]
+
     def setUp(self):
+        self.activate_binding = 'Control+space'
+        self.activate_release_binding = 'Alt+Control_L'
+
+        activate_release_binding_option = 'Alt+Release+Control_L'
+        trigger_hotkey_path = '/desktop/ibus/general/hotkey/trigger'
+
+        old_keys = self.get_gconf_option(trigger_hotkey_path)
+        new_keys = [self.activate_binding, activate_release_binding_option]
+
+        self.set_gconf_option(trigger_hotkey_path, new_keys)
+        self.addCleanup(self.set_gconf_option, trigger_hotkey_path, old_keys)
+
         super(IBusTests, self).setUp()
 
     def tearDown(self):
@@ -51,13 +70,25 @@
     def activate_ibus(self, widget):
         """Activate IBus, and wait till it's actived on 'widget'"""
         self.assertThat(widget.im_active, Equals(False))
-        self.keyboard.press_and_release('Ctrl+Space', 0.05)
+        self.keyboard.press_and_release(self.activate_binding)
         self.assertThat(widget.im_active, Eventually(Equals(True)))
 
     def deactivate_ibus(self, widget):
         """Deactivate ibus, and wait till it's inactive on 'widget'"""
         self.assertThat(widget.im_active, Equals(True))
-        self.keyboard.press_and_release('Ctrl+Space', 0.05)
+        self.keyboard.press_and_release(self.activate_binding)
+        self.assertThat(widget.im_active, Eventually(Equals(False)))
+
+    def activate_ibus_on_release(self, widget):
+        """Activate IBus when keys have been released, and wait till it's actived on 'widget'"""
+        self.assertThat(widget.im_active, Equals(False))
+        self.keyboard.press_and_release(self.activate_release_binding)
+        self.assertThat(widget.im_active, Eventually(Equals(True)))
+
+    def deactivate_ibus_on_release(self, widget):
+        """Activate IBus when keys have been released, and wait till it's actived on 'widget'"""
+        self.assertThat(widget.im_active, Equals(True))
+        self.keyboard.press_and_release(self.activate_release_binding)
         self.assertThat(widget.im_active, Eventually(Equals(False)))
 
     def do_dash_test_with_engine(self):
@@ -82,6 +113,59 @@
         self.deactivate_ibus(self.hud.searchbar)
         self.assertThat(self.hud.search_string, Eventually(Equals(self.result)))
 
+    def test_activate(self):
+        """Tests the ibus activation using the "key-down" keybinding"""
+        self.widget.ensure_visible()
+        self.addCleanup(self.widget.ensure_hidden)
+
+        self.assertThat(self.widget.searchbar.im_active, Equals(False))
+        self.keyboard.press(self.activate_binding)
+        self.addCleanup(self.keyboard.release, self.activate_binding)
+        self.assertThat(self.widget.searchbar.im_active, Eventually(Equals(True)))
+        self.keyboard.release(self.activate_binding)
+
+        self.deactivate_ibus(self.widget.searchbar)
+
+    def test_deactivate(self):
+        """Tests the ibus deactivation using the "key-down" keybinding"""
+        self.widget.ensure_visible()
+        self.addCleanup(self.widget.ensure_hidden)
+        self.activate_ibus(self.widget.searchbar)
+
+        self.assertThat(self.widget.searchbar.im_active, Equals(True))
+        self.keyboard.press(self.activate_binding)
+        self.addCleanup(self.keyboard.release, self.activate_binding)
+        self.assertThat(self.widget.searchbar.im_active, Eventually(Equals(False)))
+        self.keyboard.release(self.activate_binding)
+        self.assertThat(self.widget.searchbar.im_active, Eventually(Equals(False)))
+
+    def test_activate_on_release(self):
+        """Tests the ibus activation using "key-up" keybinding"""
+        self.widget.ensure_visible()
+        self.addCleanup(self.widget.ensure_hidden)
+
+        self.assertThat(self.widget.searchbar.im_active, Equals(False))
+        self.keyboard.press(self.activate_release_binding)
+        self.addCleanup(self.keyboard.release, self.activate_release_binding)
+        self.assertThat(self.widget.searchbar.im_active, Eventually(Equals(False)))
+        self.keyboard.release(self.activate_release_binding)
+        self.assertThat(self.widget.searchbar.im_active, Eventually(Equals(True)))
+
+        self.deactivate_ibus_on_release(self.widget.searchbar)
+
+    def test_deactivate_on_release(self):
+        """Tests the ibus deactivation using "key-up" keybinding"""
+        self.widget.ensure_visible()
+        self.addCleanup(self.widget.ensure_hidden)
+        self.activate_ibus_on_release(self.widget.searchbar)
+
+        self.assertThat(self.widget.searchbar.im_active, Equals(True))
+        self.keyboard.press(self.activate_release_binding)
+        self.addCleanup(self.keyboard.release, self.activate_release_binding)
+        self.assertThat(self.widget.searchbar.im_active, Eventually(Equals(True)))
+        self.keyboard.release(self.activate_release_binding)
+        self.assertThat(self.widget.searchbar.im_active, Eventually(Equals(False)))
+
 
 class IBusTestsPinyin(IBusTests):
     """Tests for the Pinyin(Chinese) input engine."""