Merge lp:~3v1n0/unity/gtest-1.8-fixes into lp:unity
- gtest-1.8-fixes
- Merge into trunk
Proposed by
Marco Trevisan (Treviño)
Status: | Merged |
---|---|
Approved by: | Andrea Azzarone |
Approved revision: | no longer in the source branch. |
Merged at revision: | 4210 |
Proposed branch: | lp:~3v1n0/unity/gtest-1.8-fixes |
Merge into: | lp:unity |
Diff against target: |
3283 lines (+442/-450) 68 files modified
CMakeLists.txt (+1/-49) UnityCore/CMakeLists.txt (+2/-1) tests/CMakeLists.txt (+34/-4) tests/autopilot/unity/tests/test_dash.py (+4/-4) tests/test-gestures/CMakeLists.txt (+2/-2) tests/test-gestures/test_gesture_broker.cpp (+3/-3) tests/test_action_handle.cpp (+12/-12) tests/test_animation_utils.cpp (+4/-4) tests/test_application_launcher_icon.cpp (+4/-4) tests/test_bamf_application.cpp (+3/-3) tests/test_categories.cpp (+3/-3) tests/test_connection_manager.cpp (+10/-10) tests/test_dashview.cpp (+1/-1) tests/test_dashview_impl.cpp (+3/-3) tests/test_dbus_indicators.cpp (+4/-4) tests/test_decorations_input_mixer.cpp (+7/-7) tests/test_decorations_widgets.cpp (+5/-5) tests/test_delta_tracker.cpp (+6/-6) tests/test_desktop_launcher_icon.cpp (+1/-1) tests/test_device_launcher_section.cpp (+1/-1) tests/test_favorite_store_gsettings.cpp (+5/-5) tests/test_favorite_store_private.cpp (+4/-4) tests/test_file_manager_launcher_icon.cpp (+3/-3) tests/test_filter_widgets.cpp (+1/-1) tests/test_glib_dbus_object.cpp (+2/-2) tests/test_glib_dbus_server.cpp (+17/-17) tests/test_glib_object.cpp (+10/-10) tests/test_glib_signals.cpp (+3/-3) tests/test_glib_source.cpp (+45/-45) tests/test_glib_variant.cpp (+9/-9) tests/test_gnome_session_manager.cpp (+1/-1) tests/test_grabhandle.cpp (+2/-2) tests/test_gsettings_scopes.cpp (+32/-32) tests/test_hud_button.cpp (+2/-2) tests/test_hud_private.cpp (+6/-6) tests/test_hud_view.cpp (+1/-1) tests/test_indicator.cpp (+6/-6) tests/test_indicator_appmenu.cpp (+3/-3) tests/test_indicator_entry.cpp (+3/-3) tests/test_indicators.cpp (+11/-11) tests/test_introspection_data.cpp (+40/-40) tests/test_keyboard_util.cpp (+8/-0) tests/test_launcher_controller.cpp (+11/-10) tests/test_launcher_model.cpp (+6/-6) tests/test_layout_system.cpp (+9/-9) tests/test_lockscreen_controller.cpp (+4/-4) tests/test_panel_controller.cpp (+3/-3) tests/test_panel_indicator_entry_dropdown_view.cpp (+10/-10) tests/test_pointer_barrier.cpp (+2/-2) tests/test_previews.cpp (+2/-2) tests/test_previews_application.cpp (+1/-1) tests/test_previews_generic.cpp (+1/-1) tests/test_previews_movie.cpp (+1/-1) tests/test_previews_music.cpp (+1/-1) tests/test_previews_social.cpp (+1/-1) tests/test_quicklist_view.cpp (+1/-1) tests/test_results.cpp (+10/-10) tests/test_scope.cpp (+6/-6) tests/test_scope_view.cpp (+12/-12) tests/test_session_view.cpp (+4/-4) tests/test_shortcut_model.cpp (+4/-4) tests/test_shortcut_view.cpp (+3/-3) tests/test_switcher_controller_slow.cpp (+5/-5) tests/test_texture_cache.cpp (+2/-2) tests/test_trash_launcher_icon.cpp (+6/-6) tests/test_ubus.cpp (+6/-6) tests/test_unity_window_style.cpp (+3/-3) tests/test_volume_launcher_icon.cpp (+4/-4) |
To merge this branch: | bzr merge lp:~3v1n0/unity/gtest-1.8-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrea Azzarone (community) | Approve | ||
Review via email:
|
Commit message
CMakeLists.txt: add support to compile with GTest 1.8
Description of the change
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'CMakeLists.txt' |
2 | --- CMakeLists.txt 2016-10-26 21:19:33 +0000 |
3 | +++ CMakeLists.txt 2016-11-30 11:04:07 +0000 |
4 | @@ -304,56 +304,7 @@ |
5 | add_subdirectory(gnome) |
6 | |
7 | if (ENABLE_UNIT_TESTS) |
8 | - # Check for google test and build it locally |
9 | - set ( |
10 | - GMOCK_ROOT_DIR |
11 | - "/usr/src/gmock" |
12 | - CACHE |
13 | - PATH |
14 | - "Path to Google mock srcs" |
15 | - ) |
16 | - |
17 | - set ( |
18 | - GMOCK_INCLUDE_DIR |
19 | - "/usr/include/gmock/include" |
20 | - CACHE |
21 | - PATH |
22 | - "Path to Google mock include" |
23 | - ) |
24 | - |
25 | - set( |
26 | - GTEST_ROOT_DIR |
27 | - "${GMOCK_ROOT_DIR}/gtest" # Default value, adjustable by user with e.g., ccmake |
28 | - CACHE |
29 | - PATH |
30 | - "Path to Google test srcs" |
31 | - ) |
32 | - |
33 | - set( |
34 | - GTEST_INCLUDE_DIR |
35 | - "${GMOCK_ROOT_DIR}/gtest/include" |
36 | - CACHE |
37 | - PATH |
38 | - "Path to Google tests include" |
39 | - ) |
40 | - |
41 | - if (GTEST_INCLUDE_DIR AND GMOCK_INCLUDE_DIR) |
42 | - include_directories ( |
43 | - ${GMOCK_INCLUDE_DIR} |
44 | - ${GTEST_INCLUDE_DIR} |
45 | - ) |
46 | - add_subdirectory( |
47 | - ${GMOCK_ROOT_DIR} |
48 | - "${CMAKE_CURRENT_BINARY_DIR}/gmock" |
49 | - ) |
50 | - elseif (GTEST_INCLUDE_DIR AND NOT GMOCK_INCLUDE_DIR) |
51 | - include_directories ( |
52 | - ${GTEST_INCLUDE_DIR} |
53 | - ) |
54 | - endif(GTEST_INCLUDE_DIR AND GMOCK_INCLUDE_DIR) |
55 | - |
56 | add_subdirectory(tests) |
57 | - |
58 | else (ENABLE_UNIT_TESTS) |
59 | set (MISSING_TESTS_MSG "-- Tests disabled, compile with -DENABLE_UNIT_TESTS=ON") |
60 | add_custom_target (check COMMAND echo ${MISSING_TESTS_MSG}) |
61 | @@ -390,3 +341,4 @@ |
62 | ADDITIONAL_MAKE_CLEAN_FILES api-doc) |
63 | |
64 | endif (DOXYGEN_FOUND STREQUAL "YES") |
65 | + |
66 | |
67 | === modified file 'UnityCore/CMakeLists.txt' |
68 | --- UnityCore/CMakeLists.txt 2016-02-09 01:26:22 +0000 |
69 | +++ UnityCore/CMakeLists.txt 2016-11-30 11:04:07 +0000 |
70 | @@ -145,7 +145,8 @@ |
71 | set_target_properties(${CORE_LIB_NAME} PROPERTIES |
72 | VERSION ${CORE_LIB_LT_CURRENT}.${CORE_LIB_LT_REV}.${CORE_LIB_LT_AGE} |
73 | SOVERSION ${CORE_LIB_LT_CURRENT} |
74 | - INSTALL_RPATH "${PRIVATE_CORE_DEPS_LIBRARY_DIRS}") |
75 | + INSTALL_RPATH "${PRIVATE_CORE_DEPS_LIBRARY_DIRS}" |
76 | + BUILD_WITH_INSTALL_RPATH TRUE) |
77 | add_pch(pch/unitycore_pch.hh ${CORE_LIB_NAME}) |
78 | |
79 | install (TARGETS ${CORE_LIB_NAME} |
80 | |
81 | === modified file 'tests/CMakeLists.txt' |
82 | --- tests/CMakeLists.txt 2016-11-07 11:44:45 +0000 |
83 | +++ tests/CMakeLists.txt 2016-11-30 11:04:07 +0000 |
84 | @@ -6,6 +6,37 @@ |
85 | file (COPY ${CMAKE_CURRENT_SOURCE_DIR}/data DESTINATION ${CMAKE_BINARY_DIR}/tests) |
86 | |
87 | # |
88 | +# Google Tests |
89 | +# |
90 | + |
91 | +# Check for google test and build it locally |
92 | +set (GTEST_PREFIX "/usr/src/googletest") |
93 | + |
94 | +if (EXISTS "${GTEST_PREFIX}") |
95 | + # As of version 1.8.0 |
96 | + set (GMOCK_SOURCE_DIR "${GTEST_PREFIX}/googlemock" CACHE PATH "gmock source directory") |
97 | + set (GMOCK_INCLUDE_DIR "${GMOCK_SOURCE_DIR}/include" CACHE PATH "gmock source include directory") |
98 | + set (GTEST_INCLUDE_DIR "${GTEST_PREFIX}/googletest/include" CACHE PATH "gtest source include directory") |
99 | + set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-sign-compare") |
100 | +else() |
101 | + set (GMOCK_SOURCE_DIR "/usr/src/gmock" CACHE PATH "gmock source directory") |
102 | + set (GMOCK_INCLUDE_DIR "/usr/include/gmock/include" CACHE PATH "gmock source include directory") |
103 | + set (GTEST_INCLUDE_DIR "${GMOCK_SOURCE_DIR}/gtest/include" CACHE PATH "gtest source include directory") |
104 | +endif() |
105 | + |
106 | +if (GTEST_INCLUDE_DIR AND GMOCK_INCLUDE_DIR) |
107 | + include_directories (${GMOCK_INCLUDE_DIR} ${GTEST_INCLUDE_DIR}) |
108 | + add_subdirectory(${GMOCK_SOURCE_DIR} "${CMAKE_CURRENT_BINARY_DIR}/gmock") |
109 | +elseif (GTEST_INCLUDE_DIR AND NOT GMOCK_INCLUDE_DIR) |
110 | + include_directories (${GTEST_INCLUDE_DIR}) |
111 | +endif(GTEST_INCLUDE_DIR AND GMOCK_INCLUDE_DIR) |
112 | + |
113 | +if (GMOCK_SOURCE_DIR) |
114 | + set(GMOCK_LIB gmock) |
115 | + set(GMOCK_MAIN_LIB gmock_main) |
116 | +endif (GMOCK_SOURCE_DIR) |
117 | + |
118 | +# |
119 | # Unit tests |
120 | # |
121 | set (TEST_DEPS "${UNITY_PLUGIN_DEPS};unity>=4.99.0;libupstart;xtst") |
122 | @@ -44,8 +75,6 @@ |
123 | # |
124 | |
125 | enable_testing() |
126 | -set(GMOCK_LIB gmock) |
127 | -set(GMOCK_MAIN_LIB gmock_main) |
128 | |
129 | if (GMOCK_LIB AND |
130 | GMOCK_MAIN_LIB) |
131 | @@ -375,7 +404,7 @@ |
132 | && ${DUMMY_XORG_TEST_RUNNER} ${GTEST_TEST_COMMAND_SLOW} |
133 | && ${TEST_COMMAND_XLESS}) |
134 | |
135 | -if (GTEST_ROOT_DIR) |
136 | +if (GMOCK_SOURCE_DIR) |
137 | if (ENABLE_X_SUPPORT) |
138 | add_custom_target (check COMMAND ${TEST_COMMAND} DEPENDS test-gtest test-gtest-slow test-gtest-xless test-gtest-dbus test-gestures) |
139 | add_custom_target (check-headless COMMAND ${TEST_COMMAND_HEADLESS} DEPENDS test-gtest test-gtest-slow test-gtest-xless test-gtest-dbus test-gestures) |
140 | @@ -386,9 +415,10 @@ |
141 | add_custom_target (gcheck COMMAND ${DBUS_TEST_COMMAND} DEPENDS test-gtest-xless) |
142 | endif () |
143 | add_custom_target (check-report COMMAND ${TEST_UNIT_COMMAND} && gtester-report ${TEST_RESULT_XML} > ${TEST_RESULT_HTML}) |
144 | -endif (GTEST_ROOT_DIR) |
145 | +endif (GMOCK_SOURCE_DIR) |
146 | # make target to allow devs to run "make autopilot" from build dir: |
147 | set (AUTOPILOTDIR "${CMAKE_CURRENT_SOURCE_DIR}/autopilot") |
148 | # Rules to install autopilot files and executable script: |
149 | install(CODE "execute_process(COMMAND python2.7 setup.py install --prefix ${CMAKE_INSTALL_PREFIX} WORKING_DIRECTORY ${AUTOPILOTDIR})") |
150 | add_custom_target (autopilot COMMAND cd ${AUTOPILOTDIR} && make check) |
151 | + |
152 | |
153 | === modified file 'tests/autopilot/unity/tests/test_dash.py' |
154 | --- tests/autopilot/unity/tests/test_dash.py 2016-03-18 01:47:08 +0000 |
155 | +++ tests/autopilot/unity/tests/test_dash.py 2016-11-30 11:04:07 +0000 |
156 | @@ -1136,18 +1136,18 @@ |
157 | |
158 | def setUp(self): |
159 | super(PreviewClickCancelTests, self).setUp() |
160 | - gettext.install("unity-scope-applications") |
161 | - scope = self.unity.dash.reveal_application_scope(clear_search=False) |
162 | + gettext.install("unity-scope-files") |
163 | + scope = self.unity.dash.reveal_file_scope(clear_search=False) |
164 | self.addCleanup(self.unity.dash.ensure_hidden) |
165 | # Only testing an application preview for this test. |
166 | |
167 | - search_string = "Software Updater" |
168 | + search_string = "Videos" |
169 | if self.unity.dash.search_string != search_string: |
170 | self.unity.dash.clear_search() |
171 | self.keyboard.type(search_string) |
172 | |
173 | # wait for "Installed" category |
174 | - category = self.wait_for_category(scope, _("Installed")) |
175 | + category = self.wait_for_category(scope, _("Folders")) |
176 | |
177 | # wait for results |
178 | self.assertThat(lambda: len(category.get_results()), Eventually(GreaterThan(0), timeout=20)) |
179 | |
180 | === modified file 'tests/test-gestures/CMakeLists.txt' |
181 | --- tests/test-gestures/CMakeLists.txt 2013-07-09 10:35:03 +0000 |
182 | +++ tests/test-gestures/CMakeLists.txt 2016-11-30 11:04:07 +0000 |
183 | @@ -1,4 +1,4 @@ |
184 | -if (GTEST_ROOT_DIR) |
185 | +if (GMOCK_SOURCE_DIR) |
186 | set(UNITY_SRC ${CMAKE_SOURCE_DIR}/plugins/unityshell/src) |
187 | |
188 | add_custom_command(OUTPUT CompoundGestureRecognizer.cpp |
189 | @@ -76,4 +76,4 @@ |
190 | add_dependencies(test-gestures gtest unity-core-${UNITY_API_VERSION}) |
191 | |
192 | add_custom_target (check-gestures COMMAND ./test-gestures DEPENDS test-gestures) |
193 | -endif (GTEST_ROOT_DIR) |
194 | +endif (GMOCK_SOURCE_DIR) |
195 | |
196 | === modified file 'tests/test-gestures/test_gesture_broker.cpp' |
197 | --- tests/test-gestures/test_gesture_broker.cpp 2013-11-06 11:21:43 +0000 |
198 | +++ tests/test-gestures/test_gesture_broker.cpp 2016-11-30 11:04:07 +0000 |
199 | @@ -111,11 +111,11 @@ |
200 | // Gesture shouldn't be accepted as constructions hasn't finished |
201 | ASSERT_EQ(0, g_gesture_event_accept_count[0]); |
202 | ASSERT_EQ(0, g_gesture_event_reject_count[0]); |
203 | - ASSERT_EQ(1, g_window_target_mocks.size()); |
204 | + ASSERT_EQ(1u, g_window_target_mocks.size()); |
205 | WindowGestureTargetMock *target_mock = *g_window_target_mocks.begin(); |
206 | ASSERT_TRUE(target_mock->window == middle_window); |
207 | // No events yet as the broker didn't accept the gesture yet |
208 | - ASSERT_EQ(0, target_mock->events_received.size()); |
209 | + ASSERT_EQ(0u, target_mock->events_received.size()); |
210 | |
211 | fake_event.type = nux::EVENT_GESTURE_UPDATE; |
212 | fake_event.touches.push_back(nux::TouchPoint(4, 132.0f, 142.0f)); |
213 | @@ -128,5 +128,5 @@ |
214 | // Check that this gesture target is still valid |
215 | ASSERT_EQ(1, g_window_target_mocks.count(target_mock)); |
216 | // Gesture events should have been sent to the target by now |
217 | - ASSERT_EQ(2, target_mock->events_received.size()); |
218 | + ASSERT_EQ(2u, target_mock->events_received.size()); |
219 | } |
220 | |
221 | === modified file 'tests/test_action_handle.cpp' |
222 | --- tests/test_action_handle.cpp 2013-10-04 16:58:29 +0000 |
223 | +++ tests/test_action_handle.cpp 2016-11-30 11:04:07 +0000 |
224 | @@ -29,7 +29,7 @@ |
225 | TEST(TestActionHandle, Initialization) |
226 | { |
227 | action::handle handle; |
228 | - EXPECT_EQ(handle, 0); |
229 | + EXPECT_EQ(handle, 0u); |
230 | |
231 | uint64_t val = g_random_int(); |
232 | action::handle random = val; |
233 | @@ -39,7 +39,7 @@ |
234 | TEST(TestActionHandle, Assignment) |
235 | { |
236 | action::handle handle; |
237 | - ASSERT_EQ(handle, 0); |
238 | + ASSERT_EQ(handle, 0u); |
239 | |
240 | uint64_t val = g_random_int(); |
241 | handle = val; |
242 | @@ -49,21 +49,21 @@ |
243 | TEST(TestActionHandle, CastToScalarType) |
244 | { |
245 | action::handle handle = 5; |
246 | - ASSERT_EQ(handle, 5); |
247 | + ASSERT_EQ(handle, 5u); |
248 | |
249 | int int_handle = handle; |
250 | EXPECT_EQ(int_handle, 5); |
251 | |
252 | unsigned uint_handle = handle; |
253 | - EXPECT_EQ(uint_handle, 5); |
254 | + EXPECT_EQ(uint_handle, 5u); |
255 | } |
256 | |
257 | TEST(TestActionHandle, PrefixIncrementOperator) |
258 | { |
259 | action::handle handle; |
260 | - ASSERT_EQ(handle, 0); |
261 | + ASSERT_EQ(handle, 0u); |
262 | |
263 | - for (auto i = 1; i <= 10; ++i) |
264 | + for (auto i = 1u; i <= 10u; ++i) |
265 | { |
266 | ASSERT_EQ(++handle, i); |
267 | ASSERT_EQ(handle, i); |
268 | @@ -73,9 +73,9 @@ |
269 | TEST(TestActionHandle, PostfixIncrementOperator) |
270 | { |
271 | action::handle handle; |
272 | - ASSERT_EQ(handle, 0); |
273 | + ASSERT_EQ(handle, 0u); |
274 | |
275 | - for (auto i = 1; i <= 10; ++i) |
276 | + for (auto i = 1u; i <= 10u; ++i) |
277 | { |
278 | ASSERT_EQ(handle++, i-1); |
279 | ASSERT_EQ(handle, i); |
280 | @@ -85,9 +85,9 @@ |
281 | TEST(TestActionHandle, PrefixDecrementOperator) |
282 | { |
283 | action::handle handle(10); |
284 | - ASSERT_EQ(handle, 10); |
285 | + ASSERT_EQ(handle, 10u); |
286 | |
287 | - for (auto i = 10; i > 0; --i) |
288 | + for (auto i = 10u; i > 0u; --i) |
289 | { |
290 | ASSERT_EQ(--handle, i-1); |
291 | ASSERT_EQ(handle, i-1); |
292 | @@ -97,9 +97,9 @@ |
293 | TEST(TestActionHandle, PostfixDecrementOperator) |
294 | { |
295 | action::handle handle(10); |
296 | - ASSERT_EQ(handle, 10); |
297 | + ASSERT_EQ(handle, 10u); |
298 | |
299 | - for (auto i = 10; i > 0; --i) |
300 | + for (auto i = 10u; i > 0u; --i) |
301 | { |
302 | ASSERT_EQ(handle--, i); |
303 | ASSERT_EQ(handle, i-1); |
304 | |
305 | === modified file 'tests/test_animation_utils.cpp' |
306 | --- tests/test_animation_utils.cpp 2013-10-18 03:57:12 +0000 |
307 | +++ tests/test_animation_utils.cpp 2016-11-30 11:04:07 +0000 |
308 | @@ -60,8 +60,8 @@ |
309 | |
310 | TYPED_TEST(TestAnimationUtilsIntegers, StartValueForDirection) |
311 | { |
312 | - EXPECT_EQ(0, StartValueForDirection<TypeParam>(Direction::FORWARD)); |
313 | - EXPECT_EQ(100, StartValueForDirection<TypeParam>(Direction::BACKWARD)); |
314 | + EXPECT_EQ(static_cast<TypeParam>(0), StartValueForDirection<TypeParam>(Direction::FORWARD)); |
315 | + EXPECT_EQ(static_cast<TypeParam>(100), StartValueForDirection<TypeParam>(Direction::BACKWARD)); |
316 | } |
317 | |
318 | TYPED_TEST(TestAnimationUtilsFloating, FinishValueForDirection) |
319 | @@ -72,8 +72,8 @@ |
320 | |
321 | TYPED_TEST(TestAnimationUtilsIntegers, FinishValueForDirection) |
322 | { |
323 | - EXPECT_EQ(100, FinishValueForDirection<TypeParam>(Direction::FORWARD)); |
324 | - EXPECT_EQ(0, FinishValueForDirection<TypeParam>(Direction::BACKWARD)); |
325 | + EXPECT_EQ(static_cast<TypeParam>(100), FinishValueForDirection<TypeParam>(Direction::FORWARD)); |
326 | + EXPECT_EQ(static_cast<TypeParam>(0), FinishValueForDirection<TypeParam>(Direction::BACKWARD)); |
327 | } |
328 | |
329 | TYPED_TEST(TestAnimationUtils, StartNotRunning) |
330 | |
331 | === modified file 'tests/test_application_launcher_icon.cpp' |
332 | --- tests/test_application_launcher_icon.cpp 2016-02-19 21:54:04 +0000 |
333 | +++ tests/test_application_launcher_icon.cpp 2016-11-30 11:04:07 +0000 |
334 | @@ -725,11 +725,11 @@ |
335 | mock_icon->SetQuirk(AbstractLauncherIcon::Quirk::ACTIVE, false); |
336 | |
337 | EXPECT_THAT(WM->GetWindowsInStackingOrder(), testing::ElementsAre(7, 6, 5, 4, 3, 2, 1, 8)); |
338 | - ASSERT_EQ(WM->GetActiveWindow(), 8); |
339 | + ASSERT_EQ(WM->GetActiveWindow(), 8u); |
340 | |
341 | mock_icon->PerformScroll(AbstractLauncherIcon::ScrollDirection::DOWN, 200); |
342 | EXPECT_THAT(WM->GetWindowsInStackingOrder(), testing::ElementsAre(7, 6, 5, 4, 3, 2, 8, 1)); |
343 | - ASSERT_EQ(WM->GetActiveWindow(), 1); |
344 | + ASSERT_EQ(WM->GetActiveWindow(), 1u); |
345 | } |
346 | |
347 | TEST_F(TestApplicationLauncherIcon, PerformScrollSingleUnfocusedWindow) |
348 | @@ -741,12 +741,12 @@ |
349 | mock_icon->SetQuirk(AbstractLauncherIcon::Quirk::ACTIVE, false); |
350 | |
351 | EXPECT_THAT(WM->GetWindowsInStackingOrder(), testing::ElementsAre(1, 2)); |
352 | - ASSERT_EQ(WM->GetActiveWindow(), 2); |
353 | + ASSERT_EQ(WM->GetActiveWindow(), 2u); |
354 | |
355 | mock_icon->PerformScroll(AbstractLauncherIcon::ScrollDirection::DOWN, 200); |
356 | |
357 | EXPECT_THAT(WM->GetWindowsInStackingOrder(), testing::ElementsAre(2, 1)); |
358 | - ASSERT_EQ(WM->GetActiveWindow(), 1); |
359 | + ASSERT_EQ(WM->GetActiveWindow(), 1u); |
360 | } |
361 | |
362 | TEST_F(TestApplicationLauncherIcon, ActiveQuirkWMCrossCheck) |
363 | |
364 | === modified file 'tests/test_bamf_application.cpp' |
365 | --- tests/test_bamf_application.cpp 2015-07-10 15:18:35 +0000 |
366 | +++ tests/test_bamf_application.cpp 2016-11-30 11:04:07 +0000 |
367 | @@ -56,7 +56,7 @@ |
368 | |
369 | TEST_F(TestBamfApplication, GetWindows) |
370 | { |
371 | - ASSERT_EQ(application_.GetWindows().size(), 0); |
372 | + ASSERT_EQ(application_.GetWindows().size(), 0u); |
373 | |
374 | GList* children = nullptr; |
375 | for (int i = 0; i<5; ++i) |
376 | @@ -73,9 +73,9 @@ |
377 | AddFakeWindowToWM(3, true); |
378 | AddFakeWindowToWM(4, false); |
379 | |
380 | - EXPECT_EQ(application_.GetWindows().size(), 5); |
381 | + EXPECT_EQ(application_.GetWindows().size(), 5u); |
382 | |
383 | g_list_free_full(children, g_object_unref); |
384 | } |
385 | |
386 | -} |
387 | \ No newline at end of file |
388 | +} |
389 | |
390 | === modified file 'tests/test_categories.cpp' |
391 | --- tests/test_categories.cpp 2013-07-12 15:38:12 +0000 |
392 | +++ tests/test_categories.cpp 2016-11-30 11:04:07 +0000 |
393 | @@ -49,7 +49,7 @@ |
394 | Category cat(nullptr, nullptr, nullptr); |
395 | |
396 | bool added = false; |
397 | - ASSERT_EQ(model.row_added.size(), 1); |
398 | + ASSERT_EQ(model.row_added.size(), 1u); |
399 | model.category_added.connect([&added] (Category const&) { added = true; }); |
400 | model.row_added.emit(cat); |
401 | EXPECT_TRUE(added); |
402 | @@ -60,7 +60,7 @@ |
403 | Category cat(nullptr, nullptr, nullptr); |
404 | |
405 | bool changed = false; |
406 | - ASSERT_EQ(model.row_changed.size(), 1); |
407 | + ASSERT_EQ(model.row_changed.size(), 1u); |
408 | model.category_changed.connect([&changed] (Category const&) { changed = true; }); |
409 | model.row_changed.emit(cat); |
410 | EXPECT_TRUE(changed); |
411 | @@ -71,7 +71,7 @@ |
412 | Category cat(nullptr, nullptr, nullptr); |
413 | |
414 | bool removed = false; |
415 | - ASSERT_EQ(model.row_removed.size(), 1); |
416 | + ASSERT_EQ(model.row_removed.size(), 1u); |
417 | model.category_removed.connect([&removed] (Category const&) { removed = true; }); |
418 | model.row_removed.emit(cat); |
419 | EXPECT_TRUE(removed); |
420 | |
421 | === modified file 'tests/test_connection_manager.cpp' |
422 | --- tests/test_connection_manager.cpp 2013-10-04 16:58:29 +0000 |
423 | +++ tests/test_connection_manager.cpp 2016-11-30 11:04:07 +0000 |
424 | @@ -163,7 +163,7 @@ |
425 | { |
426 | connection::Manager manager; |
427 | EXPECT_TRUE(manager.Empty()); |
428 | - EXPECT_EQ(manager.Size(), 0); |
429 | + EXPECT_EQ(manager.Size(), 0u); |
430 | } |
431 | |
432 | TEST(TestConnectionManager, AddEmpty) |
433 | @@ -176,7 +176,7 @@ |
434 | |
435 | EXPECT_EQ(handle, global_handle); |
436 | EXPECT_TRUE(manager.Empty()); |
437 | - EXPECT_EQ(manager.Size(), 0); |
438 | + EXPECT_EQ(manager.Size(), 0u); |
439 | } |
440 | |
441 | TEST(TestConnectionManager, AddSignal) |
442 | @@ -192,7 +192,7 @@ |
443 | ++global_handle; |
444 | EXPECT_EQ(handle, global_handle); |
445 | EXPECT_FALSE(manager.Empty()); |
446 | - EXPECT_EQ(manager.Size(), 1); |
447 | + EXPECT_EQ(manager.Size(), 1u); |
448 | } |
449 | |
450 | TEST(TestConnectionManager, AddMultipleSignals) |
451 | @@ -200,7 +200,7 @@ |
452 | connection::Manager manager; |
453 | SignalerObject signaler; |
454 | |
455 | - for (int i = 1; i <= 10; ++i) |
456 | + for (unsigned i = 1; i <= 10u; ++i) |
457 | { |
458 | auto const& conn = signaler.awesome_signal.connect([] {/* Awesome callback! */}); |
459 | auto handle = manager.Add(conn); |
460 | @@ -237,7 +237,7 @@ |
461 | EXPECT_TRUE(manager.RemoveAndClear(&handle)); |
462 | EXPECT_FALSE(conn.connected()); |
463 | EXPECT_TRUE(manager.Empty()); |
464 | - EXPECT_EQ(handle, 0); |
465 | + EXPECT_EQ(handle, 0u); |
466 | } |
467 | |
468 | TEST(TestConnectionManager, RemoveUnavailable) |
469 | @@ -247,7 +247,7 @@ |
470 | connection::handle handle = 5; |
471 | EXPECT_FALSE(manager.RemoveAndClear(&handle)); |
472 | EXPECT_TRUE(manager.Empty()); |
473 | - EXPECT_EQ(handle, 5); |
474 | + EXPECT_EQ(handle, 5u); |
475 | } |
476 | |
477 | TEST(TestConnectionManager, ReplaceOnEmpty) |
478 | @@ -256,7 +256,7 @@ |
479 | SignalerObject signaler; |
480 | |
481 | auto const& conn = signaler.awesome_signal.connect([] {/* Awesome callback! */}); |
482 | - EXPECT_GT(manager.Replace(0, conn), 0); |
483 | + EXPECT_GT(manager.Replace(0, conn), 0u); |
484 | EXPECT_FALSE(manager.Empty()); |
485 | } |
486 | |
487 | @@ -269,8 +269,8 @@ |
488 | manager.Add(conn); |
489 | ASSERT_FALSE(manager.Empty()); |
490 | |
491 | - EXPECT_GT(manager.Replace(0, conn), 0); |
492 | - EXPECT_EQ(manager.Size(), 2); |
493 | + EXPECT_GT(manager.Replace(0, conn), 0u); |
494 | + EXPECT_EQ(manager.Size(), 2u); |
495 | } |
496 | |
497 | TEST(TestConnectionManager, ReplaceAvailable) |
498 | @@ -284,7 +284,7 @@ |
499 | |
500 | sigc::connection second_conn = signaler.awesome_signal.connect([] {/* Awesome callback! */}); |
501 | auto second_handle = manager.Replace(first_handle, second_conn); |
502 | - EXPECT_EQ(manager.Size(), 1); |
503 | + EXPECT_EQ(manager.Size(), 1u); |
504 | EXPECT_EQ(first_handle, second_handle); |
505 | |
506 | EXPECT_FALSE(first_conn.connected()); |
507 | |
508 | === modified file 'tests/test_dashview.cpp' |
509 | --- tests/test_dashview.cpp 2014-03-21 04:40:12 +0000 |
510 | +++ tests/test_dashview.cpp 2016-11-30 11:04:07 +0000 |
511 | @@ -91,7 +91,7 @@ |
512 | Scopes::Ptr scopes(new MockGSettingsScopes(scopes_default)); |
513 | nux::ObjectPtr<MockDashView> view(new MockDashView(scopes, application_starter_)); |
514 | |
515 | - EXPECT_EQ(view->scope_views_.size(), 5) << "Error: Incorrect number of scope views (" << view->scope_views_.size() << " != 5)"; |
516 | + EXPECT_EQ(view->scope_views_.size(), 5u) << "Error: Incorrect number of scope views (" << view->scope_views_.size() << " != 5)"; |
517 | } |
518 | |
519 | |
520 | |
521 | === modified file 'tests/test_dashview_impl.cpp' |
522 | --- tests/test_dashview_impl.cpp 2013-02-21 10:47:14 +0000 |
523 | +++ tests/test_dashview_impl.cpp 2016-11-30 11:04:07 +0000 |
524 | @@ -49,7 +49,7 @@ |
525 | ScopeFilter filter = parse_scope_uri("uri?filter_param=test"); |
526 | |
527 | EXPECT_THAT(filter.id, Eq("uri")); |
528 | - EXPECT_THAT(filter.filters.size(), Eq(1)); |
529 | + EXPECT_THAT(filter.filters.size(), Eq(1u)); |
530 | EXPECT_THAT(filter.filters["param"], Eq("test")); |
531 | } |
532 | |
533 | @@ -66,7 +66,7 @@ |
534 | ScopeFilter filter = parse_scope_uri("uri?filter_param=a=b"); |
535 | |
536 | EXPECT_THAT(filter.id, Eq("uri")); |
537 | - EXPECT_THAT(filter.filters.size(), Eq(1)); |
538 | + EXPECT_THAT(filter.filters.size(), Eq(1u)); |
539 | EXPECT_THAT(filter.filters["param"], Eq("a=b")); |
540 | } |
541 | |
542 | @@ -75,7 +75,7 @@ |
543 | ScopeFilter filter = parse_scope_uri("uri?filter_param1=first&filter_param2=second"); |
544 | |
545 | EXPECT_THAT(filter.id, Eq("uri")); |
546 | - EXPECT_THAT(filter.filters.size(), Eq(2)); |
547 | + EXPECT_THAT(filter.filters.size(), Eq(2u)); |
548 | EXPECT_THAT(filter.filters["param1"], Eq("first")); |
549 | EXPECT_THAT(filter.filters["param2"], Eq("second")); |
550 | } |
551 | |
552 | === modified file 'tests/test_dbus_indicators.cpp' |
553 | --- tests/test_dbus_indicators.cpp 2014-12-19 16:48:04 +0000 |
554 | +++ tests/test_dbus_indicators.cpp 2016-11-30 11:04:07 +0000 |
555 | @@ -76,8 +76,8 @@ |
556 | // wait until the dbus indicator gets any indicator from the panel service |
557 | Utils::WaitUntil(sigc::mem_fun(*dbus_indicators, &DBusIndicatorsTest::HasIndicators), true, 5); |
558 | |
559 | - EXPECT_EQ(dbus_indicators->GetIndicators().size(), 1); |
560 | - EXPECT_EQ(dbus_indicators->GetIndicators().front()->GetEntries().size(), 2); |
561 | + EXPECT_EQ(dbus_indicators->GetIndicators().size(), 1u); |
562 | + EXPECT_EQ(dbus_indicators->GetIndicators().front()->GetEntries().size(), 2u); |
563 | EXPECT_EQ(dbus_indicators->GetIndicators().front()->GetEntries().front()->id(), "test_entry_id"); |
564 | EXPECT_EQ(dbus_indicators->GetIndicators().front()->GetEntries().back()->id(), "test_entry_id2"); |
565 | |
566 | @@ -89,8 +89,8 @@ |
567 | // so do one interation of the main loop more |
568 | g_main_context_iteration(NULL, TRUE); |
569 | |
570 | - EXPECT_EQ(dbus_indicators->GetIndicators().size(), 1); |
571 | - EXPECT_EQ(dbus_indicators->GetIndicators().front()->GetEntries().size(), 2); |
572 | + EXPECT_EQ(dbus_indicators->GetIndicators().size(), 1u); |
573 | + EXPECT_EQ(dbus_indicators->GetIndicators().front()->GetEntries().size(), 2u); |
574 | EXPECT_EQ(dbus_indicators->GetIndicators().front()->GetEntries().front()->id(), "test_entry_id2"); |
575 | EXPECT_EQ(dbus_indicators->GetIndicators().front()->GetEntries().back()->id(), "test_entry_id"); |
576 | } |
577 | |
578 | === modified file 'tests/test_decorations_input_mixer.cpp' |
579 | --- tests/test_decorations_input_mixer.cpp 2014-02-11 17:40:09 +0000 |
580 | +++ tests/test_decorations_input_mixer.cpp 2016-11-30 11:04:07 +0000 |
581 | @@ -53,13 +53,13 @@ |
582 | mixer.PushToFront(item3); |
583 | |
584 | auto const& items = mixer.Items(); |
585 | - ASSERT_EQ(3, items.size()); |
586 | + ASSERT_EQ(3u, items.size()); |
587 | EXPECT_EQ(item3, *std::next(items.begin(), 0)); |
588 | EXPECT_EQ(item2, *std::next(items.begin(), 1)); |
589 | EXPECT_EQ(item1, *std::next(items.begin(), 2)); |
590 | |
591 | mixer.PushToFront(item2); |
592 | - ASSERT_EQ(3, mixer.Items().size()); |
593 | + ASSERT_EQ(3u, mixer.Items().size()); |
594 | EXPECT_EQ(item2, *std::next(items.begin(), 0)); |
595 | EXPECT_EQ(item3, *std::next(items.begin(), 1)); |
596 | EXPECT_EQ(item1, *std::next(items.begin(), 2)); |
597 | @@ -77,13 +77,13 @@ |
598 | mixer.PushToBack(item3); |
599 | |
600 | auto const& items = mixer.Items(); |
601 | - ASSERT_EQ(3, items.size()); |
602 | + ASSERT_EQ(3u, items.size()); |
603 | EXPECT_EQ(item1, *std::next(items.begin(), 0)); |
604 | EXPECT_EQ(item2, *std::next(items.begin(), 1)); |
605 | EXPECT_EQ(item3, *std::next(items.begin(), 2)); |
606 | |
607 | mixer.PushToBack(item2); |
608 | - ASSERT_EQ(3, items.size()); |
609 | + ASSERT_EQ(3u, items.size()); |
610 | EXPECT_EQ(item1, *std::next(items.begin(), 0)); |
611 | EXPECT_EQ(item3, *std::next(items.begin(), 1)); |
612 | EXPECT_EQ(item2, *std::next(items.begin(), 2)); |
613 | @@ -101,15 +101,15 @@ |
614 | mixer.PushToFront(item3); |
615 | |
616 | auto const& items = mixer.Items(); |
617 | - ASSERT_EQ(3, items.size()); |
618 | + ASSERT_EQ(3u, items.size()); |
619 | |
620 | mixer.Remove(item2); |
621 | - ASSERT_EQ(2, items.size()); |
622 | + ASSERT_EQ(2u, items.size()); |
623 | EXPECT_EQ(item3, *std::next(items.begin(), 0)); |
624 | EXPECT_EQ(item1, *std::next(items.begin(), 1)); |
625 | |
626 | mixer.Remove(item1); |
627 | - ASSERT_EQ(1, items.size()); |
628 | + ASSERT_EQ(1u, items.size()); |
629 | EXPECT_EQ(item3, *std::next(items.begin(), 0)); |
630 | |
631 | mixer.EnterEvent(CompPoint(item3->Geometry().x2(), item3->Geometry().y1())); |
632 | |
633 | === modified file 'tests/test_decorations_widgets.cpp' |
634 | --- tests/test_decorations_widgets.cpp 2014-02-26 02:23:52 +0000 |
635 | +++ tests/test_decorations_widgets.cpp 2016-11-30 11:04:07 +0000 |
636 | @@ -321,7 +321,7 @@ |
637 | ASSERT_EQ(layout->Geometry().y() + (layout->Geometry().height() - item_geo.height()) / 2, item_geo.y()); |
638 | } |
639 | |
640 | - EXPECT_EQ(100, layout->Items().size()); |
641 | + EXPECT_EQ(100u, layout->Items().size()); |
642 | } |
643 | |
644 | TEST_F(TestDecorationLayout, AppendParentsItem) |
645 | @@ -365,7 +365,7 @@ |
646 | ASSERT_EQ(expected_geo, layout->Geometry()); |
647 | } |
648 | |
649 | - EXPECT_EQ(100, layout->Items().size()); |
650 | + EXPECT_EQ(100u, layout->Items().size()); |
651 | EXPECT_EQ(CompRect(), layout->Geometry()); |
652 | } |
653 | |
654 | @@ -388,7 +388,7 @@ |
655 | ASSERT_EQ(layout->Geometry().y() + (layout->Geometry().height() - item_geo.height()) / 2, item_geo.y()); |
656 | } |
657 | |
658 | - EXPECT_EQ(100, layout->Items().size()); |
659 | + EXPECT_EQ(100u, layout->Items().size()); |
660 | } |
661 | |
662 | TEST_F(TestDecorationLayout, AppendWithMaxWidth) |
663 | @@ -398,7 +398,7 @@ |
664 | for (int i = 0; i < 100; ++i) |
665 | layout->Append(RandomMockItem()); |
666 | |
667 | - ASSERT_EQ(100, layout->Items().size()); |
668 | + ASSERT_EQ(100u, layout->Items().size()); |
669 | |
670 | auto const& layout_geo = layout->Geometry(); |
671 | int new_width = layout_geo.width()/2; |
672 | @@ -430,7 +430,7 @@ |
673 | for (int i = 0; i < 100; ++i) |
674 | layout->Append(RandomMockItem()); |
675 | |
676 | - ASSERT_EQ(100, layout->Items().size()); |
677 | + ASSERT_EQ(100u, layout->Items().size()); |
678 | |
679 | auto const& layout_geo = layout->Geometry(); |
680 | int full_width = layout_geo.width(); |
681 | |
682 | === modified file 'tests/test_delta_tracker.cpp' |
683 | --- tests/test_delta_tracker.cpp 2013-09-19 00:05:23 +0000 |
684 | +++ tests/test_delta_tracker.cpp 2016-11-30 11:04:07 +0000 |
685 | @@ -38,7 +38,7 @@ |
686 | |
687 | TEST_F(TestDeltaTracker, TestDirectionEmptyOnStart) |
688 | { |
689 | - ASSERT_EQ(delta_tracker_.AmountOfDirectionsChanged(), 0); |
690 | + ASSERT_EQ(delta_tracker_.AmountOfDirectionsChanged(), 0u); |
691 | } |
692 | |
693 | TEST_F(TestDeltaTracker, TestCorrectDirections) |
694 | @@ -46,7 +46,7 @@ |
695 | delta_tracker_.HandleNewMouseDelta(0, -1); |
696 | delta_tracker_.HandleNewMouseDelta(1, 0); |
697 | |
698 | - ASSERT_EQ(delta_tracker_.AmountOfDirectionsChanged(), 2); |
699 | + ASSERT_EQ(delta_tracker_.AmountOfDirectionsChanged(), 2u); |
700 | } |
701 | |
702 | TEST_F(TestDeltaTracker, TestNoDuplicates) |
703 | @@ -54,7 +54,7 @@ |
704 | delta_tracker_.HandleNewMouseDelta(0, -1); |
705 | delta_tracker_.HandleNewMouseDelta(0, -1); |
706 | |
707 | - ASSERT_EQ(delta_tracker_.AmountOfDirectionsChanged(), 1); |
708 | + ASSERT_EQ(delta_tracker_.AmountOfDirectionsChanged(), 1u); |
709 | } |
710 | |
711 | TEST_F(TestDeltaTracker, TestAllDirections) |
712 | @@ -64,7 +64,7 @@ |
713 | delta_tracker_.HandleNewMouseDelta(-1, 0); |
714 | delta_tracker_.HandleNewMouseDelta(1, 0); |
715 | |
716 | - ASSERT_EQ(delta_tracker_.AmountOfDirectionsChanged(), 4); |
717 | + ASSERT_EQ(delta_tracker_.AmountOfDirectionsChanged(), 4u); |
718 | } |
719 | |
720 | TEST_F(TestDeltaTracker, TestResetStates) |
721 | @@ -74,10 +74,10 @@ |
722 | delta_tracker_.HandleNewMouseDelta(-1, 0); |
723 | delta_tracker_.HandleNewMouseDelta(1, 0); |
724 | |
725 | - ASSERT_EQ(delta_tracker_.AmountOfDirectionsChanged(), 4); |
726 | + ASSERT_EQ(delta_tracker_.AmountOfDirectionsChanged(), 4u); |
727 | |
728 | delta_tracker_.ResetState(); |
729 | - ASSERT_EQ(delta_tracker_.AmountOfDirectionsChanged(), 0); |
730 | + ASSERT_EQ(delta_tracker_.AmountOfDirectionsChanged(), 0u); |
731 | } |
732 | |
733 | } |
734 | |
735 | === modified file 'tests/test_desktop_launcher_icon.cpp' |
736 | --- tests/test_desktop_launcher_icon.cpp 2014-03-21 04:40:12 +0000 |
737 | +++ tests/test_desktop_launcher_icon.cpp 2016-11-30 11:04:07 +0000 |
738 | @@ -40,7 +40,7 @@ |
739 | |
740 | TEST_F(TestDesktopLauncherIcon, Shortcut) |
741 | { |
742 | - EXPECT_EQ(icon.GetShortcut(), 'd'); |
743 | + EXPECT_EQ(icon.GetShortcut(), static_cast<guint64>('d')); |
744 | } |
745 | |
746 | TEST_F(TestDesktopLauncherIcon, Position) |
747 | |
748 | === modified file 'tests/test_device_launcher_section.cpp' |
749 | --- tests/test_device_launcher_section.cpp 2014-03-21 04:40:12 +0000 |
750 | +++ tests/test_device_launcher_section.cpp 2016-11-30 11:04:07 +0000 |
751 | @@ -80,7 +80,7 @@ |
752 | |
753 | TEST_F(TestDeviceLauncherSection, GetIcons) |
754 | { |
755 | - EXPECT_EQ(section_.GetIcons().size(), 2); |
756 | + EXPECT_EQ(section_.GetIcons().size(), 2u); |
757 | } |
758 | |
759 | } |
760 | |
761 | === modified file 'tests/test_favorite_store_gsettings.cpp' |
762 | --- tests/test_favorite_store_gsettings.cpp 2016-02-19 21:54:04 +0000 |
763 | +++ tests/test_favorite_store_gsettings.cpp 2016-11-30 11:04:07 +0000 |
764 | @@ -44,7 +44,7 @@ |
765 | "device://uuid", |
766 | NULL |
767 | }; |
768 | -const int n_base_store_favs = G_N_ELEMENTS(base_store_favs) - 1; /* NULL */ |
769 | +const unsigned n_base_store_favs = G_N_ELEMENTS(base_store_favs) - 1; /* NULL */ |
770 | |
771 | const std::string other_desktop = "application://" BUILDDIR "/tests/data/applications/bzr-handle-patch.desktop"; |
772 | |
773 | @@ -322,7 +322,7 @@ |
774 | favorite_store->SaveFavorites(favs, false); |
775 | |
776 | ASSERT_TRUE(signal_received); |
777 | - ASSERT_EQ(paths_removed.size(), 3); |
778 | + ASSERT_EQ(paths_removed.size(), 3u); |
779 | EXPECT_EQ(paths_removed[0], base_store_favs[4]); |
780 | EXPECT_EQ(paths_removed[1], base_store_favs[1]); |
781 | EXPECT_EQ(paths_removed[2], base_store_favs[3]); |
782 | @@ -457,7 +457,7 @@ |
783 | { |
784 | EXPECT_TRUE(favorite_store->IsFavorite(FavoriteStore::URI_PREFIX_APP+base_store_favs[0])); |
785 | |
786 | - for (int i = 1; i < n_base_store_favs; i++) |
787 | + for (unsigned i = 1; i < n_base_store_favs; i++) |
788 | { |
789 | ASSERT_TRUE(favorite_store->IsFavorite(base_store_favs[i])); |
790 | } |
791 | @@ -469,9 +469,9 @@ |
792 | { |
793 | EXPECT_EQ(favorite_store->FavoritePosition(FavoriteStore::URI_PREFIX_APP+base_store_favs[0]), 0); |
794 | |
795 | - for (int i = 1; i < n_base_store_favs; i++) |
796 | + for (unsigned i = 1; i < n_base_store_favs; i++) |
797 | { |
798 | - ASSERT_EQ(favorite_store->FavoritePosition(base_store_favs[i]), i); |
799 | + ASSERT_EQ(favorite_store->FavoritePosition(base_store_favs[i]), static_cast<int>(i)); |
800 | } |
801 | |
802 | EXPECT_EQ(favorite_store->FavoritePosition("unity://invalid-favorite"), -1); |
803 | |
804 | === modified file 'tests/test_favorite_store_private.cpp' |
805 | --- tests/test_favorite_store_private.cpp 2012-01-07 15:49:40 +0000 |
806 | +++ tests/test_favorite_store_private.cpp 2016-11-30 11:04:07 +0000 |
807 | @@ -80,7 +80,7 @@ |
808 | |
809 | result = internal::impl::GetNewbies(old, fresh); |
810 | |
811 | - EXPECT_EQ(result.size(), 2); |
812 | + EXPECT_EQ(result.size(), 2u); |
813 | EXPECT_EQ(result[0], "e"); |
814 | EXPECT_EQ(result[1], "f"); |
815 | |
816 | @@ -95,7 +95,7 @@ |
817 | |
818 | result = internal::impl::GetNewbies(old, fresh); |
819 | |
820 | - EXPECT_EQ(result.size(), 2); |
821 | + EXPECT_EQ(result.size(), 2u); |
822 | EXPECT_EQ(result[0], "e"); |
823 | EXPECT_EQ(result[1], "f"); |
824 | } |
825 | @@ -212,7 +212,7 @@ |
826 | |
827 | result = internal::impl::GetRemoved(old, fresh); |
828 | |
829 | - EXPECT_EQ(result.size(), 2); |
830 | + EXPECT_EQ(result.size(), 2u); |
831 | EXPECT_EQ(result[0], "a"); |
832 | EXPECT_EQ(result[1], "d"); |
833 | |
834 | @@ -227,7 +227,7 @@ |
835 | |
836 | result = internal::impl::GetRemoved(old, fresh); |
837 | |
838 | - EXPECT_EQ(result.size(), 2); |
839 | + EXPECT_EQ(result.size(), 2u); |
840 | EXPECT_EQ(result[0], "b"); |
841 | EXPECT_EQ(result[1], "c"); |
842 | } |
843 | |
844 | === modified file 'tests/test_file_manager_launcher_icon.cpp' |
845 | --- tests/test_file_manager_launcher_icon.cpp 2016-07-06 10:45:44 +0000 |
846 | +++ tests/test_file_manager_launcher_icon.cpp 2016-11-30 11:04:07 +0000 |
847 | @@ -92,7 +92,7 @@ |
848 | TEST_F(TestFileManagerLauncherIcon, NoManagedWindow_Device) |
849 | { |
850 | auto const& device_icons = dev_->GetIcons(); |
851 | - ASSERT_EQ(2, device_icons.size()); |
852 | + ASSERT_EQ(2u, device_icons.size()); |
853 | |
854 | device_icons.at(0)->Activate(ActionArg()); |
855 | |
856 | @@ -164,7 +164,7 @@ |
857 | |
858 | EXPECT_TRUE(icon_->IsVisible()); |
859 | EXPECT_TRUE(icon_->IsRunning()); |
860 | - EXPECT_EQ(2, icon_->WindowsVisibleOnMonitor(0)); |
861 | + EXPECT_EQ(2u, icon_->WindowsVisibleOnMonitor(0)); |
862 | } |
863 | |
864 | TEST_F(TestFileManagerLauncherIcon, ManagedWindows_CopyDialogAndNoManagedWindow) |
865 | @@ -196,7 +196,7 @@ |
866 | |
867 | EXPECT_TRUE(icon_->IsVisible()); |
868 | EXPECT_TRUE(icon_->IsRunning()); |
869 | - EXPECT_EQ(1, icon_->WindowsVisibleOnMonitor(0)); |
870 | + EXPECT_EQ(1u, icon_->WindowsVisibleOnMonitor(0)); |
871 | } |
872 | |
873 | } |
874 | |
875 | === modified file 'tests/test_filter_widgets.cpp' |
876 | --- tests/test_filter_widgets.cpp 2014-03-21 04:40:12 +0000 |
877 | +++ tests/test_filter_widgets.cpp 2016-11-30 11:04:07 +0000 |
878 | @@ -123,7 +123,7 @@ |
879 | MultiRangeFilter::Ptr filter(new MultiRangeFilter(model_, AddMultiRangeFilterOptions(model_))); |
880 | SetFilter(filter); |
881 | |
882 | - ASSERT_EQ(filter_widget_->buttons_.size(), 6); |
883 | + ASSERT_EQ(filter_widget_->buttons_.size(), 6u); |
884 | } |
885 | |
886 | TEST_F(TestFilterMultiRangeWidget, TestClick) |
887 | |
888 | === modified file 'tests/test_glib_dbus_object.cpp' |
889 | --- tests/test_glib_dbus_object.cpp 2013-02-28 18:01:22 +0000 |
890 | +++ tests/test_glib_dbus_object.cpp 2016-11-30 11:04:07 +0000 |
891 | @@ -112,14 +112,14 @@ |
892 | TEST(TestGLibDBusObjectBuilder, GetObjectsForIntrospectionWithOneObject) |
893 | { |
894 | auto const& objs = DBusObjectBuilder::GetObjectsForIntrospection(introspection::SINGLE_OJBECT); |
895 | - ASSERT_EQ(objs.size(), 1); |
896 | + ASSERT_EQ(objs.size(), 1u); |
897 | EXPECT_EQ(objs.front()->InterfaceName(), "com.canonical.Unity.ObjectTest"); |
898 | } |
899 | |
900 | TEST(TestGLibDBusObjectBuilder, GetObjectsForIntrospectionWithMultipleObjects) |
901 | { |
902 | auto const& objs = DBusObjectBuilder::GetObjectsForIntrospection(introspection::MULTIPLE_OJBECTS); |
903 | - ASSERT_EQ(objs.size(), 3); |
904 | + ASSERT_EQ(objs.size(), 3u); |
905 | EXPECT_EQ((*std::next(objs.begin(), 0))->InterfaceName(), "com.canonical.Unity.ObjectTest1"); |
906 | EXPECT_EQ((*std::next(objs.begin(), 1))->InterfaceName(), "com.canonical.Unity.ObjectTest2"); |
907 | EXPECT_EQ((*std::next(objs.begin(), 2))->InterfaceName(), "com.canonical.Unity.ObjectTest3"); |
908 | |
909 | === modified file 'tests/test_glib_dbus_server.cpp' |
910 | --- tests/test_glib_dbus_server.cpp 2015-03-13 13:49:16 +0000 |
911 | +++ tests/test_glib_dbus_server.cpp 2016-11-30 11:04:07 +0000 |
912 | @@ -179,7 +179,7 @@ |
913 | unsigned objects_registered = 0; |
914 | |
915 | server.AddObjects(introspection::MULTIPLE_OJBECTS, TEST_OBJECT_PATH); |
916 | - ASSERT_EQ(server.GetObjects().size(), 3); |
917 | + ASSERT_EQ(server.GetObjects().size(), 3u); |
918 | |
919 | for (auto const& obj : server.GetObjects()) |
920 | { |
921 | @@ -193,7 +193,7 @@ |
922 | |
923 | Utils::WaitUntilMSec([this] { return server.OwnsName(); }); |
924 | |
925 | - EXPECT_EQ(objects_registered, 3); |
926 | + EXPECT_EQ(objects_registered, 3u); |
927 | } |
928 | |
929 | TEST_F(TestGLibDBusServer, RemovingObjectWontRegisterIt) |
930 | @@ -201,10 +201,10 @@ |
931 | unsigned objects_registered = 0; |
932 | |
933 | server.AddObjects(introspection::MULTIPLE_OJBECTS, TEST_OBJECT_PATH); |
934 | - ASSERT_EQ(server.GetObjects().size(), 3); |
935 | + ASSERT_EQ(server.GetObjects().size(), 3u); |
936 | |
937 | server.RemoveObject(server.GetObjects().front()); |
938 | - ASSERT_EQ(server.GetObjects().size(), 2); |
939 | + ASSERT_EQ(server.GetObjects().size(), 2u); |
940 | |
941 | for (auto const& obj : server.GetObjects()) |
942 | { |
943 | @@ -216,13 +216,13 @@ |
944 | |
945 | Utils::WaitUntilMSec([this] { return server.OwnsName(); }); |
946 | |
947 | - EXPECT_EQ(objects_registered, 2); |
948 | + EXPECT_EQ(objects_registered, 2u); |
949 | } |
950 | |
951 | TEST_F(TestGLibDBusServer, RemovingObjectsUnregistersThem) |
952 | { |
953 | server.AddObjects(introspection::MULTIPLE_OJBECTS, TEST_OBJECT_PATH); |
954 | - ASSERT_EQ(server.GetObjects().size(), 3); |
955 | + ASSERT_EQ(server.GetObjects().size(), 3u); |
956 | |
957 | Utils::WaitUntilMSec([this] { return server.OwnsName(); }); |
958 | |
959 | @@ -236,16 +236,16 @@ |
960 | } |
961 | |
962 | server.RemoveObject(server.GetObjects().front()); |
963 | - ASSERT_EQ(server.GetObjects().size(), 2); |
964 | - EXPECT_EQ(objects_unregistered, 1); |
965 | - |
966 | - server.RemoveObject(server.GetObjects().front()); |
967 | - ASSERT_EQ(server.GetObjects().size(), 1); |
968 | - EXPECT_EQ(objects_unregistered, 2); |
969 | - |
970 | - server.RemoveObject(server.GetObjects().front()); |
971 | - ASSERT_EQ(server.GetObjects().size(), 0); |
972 | - EXPECT_EQ(objects_unregistered, 3); |
973 | + ASSERT_EQ(server.GetObjects().size(), 2u); |
974 | + EXPECT_EQ(objects_unregistered, 1u); |
975 | + |
976 | + server.RemoveObject(server.GetObjects().front()); |
977 | + ASSERT_EQ(server.GetObjects().size(), 1u); |
978 | + EXPECT_EQ(objects_unregistered, 2u); |
979 | + |
980 | + server.RemoveObject(server.GetObjects().front()); |
981 | + ASSERT_EQ(server.GetObjects().size(), 0u); |
982 | + EXPECT_EQ(objects_unregistered, 3u); |
983 | } |
984 | |
985 | /// |
986 | @@ -269,7 +269,7 @@ |
987 | ASSERT_TRUE(proxy->IsConnected()); |
988 | |
989 | auto const& objects = server->GetObjects(); |
990 | - ASSERT_EQ(objects.size(), 1); |
991 | + ASSERT_EQ(objects.size(), 1u); |
992 | object = objects.front(); |
993 | ASSERT_NE(object, nullptr); |
994 | } |
995 | |
996 | === modified file 'tests/test_glib_object.cpp' |
997 | --- tests/test_glib_object.cpp 2014-07-30 00:49:35 +0000 |
998 | +++ tests/test_glib_object.cpp 2016-11-30 11:04:07 +0000 |
999 | @@ -222,7 +222,7 @@ |
1000 | EXPECT_EQ(cast_copy, gt_obj.RawPtr()); |
1001 | |
1002 | Object<GObject> g_obj = glib::object_cast<GObject>(gt_obj); |
1003 | - EXPECT_EQ(g_obj->ref_count, 2); |
1004 | + EXPECT_EQ(G_OBJECT(g_obj.RawPtr())->ref_count, 2u); |
1005 | |
1006 | g_object_set_data(g_obj, "TestData", GINT_TO_POINTER(55)); |
1007 | EXPECT_EQ(GPOINTER_TO_INT(g_object_get_data(g_obj, "TestData")), 55); |
1008 | @@ -285,7 +285,7 @@ |
1009 | // Release() doesn't unref the object. |
1010 | g_obj.Release(); |
1011 | EXPECT_EQ(g_obj, 0); |
1012 | - EXPECT_EQ(RefCount(t_obj), 1); |
1013 | + EXPECT_EQ(RefCount(t_obj), 1u); |
1014 | |
1015 | g_object_unref(t_obj); |
1016 | } |
1017 | @@ -315,8 +315,8 @@ |
1018 | EXPECT_EQ(g_obj1, t_obj1); |
1019 | EXPECT_EQ(g_obj2, t_obj2); |
1020 | |
1021 | - EXPECT_EQ(RefCount(g_obj1), 1); |
1022 | - EXPECT_EQ(RefCount(g_obj2), 1); |
1023 | + EXPECT_EQ(RefCount(g_obj1), 1u); |
1024 | + EXPECT_EQ(RefCount(g_obj2), 1u); |
1025 | } |
1026 | |
1027 | EXPECT_TRUE(IsObjectDestroyed(t_obj1)); |
1028 | @@ -336,29 +336,29 @@ |
1029 | TestObjectWrapper g_obj4; |
1030 | TestObjectWrapper g_obj5; |
1031 | |
1032 | - EXPECT_EQ(RefCount(g_obj1), 1); |
1033 | + EXPECT_EQ(RefCount(g_obj1), 1u); |
1034 | |
1035 | obj_list.push_back(g_obj1); |
1036 | obj_list.push_back(g_obj2); |
1037 | obj_list.push_back(g_obj3); |
1038 | obj_list.push_back(g_obj4); |
1039 | obj_list.push_back(g_obj5); |
1040 | - EXPECT_EQ(obj_list.size(), 5); |
1041 | + EXPECT_EQ(obj_list.size(), 5u); |
1042 | |
1043 | - EXPECT_EQ(RefCount(g_obj1), 2); |
1044 | + EXPECT_EQ(RefCount(g_obj1), 2u); |
1045 | |
1046 | obj_list.remove(g_obj2); |
1047 | - EXPECT_EQ(obj_list.size(), 4); |
1048 | + EXPECT_EQ(obj_list.size(), 4u); |
1049 | |
1050 | EXPECT_TRUE(std::find(obj_list.begin(), obj_list.end(), g_obj3) != obj_list.end()); |
1051 | EXPECT_TRUE(std::find(obj_list.begin(), obj_list.end(), g_obj3.RawPtr()) != obj_list.end()); |
1052 | |
1053 | obj_list.remove(TestObjectWrapper(t_obj1, AddRef())); |
1054 | - EXPECT_EQ(obj_list.size(), 3); |
1055 | + EXPECT_EQ(obj_list.size(), 3u); |
1056 | |
1057 | EXPECT_TRUE(std::find(obj_list.begin(), obj_list.end(), g_obj4) != obj_list.end()); |
1058 | obj_list.remove(g_obj5); |
1059 | - EXPECT_EQ(obj_list.size(), 1); |
1060 | + EXPECT_EQ(obj_list.size(), 1u); |
1061 | } |
1062 | |
1063 | } // Namespace |
1064 | |
1065 | === modified file 'tests/test_glib_signals.cpp' |
1066 | --- tests/test_glib_signals.cpp 2013-07-18 04:16:50 +0000 |
1067 | +++ tests/test_glib_signals.cpp 2016-11-30 11:04:07 +0000 |
1068 | @@ -289,7 +289,7 @@ |
1069 | g_signal_emit_by_name(test_signals_, "signal0"); |
1070 | |
1071 | EXPECT_FALSE(signal0_received_); |
1072 | - EXPECT_EQ(signal0_num_cb, 1); |
1073 | + EXPECT_EQ(signal0_num_cb, 1u); |
1074 | } |
1075 | |
1076 | TEST_F(TestGLibSignals, TestManagerConstruction) |
1077 | @@ -324,7 +324,7 @@ |
1078 | "signal6", |
1079 | sigc::mem_fun(this, &TestGLibSignals::Signal6Callback))); |
1080 | |
1081 | - EXPECT_EQ(manager.GetConnections().size(), 7); |
1082 | + EXPECT_EQ(manager.GetConnections().size(), 7u); |
1083 | } |
1084 | |
1085 | TEST_F(TestGLibSignals, TestManagerAdditionTemplate) |
1086 | @@ -345,7 +345,7 @@ |
1087 | sigc::mem_fun(this, &TestGLibSignals::Signal5Callback)); |
1088 | manager.Add<gboolean, TestSignals*, const char*, int, float, double, gboolean, char>(test_signals_, "signal6", sigc::mem_fun(this, &TestGLibSignals::Signal6Callback)); |
1089 | |
1090 | - EXPECT_EQ(manager.GetConnections().size(), 7); |
1091 | + EXPECT_EQ(manager.GetConnections().size(), 7u); |
1092 | } |
1093 | |
1094 | TEST_F(TestGLibSignals, TestManagerConnection) |
1095 | |
1096 | === modified file 'tests/test_glib_source.cpp' |
1097 | --- tests/test_glib_source.cpp 2013-10-10 09:47:46 +0000 |
1098 | +++ tests/test_glib_source.cpp 2016-11-30 11:04:07 +0000 |
1099 | @@ -56,7 +56,7 @@ |
1100 | TEST(TestGLibSource, ID) |
1101 | { |
1102 | Idle source; |
1103 | - EXPECT_EQ(source.Id(), 0); |
1104 | + EXPECT_EQ(source.Id(), 0u); |
1105 | } |
1106 | |
1107 | TEST(TestGLibSource, Running) |
1108 | @@ -91,7 +91,7 @@ |
1109 | TEST(TestGLibTimeout, Construction) |
1110 | { |
1111 | Timeout timeout(1000, &OnSourceCallbackContinue); |
1112 | - EXPECT_NE(timeout.Id(), 0); |
1113 | + EXPECT_NE(timeout.Id(), 0u); |
1114 | EXPECT_TRUE(timeout.IsRunning()); |
1115 | EXPECT_EQ(timeout.GetPriority(), Source::Priority::DEFAULT); |
1116 | } |
1117 | @@ -99,7 +99,7 @@ |
1118 | TEST(TestGLibTimeout, ConstructionEmptyCallback) |
1119 | { |
1120 | Timeout timeout(1000, Source::Callback()); |
1121 | - EXPECT_NE(timeout.Id(), 0); |
1122 | + EXPECT_NE(timeout.Id(), 0u); |
1123 | EXPECT_TRUE(timeout.IsRunning()); |
1124 | EXPECT_EQ(timeout.GetPriority(), Source::Priority::DEFAULT); |
1125 | } |
1126 | @@ -107,7 +107,7 @@ |
1127 | TEST(TestGLibTimeout, DelayedRunConstruction) |
1128 | { |
1129 | Timeout timeout(1000); |
1130 | - EXPECT_EQ(timeout.Id(), 0); |
1131 | + EXPECT_EQ(timeout.Id(), 0u); |
1132 | EXPECT_FALSE(timeout.IsRunning()); |
1133 | EXPECT_EQ(timeout.GetPriority(), Source::Priority::DEFAULT); |
1134 | } |
1135 | @@ -124,7 +124,7 @@ |
1136 | } |
1137 | |
1138 | EXPECT_TRUE(removed_called); |
1139 | - EXPECT_EQ(callback_call_count, 0); |
1140 | + EXPECT_EQ(callback_call_count, 0u); |
1141 | } |
1142 | |
1143 | TEST(TestGLibTimeout, OneShotRun) |
1144 | @@ -138,7 +138,7 @@ |
1145 | |
1146 | Utils::WaitUntilMSec([&timeout] {return timeout.IsRunning();}, false, 500); |
1147 | EXPECT_TRUE(callback_called); |
1148 | - EXPECT_EQ(callback_call_count, 1); |
1149 | + EXPECT_EQ(callback_call_count, 1u); |
1150 | EXPECT_TRUE(removed_called); |
1151 | } |
1152 | |
1153 | @@ -157,7 +157,7 @@ |
1154 | } |
1155 | |
1156 | EXPECT_TRUE(callback_called); |
1157 | - EXPECT_GT(callback_call_count, 1); |
1158 | + EXPECT_GT(callback_call_count, 1u); |
1159 | EXPECT_TRUE(removed_called); |
1160 | } |
1161 | |
1162 | @@ -185,10 +185,10 @@ |
1163 | |
1164 | Utils::WaitUntilMSec([&timeout] {return timeout.IsRunning();}, false, 300); |
1165 | |
1166 | - EXPECT_NE(timeout.Id(), 0); |
1167 | + EXPECT_NE(timeout.Id(), 0u); |
1168 | EXPECT_TRUE(removed_called); |
1169 | EXPECT_FALSE(callback_called); |
1170 | - EXPECT_EQ(callback_call_count, 0); |
1171 | + EXPECT_EQ(callback_call_count, 0u); |
1172 | } |
1173 | |
1174 | TEST(TestGLibTimeout, Running) |
1175 | @@ -204,7 +204,7 @@ |
1176 | |
1177 | Utils::WaitUntilMSec([&timeout] {return timeout.IsRunning();}, false, 500); |
1178 | EXPECT_TRUE(callback_called); |
1179 | - EXPECT_EQ(callback_call_count, 1); |
1180 | + EXPECT_EQ(callback_call_count, 1u); |
1181 | } |
1182 | |
1183 | TEST(TestGLibTimeout, RemoveOnCallback) |
1184 | @@ -225,7 +225,7 @@ |
1185 | |
1186 | ASSERT_EQ(timeout.IsRunning(), false); |
1187 | EXPECT_EQ(local_callback_called, true); |
1188 | - EXPECT_EQ(local_callback_call_count, 1); |
1189 | + EXPECT_EQ(local_callback_call_count, 1u); |
1190 | } |
1191 | |
1192 | TEST(TestGLibTimeout, RemovePtrOnCallback) |
1193 | @@ -249,7 +249,7 @@ |
1194 | |
1195 | ASSERT_EQ(timeout, nullptr); |
1196 | EXPECT_EQ(local_callback_called, true); |
1197 | - EXPECT_EQ(local_callback_call_count, 1); |
1198 | + EXPECT_EQ(local_callback_call_count, 1u); |
1199 | } |
1200 | |
1201 | TEST(TestGLibTimeout, AutoRemoveSourceOnCallback) |
1202 | @@ -270,7 +270,7 @@ |
1203 | |
1204 | timeout.reset(); |
1205 | EXPECT_EQ(local_callback_called, true); |
1206 | - EXPECT_EQ(local_callback_call_count, 1); |
1207 | + EXPECT_EQ(local_callback_call_count, 1u); |
1208 | |
1209 | // source should be removed by now. |
1210 | EXPECT_TRUE(g_main_context_find_source_by_id(NULL, id) == nullptr); |
1211 | @@ -282,7 +282,7 @@ |
1212 | TEST(TestGLibTimeoutSeconds, Construction) |
1213 | { |
1214 | TimeoutSeconds timeout(1, &OnSourceCallbackContinue); |
1215 | - EXPECT_NE(timeout.Id(), 0); |
1216 | + EXPECT_NE(timeout.Id(), 0u); |
1217 | EXPECT_TRUE(timeout.IsRunning()); |
1218 | EXPECT_EQ(timeout.GetPriority(), Source::Priority::DEFAULT); |
1219 | } |
1220 | @@ -290,7 +290,7 @@ |
1221 | TEST(TestGLibTimeoutSeconds, DelayedRunConstruction) |
1222 | { |
1223 | TimeoutSeconds timeout(1); |
1224 | - EXPECT_EQ(timeout.Id(), 0); |
1225 | + EXPECT_EQ(timeout.Id(), 0u); |
1226 | EXPECT_FALSE(timeout.IsRunning()); |
1227 | EXPECT_EQ(timeout.GetPriority(), Source::Priority::DEFAULT); |
1228 | } |
1229 | @@ -307,7 +307,7 @@ |
1230 | } |
1231 | |
1232 | EXPECT_TRUE(removed_called); |
1233 | - EXPECT_EQ(callback_call_count, 0); |
1234 | + EXPECT_EQ(callback_call_count, 0u); |
1235 | } |
1236 | |
1237 | TEST(TestGLibTimeoutSeconds, OneShotRun) |
1238 | @@ -321,7 +321,7 @@ |
1239 | |
1240 | Utils::WaitUntil([&timeout] {return timeout.IsRunning();}, false, 2); |
1241 | EXPECT_TRUE(callback_called); |
1242 | - EXPECT_EQ(callback_call_count, 1); |
1243 | + EXPECT_EQ(callback_call_count, 1u); |
1244 | EXPECT_TRUE(removed_called); |
1245 | } |
1246 | |
1247 | @@ -340,7 +340,7 @@ |
1248 | } |
1249 | |
1250 | EXPECT_TRUE(callback_called); |
1251 | - EXPECT_GT(callback_call_count, 1); |
1252 | + EXPECT_GT(callback_call_count, 1u); |
1253 | EXPECT_TRUE(removed_called); |
1254 | } |
1255 | |
1256 | @@ -349,7 +349,7 @@ |
1257 | TEST(TestGLibIdle, Construction) |
1258 | { |
1259 | Idle idle(&OnSourceCallbackStop); |
1260 | - EXPECT_NE(idle.Id(), 0); |
1261 | + EXPECT_NE(idle.Id(), 0u); |
1262 | EXPECT_EQ(idle.GetPriority(), Source::Priority::DEFAULT_IDLE); |
1263 | } |
1264 | |
1265 | @@ -365,7 +365,7 @@ |
1266 | } |
1267 | |
1268 | EXPECT_TRUE(removed_called); |
1269 | - EXPECT_EQ(callback_call_count, 0); |
1270 | + EXPECT_EQ(callback_call_count, 0u); |
1271 | } |
1272 | |
1273 | TEST(TestGLibIdle, OneShotRun) |
1274 | @@ -382,7 +382,7 @@ |
1275 | Utils::WaitUntilMSec([&idle] {return idle.IsRunning();}, false, 100); |
1276 | EXPECT_FALSE(idle.IsRunning()); |
1277 | EXPECT_TRUE(callback_called); |
1278 | - EXPECT_EQ(callback_call_count, 1); |
1279 | + EXPECT_EQ(callback_call_count, 1u); |
1280 | EXPECT_LE(pre, post); |
1281 | } |
1282 | |
1283 | @@ -402,7 +402,7 @@ |
1284 | } |
1285 | |
1286 | EXPECT_TRUE(callback_called); |
1287 | - EXPECT_GT(callback_call_count, 1); |
1288 | + EXPECT_GT(callback_call_count, 1u); |
1289 | DeltaTime time_delta = unity::TimeUtil::TimeDelta(&post, &pre); |
1290 | EXPECT_GE(time_delta, 100); |
1291 | EXPECT_LT(time_delta, 200); |
1292 | @@ -420,10 +420,10 @@ |
1293 | |
1294 | Utils::WaitUntilMSec([&idle] {return idle.IsRunning();}, false, 300); |
1295 | |
1296 | - EXPECT_NE(idle.Id(), 0); |
1297 | + EXPECT_NE(idle.Id(), 0u); |
1298 | EXPECT_TRUE(removed_called); |
1299 | EXPECT_FALSE(callback_called); |
1300 | - EXPECT_EQ(callback_call_count, 0); |
1301 | + EXPECT_EQ(callback_call_count, 0u); |
1302 | } |
1303 | |
1304 | TEST(TestGLibIdle, Running) |
1305 | @@ -439,7 +439,7 @@ |
1306 | |
1307 | Utils::WaitUntilMSec([&idle] {return idle.IsRunning();}, false, 20000); |
1308 | EXPECT_TRUE(callback_called); |
1309 | - EXPECT_EQ(callback_call_count, 1); |
1310 | + EXPECT_EQ(callback_call_count, 1u); |
1311 | } |
1312 | |
1313 | TEST(TestGLibIdle, RemoveOnCallback) |
1314 | @@ -460,7 +460,7 @@ |
1315 | |
1316 | ASSERT_EQ(idle.IsRunning(), false); |
1317 | EXPECT_EQ(local_callback_called, true); |
1318 | - EXPECT_EQ(local_callback_call_count, 1); |
1319 | + EXPECT_EQ(local_callback_call_count, 1u); |
1320 | } |
1321 | |
1322 | TEST(TestGLibIdle, RemovePtrOnCallback) |
1323 | @@ -481,7 +481,7 @@ |
1324 | |
1325 | ASSERT_EQ(idle, nullptr); |
1326 | EXPECT_EQ(local_callback_called, true); |
1327 | - EXPECT_EQ(local_callback_call_count, 1); |
1328 | + EXPECT_EQ(local_callback_call_count, 1u); |
1329 | } |
1330 | |
1331 | // Test GLibSource Manager |
1332 | @@ -509,7 +509,7 @@ |
1333 | manager.Add(new Idle()); |
1334 | manager.Add(new Idle(&OnSourceCallbackContinue)); |
1335 | |
1336 | - EXPECT_EQ(manager.GetSources().size(), 4); |
1337 | + EXPECT_EQ(manager.GetSources().size(), 4u); |
1338 | } |
1339 | |
1340 | TEST(TestGLibSourceManager, AddingNamedSources) |
1341 | @@ -532,7 +532,7 @@ |
1342 | manager.Add(idle_2, "idle-2"); |
1343 | ASSERT_EQ(manager.GetSource("idle-2").get(), idle_2); |
1344 | |
1345 | - EXPECT_EQ(manager.GetSources().size(), 4); |
1346 | + EXPECT_EQ(manager.GetSources().size(), 4u); |
1347 | } |
1348 | |
1349 | TEST(TestGLibSourceManager, AddingDuplicatedSources) |
1350 | @@ -550,7 +550,7 @@ |
1351 | EXPECT_EQ(manager.GetSource(timeout->Id()), timeout); |
1352 | EXPECT_EQ(ret, false); |
1353 | |
1354 | - EXPECT_EQ(manager.GetSources().size(), 1); |
1355 | + EXPECT_EQ(manager.GetSources().size(), 1u); |
1356 | } |
1357 | |
1358 | TEST(TestGLibSourceManager, AddingDuplicatedNamedSources) |
1359 | @@ -570,7 +570,7 @@ |
1360 | EXPECT_EQ(ret, true); |
1361 | |
1362 | EXPECT_FALSE(timeout_1->IsRunning()); |
1363 | - EXPECT_EQ(manager.GetSources().size(), 1); |
1364 | + EXPECT_EQ(manager.GetSources().size(), 1u); |
1365 | } |
1366 | |
1367 | TEST(TestGLibSourceManager, AddingTimeouts) |
1368 | @@ -580,7 +580,7 @@ |
1369 | auto timeout1 = manager.AddTimeout(1); |
1370 | auto timeout2 = manager.AddTimeout(1, &OnSourceCallbackContinue); |
1371 | |
1372 | - EXPECT_EQ(manager.GetSources().size(), 2); |
1373 | + EXPECT_EQ(manager.GetSources().size(), 2u); |
1374 | EXPECT_FALSE(timeout1->IsRunning()); |
1375 | EXPECT_TRUE(timeout2->IsRunning()); |
1376 | } |
1377 | @@ -592,7 +592,7 @@ |
1378 | auto idle1 = manager.AddIdle(); |
1379 | auto idle2 = manager.AddIdle(&OnSourceCallbackContinue); |
1380 | |
1381 | - EXPECT_EQ(manager.GetSources().size(), 2); |
1382 | + EXPECT_EQ(manager.GetSources().size(), 2u); |
1383 | EXPECT_FALSE(idle1->IsRunning()); |
1384 | EXPECT_TRUE(idle2->IsRunning()); |
1385 | } |
1386 | @@ -613,21 +613,21 @@ |
1387 | |
1388 | manager.Remove(timeout1->Id()); |
1389 | EXPECT_FALSE(timeout1->IsRunning()); |
1390 | - EXPECT_EQ(manager.GetSources().size(), 3); |
1391 | + EXPECT_EQ(manager.GetSources().size(), 3u); |
1392 | |
1393 | manager.Remove(timeout2->Id()); |
1394 | EXPECT_FALSE(timeout2->IsRunning()); |
1395 | EXPECT_EQ(manager.GetSource(timeout2->Id()), nullptr); |
1396 | - EXPECT_EQ(manager.GetSources().size(), 2); |
1397 | + EXPECT_EQ(manager.GetSources().size(), 2u); |
1398 | |
1399 | manager.Remove(idle1->Id()); |
1400 | EXPECT_FALSE(idle1->IsRunning()); |
1401 | - EXPECT_EQ(manager.GetSources().size(), 1); |
1402 | + EXPECT_EQ(manager.GetSources().size(), 1u); |
1403 | |
1404 | manager.Remove(idle2->Id()); |
1405 | EXPECT_FALSE(idle2->IsRunning()); |
1406 | EXPECT_EQ(manager.GetSource(idle2->Id()), nullptr); |
1407 | - EXPECT_EQ(manager.GetSources().size(), 0); |
1408 | + EXPECT_EQ(manager.GetSources().size(), 0u); |
1409 | } |
1410 | |
1411 | TEST(TestGLibSourceManager, RemovingSourcesByNick) |
1412 | @@ -647,22 +647,22 @@ |
1413 | manager.Remove("timeout-1"); |
1414 | EXPECT_FALSE(timeout1->IsRunning()); |
1415 | EXPECT_EQ(manager.GetSource("timeout-1"), nullptr); |
1416 | - EXPECT_EQ(manager.GetSources().size(), 3); |
1417 | + EXPECT_EQ(manager.GetSources().size(), 3u); |
1418 | |
1419 | manager.Remove("timeout-2"); |
1420 | EXPECT_FALSE(timeout2->IsRunning()); |
1421 | EXPECT_EQ(manager.GetSource("timeout-2"), nullptr); |
1422 | - EXPECT_EQ(manager.GetSources().size(), 2); |
1423 | + EXPECT_EQ(manager.GetSources().size(), 2u); |
1424 | |
1425 | manager.Remove("idle-1"); |
1426 | EXPECT_FALSE(idle1->IsRunning()); |
1427 | EXPECT_EQ(manager.GetSource("idle-1"), nullptr); |
1428 | - EXPECT_EQ(manager.GetSources().size(), 1); |
1429 | + EXPECT_EQ(manager.GetSources().size(), 1u); |
1430 | |
1431 | manager.Remove("idle-2"); |
1432 | EXPECT_FALSE(idle2->IsRunning()); |
1433 | EXPECT_EQ(manager.GetSource("idle-2"), nullptr); |
1434 | - EXPECT_EQ(manager.GetSources().size(), 0); |
1435 | + EXPECT_EQ(manager.GetSources().size(), 0u); |
1436 | } |
1437 | |
1438 | TEST(TestGLibSourceManager, RemovesOnDisconnection) |
1439 | @@ -675,16 +675,16 @@ |
1440 | manager.Add(timeout); |
1441 | manager.Add(idle); |
1442 | |
1443 | - ASSERT_EQ(manager.GetSources().size(), 2); |
1444 | + ASSERT_EQ(manager.GetSources().size(), 2u); |
1445 | EXPECT_EQ(timeout, manager.GetSource(timeout->Id())); |
1446 | EXPECT_EQ(idle, manager.GetSource(idle->Id())); |
1447 | |
1448 | timeout->Remove(); |
1449 | - EXPECT_EQ(manager.GetSources().size(), 1); |
1450 | + EXPECT_EQ(manager.GetSources().size(), 1u); |
1451 | EXPECT_EQ(manager.GetSource(timeout->Id()), nullptr); |
1452 | |
1453 | idle->Remove(); |
1454 | - EXPECT_EQ(manager.GetSources().size(), 0); |
1455 | + EXPECT_EQ(manager.GetSources().size(), 0u); |
1456 | EXPECT_EQ(manager.GetSource(idle->Id()), nullptr); |
1457 | } |
1458 | |
1459 | @@ -742,7 +742,7 @@ |
1460 | |
1461 | ASSERT_FALSE(idle->IsRunning()); |
1462 | EXPECT_TRUE(local_callback_called); |
1463 | - EXPECT_EQ(1, local_callback_call_count); |
1464 | + EXPECT_EQ(1u, local_callback_call_count); |
1465 | } |
1466 | |
1467 | } |
1468 | |
1469 | === modified file 'tests/test_glib_variant.cpp' |
1470 | --- tests/test_glib_variant.cpp 2013-11-14 01:44:15 +0000 |
1471 | +++ tests/test_glib_variant.cpp 2016-11-30 11:04:07 +0000 |
1472 | @@ -241,9 +241,9 @@ |
1473 | EXPECT_EQ("charstring-value", Variant(g_variant_lookup_value(v, "charstring-key", nullptr)).GetString()); |
1474 | EXPECT_EQ("string-value", Variant(g_variant_lookup_value(v, "string-key", nullptr)).GetString()); |
1475 | EXPECT_EQ(-1, Variant(g_variant_lookup_value(v, "gint32-key", nullptr)).GetInt32()); |
1476 | - EXPECT_EQ(2, Variant(g_variant_lookup_value(v, "guint32-key", nullptr)).GetUInt32()); |
1477 | + EXPECT_EQ(2u, Variant(g_variant_lookup_value(v, "guint32-key", nullptr)).GetUInt32()); |
1478 | EXPECT_EQ(-3, Variant(g_variant_lookup_value(v, "gint64-key", nullptr)).GetInt64()); |
1479 | - EXPECT_EQ(4, Variant(g_variant_lookup_value(v, "guint64-key", nullptr)).GetUInt64()); |
1480 | + EXPECT_EQ(4u, Variant(g_variant_lookup_value(v, "guint64-key", nullptr)).GetUInt64()); |
1481 | EXPECT_FLOAT_EQ(1.1, Variant(g_variant_lookup_value(v, "float-key", nullptr)).GetFloat()); |
1482 | EXPECT_DOUBLE_EQ(2.2, Variant(g_variant_lookup_value(v, "double-key", nullptr)).GetDouble()); |
1483 | EXPECT_EQ(true, Variant(g_variant_lookup_value(v, "bool-key", nullptr)).GetBool()); |
1484 | @@ -387,9 +387,9 @@ |
1485 | EXPECT_EQ("charstring-value", Variant(g_variant_lookup_value(v, "charstring-key", nullptr)).GetString()); |
1486 | EXPECT_EQ("string-value", Variant(g_variant_lookup_value(v, "string-key", nullptr)).GetString()); |
1487 | EXPECT_EQ(-1, Variant(g_variant_lookup_value(v, "gint32-key", nullptr)).GetInt32()); |
1488 | - EXPECT_EQ(2, Variant(g_variant_lookup_value(v, "guint32-key", nullptr)).GetUInt32()); |
1489 | + EXPECT_EQ(2u, Variant(g_variant_lookup_value(v, "guint32-key", nullptr)).GetUInt32()); |
1490 | EXPECT_EQ(-3, Variant(g_variant_lookup_value(v, "gint64-key", nullptr)).GetInt64()); |
1491 | - EXPECT_EQ(4, Variant(g_variant_lookup_value(v, "guint64-key", nullptr)).GetUInt64()); |
1492 | + EXPECT_EQ(4u, Variant(g_variant_lookup_value(v, "guint64-key", nullptr)).GetUInt64()); |
1493 | EXPECT_FLOAT_EQ(1.1, Variant(g_variant_lookup_value(v, "float-key", nullptr)).GetFloat()); |
1494 | EXPECT_DOUBLE_EQ(2.2, Variant(g_variant_lookup_value(v, "double-key", nullptr)).GetDouble()); |
1495 | EXPECT_EQ(true, Variant(g_variant_lookup_value(v, "bool-key", nullptr)).GetBool()); |
1496 | @@ -590,10 +590,10 @@ |
1497 | EXPECT_EQ(v2.GetUInt32(), value); |
1498 | |
1499 | Variant v3(g_variant_new("(ui)", value, G_MAXUINT32)); |
1500 | - EXPECT_EQ(v3.GetUInt32(), 0); |
1501 | + EXPECT_EQ(v3.GetUInt32(), 0u); |
1502 | |
1503 | Variant v4; |
1504 | - EXPECT_EQ(v4.GetUInt32(), 0); |
1505 | + EXPECT_EQ(v4.GetUInt32(), 0u); |
1506 | |
1507 | value = g_random_int(); |
1508 | Variant v5(g_variant_new_variant(g_variant_new_uint32(value))); |
1509 | @@ -632,10 +632,10 @@ |
1510 | EXPECT_EQ(v2.GetUInt64(), value); |
1511 | |
1512 | Variant v3(g_variant_new("(ti)", value, G_MAXINT64)); |
1513 | - EXPECT_EQ(v3.GetUInt64(), 0); |
1514 | + EXPECT_EQ(v3.GetUInt64(), 0u); |
1515 | |
1516 | Variant v4; |
1517 | - EXPECT_EQ(v4.GetUInt64(), 0); |
1518 | + EXPECT_EQ(v4.GetUInt64(), 0u); |
1519 | |
1520 | value = g_random_int(); |
1521 | Variant v5(g_variant_new_variant(g_variant_new_uint64(value))); |
1522 | @@ -702,7 +702,7 @@ |
1523 | |
1524 | auto const& variant = Variant::FromVector(empty); |
1525 | ASSERT_TRUE(g_variant_is_container(variant)); |
1526 | - ASSERT_EQ(0, g_variant_n_children(variant)); |
1527 | + ASSERT_EQ(0u, g_variant_n_children(variant)); |
1528 | EXPECT_TRUE(g_variant_is_of_type(variant, G_VARIANT_TYPE_ARRAY)); |
1529 | } |
1530 | |
1531 | |
1532 | === modified file 'tests/test_gnome_session_manager.cpp' |
1533 | --- tests/test_gnome_session_manager.cpp 2016-11-02 16:38:47 +0000 |
1534 | +++ tests/test_gnome_session_manager.cpp 2016-11-30 11:04:07 +0000 |
1535 | @@ -510,7 +510,7 @@ |
1536 | if (method == "Logout") |
1537 | { |
1538 | logout_called = true; |
1539 | - EXPECT_EQ(Variant(par).GetUInt32(), 1); |
1540 | + EXPECT_EQ(Variant(par).GetUInt32(), 1u); |
1541 | } |
1542 | |
1543 | return nullptr; |
1544 | |
1545 | === modified file 'tests/test_grabhandle.cpp' |
1546 | --- tests/test_grabhandle.cpp 2013-07-18 04:16:50 +0000 |
1547 | +++ tests/test_grabhandle.cpp 2016-11-30 11:04:07 +0000 |
1548 | @@ -168,7 +168,7 @@ |
1549 | EXPECT_EQ (handlesMask, MiddleHandle); |
1550 | |
1551 | handlesMask = unity::MT::getLayoutForMask (MaximizedHorzMask | MaximizedVertMask, ResizeMask); |
1552 | - EXPECT_EQ (handlesMask, 0); |
1553 | + EXPECT_EQ (handlesMask, 0u); |
1554 | |
1555 | handlesMask = unity::MT::getLayoutForMask (MaximizedHorzMask, ResizeMask); |
1556 | EXPECT_EQ (handlesMask, BottomHandle | TopHandle); |
1557 | @@ -193,7 +193,7 @@ |
1558 | EXPECT_EQ (handlesMask, MiddleHandle); |
1559 | |
1560 | handlesMask = unity::MT::getLayoutForMask (0, 0); |
1561 | - EXPECT_EQ (handlesMask, 0); |
1562 | + EXPECT_EQ (handlesMask, 0u); |
1563 | } |
1564 | |
1565 | TEST_F(UnityMTGrabHandleTest, TestLayouts) |
1566 | |
1567 | === modified file 'tests/test_gsettings_scopes.cpp' |
1568 | --- tests/test_gsettings_scopes.cpp 2014-03-21 08:51:01 +0000 |
1569 | +++ tests/test_gsettings_scopes.cpp 2016-11-30 11:04:07 +0000 |
1570 | @@ -72,9 +72,9 @@ |
1571 | }); |
1572 | } |
1573 | |
1574 | - int scope_added; |
1575 | - int scope_removed; |
1576 | - int scopes_reordered; |
1577 | + unsigned scope_added; |
1578 | + unsigned scope_removed; |
1579 | + unsigned scopes_reordered; |
1580 | }; |
1581 | |
1582 | TEST_F(TestGSettingsScopes, TestAdded) |
1583 | @@ -83,13 +83,13 @@ |
1584 | ConnectScope(&scopes); |
1585 | |
1586 | scopes.InsertScope("testscope1.scope", 0); |
1587 | - EXPECT_EQ(scopes.count, (unsigned int)1); |
1588 | - EXPECT_EQ(scopes_reordered, (unsigned int)0); |
1589 | + EXPECT_EQ(scopes.count, 1u); |
1590 | + EXPECT_EQ(scopes_reordered, 0u); |
1591 | |
1592 | // add another |
1593 | scopes.InsertScope("testscope2.scope", 1); |
1594 | - EXPECT_EQ(scopes.count, (unsigned int)2); |
1595 | - EXPECT_EQ(scopes_reordered, (unsigned int)0); |
1596 | + EXPECT_EQ(scopes.count, 2u); |
1597 | + EXPECT_EQ(scopes_reordered, 0u); |
1598 | |
1599 | int position = -1; |
1600 | EXPECT_TRUE(scopes.GetScope("testscope1.scope", &position) && position == 0); |
1601 | @@ -105,12 +105,12 @@ |
1602 | scopes.InsertScope("testscope2.scope", 1); |
1603 | scopes.InsertScope("testscope3.scope", 2); |
1604 | scopes.InsertScope("testscope4.scope", 3); |
1605 | - EXPECT_EQ(scopes.count, (unsigned int)4); |
1606 | - EXPECT_EQ(scopes_reordered, (unsigned int)0); |
1607 | + EXPECT_EQ(scopes.count, 4u); |
1608 | + EXPECT_EQ(scopes_reordered, 0u); |
1609 | |
1610 | // change position |
1611 | scopes.InsertScope("testscope3.scope", 0); |
1612 | - EXPECT_EQ(scopes_reordered, (unsigned int)1); |
1613 | + EXPECT_EQ(scopes_reordered, 1u); |
1614 | |
1615 | int position = -1; |
1616 | EXPECT_TRUE(scopes.GetScope("testscope3.scope", &position) && position == 0); |
1617 | @@ -128,12 +128,12 @@ |
1618 | scopes.InsertScope("testscope2.scope", 1); |
1619 | scopes.InsertScope("testscope3.scope", 2); |
1620 | scopes.InsertScope("testscope4.scope", 3); |
1621 | - EXPECT_EQ(scopes.count, (unsigned int)4); |
1622 | - EXPECT_EQ(scopes_reordered, (unsigned int)0); |
1623 | + EXPECT_EQ(scopes.count, 4u); |
1624 | + EXPECT_EQ(scopes_reordered, 0u); |
1625 | |
1626 | // change position |
1627 | scopes.InsertScope("testscope2.scope", 3); |
1628 | - EXPECT_EQ(scopes_reordered, (unsigned int)1); |
1629 | + EXPECT_EQ(scopes_reordered, 1u); |
1630 | |
1631 | int position = -1; |
1632 | EXPECT_TRUE(scopes.GetScope("testscope1.scope", &position) && position == 0); |
1633 | @@ -149,8 +149,8 @@ |
1634 | ConnectScope(&scopes); |
1635 | |
1636 | scopes.InsertScope("non-existing.scope", 0); |
1637 | - EXPECT_EQ(scope_added, (unsigned int)0); |
1638 | - EXPECT_EQ(scopes.count, (unsigned int)0); |
1639 | + EXPECT_EQ(scope_added, 0u); |
1640 | + EXPECT_EQ(scopes.count, 0u); |
1641 | } |
1642 | |
1643 | TEST_F(TestGSettingsScopes, TestAddSame) |
1644 | @@ -159,15 +159,15 @@ |
1645 | ConnectScope(&scopes); |
1646 | |
1647 | scopes.InsertScope("testscope1.scope", 0); |
1648 | - EXPECT_EQ(scope_added, (unsigned int)1); |
1649 | - EXPECT_EQ(scopes.count, (unsigned int)1); |
1650 | + EXPECT_EQ(scope_added, 1u); |
1651 | + EXPECT_EQ(scopes.count, 1u); |
1652 | |
1653 | // shouldnt add another |
1654 | scopes.InsertScope("testscope1.scope", 1); |
1655 | |
1656 | - EXPECT_EQ(scope_added, (unsigned int)1); |
1657 | - EXPECT_EQ(scopes.count, (unsigned int)1); |
1658 | - EXPECT_EQ(scopes_reordered, (unsigned int)0); |
1659 | + EXPECT_EQ(scope_added, 1u); |
1660 | + EXPECT_EQ(scopes.count, 1u); |
1661 | + EXPECT_EQ(scopes_reordered, 0u); |
1662 | } |
1663 | |
1664 | TEST_F(TestGSettingsScopes, TestAddRemove) |
1665 | @@ -176,12 +176,12 @@ |
1666 | ConnectScope(&scopes); |
1667 | |
1668 | scopes.InsertScope("testscope1.scope", 0); |
1669 | - EXPECT_EQ(scope_added, (unsigned int)1); |
1670 | - EXPECT_EQ(scopes.count, (unsigned int)1); |
1671 | + EXPECT_EQ(scope_added, 1u); |
1672 | + EXPECT_EQ(scopes.count, 1u); |
1673 | |
1674 | scopes.RemoveScope("testscope1.scope"); |
1675 | - EXPECT_EQ(scope_removed, (unsigned int)1); |
1676 | - EXPECT_EQ(scopes.count, (unsigned int)0); |
1677 | + EXPECT_EQ(scope_removed, 1u); |
1678 | + EXPECT_EQ(scopes.count, 0u); |
1679 | } |
1680 | |
1681 | TEST_F(TestGSettingsScopes, TestRemoveNonExists) |
1682 | @@ -190,8 +190,8 @@ |
1683 | ConnectScope(&scopes); |
1684 | |
1685 | scopes.RemoveScope("non-existing.scope"); |
1686 | - EXPECT_EQ(scope_removed, (unsigned int)0); |
1687 | - EXPECT_EQ(scopes.count, (unsigned int)0); |
1688 | + EXPECT_EQ(scope_removed, 0u); |
1689 | + EXPECT_EQ(scopes.count, 0u); |
1690 | } |
1691 | |
1692 | TEST_F(TestGSettingsScopes, TestLoad) |
1693 | @@ -200,7 +200,7 @@ |
1694 | ConnectScope(&scopes); |
1695 | |
1696 | scopes.LoadScopes(); |
1697 | - EXPECT_EQ(scope_added, (unsigned int)4); |
1698 | + EXPECT_EQ(scope_added, 4u); |
1699 | |
1700 | int position = -1; |
1701 | EXPECT_TRUE(scopes.GetScope("testscope1.scope", &position) && position == 0); |
1702 | @@ -215,15 +215,15 @@ |
1703 | ConnectScope(&scopes); |
1704 | |
1705 | scopes.LoadScopes(); |
1706 | - EXPECT_EQ(scope_added, (unsigned int)2); |
1707 | - EXPECT_EQ(scopes.count, (unsigned int)2); |
1708 | + EXPECT_EQ(scope_added, 2u); |
1709 | + EXPECT_EQ(scopes.count, 2u); |
1710 | |
1711 | scopes.UpdateScopes(scopes_updated); |
1712 | Utils::WaitUntilMSec([this] { return scope_removed > 0; }, true, 2000); |
1713 | |
1714 | - EXPECT_EQ(scope_added, (unsigned int)4); |
1715 | - EXPECT_EQ(scope_removed, (unsigned int)1); |
1716 | - EXPECT_EQ(scopes.count, (unsigned int)3); |
1717 | + EXPECT_EQ(scope_added, 4u); |
1718 | + EXPECT_EQ(scope_removed, 1u); |
1719 | + EXPECT_EQ(scopes.count, 3u); |
1720 | } |
1721 | |
1722 | |
1723 | |
1724 | === modified file 'tests/test_hud_button.cpp' |
1725 | --- tests/test_hud_button.cpp 2014-03-21 04:40:12 +0000 |
1726 | +++ tests/test_hud_button.cpp 2016-11-30 11:04:07 +0000 |
1727 | @@ -41,13 +41,13 @@ |
1728 | nux::Layout* layout = button->GetLayout(); |
1729 | |
1730 | ASSERT_NE(layout, nullptr); |
1731 | - ASSERT_EQ(layout->GetChildren().size(), 0); |
1732 | + ASSERT_EQ(layout->GetChildren().size(), 0u); |
1733 | |
1734 | hud::Query::Ptr query(new hud::Query("<b>Op</b> Fi<b>le</b>", "","", "", "", NULL)); |
1735 | button->SetQuery(query); |
1736 | |
1737 | auto children(layout->GetChildren()); |
1738 | - ASSERT_EQ(children.size(), 3); |
1739 | + ASSERT_EQ(children.size(), 3u); |
1740 | |
1741 | auto it = children.begin(); |
1742 | StaticCairoText* label = dynamic_cast<StaticCairoText*>(*it); |
1743 | |
1744 | === modified file 'tests/test_hud_private.cpp' |
1745 | --- tests/test_hud_private.cpp 2012-05-30 14:33:07 +0000 |
1746 | +++ tests/test_hud_private.cpp 2016-11-30 11:04:07 +0000 |
1747 | @@ -32,20 +32,20 @@ |
1748 | std::vector<std::pair<std::string, bool>> temp; |
1749 | |
1750 | temp = impl::RefactorText(""); |
1751 | - ASSERT_EQ(temp.size(), 0); |
1752 | + ASSERT_EQ(temp.size(), 0u); |
1753 | |
1754 | temp = impl::RefactorText("Test"); |
1755 | - ASSERT_EQ(temp.size(), 1); |
1756 | + ASSERT_EQ(temp.size(), 1u); |
1757 | EXPECT_EQ(temp[0].first, "Test"); |
1758 | EXPECT_EQ(temp[0].second, false); // True means "Full opacity", false "Half opacity" |
1759 | |
1760 | temp = impl::RefactorText("<b>Test</b>"); |
1761 | - ASSERT_EQ(temp.size(), 1); |
1762 | + ASSERT_EQ(temp.size(), 1u); |
1763 | EXPECT_EQ(temp[0].first, "Test"); |
1764 | EXPECT_EQ(temp[0].second, true); |
1765 | |
1766 | temp = impl::RefactorText("Hello > <b>Test</b> World"); |
1767 | - ASSERT_EQ(temp.size(), 3); |
1768 | + ASSERT_EQ(temp.size(), 3u); |
1769 | EXPECT_EQ(temp[0].first, "Hello > "); |
1770 | EXPECT_EQ(temp[0].second, false); |
1771 | EXPECT_EQ(temp[1].first, "Test"); |
1772 | @@ -54,7 +54,7 @@ |
1773 | EXPECT_EQ(temp[2].second, false); |
1774 | |
1775 | temp = impl::RefactorText("Open <b>Fi</b>le <b>Wit</b>h"); |
1776 | - ASSERT_EQ(temp.size(), 5); |
1777 | + ASSERT_EQ(temp.size(), 5u); |
1778 | EXPECT_EQ(temp[0].first, "Open "); |
1779 | EXPECT_EQ(temp[0].second, false); |
1780 | EXPECT_EQ(temp[1].first, "Fi"); |
1781 | @@ -67,7 +67,7 @@ |
1782 | EXPECT_EQ(temp[4].second, false); |
1783 | |
1784 | temp = impl::RefactorText("Open <b>File With"); |
1785 | - ASSERT_EQ(temp.size(), 2); |
1786 | + ASSERT_EQ(temp.size(), 2u); |
1787 | EXPECT_EQ(temp[0].first, "Open "); |
1788 | EXPECT_EQ(temp[0].second, false); |
1789 | EXPECT_EQ(temp[1].first, "File With"); |
1790 | |
1791 | === modified file 'tests/test_hud_view.cpp' |
1792 | --- tests/test_hud_view.cpp 2014-03-21 04:40:12 +0000 |
1793 | +++ tests/test_hud_view.cpp 2016-11-30 11:04:07 +0000 |
1794 | @@ -50,7 +50,7 @@ |
1795 | queries.push_back(hud::Query::Ptr(new hud::Query("4", "","", "", "", NULL))); |
1796 | view->SetQueries(queries); |
1797 | |
1798 | - ASSERT_EQ(view->buttons().size(), 4); |
1799 | + ASSERT_EQ(view->buttons().size(), 4u); |
1800 | |
1801 | auto it = view->buttons().begin(); |
1802 | EXPECT_EQ((*it)->label, "4"); |
1803 | |
1804 | === modified file 'tests/test_indicator.cpp' |
1805 | --- tests/test_indicator.cpp 2015-02-02 14:54:45 +0000 |
1806 | +++ tests/test_indicator.cpp 2016-11-30 11:04:07 +0000 |
1807 | @@ -94,19 +94,19 @@ |
1808 | } |
1809 | |
1810 | indicator.Sync(sync_data); |
1811 | - EXPECT_EQ(indicator.GetEntries().size(), 3); |
1812 | + EXPECT_EQ(indicator.GetEntries().size(), 3u); |
1813 | EXPECT_EQ(indicator.GetEntry("test-entry-2"), entry2); |
1814 | // Mock::VerifyAndClearExpectations(&sig_receiver); |
1815 | |
1816 | // Sync the indicator removing an entry |
1817 | sync_data.erase(std::remove(sync_data.begin(), sync_data.end(), entry2), sync_data.end()); |
1818 | - EXPECT_EQ(sync_data.size(), 2); |
1819 | + EXPECT_EQ(sync_data.size(), 2u); |
1820 | EXPECT_CALL(sig_receiver, Updated()); |
1821 | EXPECT_CALL(sig_receiver, EntryAdded(_)).Times(0); |
1822 | EXPECT_CALL(sig_receiver, EntryRemoved(entry2)); |
1823 | |
1824 | indicator.Sync(sync_data); |
1825 | - EXPECT_EQ(indicator.GetEntries().size(), 2); |
1826 | + EXPECT_EQ(indicator.GetEntries().size(), 2u); |
1827 | EXPECT_EQ(indicator.GetEntry("test-entry-2"), nullptr); |
1828 | |
1829 | // Sync the indicator removing an entry and adding a new one |
1830 | @@ -115,13 +115,13 @@ |
1831 | Entry::Ptr entry4(entry); |
1832 | sync_data.push_back(entry4); |
1833 | sync_data.erase(std::remove(sync_data.begin(), sync_data.end(), entry3), sync_data.end()); |
1834 | - EXPECT_EQ(sync_data.size(), 2); |
1835 | + EXPECT_EQ(sync_data.size(), 2u); |
1836 | |
1837 | EXPECT_CALL(sig_receiver, EntryAdded(entry4)); |
1838 | EXPECT_CALL(sig_receiver, EntryRemoved(entry3)); |
1839 | EXPECT_CALL(sig_receiver, Updated()); |
1840 | indicator.Sync(sync_data); |
1841 | - EXPECT_EQ(indicator.GetEntries().size(), 2); |
1842 | + EXPECT_EQ(indicator.GetEntries().size(), 2u); |
1843 | |
1844 | // Remove all the indicators |
1845 | |
1846 | @@ -132,7 +132,7 @@ |
1847 | |
1848 | sync_data.clear(); |
1849 | indicator.Sync(sync_data); |
1850 | - EXPECT_EQ(indicator.GetEntries().size(), 0); |
1851 | + EXPECT_EQ(indicator.GetEntries().size(), 0u); |
1852 | } |
1853 | |
1854 | TEST(TestIndicator, Updated) |
1855 | |
1856 | === modified file 'tests/test_indicator_appmenu.cpp' |
1857 | --- tests/test_indicator_appmenu.cpp 2015-02-09 18:55:18 +0000 |
1858 | +++ tests/test_indicator_appmenu.cpp 2016-11-30 11:04:07 +0000 |
1859 | @@ -108,7 +108,7 @@ |
1860 | |
1861 | // Sync the indicator removing an entry |
1862 | sync_data.erase(std::remove(sync_data.begin(), sync_data.end(), entry2), sync_data.end()); |
1863 | - ASSERT_EQ(sync_data.size(), 2); |
1864 | + ASSERT_EQ(sync_data.size(), 2u); |
1865 | EXPECT_CALL(sig_receiver, Updated()); |
1866 | EXPECT_CALL(sig_receiver, UpdatedWin(parent_window1)); |
1867 | EXPECT_CALL(sig_receiver, UpdatedWin(parent_window2)).Times(0); |
1868 | @@ -116,7 +116,7 @@ |
1869 | EXPECT_CALL(sig_receiver, EntryRemoved(entry2)); |
1870 | |
1871 | indicator.Sync(sync_data); |
1872 | - EXPECT_EQ(indicator.GetEntries().size(), 2); |
1873 | + EXPECT_EQ(indicator.GetEntries().size(), 2u); |
1874 | EXPECT_EQ(indicator.GetEntry("test-entry-2"), nullptr); |
1875 | EXPECT_EQ(indicator.GetEntriesForWindow(parent_window1), Indicator::Entries({entry1})); |
1876 | |
1877 | @@ -124,7 +124,7 @@ |
1878 | auto entry4 = std::make_shared<Entry>("test-entry-4", "name-hint", parent_window2, "label", true, true, 0, "icon", true, true, -1); |
1879 | sync_data.push_back(entry4); |
1880 | sync_data.erase(std::remove(sync_data.begin(), sync_data.end(), entry3), sync_data.end()); |
1881 | - EXPECT_EQ(sync_data.size(), 2); |
1882 | + EXPECT_EQ(sync_data.size(), 2u); |
1883 | |
1884 | EXPECT_CALL(sig_receiver, EntryAdded(entry4)); |
1885 | EXPECT_CALL(sig_receiver, EntryRemoved(entry3)); |
1886 | |
1887 | === modified file 'tests/test_indicator_entry.cpp' |
1888 | --- tests/test_indicator_entry.cpp 2014-12-19 17:26:43 +0000 |
1889 | +++ tests/test_indicator_entry.cpp 2016-11-30 11:04:07 +0000 |
1890 | @@ -40,7 +40,7 @@ |
1891 | |
1892 | EXPECT_EQ(entry.id(), "id"); |
1893 | EXPECT_EQ(entry.name_hint(), "name_hint"); |
1894 | - EXPECT_EQ(entry.parent_window(), 12345); |
1895 | + EXPECT_EQ(entry.parent_window(), 12345u); |
1896 | EXPECT_EQ(entry.label(), "label"); |
1897 | EXPECT_TRUE(entry.label_sensitive()); |
1898 | EXPECT_TRUE(entry.label_visible()); |
1899 | @@ -60,7 +60,7 @@ |
1900 | |
1901 | EXPECT_EQ(entry.id(), "id"); |
1902 | EXPECT_EQ(entry.name_hint(), "name_hint"); |
1903 | - EXPECT_EQ(entry.parent_window(), 12345); |
1904 | + EXPECT_EQ(entry.parent_window(), 12345u); |
1905 | EXPECT_TRUE(entry.label().empty()); |
1906 | EXPECT_FALSE(entry.label_sensitive()); |
1907 | EXPECT_FALSE(entry.label_visible()); |
1908 | @@ -85,7 +85,7 @@ |
1909 | |
1910 | EXPECT_EQ(entry.id(), "other_id"); |
1911 | EXPECT_EQ(entry.name_hint(), "other_name_hint"); |
1912 | - EXPECT_EQ(entry.parent_window(), 54321); |
1913 | + EXPECT_EQ(entry.parent_window(), 54321u); |
1914 | EXPECT_EQ(entry.label(), "other_label"); |
1915 | EXPECT_FALSE(entry.label_sensitive()); |
1916 | EXPECT_FALSE(entry.label_visible()); |
1917 | |
1918 | === modified file 'tests/test_indicators.cpp' |
1919 | --- tests/test_indicators.cpp 2015-06-05 14:27:09 +0000 |
1920 | +++ tests/test_indicators.cpp 2016-11-30 11:04:07 +0000 |
1921 | @@ -76,7 +76,7 @@ |
1922 | |
1923 | // Sync the indicator, adding 3 entries |
1924 | test_indicator_1->Sync(sync_data); |
1925 | - EXPECT_EQ(test_indicator_1->GetEntries().size(), 3); |
1926 | + EXPECT_EQ(test_indicator_1->GetEntries().size(), 3u); |
1927 | |
1928 | |
1929 | // Adding another indicator filled with entries into the TestMockIndicators |
1930 | @@ -93,9 +93,9 @@ |
1931 | |
1932 | // Sync the indicator, adding 2 entries |
1933 | test_indicator_2->Sync(sync_data); |
1934 | - EXPECT_EQ(test_indicator_2->GetEntries().size(), 2); |
1935 | + EXPECT_EQ(test_indicator_2->GetEntries().size(), 2u); |
1936 | |
1937 | - ASSERT_THAT(indicators.GetIndicators().size(), 2); |
1938 | + ASSERT_THAT(indicators.GetIndicators().size(), 2u); |
1939 | } |
1940 | |
1941 | MockIndicators::Nice indicators; |
1942 | @@ -135,7 +135,7 @@ |
1943 | EXPECT_EQ(indicators.GetIndicator("indicator-test-1"), test_indicator_1); |
1944 | |
1945 | indicators_list = indicators.GetIndicators(); |
1946 | - EXPECT_EQ(indicators_list.size(), 1); |
1947 | + EXPECT_EQ(indicators_list.size(), 1u); |
1948 | EXPECT_NE(std::find(indicators_list.begin(), indicators_list.end(), test_indicator_1), indicators_list.end()); |
1949 | |
1950 | EXPECT_CALL(sig_receiver, OnObjectAdded(_)); |
1951 | @@ -145,7 +145,7 @@ |
1952 | EXPECT_EQ(indicators.GetIndicator("indicator-test-2"), test_indicator_2); |
1953 | |
1954 | indicators_list = indicators.GetIndicators(); |
1955 | - EXPECT_EQ(indicators_list.size(), 2); |
1956 | + EXPECT_EQ(indicators_list.size(), 2u); |
1957 | EXPECT_NE(std::find(indicators_list.begin(), indicators_list.end(), test_indicator_2), indicators_list.end()); |
1958 | |
1959 | EXPECT_CALL(sig_receiver, OnObjectAdded(_)); |
1960 | @@ -155,14 +155,14 @@ |
1961 | EXPECT_EQ(indicators.GetIndicator("indicator-test-3"), test_indicator_3); |
1962 | |
1963 | indicators_list = indicators.GetIndicators(); |
1964 | - EXPECT_EQ(indicators_list.size(), 3); |
1965 | + EXPECT_EQ(indicators_list.size(), 3u); |
1966 | EXPECT_NE(std::find(indicators_list.begin(), indicators_list.end(), test_indicator_3), indicators_list.end()); |
1967 | |
1968 | EXPECT_CALL(sig_receiver, OnObjectAdded(_)).Times(0); |
1969 | EXPECT_CALL(sig_receiver, OnObjectRemoved(_)).Times(0); |
1970 | |
1971 | ASSERT_THAT(indicators.GetIndicator("invalid-indicator-test-4"), IsNull()); |
1972 | - EXPECT_EQ(indicators.GetIndicators().size(), 3); |
1973 | + EXPECT_EQ(indicators.GetIndicators().size(), 3u); |
1974 | |
1975 | // Readding an indicator already there should do nothing |
1976 | EXPECT_CALL(sig_receiver, OnObjectAdded(_)).Times(0); |
1977 | @@ -170,7 +170,7 @@ |
1978 | |
1979 | Indicator::Ptr test_indicator_3_duplicate(indicators.AddIndicator("indicator-test-3")); |
1980 | EXPECT_EQ(indicators.GetIndicator("indicator-test-3"), test_indicator_3); |
1981 | - EXPECT_EQ(indicators.GetIndicators().size(), 3); |
1982 | + EXPECT_EQ(indicators.GetIndicators().size(), 3u); |
1983 | EXPECT_EQ(test_indicator_3, test_indicator_3_duplicate); |
1984 | |
1985 | // Removing the indicators... |
1986 | @@ -181,7 +181,7 @@ |
1987 | ASSERT_THAT(indicators.GetIndicator("indicator-test-2"), IsNull()); |
1988 | |
1989 | indicators_list = indicators.GetIndicators(); |
1990 | - EXPECT_EQ(indicators_list.size(), 2); |
1991 | + EXPECT_EQ(indicators_list.size(), 2u); |
1992 | EXPECT_EQ(std::find(indicators_list.begin(), indicators_list.end(), test_indicator_2), indicators_list.end()); |
1993 | |
1994 | EXPECT_CALL(sig_receiver, OnObjectAdded(_)).Times(0); |
1995 | @@ -191,7 +191,7 @@ |
1996 | ASSERT_THAT(indicators.GetIndicator("indicator-test-1"), IsNull()); |
1997 | |
1998 | indicators_list = indicators.GetIndicators(); |
1999 | - EXPECT_EQ(indicators_list.size(), 1); |
2000 | + EXPECT_EQ(indicators_list.size(), 1u); |
2001 | EXPECT_EQ(std::find(indicators_list.begin(), indicators_list.end(), test_indicator_1), indicators_list.end()); |
2002 | |
2003 | EXPECT_CALL(sig_receiver, OnObjectAdded(_)).Times(0); |
2004 | @@ -353,7 +353,7 @@ |
2005 | ASSERT_TRUE(appmenu_indicator->IsAppmenu()); |
2006 | } |
2007 | |
2008 | - ASSERT_EQ(indicators.GetIndicators().size(), 1); |
2009 | + ASSERT_EQ(indicators.GetIndicators().size(), 1u); |
2010 | |
2011 | { |
2012 | Indicator::Ptr indicator = indicators.GetIndicator("libappmenu.so"); |
2013 | |
2014 | === modified file 'tests/test_introspection_data.cpp' |
2015 | --- tests/test_introspection_data.cpp 2014-01-08 00:01:25 +0000 |
2016 | +++ tests/test_introspection_data.cpp 2016-11-30 11:04:07 +0000 |
2017 | @@ -54,9 +54,9 @@ |
2018 | data.add("Bool", value); |
2019 | GVariant* variant = g_variant_lookup_value(data.Get(), "Bool", nullptr); |
2020 | ASSERT_THAT(variant, NotNull()); |
2021 | - ASSERT_EQ(2, g_variant_n_children(variant)); |
2022 | + ASSERT_EQ(2u, g_variant_n_children(variant)); |
2023 | |
2024 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2025 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2026 | EXPECT_EQ(value, g_variant_get_boolean(get_variant_child(variant, 1))); |
2027 | } |
2028 | |
2029 | @@ -68,9 +68,9 @@ |
2030 | auto tmp = data.Get(); |
2031 | GVariant* variant = g_variant_lookup_value(tmp, "ConstChar", nullptr); |
2032 | ASSERT_THAT(variant, NotNull()); |
2033 | - ASSERT_EQ(2, g_variant_n_children(variant)); |
2034 | + ASSERT_EQ(2u, g_variant_n_children(variant)); |
2035 | |
2036 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2037 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2038 | EXPECT_STREQ(value, g_variant_get_string(get_variant_child(variant, 1), nullptr)); |
2039 | } |
2040 | |
2041 | @@ -81,9 +81,9 @@ |
2042 | data.add("String", value); |
2043 | GVariant* variant = g_variant_lookup_value(data.Get(), "String", nullptr); |
2044 | ASSERT_THAT(variant, NotNull()); |
2045 | - ASSERT_EQ(2, g_variant_n_children(variant)); |
2046 | + ASSERT_EQ(2u, g_variant_n_children(variant)); |
2047 | |
2048 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2049 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2050 | EXPECT_EQ(value, g_variant_get_string(get_variant_child(variant, 1), nullptr)); |
2051 | } |
2052 | |
2053 | @@ -94,9 +94,9 @@ |
2054 | data.add("Int16", value); |
2055 | GVariant* variant = g_variant_lookup_value(data.Get(), "Int16", nullptr); |
2056 | ASSERT_THAT(variant, NotNull()); |
2057 | - ASSERT_EQ(2, g_variant_n_children(variant)); |
2058 | + ASSERT_EQ(2u, g_variant_n_children(variant)); |
2059 | |
2060 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2061 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2062 | EXPECT_EQ(value, g_variant_get_int16(get_variant_child(variant, 1))); |
2063 | } |
2064 | |
2065 | @@ -107,9 +107,9 @@ |
2066 | data.add("Int32", value); |
2067 | GVariant* variant = g_variant_lookup_value(data.Get(), "Int32", nullptr); |
2068 | ASSERT_THAT(variant, NotNull()); |
2069 | - ASSERT_EQ(2, g_variant_n_children(variant)); |
2070 | + ASSERT_EQ(2u, g_variant_n_children(variant)); |
2071 | |
2072 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2073 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2074 | EXPECT_EQ(value, g_variant_get_int32(get_variant_child(variant, 1))); |
2075 | } |
2076 | |
2077 | @@ -120,9 +120,9 @@ |
2078 | data.add("Int64", value); |
2079 | GVariant* variant = g_variant_lookup_value(data.Get(), "Int64", nullptr); |
2080 | ASSERT_THAT(variant, NotNull()); |
2081 | - ASSERT_EQ(2, g_variant_n_children(variant)); |
2082 | + ASSERT_EQ(2u, g_variant_n_children(variant)); |
2083 | |
2084 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2085 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2086 | EXPECT_EQ(value, g_variant_get_int64(get_variant_child(variant, 1))); |
2087 | } |
2088 | |
2089 | @@ -133,9 +133,9 @@ |
2090 | data.add("Uint16", value); |
2091 | GVariant* variant = g_variant_lookup_value(data.Get(), "Uint16", nullptr); |
2092 | ASSERT_THAT(variant, NotNull()); |
2093 | - ASSERT_EQ(2, g_variant_n_children(variant)); |
2094 | + ASSERT_EQ(2u, g_variant_n_children(variant)); |
2095 | |
2096 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2097 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2098 | EXPECT_EQ(value, g_variant_get_uint16(get_variant_child(variant, 1))); |
2099 | } |
2100 | |
2101 | @@ -146,9 +146,9 @@ |
2102 | data.add("Uint32", value); |
2103 | GVariant* variant = g_variant_lookup_value(data.Get(), "Uint32", nullptr); |
2104 | ASSERT_THAT(variant, NotNull()); |
2105 | - ASSERT_EQ(2, g_variant_n_children(variant)); |
2106 | + ASSERT_EQ(2u, g_variant_n_children(variant)); |
2107 | |
2108 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2109 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2110 | EXPECT_EQ(value, g_variant_get_uint32(get_variant_child(variant, 1))); |
2111 | } |
2112 | |
2113 | @@ -159,9 +159,9 @@ |
2114 | data.add("Uint64", value); |
2115 | GVariant* variant = g_variant_lookup_value(data.Get(), "Uint64", nullptr); |
2116 | ASSERT_THAT(variant, NotNull()); |
2117 | - ASSERT_EQ(2, g_variant_n_children(variant)); |
2118 | + ASSERT_EQ(2u, g_variant_n_children(variant)); |
2119 | |
2120 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2121 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2122 | EXPECT_EQ(value, g_variant_get_uint64(get_variant_child(variant, 1))); |
2123 | } |
2124 | |
2125 | @@ -172,9 +172,9 @@ |
2126 | data.add("Float", value); |
2127 | GVariant* variant = g_variant_lookup_value(data.Get(), "Float", nullptr); |
2128 | ASSERT_THAT(variant, NotNull()); |
2129 | - ASSERT_EQ(2, g_variant_n_children(variant)); |
2130 | + ASSERT_EQ(2u, g_variant_n_children(variant)); |
2131 | |
2132 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2133 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2134 | EXPECT_FLOAT_EQ(value, g_variant_get_double(get_variant_child(variant, 1))); |
2135 | } |
2136 | |
2137 | @@ -185,9 +185,9 @@ |
2138 | data.add("Double", value); |
2139 | GVariant* variant = g_variant_lookup_value(data.Get(), "Double", nullptr); |
2140 | ASSERT_THAT(variant, NotNull()); |
2141 | - ASSERT_EQ(2, g_variant_n_children(variant)); |
2142 | + ASSERT_EQ(2u, g_variant_n_children(variant)); |
2143 | |
2144 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2145 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2146 | EXPECT_DOUBLE_EQ(value, g_variant_get_double(get_variant_child(variant, 1))); |
2147 | } |
2148 | |
2149 | @@ -198,9 +198,9 @@ |
2150 | data.add("Variant", value); |
2151 | GVariant* variant = g_variant_lookup_value(data.Get(), "Variant", nullptr); |
2152 | ASSERT_THAT(variant, NotNull()); |
2153 | - ASSERT_EQ(2, g_variant_n_children(variant)); |
2154 | + ASSERT_EQ(2u, g_variant_n_children(variant)); |
2155 | |
2156 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2157 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2158 | EXPECT_TRUE(g_variant_equal(value, get_variant_child(variant, 1))); |
2159 | } |
2160 | |
2161 | @@ -211,9 +211,9 @@ |
2162 | data.add("GLibVariant", value); |
2163 | GVariant* variant = g_variant_lookup_value(data.Get(), "GLibVariant", nullptr); |
2164 | ASSERT_THAT(variant, NotNull()); |
2165 | - ASSERT_EQ(2, g_variant_n_children(variant)); |
2166 | + ASSERT_EQ(2u, g_variant_n_children(variant)); |
2167 | |
2168 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2169 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2170 | EXPECT_TRUE(g_variant_equal(value, get_variant_child(variant, 1))); |
2171 | } |
2172 | |
2173 | @@ -224,9 +224,9 @@ |
2174 | data.add("Rect", value); |
2175 | GVariant* variant = g_variant_lookup_value(data.Get(), "Rect", nullptr); |
2176 | ASSERT_THAT(variant, NotNull()); |
2177 | - ASSERT_EQ(5, g_variant_n_children(variant)); |
2178 | + ASSERT_EQ(5u, g_variant_n_children(variant)); |
2179 | |
2180 | - EXPECT_EQ(1, g_variant_get_uint32(get_variant_child(variant, 0))); |
2181 | + EXPECT_EQ(1u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2182 | EXPECT_EQ(value.x, g_variant_get_int32(get_variant_child(variant, 1))); |
2183 | EXPECT_EQ(value.y, g_variant_get_int32(get_variant_child(variant, 2))); |
2184 | EXPECT_EQ(value.width, g_variant_get_int32(get_variant_child(variant, 3))); |
2185 | @@ -241,9 +241,9 @@ |
2186 | GVariant* data_variant = data.Get(); |
2187 | GVariant* variant = g_variant_lookup_value(data_variant, "globalRect", nullptr); |
2188 | ASSERT_THAT(variant, NotNull()); |
2189 | - ASSERT_EQ(5, g_variant_n_children(variant)); |
2190 | + ASSERT_EQ(5u, g_variant_n_children(variant)); |
2191 | |
2192 | - EXPECT_EQ(1, g_variant_get_uint32(get_variant_child(variant, 0))); |
2193 | + EXPECT_EQ(1u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2194 | EXPECT_EQ(value.x, g_variant_get_int32(get_variant_child(variant, 1))); |
2195 | EXPECT_EQ(value.y, g_variant_get_int32(get_variant_child(variant, 2))); |
2196 | EXPECT_EQ(value.width, g_variant_get_int32(get_variant_child(variant, 3))); |
2197 | @@ -251,22 +251,22 @@ |
2198 | |
2199 | variant = g_variant_lookup_value(data_variant, "x", nullptr); |
2200 | ASSERT_THAT(variant, NotNull()); |
2201 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2202 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2203 | EXPECT_EQ(value.x, g_variant_get_int32(get_variant_child(variant, 1))); |
2204 | |
2205 | variant = g_variant_lookup_value(data_variant, "y", nullptr); |
2206 | ASSERT_THAT(variant, NotNull()); |
2207 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2208 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2209 | EXPECT_EQ(value.y, g_variant_get_int32(get_variant_child(variant, 1))); |
2210 | |
2211 | variant = g_variant_lookup_value(data_variant, "width", nullptr); |
2212 | ASSERT_THAT(variant, NotNull()); |
2213 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2214 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2215 | EXPECT_EQ(value.width, g_variant_get_int32(get_variant_child(variant, 1))); |
2216 | |
2217 | variant = g_variant_lookup_value(data_variant, "height", nullptr); |
2218 | ASSERT_THAT(variant, NotNull()); |
2219 | - EXPECT_EQ(0, g_variant_get_uint32(get_variant_child(variant, 0))); |
2220 | + EXPECT_EQ(0u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2221 | EXPECT_EQ(value.height, g_variant_get_int32(get_variant_child(variant, 1))); |
2222 | } |
2223 | |
2224 | @@ -277,9 +277,9 @@ |
2225 | data.add("Point", value); |
2226 | GVariant* variant = g_variant_lookup_value(data.Get(), "Point", nullptr); |
2227 | ASSERT_THAT(variant, NotNull()); |
2228 | - ASSERT_EQ(3, g_variant_n_children(variant)); |
2229 | + ASSERT_EQ(3u, g_variant_n_children(variant)); |
2230 | |
2231 | - EXPECT_EQ(2, g_variant_get_uint32(get_variant_child(variant, 0))); |
2232 | + EXPECT_EQ(2u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2233 | EXPECT_EQ(value.x, g_variant_get_int32(get_variant_child(variant, 1))); |
2234 | EXPECT_EQ(value.y, g_variant_get_int32(get_variant_child(variant, 2))); |
2235 | } |
2236 | @@ -291,9 +291,9 @@ |
2237 | data.add("Size", value); |
2238 | GVariant* variant = g_variant_lookup_value(data.Get(), "Size", nullptr); |
2239 | ASSERT_THAT(variant, NotNull()); |
2240 | - ASSERT_EQ(3, g_variant_n_children(variant)); |
2241 | + ASSERT_EQ(3u, g_variant_n_children(variant)); |
2242 | |
2243 | - EXPECT_EQ(3, g_variant_get_uint32(get_variant_child(variant, 0))); |
2244 | + EXPECT_EQ(3u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2245 | EXPECT_EQ(value.width, g_variant_get_int32(get_variant_child(variant, 1))); |
2246 | EXPECT_EQ(value.height, g_variant_get_int32(get_variant_child(variant, 2))); |
2247 | } |
2248 | @@ -305,9 +305,9 @@ |
2249 | data.add("Color", value); |
2250 | GVariant* variant = g_variant_lookup_value(data.Get(), "Color", nullptr); |
2251 | ASSERT_THAT(variant, NotNull()); |
2252 | - ASSERT_EQ(5, g_variant_n_children(variant)); |
2253 | + ASSERT_EQ(5u, g_variant_n_children(variant)); |
2254 | |
2255 | - EXPECT_EQ(4, g_variant_get_uint32(get_variant_child(variant, 0))); |
2256 | + EXPECT_EQ(4u, g_variant_get_uint32(get_variant_child(variant, 0))); |
2257 | EXPECT_EQ(static_cast<int32_t>(value.red * 255.), g_variant_get_int32(get_variant_child(variant, 1))); |
2258 | EXPECT_EQ(static_cast<int32_t>(value.green * 255.), g_variant_get_int32(get_variant_child(variant, 2))); |
2259 | EXPECT_EQ(static_cast<int32_t>(value.blue * 255.), g_variant_get_int32(get_variant_child(variant, 3))); |
2260 | |
2261 | === modified file 'tests/test_keyboard_util.cpp' |
2262 | --- tests/test_keyboard_util.cpp 2015-11-02 17:50:38 +0000 |
2263 | +++ tests/test_keyboard_util.cpp 2016-11-30 11:04:07 +0000 |
2264 | @@ -66,6 +66,8 @@ |
2265 | ASSERT_NE(keyboard::get_key_above_key_symbol(x_display, XStringToKeysym("x")), NoSymbol); |
2266 | ASSERT_NE(keyboard::get_key_above_key_symbol(x_display, XStringToKeysym("y")), NoSymbol); |
2267 | ASSERT_NE(keyboard::get_key_above_key_symbol(x_display, XStringToKeysym("z")), NoSymbol); |
2268 | + |
2269 | + XCloseDisplay(x_display); |
2270 | } |
2271 | |
2272 | TEST(TestKeyboardUtil, BelowKeySymbol) |
2273 | @@ -97,6 +99,8 @@ |
2274 | ASSERT_NE(keyboard::get_key_below_key_symbol(x_display, XStringToKeysym("w")), NoSymbol); |
2275 | ASSERT_NE(keyboard::get_key_below_key_symbol(x_display, XStringToKeysym("x")), NoSymbol); |
2276 | ASSERT_NE(keyboard::get_key_below_key_symbol(x_display, XStringToKeysym("y")), NoSymbol); |
2277 | + |
2278 | + XCloseDisplay(x_display); |
2279 | } |
2280 | |
2281 | TEST(TestKeyboardUtil, RightToKeySymbol) |
2282 | @@ -134,6 +138,8 @@ |
2283 | ASSERT_NE(keyboard::get_key_right_to_key_symbol(x_display, XStringToKeysym("x")), NoSymbol); |
2284 | ASSERT_NE(keyboard::get_key_right_to_key_symbol(x_display, XStringToKeysym("y")), NoSymbol); |
2285 | ASSERT_NE(keyboard::get_key_right_to_key_symbol(x_display, XStringToKeysym("z")), NoSymbol); |
2286 | + |
2287 | + XCloseDisplay(x_display); |
2288 | } |
2289 | |
2290 | TEST(TestKeyboardUtil, LeftToKeySymbol) |
2291 | @@ -172,6 +178,8 @@ |
2292 | ASSERT_NE(keyboard::get_key_left_to_key_symbol(x_display, XStringToKeysym("x")), NoSymbol); |
2293 | ASSERT_NE(keyboard::get_key_left_to_key_symbol(x_display, XStringToKeysym("y")), NoSymbol); |
2294 | ASSERT_NE(keyboard::get_key_left_to_key_symbol(x_display, XStringToKeysym("z")), NoSymbol); |
2295 | + |
2296 | + XCloseDisplay(x_display); |
2297 | } |
2298 | |
2299 | TEST(TestKeyboardUtil, PrintableKeySymbols) |
2300 | |
2301 | === modified file 'tests/test_launcher_controller.cpp' |
2302 | --- tests/test_launcher_controller.cpp 2016-08-22 12:08:46 +0000 |
2303 | +++ tests/test_launcher_controller.cpp 2016-11-30 11:04:07 +0000 |
2304 | @@ -271,6 +271,7 @@ |
2305 | for (auto const& icon : icons) |
2306 | model->RemoveIcon(icon); |
2307 | |
2308 | + |
2309 | ASSERT_EQ(model->Size(), 0); |
2310 | } |
2311 | |
2312 | @@ -299,16 +300,16 @@ |
2313 | { |
2314 | EXPECT_NE(lc.options(), nullptr); |
2315 | EXPECT_TRUE(lc.multiple_launchers()); |
2316 | - ASSERT_EQ(lc.launchers().size(), 1); |
2317 | + ASSERT_EQ(lc.launchers().size(), 1u); |
2318 | EXPECT_EQ(lc.launcher().monitor(), 0); |
2319 | ASSERT_EQ(lc.Impl()->parent_, &lc); |
2320 | ASSERT_NE(lc.Impl()->model_, nullptr); |
2321 | EXPECT_EQ(lc.Impl()->expo_icon_->GetIconType(), AbstractLauncherIcon::IconType::EXPO); |
2322 | EXPECT_EQ(lc.Impl()->desktop_icon_->GetIconType(), AbstractLauncherIcon::IconType::DESKTOP); |
2323 | EXPECT_GE(lc.Impl()->sort_priority_, AbstractLauncherIcon::DefaultPriority(AbstractLauncherIcon::IconType::APPLICATION)); |
2324 | - EXPECT_EQ(lc.Impl()->model_->GetSublist<BFBLauncherIcon>().size(), 1); |
2325 | - EXPECT_EQ(lc.Impl()->model_->GetSublist<HudLauncherIcon>().size(), 1); |
2326 | - EXPECT_EQ(lc.Impl()->model_->GetSublist<TrashLauncherIcon>().size(), 1); |
2327 | + EXPECT_EQ(lc.Impl()->model_->GetSublist<BFBLauncherIcon>().size(), 1u); |
2328 | + EXPECT_EQ(lc.Impl()->model_->GetSublist<HudLauncherIcon>().size(), 1u); |
2329 | + EXPECT_EQ(lc.Impl()->model_->GetSublist<TrashLauncherIcon>().size(), 1u); |
2330 | EXPECT_FALSE(lc.Impl()->launcher_open); |
2331 | EXPECT_FALSE(lc.Impl()->launcher_keynav); |
2332 | EXPECT_FALSE(lc.Impl()->launcher_grabbed); |
2333 | @@ -355,7 +356,7 @@ |
2334 | for (unsigned i = 0; i < monitors::MAX; ++i) |
2335 | { |
2336 | uscreen.SetPrimary(i); |
2337 | - ASSERT_EQ(lc.launchers().size(), 1); |
2338 | + ASSERT_EQ(lc.launchers().size(), 1u); |
2339 | EXPECT_EQ(lc.launcher().monitor(), i); |
2340 | } |
2341 | } |
2342 | @@ -366,7 +367,7 @@ |
2343 | lc.multiple_launchers = false; |
2344 | uscreen.SetPrimary(1); |
2345 | |
2346 | - ASSERT_EQ(lc.launchers().size(), 1); |
2347 | + ASSERT_EQ(lc.launchers().size(), 1u); |
2348 | ASSERT_EQ(lc.launcher().monitor(), 0); |
2349 | } |
2350 | |
2351 | @@ -375,7 +376,7 @@ |
2352 | lc.multiple_launchers = false; |
2353 | uscreen.SetupFakeMultiMonitor(); |
2354 | |
2355 | - ASSERT_EQ(lc.launchers().size(), 1); |
2356 | + ASSERT_EQ(lc.launchers().size(), 1u); |
2357 | |
2358 | lc.multiple_launchers = true; |
2359 | EXPECT_EQ(lc.launchers().size(), monitors::MAX); |
2360 | @@ -390,7 +391,7 @@ |
2361 | ASSERT_EQ(lc.launchers().size(), monitors::MAX); |
2362 | |
2363 | lc.multiple_launchers = false; |
2364 | - EXPECT_EQ(lc.launchers().size(), 1); |
2365 | + EXPECT_EQ(lc.launchers().size(), 1u); |
2366 | EXPECT_EQ(lc.launcher().monitor(), primary); |
2367 | } |
2368 | |
2369 | @@ -400,7 +401,7 @@ |
2370 | ASSERT_EQ(lc.launchers().size(), monitors::MAX); |
2371 | |
2372 | uscreen.Reset(); |
2373 | - EXPECT_EQ(lc.launchers().size(), 1); |
2374 | + EXPECT_EQ(lc.launchers().size(), 1u); |
2375 | EXPECT_EQ(lc.launcher().monitor(), 0); |
2376 | } |
2377 | |
2378 | @@ -419,7 +420,7 @@ |
2379 | |
2380 | TEST_F(TestLauncherController, SingleMonitorSwitchToMultimonitor) |
2381 | { |
2382 | - ASSERT_EQ(lc.launchers().size(), 1); |
2383 | + ASSERT_EQ(lc.launchers().size(), 1u); |
2384 | |
2385 | uscreen.SetupFakeMultiMonitor(); |
2386 | |
2387 | |
2388 | === modified file 'tests/test_launcher_model.cpp' |
2389 | --- tests/test_launcher_model.cpp 2012-10-11 01:44:15 +0000 |
2390 | +++ tests/test_launcher_model.cpp 2016-11-30 11:04:07 +0000 |
2391 | @@ -52,28 +52,28 @@ |
2392 | |
2393 | TEST_F(TestLauncherModel, Constructor) |
2394 | { |
2395 | - EXPECT_EQ(model.Size(), 0); |
2396 | + EXPECT_EQ(model.Size(), 0u); |
2397 | } |
2398 | |
2399 | TEST_F(TestLauncherModel, Add) |
2400 | { |
2401 | model.AddIcon(icon1); |
2402 | - EXPECT_EQ(model.Size(), 1); |
2403 | + EXPECT_EQ(model.Size(), 1u); |
2404 | |
2405 | model.AddIcon(icon1); |
2406 | - EXPECT_EQ(model.Size(), 1); |
2407 | + EXPECT_EQ(model.Size(), 1u); |
2408 | |
2409 | model.AddIcon(AbstractLauncherIcon::Ptr()); |
2410 | - EXPECT_EQ(model.Size(), 1); |
2411 | + EXPECT_EQ(model.Size(), 1u); |
2412 | } |
2413 | |
2414 | TEST_F(TestLauncherModel, Remove) |
2415 | { |
2416 | model.AddIcon(icon1); |
2417 | - EXPECT_EQ(model.Size(), 1); |
2418 | + EXPECT_EQ(model.Size(), 1u); |
2419 | |
2420 | model.RemoveIcon(icon1); |
2421 | - EXPECT_EQ(model.Size(), 0); |
2422 | + EXPECT_EQ(model.Size(), 0u); |
2423 | } |
2424 | |
2425 | TEST_F(TestLauncherModel, AddSignal) |
2426 | |
2427 | === modified file 'tests/test_layout_system.cpp' |
2428 | --- tests/test_layout_system.cpp 2015-12-16 11:18:25 +0000 |
2429 | +++ tests/test_layout_system.cpp 2016-11-30 11:04:07 +0000 |
2430 | @@ -55,7 +55,7 @@ |
2431 | LayoutWindow lwin(xid); |
2432 | EXPECT_EQ(lwin.xid, xid); |
2433 | EXPECT_EQ(lwin.geo, fake_window->geo); |
2434 | - EXPECT_EQ(lwin.decoration_height, 0); |
2435 | + EXPECT_EQ(lwin.decoration_height, 0u); |
2436 | EXPECT_EQ(lwin.selected, false); |
2437 | EXPECT_FLOAT_EQ(lwin.scale, 1.0f); |
2438 | EXPECT_EQ(lwin.aspect_ratio, fake_window->geo().width / static_cast<float>(fake_window->geo().height)); |
2439 | @@ -70,7 +70,7 @@ |
2440 | LayoutWindow lwin(xid); |
2441 | EXPECT_EQ(lwin.xid, xid); |
2442 | EXPECT_EQ(lwin.geo, fake_window->geo); |
2443 | - EXPECT_EQ(lwin.decoration_height, 0); |
2444 | + EXPECT_EQ(lwin.decoration_height, 0u); |
2445 | EXPECT_EQ(lwin.selected, false); |
2446 | EXPECT_EQ(lwin.aspect_ratio, fake_window->geo().width / static_cast<float>(fake_window->geo().height)); |
2447 | } |
2448 | @@ -84,7 +84,7 @@ |
2449 | LayoutWindow lwin(xid); |
2450 | EXPECT_EQ(lwin.xid, xid); |
2451 | EXPECT_EQ(lwin.geo, fake_window->geo); |
2452 | - EXPECT_EQ(lwin.decoration_height, 0); |
2453 | + EXPECT_EQ(lwin.decoration_height, 0u); |
2454 | EXPECT_EQ(lwin.selected, false); |
2455 | EXPECT_EQ(lwin.aspect_ratio, fake_window->geo().width / static_cast<float>(fake_window->geo().height)); |
2456 | } |
2457 | @@ -99,7 +99,7 @@ |
2458 | LayoutWindow lwin(xid); |
2459 | EXPECT_EQ(lwin.xid, xid); |
2460 | EXPECT_EQ(lwin.geo, fake_window->geo); |
2461 | - EXPECT_EQ(lwin.decoration_height, 0); |
2462 | + EXPECT_EQ(lwin.decoration_height, 0u); |
2463 | EXPECT_EQ(lwin.selected, false); |
2464 | EXPECT_EQ(lwin.aspect_ratio, fake_window->geo().width / static_cast<float>(fake_window->geo().height)); |
2465 | } |
2466 | @@ -113,7 +113,7 @@ |
2467 | lwin.ComputeDecorationHeight(); |
2468 | EXPECT_EQ(lwin.xid, xid); |
2469 | EXPECT_EQ(lwin.geo, fake_window->geo); |
2470 | - EXPECT_EQ(lwin.decoration_height, 0); |
2471 | + EXPECT_EQ(lwin.decoration_height, 0u); |
2472 | EXPECT_EQ(lwin.selected, false); |
2473 | EXPECT_FLOAT_EQ(lwin.scale, 1.0f); |
2474 | EXPECT_EQ(lwin.aspect_ratio, fake_window->geo().width / static_cast<float>(fake_window->geo().height)); |
2475 | @@ -129,7 +129,7 @@ |
2476 | lwin.ComputeDecorationHeight(); |
2477 | EXPECT_EQ(lwin.xid, xid); |
2478 | EXPECT_EQ(lwin.geo, fake_window->geo); |
2479 | - EXPECT_EQ(lwin.decoration_height, 0); |
2480 | + EXPECT_EQ(lwin.decoration_height, 0u); |
2481 | EXPECT_EQ(lwin.selected, false); |
2482 | EXPECT_EQ(lwin.aspect_ratio, fake_window->geo().width / static_cast<float>(fake_window->geo().height)); |
2483 | } |
2484 | @@ -163,7 +163,7 @@ |
2485 | LayoutWindow lwin(xid); |
2486 | EXPECT_EQ(lwin.xid, xid); |
2487 | EXPECT_EQ(lwin.geo, fake_window->geo); |
2488 | - EXPECT_EQ(lwin.decoration_height, 0); |
2489 | + EXPECT_EQ(lwin.decoration_height, 0u); |
2490 | EXPECT_EQ(lwin.selected, false); |
2491 | EXPECT_EQ(lwin.aspect_ratio, fake_window->geo().width / static_cast<float>(fake_window->geo().height)); |
2492 | } |
2493 | @@ -234,7 +234,7 @@ |
2494 | ls.LayoutWindows(lwindows, max_bounds, final_bounds); |
2495 | |
2496 | std::vector<int> const& row_sizes = ls.GetRowSizes(lwindows, max_bounds); |
2497 | - EXPECT_EQ(row_sizes.size(), 2); |
2498 | + EXPECT_EQ(row_sizes.size(), 2u); |
2499 | EXPECT_EQ(row_sizes[0], 2); |
2500 | EXPECT_EQ(row_sizes[1], 2); |
2501 | } |
2502 | @@ -259,7 +259,7 @@ |
2503 | ls.LayoutWindows(lwindows, max_bounds, final_bounds); |
2504 | |
2505 | std::vector<int> const& row_sizes = ls.GetRowSizes(lwindows, max_bounds); |
2506 | - EXPECT_EQ(row_sizes.size(), 2); |
2507 | + EXPECT_EQ(row_sizes.size(), 2u); |
2508 | EXPECT_EQ(row_sizes[0], 2); |
2509 | EXPECT_EQ(row_sizes[1], 3); |
2510 | } |
2511 | |
2512 | === modified file 'tests/test_lockscreen_controller.cpp' |
2513 | --- tests/test_lockscreen_controller.cpp 2016-11-11 15:55:39 +0000 |
2514 | +++ tests/test_lockscreen_controller.cpp 2016-11-30 11:04:07 +0000 |
2515 | @@ -186,7 +186,7 @@ |
2516 | session_manager->lock_requested.emit(); |
2517 | |
2518 | Utils::WaitUntilMSec([this]{ return controller.shields_.size() == 1; }); |
2519 | - ASSERT_EQ(1, controller.shields_.size()); |
2520 | + ASSERT_EQ(1u, controller.shields_.size()); |
2521 | |
2522 | Utils::WaitUntilMSec([this]{ return uscreen.GetMonitors().at(0) == controller.shields_.at(0)->GetGeometry(); }); |
2523 | EXPECT_EQ(uscreen.GetMonitors().at(0), controller.shields_.at(0)->GetGeometry()); |
2524 | @@ -216,7 +216,7 @@ |
2525 | |
2526 | uscreen.Reset(/* emit_change */ true); |
2527 | |
2528 | - ASSERT_EQ(1, controller.shields_.size()); |
2529 | + ASSERT_EQ(1u, controller.shields_.size()); |
2530 | EXPECT_EQ(uscreen.GetMonitors().at(0), controller.shields_.at(0)->GetGeometry()); |
2531 | } |
2532 | |
2533 | @@ -225,7 +225,7 @@ |
2534 | session_manager->lock_requested.emit(); |
2535 | |
2536 | Utils::WaitUntilMSec([this]{ return controller.shields_.size() == 1; }); |
2537 | - ASSERT_EQ(1, controller.shields_.size()); |
2538 | + ASSERT_EQ(1u, controller.shields_.size()); |
2539 | |
2540 | session_manager->unlock_requested.emit(); |
2541 | tick_source.tick(ANIMATION_DURATION); |
2542 | @@ -253,7 +253,7 @@ |
2543 | // Lock... |
2544 | session_manager->lock_requested.emit(); |
2545 | Utils::WaitUntilMSec([this]{ return controller.shields_.size() == 1; }); |
2546 | - ASSERT_EQ(1, controller.shields_.size()); |
2547 | + ASSERT_EQ(1u, controller.shields_.size()); |
2548 | |
2549 | // ...and let the screen blank. |
2550 | session_manager->presence_status_changed.emit(true); |
2551 | |
2552 | === modified file 'tests/test_panel_controller.cpp' |
2553 | --- tests/test_panel_controller.cpp 2016-09-01 23:56:54 +0000 |
2554 | +++ tests/test_panel_controller.cpp 2016-11-30 11:04:07 +0000 |
2555 | @@ -57,7 +57,7 @@ |
2556 | { |
2557 | Controller pc(menus, edge_barriers); |
2558 | |
2559 | - ASSERT_EQ(pc.panels().size(), 1); |
2560 | + ASSERT_EQ(pc.panels().size(), 1u); |
2561 | EXPECT_EQ(pc.panels()[0]->GetMonitor(), 0); |
2562 | panel_ptr = pc.panels()[0]; |
2563 | } |
2564 | @@ -98,7 +98,7 @@ |
2565 | ASSERT_EQ(pc.panels().size(), monitors::MAX); |
2566 | |
2567 | uscreen.Reset(); |
2568 | - EXPECT_EQ(pc.panels().size(), 1); |
2569 | + EXPECT_EQ(pc.panels().size(), 1u); |
2570 | EXPECT_EQ(pc.panels()[0]->GetMonitor(), 0); |
2571 | } |
2572 | } |
2573 | @@ -127,7 +127,7 @@ |
2574 | { |
2575 | Controller pc(menus, edge_barriers); |
2576 | |
2577 | - ASSERT_EQ(pc.panels().size(), 1); |
2578 | + ASSERT_EQ(pc.panels().size(), 1u); |
2579 | |
2580 | uscreen.SetupFakeMultiMonitor(); |
2581 | EXPECT_EQ(pc.panels().size(), monitors::MAX); |
2582 | |
2583 | === modified file 'tests/test_panel_indicator_entry_dropdown_view.cpp' |
2584 | --- tests/test_panel_indicator_entry_dropdown_view.cpp 2014-03-21 04:40:12 +0000 |
2585 | +++ tests/test_panel_indicator_entry_dropdown_view.cpp 2016-11-30 11:04:07 +0000 |
2586 | @@ -97,12 +97,12 @@ |
2587 | |
2588 | dropdown.Push(first_entry); |
2589 | EXPECT_FALSE(dropdown.Empty()); |
2590 | - EXPECT_EQ(1, dropdown.Size()); |
2591 | + EXPECT_EQ(1u, dropdown.Size()); |
2592 | EXPECT_TRUE(dropdown.IsVisible()); |
2593 | EXPECT_THAT(dropdown.Children(), Contains(first_entry)); |
2594 | EXPECT_EQ(first_entry, dropdown.Top()); |
2595 | |
2596 | - EXPECT_EQ(1, first_entry->GetEntry()->parents().size()); |
2597 | + EXPECT_EQ(1u, first_entry->GetEntry()->parents().size()); |
2598 | EXPECT_THAT(first_entry->GetEntry()->parents(), Contains(dropdown.GetEntry())); |
2599 | |
2600 | auto second_entry = BuildEntry("SecondEntry"); |
2601 | @@ -110,12 +110,12 @@ |
2602 | |
2603 | dropdown.Push(second_entry); |
2604 | EXPECT_FALSE(dropdown.Empty()); |
2605 | - EXPECT_EQ(2, dropdown.Size()); |
2606 | + EXPECT_EQ(2u, dropdown.Size()); |
2607 | EXPECT_TRUE(dropdown.IsVisible()); |
2608 | EXPECT_THAT(dropdown.Children(), Contains(second_entry)); |
2609 | EXPECT_EQ(first_entry, dropdown.Top()); |
2610 | |
2611 | - EXPECT_EQ(1, second_entry->GetEntry()->parents().size()); |
2612 | + EXPECT_EQ(1u, second_entry->GetEntry()->parents().size()); |
2613 | EXPECT_THAT(second_entry->GetEntry()->parents(), Contains(dropdown.GetEntry())); |
2614 | } |
2615 | |
2616 | @@ -127,12 +127,12 @@ |
2617 | |
2618 | dropdown.Insert(first_entry); |
2619 | EXPECT_FALSE(dropdown.Empty()); |
2620 | - EXPECT_EQ(1, dropdown.Size()); |
2621 | + EXPECT_EQ(1u, dropdown.Size()); |
2622 | EXPECT_TRUE(dropdown.IsVisible()); |
2623 | EXPECT_THAT(dropdown.Children(), Contains(first_entry)); |
2624 | EXPECT_EQ(first_entry, dropdown.Top()); |
2625 | |
2626 | - EXPECT_EQ(1, first_entry->GetEntry()->parents().size()); |
2627 | + EXPECT_EQ(1u, first_entry->GetEntry()->parents().size()); |
2628 | EXPECT_THAT(first_entry->GetEntry()->parents(), Contains(dropdown.GetEntry())); |
2629 | |
2630 | auto second_entry = BuildEntry("SecondEntry"); |
2631 | @@ -141,12 +141,12 @@ |
2632 | |
2633 | dropdown.Insert(second_entry); |
2634 | EXPECT_FALSE(dropdown.Empty()); |
2635 | - EXPECT_EQ(2, dropdown.Size()); |
2636 | + EXPECT_EQ(2u, dropdown.Size()); |
2637 | EXPECT_TRUE(dropdown.IsVisible()); |
2638 | EXPECT_THAT(dropdown.Children(), Contains(second_entry)); |
2639 | EXPECT_EQ(second_entry, dropdown.Top()); |
2640 | |
2641 | - EXPECT_EQ(1, second_entry->GetEntry()->parents().size()); |
2642 | + EXPECT_EQ(1u, second_entry->GetEntry()->parents().size()); |
2643 | EXPECT_THAT(second_entry->GetEntry()->parents(), Contains(dropdown.GetEntry())); |
2644 | } |
2645 | |
2646 | @@ -161,7 +161,7 @@ |
2647 | EXPECT_CALL(sig_receiver, Refreshed(&dropdown)).Times(0); |
2648 | dropdown.Remove(second_entry); |
2649 | |
2650 | - EXPECT_EQ(1, dropdown.Size()); |
2651 | + EXPECT_EQ(1u, dropdown.Size()); |
2652 | EXPECT_TRUE(dropdown.IsVisible()); |
2653 | EXPECT_THAT(dropdown.Children(), Not(Contains(second_entry))); |
2654 | EXPECT_THAT(second_entry->GetEntry()->parents(), Not(Contains(dropdown.GetEntry()))); |
2655 | @@ -193,7 +193,7 @@ |
2656 | EXPECT_CALL(sig_receiver, Refreshed(&dropdown)).Times(0); |
2657 | EXPECT_EQ(first_entry, dropdown.Pop()); |
2658 | |
2659 | - EXPECT_EQ(1, dropdown.Size()); |
2660 | + EXPECT_EQ(1u, dropdown.Size()); |
2661 | EXPECT_TRUE(dropdown.IsVisible()); |
2662 | EXPECT_THAT(dropdown.Children(), Not(Contains(first_entry))); |
2663 | EXPECT_THAT(first_entry->GetEntry()->parents(), Not(Contains(dropdown.GetEntry()))); |
2664 | |
2665 | === modified file 'tests/test_pointer_barrier.cpp' |
2666 | --- tests/test_pointer_barrier.cpp 2015-01-14 02:46:10 +0000 |
2667 | +++ tests/test_pointer_barrier.cpp 2016-11-30 11:04:07 +0000 |
2668 | @@ -94,7 +94,7 @@ |
2669 | EXPECT_EQ(bev->x, ev.root_x); |
2670 | EXPECT_EQ(bev->y, ev.root_y); |
2671 | EXPECT_EQ(bev->velocity, 600 * pb->max_velocity_multiplier); |
2672 | - EXPECT_EQ(bev->event_id, ev.eventid); |
2673 | + EXPECT_EQ(bev->event_id, static_cast<int>(ev.eventid)); |
2674 | } |
2675 | }); |
2676 | |
2677 | @@ -120,7 +120,7 @@ |
2678 | EXPECT_EQ(bev->x, ev.root_x); |
2679 | EXPECT_EQ(bev->y, ev.root_y); |
2680 | EXPECT_GT(bev->velocity, 0); |
2681 | - EXPECT_EQ(bev->event_id, ev.eventid); |
2682 | + EXPECT_EQ(bev->event_id, static_cast<int>(ev.eventid)); |
2683 | }); |
2684 | |
2685 | pb->released = true; |
2686 | |
2687 | === modified file 'tests/test_previews.cpp' |
2688 | --- tests/test_previews.cpp 2013-07-18 04:16:50 +0000 |
2689 | +++ tests/test_previews.cpp 2016-11-30 11:04:07 +0000 |
2690 | @@ -106,7 +106,7 @@ |
2691 | auto actions = preview->GetActions(); |
2692 | auto info_hints = preview->GetInfoHints(); |
2693 | |
2694 | - EXPECT_EQ(actions.size(), 2); |
2695 | + EXPECT_EQ(actions.size(), 2u); |
2696 | |
2697 | auto action1 = actions[0]; |
2698 | EXPECT_EQ(action1->id, "action1"); |
2699 | @@ -121,7 +121,7 @@ |
2700 | EXPECT_EQ(action2->icon_hint, ""); |
2701 | EXPECT_EQ(action2->extra_text, "Foo"); |
2702 | |
2703 | - EXPECT_EQ(info_hints.size(), 2); |
2704 | + EXPECT_EQ(info_hints.size(), 2u); |
2705 | auto hint1 = info_hints[0]; |
2706 | EXPECT_EQ(hint1->id, "hint1"); |
2707 | EXPECT_EQ(hint1->display_name, "Hint 1"); |
2708 | |
2709 | === modified file 'tests/test_previews_application.cpp' |
2710 | --- tests/test_previews_application.cpp 2016-02-09 01:58:11 +0000 |
2711 | +++ tests/test_previews_application.cpp 2016-11-30 11:04:07 +0000 |
2712 | @@ -122,7 +122,7 @@ |
2713 | EXPECT_EQ(preview_view->copywrite_->GetText(), "Copywrite & special char"); |
2714 | |
2715 | EXPECT_EQ(preview_view->app_rating_->GetRating(), 0.8f); |
2716 | - EXPECT_EQ(preview_view->action_buttons_.size(), 2); |
2717 | + EXPECT_EQ(preview_view->action_buttons_.size(), 2u); |
2718 | |
2719 | if (preview_view->action_buttons_.size() >= 2) |
2720 | { |
2721 | |
2722 | === modified file 'tests/test_previews_generic.cpp' |
2723 | --- tests/test_previews_generic.cpp 2014-03-21 04:40:12 +0000 |
2724 | +++ tests/test_previews_generic.cpp 2016-11-30 11:04:07 +0000 |
2725 | @@ -105,7 +105,7 @@ |
2726 | EXPECT_EQ(preview_view->subtitle_->GetText(), "Generic Subtitle > special char"); |
2727 | EXPECT_EQ(preview_view->description_->GetText(), "Generic Desctiption < special char"); |
2728 | |
2729 | - EXPECT_EQ(preview_view->action_buttons_.size(), 2); |
2730 | + EXPECT_EQ(preview_view->action_buttons_.size(), 2u); |
2731 | |
2732 | if (preview_view->action_buttons_.size() >= 2) |
2733 | { |
2734 | |
2735 | === modified file 'tests/test_previews_movie.cpp' |
2736 | --- tests/test_previews_movie.cpp 2014-03-21 04:40:12 +0000 |
2737 | +++ tests/test_previews_movie.cpp 2016-11-30 11:04:07 +0000 |
2738 | @@ -116,7 +116,7 @@ |
2739 | EXPECT_EQ(preview_view->description_->GetText(), "Movie Desctiption < special char"); |
2740 | |
2741 | EXPECT_EQ(preview_view->rating_->GetRating(), 0.8f); |
2742 | - EXPECT_EQ(preview_view->action_buttons_.size(), 2); |
2743 | + EXPECT_EQ(preview_view->action_buttons_.size(), 2u); |
2744 | |
2745 | if (preview_view->action_buttons_.size() >= 2) |
2746 | { |
2747 | |
2748 | === modified file 'tests/test_previews_music.cpp' |
2749 | --- tests/test_previews_music.cpp 2014-03-21 04:40:12 +0000 |
2750 | +++ tests/test_previews_music.cpp 2016-11-30 11:04:07 +0000 |
2751 | @@ -107,7 +107,7 @@ |
2752 | EXPECT_EQ(preview_view->title_->GetText(), "Music Title & special char"); |
2753 | EXPECT_EQ(preview_view->subtitle_->GetText(), "Music Subtitle > special char"); |
2754 | |
2755 | - EXPECT_EQ(preview_view->action_buttons_.size(), 4); |
2756 | + EXPECT_EQ(preview_view->action_buttons_.size(), 4u); |
2757 | |
2758 | if (preview_view->action_buttons_.size() >= 2) |
2759 | { |
2760 | |
2761 | === modified file 'tests/test_previews_social.cpp' |
2762 | --- tests/test_previews_social.cpp 2014-03-21 04:40:12 +0000 |
2763 | +++ tests/test_previews_social.cpp 2016-11-30 11:04:07 +0000 |
2764 | @@ -101,7 +101,7 @@ |
2765 | |
2766 | EXPECT_EQ(preview_view->title_->GetText(), "Social Title & special char"); |
2767 | EXPECT_EQ(preview_view->subtitle_->GetText(), "Social Subtitle > special char"); |
2768 | - EXPECT_EQ(preview_view->action_buttons_.size(), 2); |
2769 | + EXPECT_EQ(preview_view->action_buttons_.size(), 2u); |
2770 | } |
2771 | |
2772 | } |
2773 | |
2774 | === modified file 'tests/test_quicklist_view.cpp' |
2775 | --- tests/test_quicklist_view.cpp 2014-03-21 04:40:12 +0000 |
2776 | +++ tests/test_quicklist_view.cpp 2016-11-30 11:04:07 +0000 |
2777 | @@ -110,7 +110,7 @@ |
2778 | |
2779 | AddMenuItems(root); |
2780 | |
2781 | - ASSERT_EQ(quicklist->GetChildren().size(), 4); |
2782 | + ASSERT_EQ(quicklist->GetChildren().size(), 4u); |
2783 | ASSERT_EQ(quicklist->GetNumItems(), 4); |
2784 | EXPECT_EQ(quicklist->GetNthType(0), unity::QuicklistMenuItemType::LABEL); |
2785 | EXPECT_EQ(quicklist->GetNthType(1), unity::QuicklistMenuItemType::SEPARATOR); |
2786 | |
2787 | === modified file 'tests/test_results.cpp' |
2788 | --- tests/test_results.cpp 2013-09-19 00:25:44 +0000 |
2789 | +++ tests/test_results.cpp 2016-11-30 11:04:07 +0000 |
2790 | @@ -41,7 +41,7 @@ |
2791 | Result res(nullptr, nullptr, nullptr); |
2792 | |
2793 | bool added = false; |
2794 | - ASSERT_EQ(model.row_added.size(), 1); |
2795 | + ASSERT_EQ(model.row_added.size(), 1u); |
2796 | model.result_added.connect([&added] (Result const&) { added = true; }); |
2797 | model.row_added.emit(res); |
2798 | EXPECT_TRUE(added); |
2799 | @@ -52,7 +52,7 @@ |
2800 | Result res(nullptr, nullptr, nullptr); |
2801 | |
2802 | bool changed = false; |
2803 | - ASSERT_EQ(model.row_changed.size(), 1); |
2804 | + ASSERT_EQ(model.row_changed.size(), 1u); |
2805 | model.result_changed.connect([&changed] (Result const&) { changed = true; }); |
2806 | model.row_changed.emit(res); |
2807 | EXPECT_TRUE(changed); |
2808 | @@ -63,7 +63,7 @@ |
2809 | Result res(nullptr, nullptr, nullptr); |
2810 | |
2811 | bool removed = false; |
2812 | - ASSERT_EQ(model.row_removed.size(), 1); |
2813 | + ASSERT_EQ(model.row_removed.size(), 1u); |
2814 | model.result_removed.connect([&removed] (Result const&) { removed = true; }); |
2815 | model.row_removed.emit(res); |
2816 | EXPECT_TRUE(removed); |
2817 | @@ -83,15 +83,15 @@ |
2818 | |
2819 | dee_filter_new_for_any_column(2, g_variant_new_uint32(1), &filter); |
2820 | glib::Object<DeeModel> filter_model(dee_filter_model_new(model.model(), &filter)); |
2821 | - |
2822 | + |
2823 | unsigned int i = 0; |
2824 | for (ResultIterator iter(filter_model); !iter.IsLast(); ++iter) |
2825 | { |
2826 | - EXPECT_EQ((*iter).category_index(), 1); |
2827 | + EXPECT_EQ((*iter).category_index(), 1u); |
2828 | i++; |
2829 | } |
2830 | |
2831 | - EXPECT_EQ(i, 50); |
2832 | + EXPECT_EQ(i, 50u); |
2833 | } |
2834 | |
2835 | TEST_F(TestResults, TestRowsValid) |
2836 | @@ -108,7 +108,7 @@ |
2837 | EXPECT_EQ(result.uri(), value); |
2838 | EXPECT_EQ(result.icon_hint(), value); |
2839 | EXPECT_EQ(result.category_index(), (i / 50)); |
2840 | - EXPECT_EQ(result.result_type(), 0); |
2841 | + EXPECT_EQ(result.result_type(), 0u); |
2842 | EXPECT_EQ(result.mimetype(), value); |
2843 | EXPECT_EQ(result.name(), value); |
2844 | EXPECT_EQ(result.comment(), value); |
2845 | @@ -287,8 +287,8 @@ |
2846 | |
2847 | EXPECT_EQ(local_result_2.uri, "uri"); |
2848 | EXPECT_EQ(local_result_2.icon_hint, "icon_hint"); |
2849 | - EXPECT_EQ(local_result_2.category_index, 1); |
2850 | - EXPECT_EQ(local_result_2.result_type, 2); |
2851 | + EXPECT_EQ(local_result_2.category_index, 1u); |
2852 | + EXPECT_EQ(local_result_2.result_type, 2u); |
2853 | EXPECT_EQ(local_result_2.mimetype, "mimetype"); |
2854 | EXPECT_EQ(local_result_2.name, "name"); |
2855 | EXPECT_EQ(local_result_2.comment, "comment"); |
2856 | @@ -315,7 +315,7 @@ |
2857 | TEST_F(TestResults, LocalResult_Variants) |
2858 | { |
2859 | LocalResult local_result; |
2860 | - EXPECT_EQ(local_result.Variants().size(), 9); |
2861 | + EXPECT_EQ(local_result.Variants().size(), 9u); |
2862 | } |
2863 | |
2864 | } |
2865 | |
2866 | === modified file 'tests/test_scope.cpp' |
2867 | --- tests/test_scope.cpp 2013-11-06 11:21:43 +0000 |
2868 | +++ tests/test_scope.cpp 2016-11-30 11:04:07 +0000 |
2869 | @@ -258,9 +258,9 @@ |
2870 | ASSERT_THAT(category_model1, NotNull()); |
2871 | ASSERT_THAT(category_model2, NotNull()); |
2872 | |
2873 | - EXPECT_EQ(category_model0->count(), 5) << "Category 0 result count not as expected (" << category_model0->count() << " != 5)"; |
2874 | - EXPECT_EQ(category_model1->count(), 4) << "Category 1 result count not as expected (" << category_model1->count() << " != 4)"; |
2875 | - EXPECT_EQ(category_model2->count(), 4) << "Category 2 result count not as expected (" << category_model2->count() << " != 4)"; |
2876 | + EXPECT_EQ(category_model0->count(), 5u) << "Category 0 result count not as expected (" << category_model0->count() << " != 5)"; |
2877 | + EXPECT_EQ(category_model1->count(), 4u) << "Category 1 result count not as expected (" << category_model1->count() << " != 4)"; |
2878 | + EXPECT_EQ(category_model2->count(), 4u) << "Category 2 result count not as expected (" << category_model2->count() << " != 4)"; |
2879 | |
2880 | // 2. Update the filter. |
2881 | CheckOptionFilter::Ptr type_filter = std::static_pointer_cast<CheckOptionFilter>(WaitForFilter("categories")); |
2882 | @@ -287,9 +287,9 @@ |
2883 | category_model1 = scope_->GetResultsForCategory(1); |
2884 | category_model2 = scope_->GetResultsForCategory(2); |
2885 | |
2886 | - EXPECT_EQ(category_model0->count(), 0) << "Category 0 result count not as expected (" << category_model0->count() << " != 0)"; |
2887 | - EXPECT_EQ(category_model1->count(), 4) << "Category 1 result count not as expected (" << category_model1->count() << " != 4)"; |
2888 | - EXPECT_EQ(category_model2->count(), 0) << "Category 2 result count not as expected (" << category_model2->count() << " != 0)"; |
2889 | + EXPECT_EQ(category_model0->count(), 0u) << "Category 0 result count not as expected (" << category_model0->count() << " != 0)"; |
2890 | + EXPECT_EQ(category_model1->count(), 4u) << "Category 1 result count not as expected (" << category_model1->count() << " != 4)"; |
2891 | + EXPECT_EQ(category_model2->count(), 0u) << "Category 2 result count not as expected (" << category_model2->count() << " != 0)"; |
2892 | } |
2893 | |
2894 | } // namespace dash |
2895 | |
2896 | === modified file 'tests/test_scope_view.cpp' |
2897 | --- tests/test_scope_view.cpp 2014-03-21 04:40:12 +0000 |
2898 | +++ tests/test_scope_view.cpp 2016-11-30 11:04:07 +0000 |
2899 | @@ -87,14 +87,14 @@ |
2900 | MockCategories::Ptr categories = std::make_shared<MockCategories>(2); |
2901 | scope_->categories.changed.emit(categories); |
2902 | Utils::WaitUntilMSec([this] { return scope_view_->GetOrderedCategoryViews().size() == 2; }); |
2903 | - ASSERT_EQ(scope_view_->GetOrderedCategoryViews().size(), 2); |
2904 | + ASSERT_EQ(scope_view_->GetOrderedCategoryViews().size(), 2u); |
2905 | } |
2906 | |
2907 | TEST_F(TestScopeView, TestFilterExpansion) |
2908 | { |
2909 | MockCategories::Ptr categories = std::make_shared<MockCategories>(4); |
2910 | scope_->categories.changed.emit(categories); |
2911 | - ASSERT_EQ(scope_view_->fake_groups_.size(), 4); |
2912 | + ASSERT_EQ(scope_view_->fake_groups_.size(), 4u); |
2913 | |
2914 | scope_view_->filters_expanded = true; |
2915 | for (unsigned i = 0; i < scope_view_->fake_groups_.size(); ++i) |
2916 | @@ -107,7 +107,7 @@ |
2917 | scope_view_->search_string_ = ""; |
2918 | |
2919 | scope_->categories.changed.emit(categories); |
2920 | - ASSERT_EQ(scope_view_->fake_groups_.size(), 1); |
2921 | + ASSERT_EQ(scope_view_->fake_groups_.size(), 1u); |
2922 | Utils::WaitPendingEvents(); |
2923 | Utils::WaitUntilMSec([this] () { return scope_view_->fake_groups_[0]->GetExpanded(); }); |
2924 | } |
2925 | @@ -118,7 +118,7 @@ |
2926 | scope_view_->search_string_ = "Ubuntu"; |
2927 | |
2928 | scope_->categories.changed.emit(categories); |
2929 | - ASSERT_EQ(scope_view_->fake_groups_.size(), 1); |
2930 | + ASSERT_EQ(scope_view_->fake_groups_.size(), 1u); |
2931 | Utils::WaitPendingEvents(); |
2932 | Utils::WaitUntilMSec([this] () { return scope_view_->fake_groups_[0]->GetExpanded(); }); |
2933 | } |
2934 | @@ -129,7 +129,7 @@ |
2935 | scope_view_->search_string_ = ""; |
2936 | |
2937 | scope_->categories.changed.emit(categories); |
2938 | - ASSERT_EQ(scope_view_->fake_groups_.size(), 2); |
2939 | + ASSERT_EQ(scope_view_->fake_groups_.size(), 2u); |
2940 | Utils::WaitPendingEvents(); |
2941 | Utils::WaitUntilMSec([this] () { return not scope_view_->fake_groups_[0]->GetExpanded(); }); |
2942 | Utils::WaitUntilMSec([this] () { return scope_view_->fake_groups_[1]->GetExpanded(); }); |
2943 | @@ -141,7 +141,7 @@ |
2944 | scope_view_->search_string_ = "Ubuntu"; |
2945 | |
2946 | scope_->categories.changed.emit(categories); |
2947 | - ASSERT_EQ(scope_view_->fake_groups_.size(), 2); |
2948 | + ASSERT_EQ(scope_view_->fake_groups_.size(), 2u); |
2949 | Utils::WaitPendingEvents(); |
2950 | Utils::WaitUntilMSec([this] () { return not scope_view_->fake_groups_[0]->GetExpanded(); }); |
2951 | Utils::WaitUntilMSec([this] () { return scope_view_->fake_groups_[1]->GetExpanded(); }); |
2952 | @@ -153,7 +153,7 @@ |
2953 | scope_view_->search_string_ = ""; |
2954 | |
2955 | scope_->categories.changed.emit(categories); |
2956 | - ASSERT_EQ(scope_view_->fake_groups_.size(), 3); |
2957 | + ASSERT_EQ(scope_view_->fake_groups_.size(), 3u); |
2958 | Utils::WaitPendingEvents(); |
2959 | Utils::WaitUntilMSec([this] () { return not scope_view_->fake_groups_[0]->GetExpanded(); }); |
2960 | Utils::WaitUntilMSec([this] () { return not scope_view_->fake_groups_[1]->GetExpanded(); }); |
2961 | @@ -166,7 +166,7 @@ |
2962 | scope_view_->search_string_ = "Ubuntu"; |
2963 | |
2964 | scope_->categories.changed.emit(categories); |
2965 | - ASSERT_EQ(scope_view_->fake_groups_.size(), 3); |
2966 | + ASSERT_EQ(scope_view_->fake_groups_.size(), 3u); |
2967 | Utils::WaitPendingEvents(); |
2968 | Utils::WaitUntilMSec([this] () { return not scope_view_->fake_groups_[0]->GetExpanded(); }); |
2969 | Utils::WaitUntilMSec([this] () { return not scope_view_->fake_groups_[1]->GetExpanded(); }); |
2970 | @@ -178,7 +178,7 @@ |
2971 | MockCategories::Ptr categories = std::make_shared<MockCategories>(2); |
2972 | |
2973 | scope_->categories.changed.emit(categories); |
2974 | - ASSERT_EQ(scope_view_->fake_groups_.size(), 2); |
2975 | + ASSERT_EQ(scope_view_->fake_groups_.size(), 2u); |
2976 | Utils::WaitPendingEvents(); |
2977 | Utils::WaitUntilMSec([this] () { return not scope_view_->fake_groups_[0]->GetExpanded(); }); |
2978 | Utils::WaitUntilMSec([this] () { return scope_view_->fake_groups_[1]->GetExpanded(); }); |
2979 | @@ -202,7 +202,7 @@ |
2980 | scope_view_->search_string_ = "Ubuntu"; |
2981 | |
2982 | scope_->categories.changed.emit(categories); |
2983 | - ASSERT_EQ(scope_view_->fake_groups_.size(), 2); |
2984 | + ASSERT_EQ(scope_view_->fake_groups_.size(), 2u); |
2985 | Utils::WaitPendingEvents(); |
2986 | Utils::WaitUntilMSec([this] () { return not scope_view_->fake_groups_[0]->GetExpanded(); }); |
2987 | Utils::WaitUntilMSec([this] () { return scope_view_->fake_groups_[1]->GetExpanded(); }); |
2988 | @@ -225,7 +225,7 @@ |
2989 | MockCategories::Ptr categories = std::make_shared<MockCategories>(3); |
2990 | |
2991 | scope_->categories.changed.emit(categories); |
2992 | - ASSERT_EQ(scope_view_->fake_groups_.size(), 3); |
2993 | + ASSERT_EQ(scope_view_->fake_groups_.size(), 3u); |
2994 | Utils::WaitPendingEvents(); |
2995 | Utils::WaitUntilMSec([this] () { return not scope_view_->fake_groups_[0]->GetExpanded(); }); |
2996 | Utils::WaitUntilMSec([this] () { return not scope_view_->fake_groups_[1]->GetExpanded(); }); |
2997 | @@ -257,7 +257,7 @@ |
2998 | scope_view_->search_string_ = "Ubuntu"; |
2999 | |
3000 | scope_->categories.changed.emit(categories); |
3001 | - ASSERT_EQ(scope_view_->fake_groups_.size(), 3); |
3002 | + ASSERT_EQ(scope_view_->fake_groups_.size(), 3u); |
3003 | Utils::WaitPendingEvents(); |
3004 | Utils::WaitUntilMSec([this] () { return not scope_view_->fake_groups_[0]->GetExpanded(); }); |
3005 | Utils::WaitUntilMSec([this] () { return not scope_view_->fake_groups_[1]->GetExpanded(); }); |
3006 | |
3007 | === modified file 'tests/test_session_view.cpp' |
3008 | --- tests/test_session_view.cpp 2014-05-16 03:05:20 +0000 |
3009 | +++ tests/test_session_view.cpp 2016-11-30 11:04:07 +0000 |
3010 | @@ -179,7 +179,7 @@ |
3011 | ON_CALL(*manager, CanShutdown()).WillByDefault(testing::Return(true)); |
3012 | view.mode = View::Mode::SHUTDOWN; |
3013 | |
3014 | - EXPECT_EQ(view.GetButtons().size(), 2); |
3015 | + EXPECT_EQ(view.GetButtons().size(), 2u); |
3016 | EXPECT_EQ(view.GetButtonPosition(Button::Action::REBOOT), 0); |
3017 | EXPECT_EQ(view.GetButtonPosition(Button::Action::SHUTDOWN), 1); |
3018 | EXPECT_EQ(view.key_focus_area(), view.GetButtonByAction(Button::Action::SHUTDOWN)); |
3019 | @@ -190,7 +190,7 @@ |
3020 | ON_CALL(*manager, CanLock()).WillByDefault(testing::Return(true)); |
3021 | view.mode = View::Mode::LOGOUT; |
3022 | |
3023 | - EXPECT_EQ(view.GetButtons().size(), 2); |
3024 | + EXPECT_EQ(view.GetButtons().size(), 2u); |
3025 | EXPECT_EQ(view.GetButtonPosition(Button::Action::LOCK), 0); |
3026 | EXPECT_EQ(view.GetButtonPosition(Button::Action::LOGOUT), 1); |
3027 | EXPECT_EQ(view.key_focus_area(), view.GetButtonByAction(Button::Action::LOGOUT)); |
3028 | @@ -201,7 +201,7 @@ |
3029 | ON_CALL(*manager, CanLock()).WillByDefault(testing::Return(false)); |
3030 | view.mode = View::Mode::LOGOUT; |
3031 | |
3032 | - EXPECT_EQ(view.GetButtons().size(), 1); |
3033 | + EXPECT_EQ(view.GetButtons().size(), 1u); |
3034 | EXPECT_EQ(view.GetButtonPosition(Button::Action::LOGOUT), 0); |
3035 | EXPECT_EQ(view.key_focus_area(), view.GetButtonByAction(Button::Action::LOGOUT)); |
3036 | } |
3037 | @@ -314,4 +314,4 @@ |
3038 | } |
3039 | |
3040 | } // session |
3041 | -} // unity |
3042 | \ No newline at end of file |
3043 | +} // unity |
3044 | |
3045 | === modified file 'tests/test_shortcut_model.cpp' |
3046 | --- tests/test_shortcut_model.cpp 2013-01-19 00:37:45 +0000 |
3047 | +++ tests/test_shortcut_model.cpp 2016-11-30 11:04:07 +0000 |
3048 | @@ -40,10 +40,10 @@ |
3049 | Model model(hints); |
3050 | |
3051 | EXPECT_EQ(model.categories_per_column(), 3); |
3052 | - EXPECT_EQ(model.categories().size(), 3); |
3053 | - EXPECT_EQ(model.hints().at("Launcher").size(), 2); |
3054 | - EXPECT_EQ(model.hints().at("Dash").size(), 1); |
3055 | - EXPECT_EQ(model.hints().at("Menu Bar").size(), 1); |
3056 | + EXPECT_EQ(model.categories().size(), 3u); |
3057 | + EXPECT_EQ(model.hints().at("Launcher").size(), 2u); |
3058 | + EXPECT_EQ(model.hints().at("Dash").size(), 1u); |
3059 | + EXPECT_EQ(model.hints().at("Menu Bar").size(), 1u); |
3060 | EXPECT_EQ(model.hints().find("Unity"), model.hints().end()); |
3061 | } |
3062 | |
3063 | |
3064 | === modified file 'tests/test_shortcut_view.cpp' |
3065 | --- tests/test_shortcut_view.cpp 2014-03-21 04:40:12 +0000 |
3066 | +++ tests/test_shortcut_view.cpp 2016-11-30 11:04:07 +0000 |
3067 | @@ -85,7 +85,7 @@ |
3068 | model->categories_per_column = 1; |
3069 | view.SetModel(model); |
3070 | |
3071 | - EXPECT_EQ(view.columns_layout_->GetChildren().size(), 2); |
3072 | + EXPECT_EQ(view.columns_layout_->GetChildren().size(), 2u); |
3073 | } |
3074 | |
3075 | TEST_F(TestShortcutView, SettingModelRebuildsColumns) |
3076 | @@ -93,12 +93,12 @@ |
3077 | auto model1 = GetMockModel({"Cat1", "Cat2"}, 1); |
3078 | model1->categories_per_column = 1; |
3079 | view.SetModel(model1); |
3080 | - ASSERT_EQ(view.columns_layout_->GetChildren().size(), 2); |
3081 | + ASSERT_EQ(view.columns_layout_->GetChildren().size(), 2u); |
3082 | |
3083 | auto model2 = GetMockModel({"Cat1"}, 1); |
3084 | model2->categories_per_column = 1; |
3085 | view.SetModel(model2); |
3086 | - EXPECT_EQ(view.columns_layout_->GetChildren().size(), 1); |
3087 | + EXPECT_EQ(view.columns_layout_->GetChildren().size(), 1u); |
3088 | } |
3089 | |
3090 | TEST_F(TestShortcutView, ChangingModelParametersRebuildsColumns) |
3091 | |
3092 | === modified file 'tests/test_switcher_controller_slow.cpp' |
3093 | --- tests/test_switcher_controller_slow.cpp 2014-03-03 22:49:48 +0000 |
3094 | +++ tests/test_switcher_controller_slow.cpp 2016-11-30 11:04:07 +0000 |
3095 | @@ -39,7 +39,7 @@ |
3096 | controller_->Show(ShowMode::ALL, SortMode::LAUNCHER_ORDER, icons_); |
3097 | Selection selection = controller_->GetCurrentSelection(); |
3098 | EXPECT_EQ(selection.application_->tooltip_text(), "Second"); |
3099 | - EXPECT_EQ(selection.window_, 0); |
3100 | + EXPECT_EQ(selection.window_, 0u); |
3101 | |
3102 | Utils::WaitForTimeoutMSec(initial_details_timeout * 1.1); |
3103 | selection = controller_->GetCurrentSelection(); |
3104 | @@ -65,22 +65,22 @@ |
3105 | controller_->Show(ShowMode::ALL, SortMode::LAUNCHER_ORDER, icons_); |
3106 | Selection selection = controller_->GetCurrentSelection(); |
3107 | EXPECT_EQ(selection.application_->tooltip_text(), "Second"); |
3108 | - EXPECT_EQ(selection.window_, 0); |
3109 | + EXPECT_EQ(selection.window_, 0u); |
3110 | |
3111 | controller_->Next(); |
3112 | selection = controller_->GetCurrentSelection(); |
3113 | ASSERT_EQ(selection.application_->tooltip_text(), "Third"); |
3114 | - EXPECT_EQ(selection.window_, 0); |
3115 | + EXPECT_EQ(selection.window_, 0u); |
3116 | |
3117 | controller_->Next(); |
3118 | selection = controller_->GetCurrentSelection(); |
3119 | ASSERT_EQ(selection.application_->tooltip_text(), "Show Desktop"); |
3120 | - EXPECT_EQ(selection.window_, 0); |
3121 | + EXPECT_EQ(selection.window_, 0u); |
3122 | |
3123 | controller_->Next(); |
3124 | selection = controller_->GetCurrentSelection(); |
3125 | ASSERT_EQ(selection.application_->tooltip_text(), "First"); |
3126 | - EXPECT_EQ(selection.window_, 0); |
3127 | + EXPECT_EQ(selection.window_, 0u); |
3128 | |
3129 | Utils::WaitForTimeoutMSec(details_timeout * 1.1); |
3130 | selection = controller_->GetCurrentSelection(); |
3131 | |
3132 | === modified file 'tests/test_texture_cache.cpp' |
3133 | --- tests/test_texture_cache.cpp 2014-01-14 17:08:11 +0000 |
3134 | +++ tests/test_texture_cache.cpp 2016-11-30 11:04:07 +0000 |
3135 | @@ -126,11 +126,11 @@ |
3136 | TextureCache& cache = TextureCache::GetDefault(); |
3137 | nux::ObjectPtr<nux::BaseTexture> t1 = cache.FindTexture("foo", 5, 7, callback); |
3138 | cache.Invalidate("foo", 5, 7); |
3139 | - ASSERT_EQ(0, cache.Size()); |
3140 | + ASSERT_EQ(0u, cache.Size()); |
3141 | |
3142 | nux::ObjectPtr<nux::BaseTexture> t2 = cache.FindTexture("foo", 5, 7, callback); |
3143 | EXPECT_NE(t1, t2); |
3144 | - EXPECT_EQ(1, cache.Size()); |
3145 | + EXPECT_EQ(1u, cache.Size()); |
3146 | EXPECT_EQ(2, counter.count); |
3147 | } |
3148 | |
3149 | |
3150 | === modified file 'tests/test_trash_launcher_icon.cpp' |
3151 | --- tests/test_trash_launcher_icon.cpp 2015-11-26 03:12:38 +0000 |
3152 | +++ tests/test_trash_launcher_icon.cpp 2016-11-30 11:04:07 +0000 |
3153 | @@ -65,13 +65,13 @@ |
3154 | TEST_F(TestTrashLauncherIcon, Quicklist) |
3155 | { |
3156 | auto const& menus = icon.Menus(); |
3157 | - EXPECT_EQ(menus.size(), 1); |
3158 | + EXPECT_EQ(menus.size(), 1u); |
3159 | } |
3160 | |
3161 | TEST_F(TestTrashLauncherIcon, QuicklistEmptyTrash) |
3162 | { |
3163 | auto const& menus = icon.Menus(); |
3164 | - ASSERT_EQ(menus.size(), 1); |
3165 | + ASSERT_EQ(menus.size(), 1u); |
3166 | |
3167 | auto const& empty_trash_menu = menus.front(); |
3168 | |
3169 | @@ -145,12 +145,12 @@ |
3170 | ON_CALL(*fm_, WindowsForLocation(TRASH_URI)).WillByDefault(Return(WindowList({win}))); |
3171 | fm_->locations_changed.emit(); |
3172 | |
3173 | - EXPECT_EQ(icon.WindowsVisibleOnMonitor(0), 1); |
3174 | - EXPECT_EQ(icon.WindowsVisibleOnMonitor(1), 0); |
3175 | + EXPECT_EQ(icon.WindowsVisibleOnMonitor(0), 1u); |
3176 | + EXPECT_EQ(icon.WindowsVisibleOnMonitor(1), 0u); |
3177 | |
3178 | win->SetMonitor(1); |
3179 | - EXPECT_EQ(icon.WindowsVisibleOnMonitor(0), 0); |
3180 | - EXPECT_EQ(icon.WindowsVisibleOnMonitor(1), 1); |
3181 | + EXPECT_EQ(icon.WindowsVisibleOnMonitor(0), 0u); |
3182 | + EXPECT_EQ(icon.WindowsVisibleOnMonitor(1), 1u); |
3183 | } |
3184 | |
3185 | TEST_F(TestTrashLauncherIcon, FilemanagerSignalDisconnection) |
3186 | |
3187 | === modified file 'tests/test_ubus.cpp' |
3188 | --- tests/test_ubus.cpp 2013-11-06 11:21:43 +0000 |
3189 | +++ tests/test_ubus.cpp 2016-11-30 11:04:07 +0000 |
3190 | @@ -114,7 +114,7 @@ |
3191 | ProcessMessages(); |
3192 | |
3193 | EXPECT_TRUE(callback_called); |
3194 | - EXPECT_EQ(callback_call_count, 1); |
3195 | + EXPECT_EQ(callback_call_count, 1u); |
3196 | } |
3197 | |
3198 | TEST_F(TestUBusServer, SingleDispatchWithData) |
3199 | @@ -125,7 +125,7 @@ |
3200 | ProcessMessages(); |
3201 | |
3202 | EXPECT_TRUE(callback_called); |
3203 | - EXPECT_EQ(callback_call_count, 1); |
3204 | + EXPECT_EQ(callback_call_count, 1u); |
3205 | EXPECT_EQ(last_msg_variant.GetString(), "UserData"); |
3206 | } |
3207 | |
3208 | @@ -137,7 +137,7 @@ |
3209 | ProcessMessages(); |
3210 | |
3211 | EXPECT_TRUE(callback_called); |
3212 | - EXPECT_EQ(callback_call_count, 1); |
3213 | + EXPECT_EQ(callback_call_count, 1u); |
3214 | } |
3215 | |
3216 | TEST_F(TestUBusServer, SendUnregisteredMessage) |
3217 | @@ -166,7 +166,7 @@ |
3218 | |
3219 | ProcessMessages(); |
3220 | EXPECT_TRUE(callback_called); |
3221 | - EXPECT_EQ(callback_call_count, 3); |
3222 | + EXPECT_EQ(callback_call_count, 3u); |
3223 | } |
3224 | |
3225 | TEST_F(TestUBusServer, MultipleDispatchesWithData) |
3226 | @@ -253,7 +253,7 @@ |
3227 | |
3228 | ProcessMessages(); |
3229 | EXPECT_TRUE(callback_called); |
3230 | - EXPECT_EQ(callback_call_count, 1); |
3231 | + EXPECT_EQ(callback_call_count, 1u); |
3232 | } |
3233 | |
3234 | TEST_F(TestUBusManager, Unregister) |
3235 | @@ -301,7 +301,7 @@ |
3236 | |
3237 | ProcessMessages(); |
3238 | EXPECT_TRUE(callback_called); |
3239 | - EXPECT_EQ(callback_call_count, 1); |
3240 | + EXPECT_EQ(callback_call_count, 1u); |
3241 | } |
3242 | |
3243 | TEST_F(TestUBusManager, DispatchWithPriority) |
3244 | |
3245 | === modified file 'tests/test_unity_window_style.cpp' |
3246 | --- tests/test_unity_window_style.cpp 2013-12-16 16:21:54 +0000 |
3247 | +++ tests/test_unity_window_style.cpp 2016-11-30 11:04:07 +0000 |
3248 | @@ -34,10 +34,10 @@ |
3249 | auto style_copy = UnityWindowStyle::Get(); |
3250 | ASSERT_EQ(style, style_copy); |
3251 | |
3252 | - EXPECT_EQ(style.use_count(), 2); |
3253 | + EXPECT_EQ(style.use_count(), 2u); |
3254 | } |
3255 | |
3256 | - EXPECT_EQ(style.use_count(), 1); |
3257 | + EXPECT_EQ(style.use_count(), 1u); |
3258 | } |
3259 | |
3260 | -} |
3261 | \ No newline at end of file |
3262 | +} |
3263 | |
3264 | === modified file 'tests/test_volume_launcher_icon.cpp' |
3265 | --- tests/test_volume_launcher_icon.cpp 2016-07-21 12:37:19 +0000 |
3266 | +++ tests/test_volume_launcher_icon.cpp 2016-11-30 11:04:07 +0000 |
3267 | @@ -213,12 +213,12 @@ |
3268 | ON_CALL(*file_manager_, WindowsForLocation(volume_->GetUri())).WillByDefault(Return(WindowList({win}))); |
3269 | file_manager_->locations_changed.emit(); |
3270 | |
3271 | - EXPECT_EQ(icon_->WindowsVisibleOnMonitor(0), 1); |
3272 | - EXPECT_EQ(icon_->WindowsVisibleOnMonitor(1), 0); |
3273 | + EXPECT_EQ(icon_->WindowsVisibleOnMonitor(0), 1u); |
3274 | + EXPECT_EQ(icon_->WindowsVisibleOnMonitor(1), 0u); |
3275 | |
3276 | win->SetMonitor(1); |
3277 | - EXPECT_EQ(icon_->WindowsVisibleOnMonitor(0), 0); |
3278 | - EXPECT_EQ(icon_->WindowsVisibleOnMonitor(1), 1); |
3279 | + EXPECT_EQ(icon_->WindowsVisibleOnMonitor(0), 0u); |
3280 | + EXPECT_EQ(icon_->WindowsVisibleOnMonitor(1), 1u); |
3281 | } |
3282 | |
3283 | TEST_F(TestVolumeLauncherIcon, TestPosition) |
+1