Merge lp:~3v1n0/unity/fix-keyboardutil-crash-920258 into lp:unity
Proposed by
Marco Trevisan (Treviño)
Status: | Merged |
---|---|
Approved by: | Tim Penhey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2515 |
Proposed branch: | lp:~3v1n0/unity/fix-keyboardutil-crash-920258 |
Merge into: | lp:unity |
Diff against target: |
68 lines (+12/-7) 2 files modified
unity-shared/KeyboardUtil.cpp (+11/-6) unity-shared/KeyboardUtil.h (+1/-1) |
To merge this branch: | bzr merge lp:~3v1n0/unity/fix-keyboardutil-crash-920258 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Approve | ||
Andrea Azzarone (community) | Approve | ||
jenkins (community) | continuous-integration | Approve | |
Review via email: mp+113658@code.launchpad.net |
Commit message
KeyboardUtil: fix possible crash if XkbGetKeyboard returns null
Also use initializer list
Description of the change
Add safety checks and initializer list to KeyboardUtil
To post a comment you must log in.
typo: FETCH_MAKS
What will happen if it can't get a keyboard?