Merge lp:~3v1n0/unity/alpha-windows-shadows-fix into lp:unity

[Marco Trevisan (Treviño)]

CompizUtils: only shadow-decorate alpha windows that have full decorations as well

Since alpha windows might have custom shapes, it's safer not to shadow-decorate them
unless they don't provide, for sure, a full decoration.

This fixes, between the others, the unity force-quit dialog.

Reproposing the fix, as it got lost in revision 3775, due to a merge error.
It affects the unity force-quit dialogs.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3782
http://jenkins.qa.ubuntu.com/job/unity-ci/868/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/404
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/400
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/402

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/868/rebuild

review: Approve (continuous-integration)

=== modified file 'unity-shared/CompizUtils.cpp'
--- unity-shared/CompizUtils.cpp	2014-04-01 18:38:30 +0000
+++ unity-shared/CompizUtils.cpp	2014-04-14 13:54:13 +0000
@@ -180,8 +180,8 @@
   if (win->region().numRects() != 1) // Non rectangular windows
     return false;
 
-  if (win->overrideRedirect() && win->alpha())
-    return false;
+  if (win->alpha())
+    return WindowHasMotifDecorations(win);
 
   return true;
 }
@@ -194,6 +194,14 @@
   if (!IsWindowShadowDecorable(win))
     return false;
 
+  return WindowHasMotifDecorations(win);
+}
+
+bool WindowHasMotifDecorations(CompWindow* win)
+{
+  if (!win)
+    return false;
+
   if (win->overrideRedirect())
     return false;
 

=== modified file 'unity-shared/CompizUtils.h'
--- unity-shared/CompizUtils.h	2014-04-01 18:38:30 +0000
+++ unity-shared/CompizUtils.h	2014-04-14 13:54:13 +0000
@@ -113,6 +113,7 @@
 
 bool IsWindowShadowDecorable(CompWindow*);
 bool IsWindowFullyDecorable(CompWindow*);
+bool WindowHasMotifDecorations(CompWindow*);
 
 } // compiz_utils namespace
 } // unity namespace