Merge lp:~3v1n0/unity/add-launcher-icon-to-dash into lp:unity

[Marco Trevisan (Treviño)]

ApplicationLauncherIcon: if an app is not running and has no desktop file, add QL item to add to dash

This allows to generate a desktop file without sticking the icon

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:4028
http://jenkins.qa.ubuntu.com/job/unity-ci/1323/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-wily-amd64-ci/101
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-wily-armhf-ci/99
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-wily-i386-ci/99/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/1323/rebuild

review: Needs Fixing (continuous-integration)

[Andrea Azzarone (azzar1)]

LGTM.

review: Approve

=== modified file 'launcher/ApplicationLauncherIcon.cpp'
--- launcher/ApplicationLauncherIcon.cpp	2015-09-21 17:02:08 +0000
+++ launcher/ApplicationLauncherIcon.cpp	2015-10-28 09:28:38 +0000
@@ -1092,6 +1092,22 @@
 
   if (IsRunning())
   {
+    if (DesktopFile().empty() && !IsSticky())
+    {
+      /* Add to Dash */
+      glib::Object<DbusmenuMenuitem> menu_item(dbusmenu_menuitem_new());
+      dbusmenu_menuitem_property_set(menu_item, DBUSMENU_MENUITEM_PROP_LABEL, _("Add to Dash"));
+      dbusmenu_menuitem_property_set_bool(menu_item, DBUSMENU_MENUITEM_PROP_ENABLED, true);
+      dbusmenu_menuitem_property_set_bool(menu_item, DBUSMENU_MENUITEM_PROP_VISIBLE, true);
+
+      _gsignals.Add<void, DbusmenuMenuitem*, unsigned>(menu_item, DBUSMENU_MENUITEM_SIGNAL_ITEM_ACTIVATED,
+        [this] (DbusmenuMenuitem*, unsigned) {
+          app_->CreateLocalDesktopFile();
+      });
+
+      result.push_back(menu_item);
+    }
+
     if (!quit_item)
       quit_item = _menu_items[MenuItemType::QUIT];