Merge lp:~3v1n0/unity-lens-video/use-gee-0.8 into lp:unity-lens-video

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 123
Proposed branch: lp:~3v1n0/unity-lens-video/use-gee-0.8
Merge into: lp:unity-lens-video
Diff against target: 85 lines (+6/-11)
5 files modified
configure.ac (+1/-1)
debian/control (+1/-1)
src/Makefile.am (+2/-2)
src/scope.vala (+1/-6)
tests/unit/Makefile.am (+1/-1)
To merge this branch: bzr merge lp:~3v1n0/unity-lens-video/use-gee-0.8
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+285922@code.launchpad.net

Commit message

Build using libgee-0.8-dev instead of libgee-dev

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Rubberstamp! Proposer approves of own proposal.

review: Approve
123. By Matthias Klose

Build using libgee-0.8-dev instead of libgee-dev

124. By Marco Trevisan (Treviño)

scope: fix sort function using proper CompareDataFunc (through lambda)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2013-05-16 11:33:59 +0000
3+++ configure.ac 2016-02-12 19:38:06 +0000
4@@ -72,7 +72,7 @@
5 gio-2.0 >= $GLIB_REQUIRED
6 gio-unix-2.0 >= $GLIB_REQUIRED
7 dee-1.0 >= 1.0.7
8- gee-1.0
9+ gee-0.8
10 libsoup-gnome-2.4
11 json-glib-1.0
12 zeitgeist-1.0 >= 0.3.8
13
14=== modified file 'debian/control'
15--- debian/control 2013-09-17 09:11:03 +0000
16+++ debian/control 2016-02-12 19:38:06 +0000
17@@ -7,7 +7,7 @@
18 dh-translations,
19 gnome-common,
20 libdee-dev (>= 1.0.7),
21- libgee-dev,
22+ libgee-0.8-dev,
23 libglib2.0-dev (>= 2.27),
24 libjson-glib-dev,
25 libsoup-gnome2.4-dev,
26
27=== modified file 'src/Makefile.am'
28--- src/Makefile.am 2013-09-17 11:11:02 +0000
29+++ src/Makefile.am 2016-02-12 19:38:06 +0000
30@@ -42,7 +42,7 @@
31 --pkg gio-2.0 \
32 --pkg gio-unix-2.0 \
33 --pkg glib-2.0 \
34- --pkg gee-1.0 \
35+ --pkg gee-0.8 \
36 --pkg zeitgeist-1.0 \
37 --vapidir $(srcdir) \
38 --vapidir $(top_srcdir)/vapi \
39@@ -58,7 +58,7 @@
40 --pkg gio-2.0 \
41 --pkg gio-unix-2.0 \
42 --pkg glib-2.0 \
43- --pkg gee-1.0 \
44+ --pkg gee-0.8 \
45 --pkg zeitgeist-1.0 \
46 --pkg libsoup-gnome-2.4 \
47 --pkg libsoup-2.4 \
48
49=== modified file 'src/scope.vala'
50--- src/scope.vala 2013-06-20 16:13:59 +0000
51+++ src/scope.vala 2016-02-12 19:38:06 +0000
52@@ -153,7 +153,7 @@
53 {
54 GLib.Idle.add (() =>
55 {
56- result_list.sort ((GLib.CompareFunc?)sort_alpha);
57+ result_list.sort ((a, b) => { return a.lc_title.collate (b.lc_title); });
58 add_results (search, model, cat, cancellable, result_list, search_string, clear_model);
59 return false;
60 });
61@@ -181,11 +181,6 @@
62 }
63 }
64
65- internal static int sort_alpha (VideoFile a, VideoFile b)
66- {
67- return a.lc_title.collate (b.lc_title);
68- }
69-
70 private async void zg_call (GLib.Cancellable? cancellable, DeprecatedScopeSearch search_status) throws Error
71 {
72 bool active = sources.get_option ("local").active;
73
74=== modified file 'tests/unit/Makefile.am'
75--- tests/unit/Makefile.am 2013-09-17 11:11:02 +0000
76+++ tests/unit/Makefile.am 2016-02-12 19:38:06 +0000
77@@ -16,7 +16,7 @@
78 --pkg gio-unix-2.0 \
79 --pkg json-glib-1.0 \
80 --pkg glib-2.0 \
81- --pkg gee-1.0 \
82+ --pkg gee-0.8 \
83 --pkg zeitgeist-1.0 \
84 --pkg libsoup-gnome-2.4 \
85 --pkg libsoup-2.4 \

Subscribers

People subscribed via source and target branches