Merge lp:~3v1n0/ubuntu/precise/gnome-control-center/add-window-role-to-panels into lp:~ubuntu-desktop/gnome-control-center/ubuntu

Proposed by Marco Trevisan (Treviño)
Status: Merged
Merged at revision: 324
Proposed branch: lp:~3v1n0/ubuntu/precise/gnome-control-center/add-window-role-to-panels
Merge into: lp:~ubuntu-desktop/gnome-control-center/ubuntu
Diff against target: 57 lines (+28/-2)
3 files modified
debian/changelog (+7/-1)
debian/patches/93_change_window_role_on_panel_change.patch (+20/-0)
debian/patches/series (+1/-1)
To merge this branch: bzr merge lp:~3v1n0/ubuntu/precise/gnome-control-center/add-window-role-to-panels
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+89514@code.launchpad.net

Description of the change

Update the g-c-c window role when its content changes, this is needed by the BAMF branch lp:~3v1n0/bamf/g-control-center-rematching to fix the bug #801784 and rematch the g-c-c window when needed.

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! Can you please also forward this upstream? Please point to the upstream bug in the LP bug.

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

That was the plan, but I forgot to submit it. So thanks for reminding me :)

Upstream bug is at https://bugzilla.gnome.org/show_bug.cgi?id=668504

Revision history for this message
Martin Pitt (pitti) wrote :

And committed already, nice!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-01-16 10:58:25 +0000
3+++ debian/changelog 2012-01-21 00:35:27 +0000
4@@ -1,11 +1,17 @@
5 gnome-control-center (1:3.2.2-2ubuntu2) UNRELEASED; urgency=low
6
7+ [ Sebastien Bacher ]
8 * debian/libgnome-control-center1.symbols: restore the symbols tracking,
9 since we build external capplets we better check they don't break
10 * debian/rules: don't build shlibs for a library which stopped being
11 distributed in GNOME3
12
13- -- Sebastien Bacher <seb128@ubuntu.com> Mon, 16 Jan 2012 11:52:09 +0100
14+ [ Marco Trevisan (Treviño) ]
15+ * debian/patches/93_change_window_role_on_panel_change.patch:
16+ - Set the gtk WM window role when changing panel, this is needed
17+ to get the real window id and match the gcc in unity (LP: #801784)
18+
19+ -- Marco Trevisan (Treviño) <3v1n0@ubuntu.com> Sat, 21 Jan 2012 01:02:11 +0100
20
21 gnome-control-center (1:3.2.2-2ubuntu1) precise; urgency=low
22
23
24=== added file 'debian/patches/93_change_window_role_on_panel_change.patch'
25--- debian/patches/93_change_window_role_on_panel_change.patch 1970-01-01 00:00:00 +0000
26+++ debian/patches/93_change_window_role_on_panel_change.patch 2012-01-21 00:35:27 +0000
27@@ -0,0 +1,20 @@
28+Index: gnome-control-center/shell/gnome-control-center.c
29+===================================================================
30+--- gnome-control-center.orig/shell/gnome-control-center.c 2012-01-21 00:46:54.529573272 +0100
31++++ gnome-control-center/shell/gnome-control-center.c 2012-01-21 00:46:59.321513028 +0100
32+@@ -174,6 +174,7 @@
33+
34+ /* set the title of the window */
35+ icon_name = get_icon_name_from_g_icon (gicon);
36++ gtk_window_set_role (GTK_WINDOW (priv->window), id);
37+ gtk_window_set_title (GTK_WINDOW (priv->window), name);
38+ gtk_window_set_default_icon_name (icon_name);
39+ gtk_window_set_icon_name (GTK_WINDOW (priv->window), icon_name);
40+@@ -232,6 +233,7 @@
41+ gtk_lock_button_set_permission (GTK_LOCK_BUTTON (priv->lock_button), NULL);
42+
43+ /* reset window title and icon */
44++ gtk_window_set_role (GTK_WINDOW (priv->window), NULL);
45+ gtk_window_set_title (GTK_WINDOW (priv->window), priv->default_window_title);
46+ gtk_window_set_default_icon_name (priv->default_window_icon);
47+ gtk_window_set_icon_name (GTK_WINDOW (priv->window),
48
49=== modified file 'debian/patches/series'
50--- debian/patches/series 2012-01-14 21:22:09 +0000
51+++ debian/patches/series 2012-01-21 00:35:27 +0000
52@@ -23,4 +23,4 @@
53 90_git_sound_tab_order.patch
54 91_git_build_use_fontconfig.patch
55 92_git_minimal_output_height.patch
56-
57+93_change_window_role_on_panel_change.patch

Subscribers

People subscribed via source and target branches