Merge lp:~3v1n0/ubuntu/oneiric/nautilus/unity-progress-fix-overflow into lp:~ubuntu-desktop/nautilus/ubuntu

Proposed by Marco Trevisan (Treviño)
Status: Merged
Merged at revision: 187
Proposed branch: lp:~3v1n0/ubuntu/oneiric/nautilus/unity-progress-fix-overflow
Merge into: lp:~ubuntu-desktop/nautilus/ubuntu
Diff against target: 37 lines (+10/-2)
2 files modified
debian/changelog (+8/-0)
debian/patches/12_unity_launcher_support.patch (+2/-2)
To merge this branch: bzr merge lp:~3v1n0/ubuntu/oneiric/nautilus/unity-progress-fix-overflow
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Pending
Review via email: mp+77435@code.launchpad.net

Description of the change

Fixed the bug #845188 that in 32bit systems (mostly) lead to get a bad progress computation for the unity launcher progressbar due to an overflow.

Unfortunately this was a really stupid typo that I left in the patch, but that has a really bad effect.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-09-27 06:24:09 +0000
3+++ debian/changelog 2011-09-29 03:26:23 +0000
4@@ -1,3 +1,11 @@
5+nautilus (1:3.2.0-0ubuntu3) UNRELEASED; urgency=low
6+
7+ * debian/patches/12_unity_launcher_support.patch:
8+ - Fixed a typo that lead to bad computation of progress for
9+ files with size >= 2GB due to a type overflow (LP: #845188)
10+
11+ -- Marco Trevisan (Treviño) <3v1n0@ubuntu.com> Thu, 29 Sep 2011 05:09:47 +0200
12+
13 nautilus (1:3.2.0-0ubuntu2) oneiric; urgency=low
14
15 * debian/control.in: Bump libglib2.0-dev build dependency to ensure that we
16
17=== modified file 'debian/patches/12_unity_launcher_support.patch'
18--- debian/patches/12_unity_launcher_support.patch 2011-09-19 20:03:37 +0000
19+++ debian/patches/12_unity_launcher_support.patch 2011-09-29 03:26:23 +0000
20@@ -78,7 +78,7 @@
21 +double
22 +nautilus_progress_info_get_current (NautilusProgressInfo *info)
23 +{
24-+ int current;
25++ double current;
26 +
27 + G_LOCK (progress_info);
28 +
29@@ -96,7 +96,7 @@
30 +double
31 +nautilus_progress_info_get_total (NautilusProgressInfo *info)
32 +{
33-+ int total;
34++ double total;
35 +
36 + G_LOCK (progress_info);
37 +

Subscribers

People subscribed via source and target branches

to all changes: