Code review comment for ~3v1n0/ubuntu/+source/mutter:ubuntu/xrandr-scaling

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Looks OK, but of course it's too hard to be sure. I don't really know this area of code.

Notes:

(1) The fix for bug 1822616 looks good now.

(2) Upstream will (eventually) ask you to reformat function parameters to be one parameter per line. Remember to do that (some time).

(3) Another formatting nit: Indentation in apply_crtc_assignments

review: Approve

« Back to merge proposal