Merge ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-theming-fixes into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic

Proposed by Marco Trevisan (Treviño) on 2018-10-02
Status: Merged
Merged at revision: 42c4c95026391cfc7eca905378d7fa1de3f9da86
Proposed branch: ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-theming-fixes
Merge into: ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic
Diff against target: 42 lines (+10/-2)
2 files modified
debian/changelog (+4/-1)
debian/ubuntu-session-mods/ubuntu.css (+6/-1)
Reviewer Review Type Date Requested Status
Didier Roche 2018-10-02 Approve on 2018-10-30
Review via email: mp+356023@code.launchpad.net
To post a comment you must log in.
Didier Roche (didrocks) wrote :

Please ensure the bugs are SRU-able. LGTM otherwise.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 610ea63..0ce4a7d 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -6,8 +6,11 @@ gnome-shell (3.28.3-0ubuntu0.18.04.3) UNRELEASED; urgency=medium
6 d/p/ubuntu/search-call-XUbuntuCancel-method-on-providers-when-no-dat.patch:
7 - Add support for cancelling remote search providers when the overlay
8 is closed (and actually stop searches when requested from UI, LP: #1756826)
9+ * debian/ubuntu.css:
10+ - use defined color for menu separators (LP: #1739931)
11+ - set StEntry minimun height to work properly with Ubuntu font (LP: #1743058)
12
13- -- Marco Trevisan (Treviño) <marco@ubuntu.com> Wed, 05 Sep 2018 14:31:58 +0200
14+ -- Marco Trevisan (Treviño) <marco@ubuntu.com> Wed, 03 Oct 2018 00:50:42 +0200
15
16 gnome-shell (3.28.3-0ubuntu0.18.04.2) bionic; urgency=medium
17
18diff --git a/debian/ubuntu-session-mods/ubuntu.css b/debian/ubuntu-session-mods/ubuntu.css
19index da34f04..4bb58e4 100644
20--- a/debian/ubuntu-session-mods/ubuntu.css
21+++ b/debian/ubuntu-session-mods/ubuntu.css
22@@ -519,7 +519,7 @@ StScrollBar {
23 height: 1px;
24 margin: 6px 64px;
25 background-color: transparent;
26- border-color: #3a3a34;
27+ border-color: #2c2c28;
28 border-bottom-width: 1px;
29 border-bottom-style: solid; }
30
31@@ -1911,6 +1911,11 @@ stage {
32 font-family: Ubuntu, Cantarell, Sans-Serif;
33 }
34
35+/* Set minimum height as per Ubuntu font usage, fixes password entries (LP: #1743058) */
36+StEntry {
37+ min-height: 19px;
38+}
39+
40 /* switch colors */
41 .toggle-switch-us:checked {
42 background-image: url("ubuntu-toggle-on-us.svg");

Subscribers

People subscribed via source and target branches