Merge ~3v1n0/ubuntu/+source/gnome-session:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/gnome-session:ubuntu/master

Proposed by Marco Trevisan (Treviño)
Status: Rejected
Rejected by: Didier Roche-Tolomelli
Proposed branch: ~3v1n0/ubuntu/+source/gnome-session:ubuntu/master
Merge into: ~ubuntu-desktop/ubuntu/+source/gnome-session:ubuntu/master
Diff against target: 29 lines (+9/-1)
2 files modified
debian/changelog (+8/-0)
debian/ubuntu-settings-migrate-to-defaults.18.10.0.py (+1/-1)
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Disapprove
Review via email: mp+354394@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Let's just use getenv which is better for this IMHO. I'm adding also a missing import sys.

review: Disapprove

Unmerged commits

c24429f... by Marco Trevisan (Treviño)

migration: Skip if DESKTOP_SESSION is not exported

Fixes LP: #1790532

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 88be35d..b072519 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+gnome-session (3.30.0-0ubuntu2) UNRELEASED; urgency=medium
7+
8+ * debian/ubuntu-settings-migrate-to-defaults.18.10.0.py:
9+ - Skip the settings migrations even if DESKTOP_SESSION is not
10+ exported (LP: #1790532)
11+
12+ -- Marco Trevisan (Treviño) <marco@ubuntu.com> Thu, 06 Sep 2018 15:11:53 +0200
13+
14 gnome-session (3.30.0-0ubuntu1) cosmic; urgency=medium
15
16 * New upstream release:
17diff --git a/debian/ubuntu-settings-migrate-to-defaults.18.10.0.py b/debian/ubuntu-settings-migrate-to-defaults.18.10.0.py
18index 3fdf000..4220c83 100755
19--- a/debian/ubuntu-settings-migrate-to-defaults.18.10.0.py
20+++ b/debian/ubuntu-settings-migrate-to-defaults.18.10.0.py
21@@ -32,7 +32,7 @@ OLD_DEFAULTS = {
22 }
23 }
24
25-if os.environ['DESKTOP_SESSION'] != 'ubuntu':
26+if 'DESKTOP_SESSION' not in os.environ or os.environ['DESKTOP_SESSION'] != 'ubuntu':
27 sys.exit(0)
28
29 any_changed = False

Subscribers

People subscribed via source and target branches