Ubuntu
gnome-calculator package

Code review comment for ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/master-xubuntu-cancel-search

  1. Git
  2. lp:~3v1n0/ubuntu/+source/gnome-calculator
  3. ubuntu/master-xubuntu-cancel-search
  4. Merge into ubuntu/master
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

So I have some requested changes and questions, but the code itself seems mostly OK. Note that I'm not a vala expert and would appreciate, even if the upstream patches are going to land in 3.32 (as per upstream MR comment) that you request still a quick review in your last set of patch. Do you think this is doable?

See my comments about cosmic/changelog version.

and oh, you are making me reviewing some vala code, this is mean of you ;)

review: Needs Fixing

« Back to merge proposal