Merge lp:~3v1n0/ubuntu-themes/popover-tip-fix into lp:ubuntu-themes

[Marco Trevisan (Treviño)]

Ambiance, Radiance: Remove the gap between the popover and tip, add border

Margin value is now matching Adwaita.

[lp:~3v1n0/ubuntu-themes/popover-tip-fix]

610. By Marco Trevisan (Treviño) on 2018-03-22

Ambiance, Radiance: add slight border around popovers

[Daniel van Vugt (vanvugt)]

Sounds good.

Screenshot from 3v1n0: https://usercontent.irccloud-cdn.com/file/QZ2WV3hG/image.png

[Daniel van Vugt (vanvugt)]

Per above.

review: Approve

[Daniel van Vugt (vanvugt)]

Although ideally if we start to use something that's the same as Adwaita then we should be able to just delete it from Ambiance/Radiance, and we'll get the Adwaita definition.

I'm not sure that would work here, but it's a suggestion to keep in mind in future.

[Marco Trevisan (Treviño) (3v1n0)]

> I'm not sure that would work here, but it's a suggestion to keep in mind in
> future.

Yes, sure, but in this case the value was defined somewhere else inside our theme.

=== modified file 'Ambiance/gtk-3.20/gtk-widgets.css'
--- Ambiance/gtk-3.20/gtk-widgets.css	2018-03-22 08:26:49 +0000
+++ Ambiance/gtk-3.20/gtk-widgets.css	2018-03-22 16:38:44 +0000
@@ -2560,7 +2560,7 @@
 /* FIXME: we can't reuse the default shadow definition as increasing marging
  *        would break the tip
  */
-    margin: 13px;
+    margin: 4px;
     box-shadow: 1px 3px 6px @inactive_shadow_color;
 }
 
@@ -3426,7 +3426,8 @@
                                       shade (@bg_color, 0.93),
                                       shade (@bg_color, 0.98));
     border-radius: 5px;
-    border: none;
+    border: 1px solid shade (@bg_color, 0.85);
+    border-image: none;
     padding: 2px;
 }
 
@@ -3434,7 +3435,7 @@
     background-image: none;
     background-color: shade (@bg_color, 0.95);
     border-radius: 5px;
-    border: none;
+    border-color: shade (@bg_color, 0.88);
     padding: 2px;
 }
 

=== modified file 'Radiance/gtk-3.20/gtk-widgets.css'
--- Radiance/gtk-3.20/gtk-widgets.css	2018-03-22 08:26:49 +0000
+++ Radiance/gtk-3.20/gtk-widgets.css	2018-03-22 16:38:44 +0000
@@ -2556,7 +2556,7 @@
 /* FIXME: we can't reuse the default shadow definition as increasing marging
  *        would break the tip
  */
-    margin: 13px;
+    margin: 4px;
     box-shadow: 1px 3px 6px @inactive_shadow_color;
 }
 
@@ -3423,7 +3423,8 @@
                                       shade (@bg_color, 0.93),
                                       shade (@bg_color, 0.98));
     border-radius: 5px;
-    border: none;
+    border: 1px solid shade (@bg_color, 0.85);
+    border-image: none;
     padding: 2px;
 }
 
@@ -3431,7 +3432,7 @@
     background-image: none;
     background-color: shade (@bg_color, 0.95);
     border-radius: 5px;
-    border: none;
+    border-color: shade (@bg_color, 0.88);
     padding: 2px;
 }