Merge lp:~3v1n0/ubuntu-themes/panel-rules-ignore-unity into lp:ubuntu-themes

[Marco Trevisan (Treviño)]

gnome-panel: don't apply the gnome-menubar rules to unity decorations and panel too

[Iain Lane (laney)]

It looks good to me, thanks. I want Dmitry or Alberts to sign off too though, please. :)

(Seems unity was using gnome-panel's CSS classes, who knew?)

https://requests.ci-train.ubuntu.com/#/ticket/1876 (ppa:ci-train-ppa-service/landing-099) to test

review: Approve

[Alberts Muktupāvels (muktupavels)]

Why Unity use gnome-panel* css classes? I think that proper fix is to not use same css classes in Unity. Otherwise similar things/bugs might happen in future, no?

review: Needs Information

[Marco Trevisan (Treviño) (3v1n0)]

The reason behind that, is that we want some gnome themes which have been done without unity in mind to still work in unity.

This for example allows to use Adwita without having to define unity classes there.

So there won't be such problems in non-unity themes, but indeed there will be in the ubuntu-ones.

[Alberts Muktupāvels (muktupavels)]

Adwaita does not have gnome-panel related css... Is there any other example?

Does unity panel really adds these classes to menubar:
.gnome-panel-menu-bar
.unity-panel
.unity-decoration

I would expect that it might look like this:
.unity-panel .gnome-panel-menu-bar { .. }

.unity-panel class added to panel and .gnome-panel-menu-bar to menubar.

[Dmitry Shachnev (mitya57)]

How about prefixing the rules with panel-toplevel instead of using not()?

[Marco Trevisan (Treviño) (3v1n0)]

Alberts, I don't know other themes that needed that.. Maybe the high-visibility ones, however in the past we had situations where with "standard gnome" themes the panel wasn't usable, while having this ensures tings would at least work. Not well, but in a better usable way.

> How about prefixing the rules with panel-toplevel instead of using not()?

That was my first idea too

Let me know what you prefer

[Dmitry Shachnev (mitya57)]

>> How about prefixing the rules with panel-toplevel instead of using not()?
>
> That was my first idea too
>
> Let me know what you prefer

I would prefer prefixing, it looks less hacky.

[Alberts Muktupāvels (muktupavels)]

Maybe not needed these days if problem was with gnome standard themes?
- GTK+ built-in themes does not have gnome-panel css classes.
- gnome-themes-standard does not have GTK+ 3 theme.

[Marco Trevisan (Treviño) (3v1n0)]

Quite famous 3rd party themes such as numix defines these... So I didn't want to break them too, but indeed is something we could you think that to be cleaner.

However... I really think that the best way is to use a parent selector too..

I've pushed a change, let me know if it works correctly in your case too.
I'll change unity in the future, but I'd prefer to ensure the theme applies to your case only.

[Alberts Muktupāvels (muktupavels)]

review: Approve

[Alberts Muktupāvels (muktupavels)]

review: Needs Fixing

[Alberts Muktupāvels (muktupavels)]

There is missing `,`...

[Marco Trevisan (Treviño) (3v1n0)]

> There is missing `,`...

I noticed when committing, I thought I had saved... But it wasn't the case.

Fixed.

[Alberts Muktupāvels (muktupavels)]

> Fixed.

Diff still does not have `,`...

[lp:~3v1n0/ubuntu-themes/panel-rules-ignore-unity]

502. By Marco Trevisan (Treviño) on 2016-08-29

gnome-panel: use panel-toplevel as selector

[Marco Trevisan (Treviño) (3v1n0)]

It should now...

[Alberts Muktupāvels (muktupavels)]

review: Approve

[Dmitry Shachnev (mitya57)]

review: Approve

=== modified file 'Ambiance/gtk-3.20/apps/gnome-panel.css'
--- Ambiance/gtk-3.20/apps/gnome-panel.css	2016-08-08 21:44:55 +0000
+++ Ambiance/gtk-3.20/apps/gnome-panel.css	2016-08-29 10:08:19 +0000
@@ -6,8 +6,8 @@
                                      to (shade (@dark_bg_color, 1.05)));
 }
 
-.gnome-panel-menu-bar:backdrop,
-.gnome-panel-menu-bar,
+panel-toplevel .gnome-panel-menu-bar:backdrop,
+panel-toplevel .gnome-panel-menu-bar,
 panel-applet > menubar,
 clock-box {
     background: transparent;

=== modified file 'Radiance/gtk-3.20/apps/gnome-panel.css'
--- Radiance/gtk-3.20/apps/gnome-panel.css	2016-08-25 17:32:23 +0000
+++ Radiance/gtk-3.20/apps/gnome-panel.css	2016-08-29 10:08:19 +0000
@@ -6,8 +6,8 @@
                                      to (shade (@dark_bg_color, 0.95)));
 }
 
-.gnome-panel-menu-bar:backdrop,
-.gnome-panel-menu-bar,
+panel-toplevel .gnome-panel-menu-bar:backdrop,
+panel-toplevel .gnome-panel-menu-bar,
 panel-applet > menubar,
 clock-box {
     background: transparent;