Ubuntu theme

Merge lp:~3v1n0/ubuntu-themes/messagedialog-minheight into lp:ubuntu-themes

  1. messagedialog-minheight
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño) on 2017-05-15
Status: Merged
Approved by: Iain Lane on 2017-05-15
Approved revision: 544
Merged at revision: 542
Proposed branch: lp:~3v1n0/ubuntu-themes/messagedialog-minheight
Merge into: lp:ubuntu-themes
Prerequisite: lp:~3v1n0/ubuntu-themes/closer-window-buttons
Diff against target: 25 lines (+4/-0)
2 files modified
Ambiance/gtk-3.20/gtk-widgets.css (+2/-0)
Radiance/gtk-3.20/gtk-widgets.css (+2/-0)
To merge this branch: bzr merge lp:~3v1n0/ubuntu-themes/messagedialog-minheight
Reviewer Review Type Date Requested Status
Iain Lane 2017-05-15 Approve on 2017-05-15
Review via email: mp+324052@code.launchpad.net

Commit Message

Ambiance, Radiance: set proper min-height for messagedialog decorations

To post a comment you must log in.
lp:~3v1n0/ubuntu-themes/messagedialog-minheight updated on 2017-05-15
544. By Marco Trevisan (Treviño) on 2017-05-15

Ambiance, Radiance: set minimum height for solid-csd message dialogs

Iain Lane (laney) wrote :

I'm not sure why we don't set min-height on .titlebar all the time.

But this looks OK to me, thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.20/gtk-widgets.css'
2--- Ambiance/gtk-3.20/gtk-widgets.css 2017-05-15 12:04:49 +0000
3+++ Ambiance/gtk-3.20/gtk-widgets.css 2017-05-15 12:04:49 +0000
4@@ -2006,6 +2006,8 @@
5 }
6
7 .default-decoration.titlebar:not(headerbar),
8+messagedialog.csd .titlebar:not(headerbar),
9+messagedialog.solid-csd .titlebar:not(headerbar),
10 headerbar.default-decoration {
11 min-height: 26px;
12 }
13
14=== modified file 'Radiance/gtk-3.20/gtk-widgets.css'
15--- Radiance/gtk-3.20/gtk-widgets.css 2017-05-15 12:04:49 +0000
16+++ Radiance/gtk-3.20/gtk-widgets.css 2017-05-15 12:04:49 +0000
17@@ -2005,6 +2005,8 @@
18 }
19
20 .default-decoration.titlebar:not(headerbar),
21+messagedialog.csd .titlebar:not(headerbar),
22+messagedialog.solid-csd .titlebar:not(headerbar),
23 headerbar.default-decoration {
24 min-height: 26px;
25 }

Subscribers

People subscribed via source and target branches