Code review comment for lp:~3v1n0/ubuntu-themes/list-theming

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This seems to break the list in Settings a bit:

(1) Alternating background (every second item) is the same colour as the selection.

(2) Text colour is white on light grey (unreadable).

And pre-existing bugs should be fixed but aren't:

(3) Some list items (like the monitor name in Settings > Color) never highlight. Works in Adwaita.

(4) List in bubble menus (Settings > Displays > Resolution etc) are a mixture of grey and white backgrounds.

(5) The background area around the Settings > Color > 'Add profile' and 'Calibrate' buttons is still missing in Ambiance (but not in Adwaita).

---
So this feels like more of a step backwards. Maybe try fixing each issue in separate smaller branches?

review: Needs Fixing

« Back to merge proposal