Merge lp:~3v1n0/ubuntu-themes/gtk2-revive into lp:ubuntu-themes

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 580
Merged at revision: 583
Proposed branch: lp:~3v1n0/ubuntu-themes/gtk2-revive
Merge into: lp:ubuntu-themes
Diff against target: 254 lines (+141/-3)
6 files modified
Ambiance/gtk-2.0/apps/caja.rc (+11/-0)
Ambiance/gtk-2.0/apps/mate-panel.rc (+30/-0)
Ambiance/gtk-2.0/gtkrc (+30/-2)
Radiance/gtk-2.0/apps/caja.rc (+11/-0)
Radiance/gtk-2.0/apps/mate-panel.rc (+30/-0)
Radiance/gtk-2.0/gtkrc (+29/-1)
To merge this branch: bzr merge lp:~3v1n0/ubuntu-themes/gtk2-revive
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Martin Wimpress  Pending
Review via email: mp+331925@code.launchpad.net

Commit message

gtk2: Ambiance, Radiance: inherit style fixes from MATE themes

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Martin, we might need to include this in the mate PPA, could you include this to that?

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

+1

review: Approve
Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

@3v1n0 Do you mean adding the updated ubuntu-themes to the xenial-mate PPA?

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

2017-10-12 3:56 GMT-05:00 Martin Wimpress <email address hidden>:
> @3v1n0 Do you mean adding the updated ubuntu-themes to the xenial-mate PPA?

Yes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'Ambiance/gtk-2.0/apps/caja.rc'
2--- Ambiance/gtk-2.0/apps/caja.rc 1970-01-01 00:00:00 +0000
3+++ Ambiance/gtk-2.0/apps/caja.rc 2017-10-06 07:57:05 +0000
4@@ -0,0 +1,11 @@
5+# ==============================================================================
6+# CAJA SPECIFIC SETTINGS
7+# ==============================================================================
8+
9+style "caja_info_pane" {
10+ bg[NORMAL] = @bg_color
11+}
12+
13+widget_class "*Caja*<GtkNotebook>*<GtkEventBox>" style "caja_info_pane"
14+widget_class "*Caja*<GtkButton>" style "notebook_button"
15+widget_class "*Caja*<GtkButton>*<GtkLabel>" style "notebook_button"
16
17=== added file 'Ambiance/gtk-2.0/apps/mate-panel.rc'
18--- Ambiance/gtk-2.0/apps/mate-panel.rc 1970-01-01 00:00:00 +0000
19+++ Ambiance/gtk-2.0/apps/mate-panel.rc 2017-10-06 07:57:05 +0000
20@@ -0,0 +1,30 @@
21+# Panel specific settings for correct theming on MATE
22+
23+style "panel" = "dark"
24+{
25+ xthickness = 0
26+ ythickness = 0
27+
28+ engine "murrine" {
29+ colorize_scrollbar = TRUE
30+ }
31+}
32+
33+style "panel_default" = "dark"
34+{
35+ engine "murrine" {
36+ colorize_scrollbar = TRUE
37+ }
38+}
39+
40+widget "*Panel" style "panel"
41+widget "*PanelWidget*" style "panel"
42+widget "*PanelApplet*" style "panel" # workaround for right click menu corrupted bg
43+widget "*fast-user-switch*" style "panel" # workaround for Fast User Switch applet
44+widget "*CPUFreqApplet*" style "panel" # workaround for CpuFreq Applet
45+class "PanelApp*" style "panel"
46+class "PanelToplevel*" style "panel"
47+widget_class "*notif*" style "panel"
48+widget_class "*PanelApplet*" style "panel_default" # workaround for right click menu corrupted bg
49+widget_class "*Tray*" style "panel" # workaround for StarDict, gnubiff... tray icon bg
50+class "GtkScrollbar" style "murrine-scrollbar"
51
52=== modified file 'Ambiance/gtk-2.0/gtkrc'
53--- Ambiance/gtk-2.0/gtkrc 2014-03-04 17:08:48 +0000
54+++ Ambiance/gtk-2.0/gtkrc 2017-10-06 07:57:05 +0000
55@@ -35,6 +35,9 @@
56 GtkScrollbar::slider-width = 13
57 GtkScrollbar::min-slider-length = 31
58
59+ GtkScrolledWindow::scrollbar-spacing = 0
60+ GtkScrolledWindow::scrollbars-within-bevel = 0
61+
62 GtkMenuBar::internal-padding = 0
63 GtkMenuBar::shadow-type = GTK_SHADOW_NONE
64 GtkExpander::expander-size = 11
65@@ -340,7 +343,7 @@
66 }
67 }
68
69-style "menu" {
70+style "menu" = "dark" {
71 xthickness = 0
72 ythickness = 0
73
74@@ -528,6 +531,10 @@
75 bg[NORMAL] = mix (0.60, shade (1.05, @bg_color), @selected_bg_color)
76 }
77
78+style "caja_location" {
79+ bg[NORMAL] = mix (0.60, shade (1.05, @bg_color), @selected_bg_color)
80+}
81+
82 style "calendar" {
83 xthickness = 0
84 ythickness = 0
85@@ -693,6 +700,10 @@
86 # ToDo: A more generic approach for all applications that have a widget like this.
87 widget "*.nautilus-extra-view-widget" style : highest "nautilus_location"
88
89+# Special case the caja-extra-view-widget
90+# ToDo: A more generic approach for all applications that have a widget like this.
91+widget "*.caja-extra-view-widget" style : highest "caja_location"
92+
93 # Work around for http://bugzilla.gnome.org/show_bug.cgi?id=382646
94 # Note that this work around assumes that the combobox is _not_ in appears-as-list mode.
95 widget_class "*.<GtkComboBox>.<GtkCellView>" style "text_is_fg_color_workaround"
96@@ -704,7 +715,7 @@
97 widget_class "*<GtkListItem>*" style "fg_is_text_color_workaround"
98 # GtkCList also uses the fg color to draw text on top of the base colors.
99 widget_class "*<GtkCList>" style "fg_is_text_color_workaround"
100-# Nautilus when renaming files, and maybe other places.
101+# Nautilus/Caja when renaming files, and maybe other places.
102 widget_class "*<EelEditableLabel>" style "fg_is_text_color_workaround"
103 # Work around for ubuntu's lucid sound indicator
104 widget "ido-offscreen-scale" style "soundfix"
105@@ -714,9 +725,26 @@
106 # See the documentation of the style.
107 widget_class "EShellWindow.GtkVBox.BonoboDock.BonoboDockBand.BonoboDockItem*" style "evo_new_button_workaround"
108
109+# Various performance fixes if murrine textstyle is on by default in the theme.
110+style "performance-fix" {
111+ engine "murrine" {
112+ textstyle = 0
113+ contrast = 0.5
114+ }
115+}
116+
117+widget_class "*gtkmm__GtkWindow*" style "performance-fix" # Inkscape
118+widget_class "*GimpDisplayShell*" style "performance-fix" # Gimp
119+widget_class "*GimpToolbox*" style "performance-fix"
120+widget_class "*GimpMenuDock*" style "performance-fix"
121+widget "*OOoFixed*" style "performance-fix" # Openoffice/Libreoffice
122+widget_class "*MozContainer*" style "performance-fix" # Firefox (Not sure if this one does anything though.)
123+
124 # Includes
125 #include "apps/banshee.rc"
126 include "apps/chromium.rc"
127 include "apps/ff.rc"
128 include "apps/gnome-terminal.rc"
129 include "apps/nautilus.rc"
130+include "apps/caja.rc"
131+include "apps/mate-panel.rc"
132
133=== added file 'Radiance/gtk-2.0/apps/caja.rc'
134--- Radiance/gtk-2.0/apps/caja.rc 1970-01-01 00:00:00 +0000
135+++ Radiance/gtk-2.0/apps/caja.rc 2017-10-06 07:57:05 +0000
136@@ -0,0 +1,11 @@
137+# ==============================================================================
138+# CAJA SPECIFIC SETTINGS
139+# ==============================================================================
140+
141+style "caja_info_pane" {
142+ bg[NORMAL] = @bg_color
143+}
144+
145+widget_class "*Caja*<GtkNotebook>*<GtkEventBox>" style "caja_info_pane"
146+widget_class "*Caja*<GtkButton>" style "notebook_button"
147+widget_class "*Caja*<GtkButton>*<GtkLabel>" style "notebook_button"
148
149=== added file 'Radiance/gtk-2.0/apps/mate-panel.rc'
150--- Radiance/gtk-2.0/apps/mate-panel.rc 1970-01-01 00:00:00 +0000
151+++ Radiance/gtk-2.0/apps/mate-panel.rc 2017-10-06 07:57:05 +0000
152@@ -0,0 +1,30 @@
153+# Panel specific settings for correct theming on MATE
154+
155+style "panel" = "dark"
156+{
157+ xthickness = 0
158+ ythickness = 0
159+
160+ engine "murrine" {
161+ colorize_scrollbar = TRUE
162+ }
163+}
164+
165+style "panel_default" = "dark"
166+{
167+ engine "murrine" {
168+ colorize_scrollbar = TRUE
169+ }
170+}
171+
172+widget "*Panel" style "panel"
173+widget "*PanelWidget*" style "panel"
174+widget "*PanelApplet*" style "panel" # workaround for right click menu corrupted bg
175+widget "*fast-user-switch*" style "panel" # workaround for Fast User Switch applet
176+widget "*CPUFreqApplet*" style "panel" # workaround for CpuFreq Applet
177+class "PanelApp*" style "panel"
178+class "PanelToplevel*" style "panel"
179+widget_class "*notif*" style "panel"
180+widget_class "*PanelApplet*" style "panel_default" # workaround for right click menu corrupted bg
181+widget_class "*Tray*" style "panel" # workaround for StarDict, gnubiff... tray icon bg
182+class "GtkScrollbar" style "murrine-scrollbar"
183
184=== modified file 'Radiance/gtk-2.0/gtkrc'
185--- Radiance/gtk-2.0/gtkrc 2014-03-04 17:08:48 +0000
186+++ Radiance/gtk-2.0/gtkrc 2017-10-06 07:57:05 +0000
187@@ -35,6 +35,9 @@
188 GtkScrollbar::slider-width = 13
189 GtkScrollbar::min-slider-length = 31
190
191+ GtkScrolledWindow::scrollbar-spacing = 0
192+ GtkScrolledWindow::scrollbars-within-bevel = 0
193+
194 GtkMenuBar::internal-padding = 0
195 GtkMenuBar::shadow-type = GTK_SHADOW_NONE
196 GtkExpander::expander-size = 11
197@@ -488,6 +491,10 @@
198 bg[NORMAL] = mix (0.60, shade (1.05, @bg_color), @selected_bg_color)
199 }
200
201+style "caja_location" {
202+ bg[NORMAL] = mix (0.60, shade (1.05, @bg_color), @selected_bg_color)
203+}
204+
205 style "calendar" {
206 xthickness = 0
207 ythickness = 0
208@@ -642,6 +649,10 @@
209 # ToDo: A more generic approach for all applications that have a widget like this.
210 widget "*.nautilus-extra-view-widget" style : highest "nautilus_location"
211
212+# Special case the caja-extra-view-widget
213+# ToDo: A more generic approach for all applications that have a widget like this.
214+widget "*.caja-extra-view-widget" style : highest "caja_location"
215+
216 # Work around for http://bugzilla.gnome.org/show_bug.cgi?id=382646
217 # Note that this work around assumes that the combobox is _not_ in appears-as-list mode.
218 widget_class "*.<GtkComboBox>.<GtkCellView>" style "text_is_fg_color_workaround"
219@@ -653,7 +664,7 @@
220 widget_class "*<GtkListItem>*" style "fg_is_text_color_workaround"
221 # GtkCList also uses the fg color to draw text on top of the base colors.
222 widget_class "*<GtkCList>" style "fg_is_text_color_workaround"
223-# Nautilus when renaming files, and maybe other places.
224+# Nautilus/Caja when renaming files, and maybe other places.
225 widget_class "*<EelEditableLabel>" style "fg_is_text_color_workaround"
226 # Work around for ubuntu's lucid sound indicator
227 widget "ido-offscreen-scale" style "soundfix"
228@@ -663,9 +674,26 @@
229 # See the documentation of the style.
230 widget_class "EShellWindow.GtkVBox.BonoboDock.BonoboDockBand.BonoboDockItem*" style "evo_new_button_workaround"
231
232+# Various performance fixes if murrine textstyle is on by default in the theme.
233+style "performance-fix" {
234+ engine "murrine" {
235+ textstyle = 0
236+ contrast = 0.5
237+ }
238+}
239+
240+widget_class "*gtkmm__GtkWindow*" style "performance-fix" # Inkscape
241+widget_class "*GimpDisplayShell*" style "performance-fix" # Gimp
242+widget_class "*GimpToolbox*" style "performance-fix"
243+widget_class "*GimpMenuDock*" style "performance-fix"
244+widget "*OOoFixed*" style "performance-fix" # Openoffice/Libreoffice
245+widget_class "*MozContainer*" style "performance-fix" # Firefox (Not sure if this one does anything though.)
246+
247 # Includes
248 #include "apps/banshee.rc"
249 include "apps/chromium.rc"
250 include "apps/ff.rc"
251 include "apps/gnome-terminal.rc"
252 include "apps/nautilus.rc"
253+include "apps/caja.rc"
254+include "apps/mate-panel.rc"

Subscribers

People subscribed via source and target branches