Merge lp:~3v1n0/ubuntu-themes/fix-dialog-headerbar-min-height into lp:ubuntu-themes

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Iain Lane
Approved revision: 568
Merged at revision: 565
Proposed branch: lp:~3v1n0/ubuntu-themes/fix-dialog-headerbar-min-height
Merge into: lp:ubuntu-themes
Prerequisite: lp:~3v1n0/ubuntu-themes/vertical-linked-buttons-tuning
Diff against target: 32 lines (+4/-8)
2 files modified
Ambiance/gtk-3.20/gtk-widgets.css (+2/-4)
Radiance/gtk-3.20/gtk-widgets.css (+2/-4)
To merge this branch: bzr merge lp:~3v1n0/ubuntu-themes/fix-dialog-headerbar-min-height
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+331197@code.launchpad.net

Commit message

Ambiance, Radiance: be less restrictive in setting headerbar minimum height

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

Seems good, might be worth a quick grep in gtk to see that titlebar isn't added in other situations (not sure why it was limited like that).

Thanks!

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

It was limited in that way, since so it was also in Adwaita... Then upstream changed a bit the things.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.20/gtk-widgets.css'
2--- Ambiance/gtk-3.20/gtk-widgets.css 2017-09-22 14:26:48 +0000
3+++ Ambiance/gtk-3.20/gtk-widgets.css 2017-09-22 14:26:48 +0000
4@@ -2152,10 +2152,8 @@
5 border-radius: 0;
6 }
7
8-.default-decoration.titlebar:not(headerbar),
9-messagedialog.csd .titlebar:not(headerbar),
10-messagedialog.solid-csd .titlebar:not(headerbar),
11-headerbar.default-decoration {
12+.titlebar:not(headerbar),
13+headerbar {
14 min-height: 26px;
15 }
16
17
18=== modified file 'Radiance/gtk-3.20/gtk-widgets.css'
19--- Radiance/gtk-3.20/gtk-widgets.css 2017-09-22 14:26:48 +0000
20+++ Radiance/gtk-3.20/gtk-widgets.css 2017-09-22 14:26:48 +0000
21@@ -2151,10 +2151,8 @@
22 border-radius: 0;
23 }
24
25-.default-decoration.titlebar:not(headerbar),
26-messagedialog.csd .titlebar:not(headerbar),
27-messagedialog.solid-csd .titlebar:not(headerbar),
28-headerbar.default-decoration {
29+.titlebar:not(headerbar),
30+headerbar {
31 min-height: 26px;
32 }
33

Subscribers

People subscribed via source and target branches