Merge lp:~3v1n0/ubuntu-themes/borderless-decorations-radiance-fix into lp:ubuntu-themes

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Brandon Schaefer
Approved revision: 363
Merged at revision: 368
Proposed branch: lp:~3v1n0/ubuntu-themes/borderless-decorations-radiance-fix
Merge into: lp:ubuntu-themes
Diff against target: 14 lines (+2/-2)
1 file modified
Radiance/gtk-3.0/apps/unity.css (+2/-2)
To merge this branch: bzr merge lp:~3v1n0/ubuntu-themes/borderless-decorations-radiance-fix
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Brandon Schaefer (community) Approve
Marco Trevisan (Treviño) Abstain
Review via email: mp+211381@code.launchpad.net

Commit message

Radiance: use properly sized corner radius (matching Ambiance)

Description of the change

It seems I forgot a "bzr push" on the borderless-decorations branch, so I didn't push the fix to make the corner radius of Radiance to match Ambiance.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Cool, it works like a charm and code looks good.

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ops, wrong tab... Firefox tricked me :D

review: Abstain
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

Oh... And I was about to report that Ambiance's corners now looked too small... I honestly like 8px radius better.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Personally me too, but I think it's a matter of getting used to them... Btw this is the new design :)

Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

Yeah, you're right Marco, not a huge deal :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Radiance/gtk-3.0/apps/unity.css'
2--- Radiance/gtk-3.0/apps/unity.css 2014-03-11 16:25:55 +0000
3+++ Radiance/gtk-3.0/apps/unity.css 2014-03-17 18:37:17 +0000
4@@ -22,8 +22,8 @@
5 UnityDecoration.top {
6 border: 1px solid rgba (85, 40, 0, 0.04); /* shade (@dark_bg_color) (shade (#edebe6, 1.06) */
7 border-bottom-width: 0;
8- border-radius: 8px 8px 0 0;
9- padding: 1px 8px 0 8px;
10+ border-radius: 6px 6px 0 0;
11+ padding: 1px 6px 0 6px;
12
13 box-shadow: inset 0 0 transparent, inset 0 0 transparent,
14 inset 0 1px shade (#edebe6, 1.065), inset 0 0 transparent;

Subscribers

People subscribed via source and target branches