Merge lp:~3v1n0/ubuntu-themes/appmenu-theming-shape-fix into lp:ubuntu-themes

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 552
Merged at revision: 557
Proposed branch: lp:~3v1n0/ubuntu-themes/appmenu-theming-shape-fix
Merge into: lp:ubuntu-themes
Prerequisite: lp:~3v1n0/ubuntu-themes/radiance-headerbar-buttons-fix
Diff against target: 57 lines (+32/-4)
2 files modified
Ambiance/gtk-3.20/gtk-widgets.css (+16/-2)
Radiance/gtk-3.20/gtk-widgets.css (+16/-2)
To merge this branch: bzr merge lp:~3v1n0/ubuntu-themes/appmenu-theming-shape-fix
Reviewer Review Type Date Requested Status
Dmitry Shachnev Approve
Review via email: mp+324517@code.launchpad.net

Commit message

Ambiance, Radiance: ignore titlebutton theming for appmenu

To post a comment you must log in.
552. By Marco Trevisan (Treviño)

Ambiance, Radiance: reduce opacity of the appmenu button on active and checked state

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

This removes the ugly circle, thanks! I was originally thinking of a proper rectangle button, but this also looks nice.

review: Approve
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

I think some hover effect also would be nice, but this is definitely better. :) Thanks!

Revision history for this message
Adolfo Jayme (fitojb) wrote :

Is anything blocking the merging of this patch?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.20/gtk-widgets.css'
2--- Ambiance/gtk-3.20/gtk-widgets.css 2017-05-18 16:14:20 +0000
3+++ Ambiance/gtk-3.20/gtk-widgets.css 2017-05-24 05:34:05 +0000
4@@ -2151,8 +2151,22 @@
5 background-image: linear-gradient(to top, #605f59, #5b5a54);
6 }
7
8-
9-
10+.titlebar button.titlebutton.appmenu,
11+.titlebar button.titlebutton.appmenu:backdrop {
12+ border: none;
13+ background-image: none;
14+ color: transparent;
15+ background-color: transparent;
16+}
17+
18+.titlebar button.titlebutton.appmenu:checked,
19+.titlebar button.titlebutton.appmenu:active {
20+ opacity: 0.75;
21+}
22+
23+.titlebar button.titlebutton.appmenu:backdrop {
24+ opacity: 0.5;
25+}
26
27 /***********
28 * toolbar *
29
30=== modified file 'Radiance/gtk-3.20/gtk-widgets.css'
31--- Radiance/gtk-3.20/gtk-widgets.css 2017-05-24 05:34:05 +0000
32+++ Radiance/gtk-3.20/gtk-widgets.css 2017-05-24 05:34:05 +0000
33@@ -2154,8 +2154,22 @@
34 background-image: linear-gradient(to top, #ece9e6, #e8e4e1);
35 }
36
37-
38-
39+.titlebar button.titlebutton.appmenu,
40+.titlebar button.titlebutton.appmenu:backdrop {
41+ border: none;
42+ background-image: none;
43+ color: transparent;
44+ background-color: transparent;
45+}
46+
47+.titlebar button.titlebutton.appmenu:checked,
48+.titlebar button.titlebutton.appmenu:active {
49+ opacity: 0.75;
50+}
51+
52+.titlebar button.titlebutton.appmenu:backdrop {
53+ opacity: 0.5;
54+}
55
56 /***********
57 * toolbar *

Subscribers

People subscribed via source and target branches