Code review comment for lp:~3v1n0/ubuntu-settings-components/new-calendar-design

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> It's not possible to pick an arbitrary month/year. According to Patty, this
> should use some new date/time picker: https://docs.google.com/document/d/1RR9p
> FColFvHuBpUcXyptcz9VuQ3jAhC22UBMYUVF6dc/edit?ts=57f4cae5#heading=h.jm1brcrw6j5
> p
>
>
> Is this going to be implemented at this stage?

As I wrote in the description, since this component is something that is going to be replaced soon by default SDK one (which is in the works and that will be ready in some weeks), I didn't want to spend too much time for that...

So, I think for now this should be enough (as there's no regression anyway), while this will be then replaced.

> The month name in the calendar header should imho use some smaller font, it
> looks different than on the screenshots.

Mh, might be... But in the specs I have (see the linked doc above), it was marked as "Small" font. I've used XSmall instead since it looked more similar to the designs, but if you think it's better I can switch to XXSmall (it would be http://imgur.com/mTHSh8b.png)

« Back to merge proposal