Merge ~3v1n0/ubuntu-app-platform:master into ubuntu-app-platform:master

[Marco Trevisan (Treviño)]

snapcraft.yaml: load indicator-qt5 remote part

It adds proper support to app-indicators in classic space.

See https://github.com/3v1n0/indicators-examples-snaps for more infos or the part definition at https://github.com/3v1n0/appindicators-snapcraft-parts

Removed also the unneeded and outdated custom plugins (the x-qmake one specifically was pointing to the wrong location, thus causing indicator-qt5 not to compile).

[Tim Peeters (tpeeters)]

Thanks for the MR, but can you separate adding of a dependency and removing the plugins into separate MRs to make it easier to review?

Perhaps a bug report describing the the outdated plugins is useful too.

review: Needs Fixing

[Tim Peeters (tpeeters)]

Why does this need to go in the ubuntu-app-platform?

Perhaps the question is similar for [desktop-ubuntu-app-platform], see https://wiki.ubuntu.com/snapcraft/parts. That needs to be included in the after: for apps that use ubuntu-app-platform. But perhaps we can just include it all in the platform snap?

review: Needs Information

[Marco Trevisan (Treviño) (3v1n0)]

Mh, I'm not sure what you mean...

Adding it to the after part of desktop-ubuntu-app-platform, isn't probably the best thing, as I think if this is just available for all the apps using the app-platform.

Anyway this will will work only in unity7, as for unity8 we still need to address this.

[Marco Trevisan (Treviño) (3v1n0)]

No news in this?

[Timo Jyrinki (timo-jyrinki)]

Sorry, I was on a long leave when this was discussed.

So, compile appmenu-qt5 as part of every application build? Wouldn't it be possible to just stage appmenu-qt5 in ubuntu-app-platform to share also that? If one needs the to-be-SRU:d patches to xenial and there are SRU problems, maybe it'd make sense to land to xenial overlay PPA instead as ubuntu-app-platform is anyway built with the overlay PPA.

[Marco Trevisan (Treviño) (3v1n0)]

> So, compile appmenu-qt5 as part of every application build?

Nope, being this in the runtime, it will be needed only when compiling the runtime, so... It doesn't seem like a problem to me, in the mean time.

> Wouldn't it be possible to just stage appmenu-qt5 in ubuntu-app-platform to
> share also that?

That was my idea, but needs time to SRU...

> maybe it'd make sense to land to xenial overlay PPA instead as ubuntu-app-platform
> is anyway built with the overlay PPA.

Ok, this is a better thing... I've added a no-change rebuild here:
https://bileto.ubuntu.com/#/ticket/2487

[Marco Trevisan (Treviño) (3v1n0)]

Timo, since appmenu-qt5 is in xenial+overlay, I've updated the branch accordingly,

[Timo Jyrinki (timo-jyrinki)]

This should be ok, just that currently not allowed to upload anything new even to the edge channel so this won't be in store yet.

review: Approve

diff --git a/snapcraft.yaml b/snapcraft.yaml
index c9cd641..58ea1d0 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -100,6 +100,8 @@ parts:
         - qtdeclarative5-ubuntu-contacts0.1
         # Add a droid derived Sans-Serif style CJK font
         - fonts-wqy-microhei
+        # Unity7 desktop integration (menus and indicators with snap support)
+        - appmenu-qt5
         # OSK
         - ubuntu-keyboard-arabic
         - ubuntu-keyboard-autopilot
@@ -162,4 +164,3 @@ parts:
         - etc/xdg/maliit.org/
         - usr/lib/maliit/plugins
         - usr/share/maliit/plugins
-