Nux

Merge lp:~3v1n0/nux/x11-conffile-on-unity-only into lp:nux/artful

Proposed by Marco Trevisan (Treviño) on 2018-06-13
Status: Rejected
Rejected by: Marco Trevisan (Treviño) on 2018-06-13
Proposed branch: lp:~3v1n0/nux/x11-conffile-on-unity-only
Merge into: lp:nux/artful
Diff against target: 56 lines (+25/-4)
3 files modified
debian/50_check_unity_support (+14/-2)
debian/changelog (+9/-0)
m4/gtest.m4 (+2/-2)
To merge this branch: bzr merge lp:~3v1n0/nux/x11-conffile-on-unity-only
Reviewer Review Type Date Requested Status
Iain Lane 2018-06-13 Approve on 2018-06-13
Review via email: mp+347862@code.launchpad.net

Commit message

X11-check-unity-support: only run when called from an unity session

The content of $XDG_CURRENT_DESKTOP is checked inside a sub-shell
not to affect the value of IFS for all the scripts sourced by the X session.

If running in Unity we should call unity_support_test, not inside gnome
ubuntu X sessions.

XDG_CURRENT_DESKTOP values are currently the followings:
 - unity before 17.10: Unity
 - unity after 17.10: Unity:Unity7:ubuntu
 - gnome session: GNOME
 - ubuntu gnome session: ubuntu:GNOME

Also, at debian level, don't consider the Xsession.d script as a config file anymore

This is just a script to be loaded, and not something the user is supposed to change,
so it should be removed on simple package removal.
To achieve this, as per maintainer-guide 5.3, using sym-links is the standard way.

To post a comment you must log in.
894. By Marco Trevisan (Treviño) on 2018-06-13

gtest: update default google-test prefix to match distro

895. By Marco Trevisan (Treviño) on 2018-06-13

Revert: "debian: don't consider the Xsession.d script as a config file anymore"

It seems something there's not full agreement on it, so to avoid further discussions
I'm reverting this back. However I strongly believe that given the current tools we have
this is the way to go, as debian doesn't provide other tools to get this done.
Nor X11 can move files outside of /etc.

Iain Lane (laney) wrote :

thanks

review: Approve

Unmerged revisions

895. By Marco Trevisan (Treviño) on 2018-06-13

Revert: "debian: don't consider the Xsession.d script as a config file anymore"

It seems something there's not full agreement on it, so to avoid further discussions
I'm reverting this back. However I strongly believe that given the current tools we have
this is the way to go, as debian doesn't provide other tools to get this done.
Nor X11 can move files outside of /etc.

894. By Marco Trevisan (Treviño) on 2018-06-13

gtest: update default google-test prefix to match distro

893. By Marco Trevisan (Treviño) on 2018-06-13

debian: don't consider the Xsession.d script as a config file anymore

This is just a script to be loaded, and not something the user is supposed to change,
so it should be removed on simple package removal.
To achieve this, as per maintainer-guide 5.3, using sym-links is the standard way.

892. By Marco Trevisan (Treviño) on 2018-06-13

50_check_unity_support: only run when called from an unity session

The content of $XDG_CURRENT_DESKTOP is checked inside a sub-shell
not to affect the value of IFS for all the scripts sourced by the X session.

If running in Unity we should call unity_support_test, not inside gnome
ubuntu X sessions.

XDG_CURRENT_DESKTOP values are currently the followings:
 - unity before 17.10: Unity
 - unity after 17.10: Unity:Unity7:ubuntu
 - gnome session: GNOME
 - ubuntu gnome session: ubuntu:GNOME

891. By Marco Trevisan (Treviño) on 2018-06-12

50_check_unity_support: only export LIBGL_ALWAYS_SOFTWARE=1 on command failed

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/50_check_unity_support'
2--- debian/50_check_unity_support 2013-08-12 11:20:24 +0000
3+++ debian/50_check_unity_support 2018-06-13 12:17:38 +0000
4@@ -2,6 +2,18 @@
5 # If the hardware does not pass unity_support_test, fall back to LLVMpipe
6 # which does.
7
8-if [ "x$DESKTOP_SESSION" = "xubuntu" ]; then
9- /usr/lib/nux/unity_support_test || export LIBGL_ALWAYS_SOFTWARE=1
10+if [ "x$DESKTOP_SESSION" = "xubuntu" ] && [ -x "/usr/lib/nux/unity_support_test" ]; then
11+ (
12+ IFS=':'
13+ for d in $XDG_CURRENT_DESKTOP; do
14+ if [ "x$d" = "xUnity" ] || [ "x$d" = "xUnity7" ]; then
15+ return 0
16+ fi
17+ done
18+ return 1
19+ )
20+
21+ if [ $? = 0 ]; then
22+ /usr/lib/nux/unity_support_test || export LIBGL_ALWAYS_SOFTWARE=1
23+ fi
24 fi
25
26=== modified file 'debian/changelog'
27--- debian/changelog 2017-09-22 13:12:54 +0000
28+++ debian/changelog 2018-06-13 12:17:38 +0000
29@@ -1,3 +1,12 @@
30+nux (4.0.8+17.10.20170922-0ubuntu2) UNRELEASED; urgency=medium
31+
32+ * debian/50_check_unity_support:
33+ - various changes to fix (LP: #1768610):
34+ + export LIBGL_ALWAYS_SOFTWARE=1 only on command failure
35+ + run only when called inside an unity session
36+
37+ -- Marco Trevisan (Treviño) <marco@ubuntu.com> Wed, 13 Jun 2018 03:35:45 +0200
38+
39 nux (4.0.8+17.10.20170922-0ubuntu1) artful; urgency=medium
40
41 * Nux: mark explicit fallthrough jumps (to please gcc7)
42
43=== modified file 'm4/gtest.m4'
44--- m4/gtest.m4 2013-08-15 01:17:55 +0000
45+++ m4/gtest.m4 2018-06-13 12:17:38 +0000
46@@ -35,8 +35,8 @@
47 AC_ARG_VAR([GMOCK_CPPFLAGS],
48 [C preprocessor flags for Google Mock.])
49
50- gmock_prefix=/usr/src/gmock
51- gmock_includes=$gmock_prefix/gtest/include
52+ gmock_prefix=/usr/src/googletest/googlemock
53+ gmock_includes=$gmock_prefix/include
54 AC_ARG_WITH([gmock-prefix],[
55 AS_HELP_STRING([--with-gmock-prefix],
56 [Prefix where Google Mock is installed (default $gmock_prefix)])

Subscribers

People subscribed via source and target branches