Nux

Merge lp:~3v1n0/nux/check-dnd_area into lp:nux

Proposed by Marco Trevisan (Treviño) on 2014-10-03
Status: Merged
Approved by: Brandon Schaefer on 2014-10-03
Approved revision: 855
Merged at revision: 855
Proposed branch: lp:~3v1n0/nux/check-dnd_area
Merge into: lp:nux
Diff against target: 14 lines (+2/-3)
1 file modified
Nux/WindowCompositor.cpp (+2/-3)
To merge this branch: bzr merge lp:~3v1n0/nux/check-dnd_area
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) 2014-10-03 Approve on 2014-10-03
Review via email: mp+237150@code.launchpad.net

Commit message

WindowCompositor: don't try to use an null dnd_area pointer

To post a comment you must log in.
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Nux/WindowCompositor.cpp'
2--- Nux/WindowCompositor.cpp 2014-07-30 00:23:32 +0000
3+++ Nux/WindowCompositor.cpp 2014-10-03 22:55:18 +0000
4@@ -283,9 +283,8 @@
5 }
6 else if (event.type == NUX_DND_DROP)
7 {
8- InputArea* current_dnd_area = GetDnDArea();
9- if (current_dnd_area->GetAbsoluteGeometry().IsPointInside(event.x - event.x_root, event.y - event.y_root))
10- current_dnd_area->HandleDndDrop(event);
11+ if (_dnd_area && _dnd_area->GetAbsoluteGeometry().IsPointInside(event.x - event.x_root, event.y - event.y_root))
12+ _dnd_area->HandleDndDrop(event);
13 }
14 }
15

Subscribers

People subscribed via source and target branches