Nux

Code review comment for lp:~3v1n0/nux/callgrind-improvements

Revision history for this message
Michi Henning (michihenning) wrote :

Geometry const& geo = view->GetAbsoluteGeometry();
parent = view->GetToplevel();

As far as I can see, if this actually works, it works only by accident. This binds a C++ reference to the return value of a function. The return value is a temporary that will disappear the instant the function completes.

Further down in the function, we have:

m_dirty_areas.push_back(geo);

This looks like it pushes a dangling reference.

review: Needs Fixing

« Back to merge proposal