Created by Marco Trevisan (Treviño) and last modified
Get this branch:
bzr branch lp:~3v1n0/notify-osd/fix-notifications-replacing
Only Marco Trevisan (Treviño) can upload to this branch. If you are Marco Trevisan (Treviño) please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Marco Trevisan (Treviño)
Notify OSD

Recent revisions

506. By Marco Trevisan (Treviño)

Stack: indentation fix

505. By Marco Trevisan (Treviño)

Stack: don't allow a different sender to replace a notification that has been requested by someone else

504. By Marco Trevisan (Treviño)

Stack: don't overridde a bubble id if this has been provided by the call

This fixes the case where we want to replace a notification with a given
ID that is about to show or currently visible.

503. By CI Train Bot Account

Releasing 0.9.35+16.04.20151201-0ubuntu1

502. By Lars Karlitski

bubble_set_icon: allow absolute paths in the icon name field Fixes: #1520667
Approved by: Sebastien Bacher

501. By CI Train Bot Account

Releasing 0.9.35+16.04.20151118-0ubuntu1

500. By Lars Karlitski

Ignore body for synchronous notifications

It doesn't make sense to not show the notification at all when a body is set. Instead, simply ignore the body.

499. By CI Train Bot Account

Releasing 0.9.35+16.04.20151112-0ubuntu1

498. By Lars Karlitski

Listen to xsettings dpi changes

We only listened to font scale factor changes on gsettings, but retrieved the actual value from xsettings (through gtk-xft-dpi). This is racy: unity-settings-daemon also listens to gsettings and might not have set the xsettings value when our handler is run.

Fix this by listening to xsettings changes as well.

This means that we're now listening for both xsettings and gsettings changes for what is essentially the same thing and recalculate size on each of them. This creates some unnecessary work, but those settings are not changed very often. We can't only listen on xsettings, because there are other gsettings keys that might trigger a change in notification bubble appearance. Fixes: #1303796
Approved by: Sebastien Bacher

497. By Lars Karlitski

Refactor bubble_set_icon()

This function did the same as bubble_set_icon_for_path(), because paths are allowed in addition to icon names for both the app-icon parameter and the image-path hint.

Remove one of those functions and inline load_icon(), which gives us more control over when icon-not-found warnings are shown. Don't show one when using the fallback of prefixing the icon name with "notification-".

Remove TEMPORARY_ICON_PREFIX_WORKAROUND. It's been there since 2009 and
was never set to anything but 1.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
This branch contains Public information 
Everyone can see this information.