Code review comment for lp:~3v1n0/nautilus/nautilus-3.8-location-xids

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Thanks, but this doesn't compile here on Saucy:

nautilus-freedesktop-dbus.c:233:1: error: conflicting types for 'nautilus_freedesktop_dbus_set_open_locations'
 nautilus_freedesktop_dbus_set_open_locations (NautilusFreedesktopDBus *fdb,
 ^
nautilus-freedesktop-dbus.c:224:1: note: previous definition of 'nautilus_freedesktop_dbus_set_open_locations' was here
 nautilus_freedesktop_dbus_set_open_locations (NautilusFreedesktopDBus *fdb,
 ^
make[4]: *** [nautilus-freedesktop-dbus.o] Error 1
make[4]: Leaving directory `/«PKGBUILDDIR»/src'

Could you also add a Description header to this patch so that someone coming to this later won't be as confused as I was about what the patch is for?

http://dep.debian.net/deps/dep3/

review: Needs Fixing

« Back to merge proposal