libunity

Merge lp:~3v1n0/libunity/launcher-use-class-settings into lp:libunity

  1. launcher-use-class-settings
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 317
Merged at revision: 317
Proposed branch: lp:~3v1n0/libunity/launcher-use-class-settings
Merge into: lp:libunity
Diff against target: 12 lines (+1/-1)
1 file modified
src/unity-launcher.vala (+1/-1)
To merge this branch: bzr merge lp:~3v1n0/libunity/launcher-use-class-settings
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+271847@code.launchpad.net

Commit message

UnityLauncher: use member setting variable instead of a temporary one

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:317
http://jenkins.qa.ubuntu.com/job/libunity-ci/142/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libunity-wily-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libunity-wily-armhf-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libunity-wily-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/libunity-ci/142/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

looks good and fixes the warning, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/unity-launcher.vala'
2--- src/unity-launcher.vala 2015-09-11 13:37:15 +0000
3+++ src/unity-launcher.vala 2015-09-21 18:00:40 +0000
4@@ -365,7 +365,7 @@
5
6 if (schema_src != null)
7 {
8- var settings = new Settings.full (schema_src, null, null);
9+ settings = new Settings.full (schema_src, null, null);
10 reset_fav_cache ();
11
12 settings.changed["favorites"].connect (reset_fav_cache);

Subscribers

People subscribed via source and target branches