Merge lp:~3v1n0/libappindicator/rm-approver into lp:libappindicator/13.10

Proposed by Ted Gould
Status: Superseded
Proposed branch: lp:~3v1n0/libappindicator/rm-approver
Merge into: lp:libappindicator/13.10
Diff against target: 17 lines (+0/-7)
1 file modified
src/notification-watcher.xml (+0/-7)
To merge this branch: bzr merge lp:~3v1n0/libappindicator/rm-approver
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Ted Gould (community) Approve
Review via email: mp+168196@code.launchpad.net

This proposal supersedes a proposal from 2012-12-18.

This proposal has been superseded by a proposal from 2013-06-09.

Description of the change

NotificationWatcher interface has not anymore the XAyatanaRegisterNotificationApprover method

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ted Gould (ted) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Allan LeSage (allanlesage) wrote : Posted in a previous version of this proposal

I'm able to show a clean build in quantal but not in raring, FWIW--we might need some packaging help to land this.

Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
Ted Gould (ted) wrote :

Resubmitting to current trunk.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/libappindicator-autolanding/5/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libappindicator-saucy-amd64-autolanding/1/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/notification-watcher.xml'
2--- src/notification-watcher.xml 2010-10-08 16:04:27 +0000
3+++ src/notification-watcher.xml 2013-06-07 21:28:28 +0000
4@@ -15,13 +15,6 @@
5 <method name="RegisterStatusNotifierHost">
6 <arg type="s" name="service" direction="in" />
7 </method>
8- <method name="XAyatanaRegisterNotificationApprover">
9- <annotation name="org.freedesktop.DBus.GLib.Async" value="true" />
10- <!-- The path where to find the approver interface -->
11- <arg type="o" name="path" direction="in" />
12- <!-- List of categories to approve, none represents all -->
13- <arg type="as" name="categories" direction="in" />
14- </method>
15
16 <!-- Signals -->
17 <signal name="StatusNotifierItemRegistered">

Subscribers

People subscribed via source and target branches