libappindicator

Merge lp:~3v1n0/libappindicator/label-guide-resend-null-fix into lp:libappindicator/16.10

  1. label-guide-resend-null-fix
  2. Merge into trunk.16.10
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 279
Proposed branch: lp:~3v1n0/libappindicator/label-guide-resend-null-fix
Merge into: lp:libappindicator/16.10
Diff against target: 15 lines (+5/-0)
1 file modified
src/app-indicator.c (+5/-0)
To merge this branch: bzr merge lp:~3v1n0/libappindicator/label-guide-resend-null-fix
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Review via email: mp+317131@code.launchpad.net

Commit message

AppIndicator: don't emit label cahanges when guide is still empty

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

lgtm

review: Approve
Revision history for this message
Andrea Azzarone (azzar1) wrote :

lgtm.

review: Approve
lp:~3v1n0/libappindicator/label-guide-resend-null-fix updated
279. By Marco Trevisan (Treviño)

AppIndicator: don't emit label changes when guide is empty (and not null)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app-indicator.c'
2--- src/app-indicator.c 2016-11-29 17:27:16 +0000
3+++ src/app-indicator.c 2017-02-13 17:13:16 +0000
4@@ -998,6 +998,11 @@
5 gchar * oldguide = priv->label_guide;
6 priv->label_guide = g_value_dup_string(value);
7
8+ if (priv->label_guide != NULL && priv->label_guide[0] == '\0') {
9+ g_free(priv->label_guide);
10+ priv->label_guide = NULL;
11+ }
12+
13 if (g_strcmp0(oldguide, priv->label_guide) != 0) {
14 signal_label_change(APP_INDICATOR(object));
15 }

Subscribers

People subscribed via source and target branches