Merge lp:~3v1n0/indicator-datetime/add-name-hint into lp:indicator-datetime/0.3

Proposed by Marco Trevisan (Treviño)
Status: Merged
Merged at revision: 147
Proposed branch: lp:~3v1n0/indicator-datetime/add-name-hint
Merge into: lp:indicator-datetime/0.3
Diff against target: 29 lines (+8/-0)
1 file modified
src/indicator-datetime.c (+8/-0)
To merge this branch: bzr merge lp:~3v1n0/indicator-datetime/add-name-hint
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+81652@code.launchpad.net

Description of the change

Added the name hint to the indicator, to use it on unity-panel-service.

I'm using the autoconf generated config.h PACKAGE_NAME value.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

This is the only missing branch of this "series"... Please merge it :)

Revision history for this message
Charles Kerr (charlesk) wrote :

Looks fine, this is how the other indicators do it too

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/indicator-datetime.c'
2--- src/indicator-datetime.c 2011-09-21 20:19:53 +0000
3+++ src/indicator-datetime.c 2011-11-08 23:01:20 +0000
4@@ -161,6 +161,7 @@
5 static GtkLabel * get_label (IndicatorObject * io);
6 static GtkMenu * get_menu (IndicatorObject * io);
7 static const gchar * get_accessible_desc (IndicatorObject * io);
8+static const gchar * get_name_hint (IndicatorObject * io);
9 static GVariant * bind_enum_set (const GValue * value, const GVariantType * type, gpointer user_data);
10 static gboolean bind_enum_get (GValue * value, GVariant * variant, gpointer user_data);
11 static gchar * generate_format_string_now (IndicatorDatetime * self);
12@@ -200,6 +201,7 @@
13 io_class->get_label = get_label;
14 io_class->get_menu = get_menu;
15 io_class->get_accessible_desc = get_accessible_desc;
16+ io_class->get_name_hint = get_name_hint;
17
18 g_object_class_install_property (object_class,
19 PROP_SHOW_CLOCK,
20@@ -1548,3 +1550,9 @@
21 }
22 return NULL;
23 }
24+
25+static const gchar *
26+get_name_hint (IndicatorObject * io)
27+{
28+ return PACKAGE_NAME;
29+}

Subscribers

People subscribed via source and target branches