Merge lp:~3v1n0/indicator-application/scroll-api-merge into lp:indicator-application/0.4

Proposed by Marco Trevisan (Treviño)
Status: Merged
Merged at revision: 205
Proposed branch: lp:~3v1n0/indicator-application/scroll-api-merge
Merge into: lp:indicator-application/0.4
Diff against target: 42 lines (+4/-4)
2 files modified
configure.ac (+1/-1)
src/indicator-application.c (+3/-3)
To merge this branch: bzr merge lp:~3v1n0/indicator-application/scroll-api-merge
Reviewer Review Type Date Requested Status
Indicator Applet Developers Pending
Review via email: mp+66678@code.launchpad.net

Description of the change

Use the "entry-scrolled" signal instead of the old one.
It follows the API change of libindicator, See related bug #804618 for more informations.
Plus fixed the compilation with GTK-2.0

It needs the merge of lp:~3v1n0/libindicator/scroll-api-merge

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.ac'
--- configure.ac 2011-06-22 16:22:45 +0000
+++ configure.ac 2011-07-02 03:55:05 +0000
@@ -64,7 +64,7 @@
64 dbus-glib-1 >= $DBUS_GLIB_REQUIRED_VERSION64 dbus-glib-1 >= $DBUS_GLIB_REQUIRED_VERSION
65 dbusmenu-gtk-0.4 >= $DBUSMENUGTK_REQUIRED_VERSION)65 dbusmenu-gtk-0.4 >= $DBUSMENUGTK_REQUIRED_VERSION)
6666
67 PKG_CHECK_MODULES(APPINDICATOR, appindicator3-0.1 >= $LIBAPPINDICATOR_REQUIRED_VERSION)67 PKG_CHECK_MODULES(APPINDICATOR, appindicator-0.1 >= $LIBAPPINDICATOR_REQUIRED_VERSION)
68 ],68 ],
69 [AC_MSG_FAILURE([Value for --with-gtk was neither 2 nor 3])]69 [AC_MSG_FAILURE([Value for --with-gtk was neither 2 nor 3])]
70)70)
7171
=== modified file 'src/indicator-application.c'
--- src/indicator-application.c 2011-03-11 22:28:20 +0000
+++ src/indicator-application.c 2011-07-02 03:55:05 +0000
@@ -109,7 +109,7 @@
109static void indicator_application_finalize (GObject *object);109static void indicator_application_finalize (GObject *object);
110static GList * get_entries (IndicatorObject * io);110static GList * get_entries (IndicatorObject * io);
111static guint get_location (IndicatorObject * io, IndicatorObjectEntry * entry);111static guint get_location (IndicatorObject * io, IndicatorObjectEntry * entry);
112static void scroll_entry (IndicatorObject * io, IndicatorObjectEntry * entry, gint delta, IndicatorScrollDirection direction);112static void entry_scrolled (IndicatorObject * io, IndicatorObjectEntry * entry, gint delta, IndicatorScrollDirection direction);
113void connection_changed (IndicatorServiceManager * sm, gboolean connected, IndicatorApplication * application);113void connection_changed (IndicatorServiceManager * sm, gboolean connected, IndicatorApplication * application);
114static void connected (IndicatorApplication * application);114static void connected (IndicatorApplication * application);
115static void disconnected (IndicatorApplication * application);115static void disconnected (IndicatorApplication * application);
@@ -144,7 +144,7 @@
144144
145 io_class->get_entries = get_entries;145 io_class->get_entries = get_entries;
146 io_class->get_location = get_location;146 io_class->get_location = get_location;
147 io_class->scroll_entry = scroll_entry;147 io_class->entry_scrolled = entry_scrolled;
148148
149 return;149 return;
150}150}
@@ -403,7 +403,7 @@
403}403}
404404
405/* Redirect the scroll event to the Application Item */405/* Redirect the scroll event to the Application Item */
406static void scroll_entry (IndicatorObject * io, IndicatorObjectEntry * entry, gint delta, IndicatorScrollDirection direction) {406static void entry_scrolled (IndicatorObject * io, IndicatorObjectEntry * entry, gint delta, IndicatorScrollDirection direction) {
407 407
408 g_return_if_fail(IS_INDICATOR_APPLICATION(io));408 g_return_if_fail(IS_INDICATOR_APPLICATION(io));
409409

Subscribers

People subscribed via source and target branches