Merge lp:~3v1n0/gtk/unity-rgba-tooltips into lp:~ubuntu-desktop/gtk/ubuntugtk3

Proposed by Marco Trevisan (Treviño) on 2015-10-21
Status: Merged
Approved by: Sebastien Bacher on 2015-10-21
Approved revision: 469
Merged at revision: 468
Proposed branch: lp:~3v1n0/gtk/unity-rgba-tooltips
Merge into: lp:~ubuntu-desktop/gtk/ubuntugtk3
Diff against target: 52 lines (+32/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/series (+1/-0)
debian/patches/unity_rbga_tooltips.patch (+24/-0)
To merge this branch: bzr merge lp:~3v1n0/gtk/unity-rgba-tooltips
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve on 2015-10-21
Ubuntu Desktop 2015-10-21 Pending
Review via email: mp+275187@code.launchpad.net

Commit Message

debian/patches/unity_rbga_tooltips.patch:
  - GtkTooltip: set always an rgba visual when running in Unity (LP: #1508357)

To post a comment you must log in.
lp:~3v1n0/gtk/unity-rgba-tooltips updated on 2015-10-21
469. By Marco Trevisan (Treviño) on 2015-10-21

debian/patches/unity_rbga_tooltips.patch: add patch-header

Lars Karlitski (larsu) wrote :

Yep, as discussed. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-10-16 08:18:44 +0000
3+++ debian/changelog 2015-10-21 13:40:17 +0000
4@@ -1,3 +1,10 @@
5+gtk+3.0 (3.16.7-0ubuntu4) UNRELEASED; urgency=medium
6+
7+ * debian/patches/unity_rbga_tooltips.patch:
8+ - GtkTooltip: set always an rgba visual when running in Unity (LP: #1508357)
9+
10+ -- Marco Trevisan (Treviño) <marco@ubuntu.com> Wed, 21 Oct 2015 15:30:47 +0200
11+
12 gtk+3.0 (3.16.7-0ubuntu3) wily; urgency=medium
13
14 * debian/control: refresh from control.in
15
16=== modified file 'debian/patches/series'
17--- debian/patches/series 2015-10-16 08:18:24 +0000
18+++ debian/patches/series 2015-10-21 13:40:17 +0000
19@@ -24,3 +24,4 @@
20 0001-calendar-always-emit-day-selected-once.patch
21 git_icon_fallback.patch
22 git_nameless_devices.patch
23+unity_rbga_tooltips.patch
24
25=== added file 'debian/patches/unity_rbga_tooltips.patch'
26--- debian/patches/unity_rbga_tooltips.patch 1970-01-01 00:00:00 +0000
27+++ debian/patches/unity_rbga_tooltips.patch 2015-10-21 13:40:17 +0000
28@@ -0,0 +1,24 @@
29+Description: Ensure that tooltips are drawn on a rgba surface in Unity
30+ This has to be removed once better unity/CSD integration has landed
31+Author: Marco Trevisan <marco.trevisan@canonical.com>
32+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1508357
33+
34+Index: gtk+3.0-3.16.7/gtk/gtktooltip.c
35+===================================================================
36+--- gtk+3.0-3.16.7.orig/gtk/gtktooltip.c
37++++ gtk+3.0-3.16.7/gtk/gtktooltip.c
38+@@ -197,6 +197,14 @@ gtk_tooltip_init (GtkTooltip *tooltip)
39+ context = gtk_widget_get_style_context (window);
40+ gtk_style_context_add_class (context, GTK_STYLE_CLASS_TOOLTIP);
41+
42++ if (g_strcmp0 (g_getenv ("XDG_CURRENT_DESKTOP"), "Unity") == 0)
43++ {
44++ GdkVisual *visual;
45++ visual = gdk_screen_get_rgba_visual (gtk_widget_get_screen (window));
46++ if (visual)
47++ gtk_widget_set_visual (GTK_WIDGET (window), visual);
48++ }
49++
50+ atk_obj = gtk_widget_get_accessible (window);
51+ if (GTK_IS_ACCESSIBLE (atk_obj))
52+ atk_object_set_role (atk_obj, ATK_ROLE_TOOL_TIP);

Subscribers

People subscribed via source and target branches