Merge lp:~3v1n0/fogger/fix-crash-1025332 into lp:fogger

Proposed by Marco Trevisan (Treviño)
Status: Work in progress
Proposed branch: lp:~3v1n0/fogger/fix-crash-1025332
Merge into: lp:fogger
Diff against target: 28 lines (+0/-11)
1 file modified
data/ui/FoggerAppWindow.ui (+0/-11)
To merge this branch: bzr merge lp:~3v1n0/fogger/fix-crash-1025332
Reviewer Review Type Date Requested Status
Owais Lone Disapprove
Review via email: mp+115189@code.launchpad.net

Description of the change

FoggerAppWindow: removing invalid packing that lead to crashes

To post a comment you must log in.
Revision history for this message
Owais Lone (loneowais) wrote :

Awesome! Thanks a ton Marco!

I tested glade and it seems to add these lines on every save.
I guess I'll replace the widget completely with something else so I don't have to remove these lines alll the time after using glade.

Thanks a lot for helping me out with this :)

review: Disapprove
Revision history for this message
Owais Lone (loneowais) wrote :

Hi Marco,

I see you changed the status to in-progress. I've already replaced the GtkInfoBar with a normal toolbar and it works fine. Just want to make sure you don't waste time on this.

Thanks

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

No, don't worry... I sat not to show it as an active branch.

Unmerged revisions

199. By Marco Trevisan (Treviño)

FoggerAppWindow: removing invalid packing that lead to crashes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/ui/FoggerAppWindow.ui'
2--- data/ui/FoggerAppWindow.ui 2012-07-15 10:58:14 +0000
3+++ data/ui/FoggerAppWindow.ui 2012-07-16 17:19:18 +0000
4@@ -117,12 +117,6 @@
5 </packing>
6 </child>
7 </object>
8- <packing>
9- <property name="expand">False</property>
10- <property name="fill">False</property>
11- <property name="pack_type">end</property>
12- <property name="position">0</property>
13- </packing>
14 </child>
15 <child internal-child="action_area">
16 <object class="GtkButtonBox" id="infobar-action_area1">
17@@ -133,11 +127,6 @@
18 <placeholder/>
19 </child>
20 </object>
21- <packing>
22- <property name="expand">False</property>
23- <property name="fill">False</property>
24- <property name="position">1</property>
25- </packing>
26 </child>
27 </object>
28 <packing>

Subscribers

People subscribed via source and target branches