Merge lp:~3v1n0/compiz/unity-wm-shortcuts-0.9.10 into lp:compiz/0.9.11

Proposed by Marco Trevisan (Treviño) on 2013-09-16
Status: Superseded
Proposed branch: lp:~3v1n0/compiz/unity-wm-shortcuts-0.9.10
Merge into: lp:compiz/0.9.11
Diff against target: 1598 lines (+1409/-130) (has conflicts)
5 files modified
debian/changelog (+1357/-3)
debian/control (+8/-0)
debian/patches/series (+0/-1)
debian/patches/ubuntu-config.patch (+44/-36)
debian/patches/unity_support_test.patch (+0/-90)
Text conflict in debian/control
Text conflict in debian/patches/ubuntu-config.patch
To merge this branch: bzr merge lp:~3v1n0/compiz/unity-wm-shortcuts-0.9.10
Reviewer Review Type Date Requested Status
Compiz Maintainers 2013-09-16 Pending
Review via email: mp+185822@code.launchpad.net

Commit message

debian/patches/ubuntu-config.patch: remove grid custom keybindings for window management

We handle these directly in unity

To post a comment you must log in.
3789. By Marco Trevisan (Treviño) on 2013-09-16

debian/patches/ubuntu-config.patch: remove grid custom keybindings for window management

We handle these directly in unity

Unmerged revisions

3789. By Marco Trevisan (Treviño) on 2013-09-16

debian/patches/ubuntu-config.patch: remove grid custom keybindings for window management

We handle these directly in unity

3788. By Christopher Townsend on 2013-09-09

Alt-Tabbing or Launcher selecting a window that is over 50% in a different viewport should not switch the viewport nor change the placement of the window. The fix is to add an option to turn this behavior on or off. By default, the option is on, but Ubuntu is patched to turn it off to fix this bug. Fixes: https://bugs.launchpad.net/bugs/1092323.

Approved by Brandon Schaefer, PS Jenkins bot.

3787. By Christopher Townsend on 2013-09-09

Work done by Sam Spilsbury:
- Ensure that the frame region is always set as soon as the window is decorated.
- Further ensure that the window decoration isn't needlessly reset if the window already had one.
- Refactored XShape usage into a common function.
- Added tests to verify the behaviour of shape set on initially creating a decorated window and also upon changing the input frame window shape. Fixes: https://bugs.launchpad.net/bugs/1158267.

Approved by Brandon Schaefer, PS Jenkins bot.

3786. By PS Jenkins bot on 2013-08-28

Releasing 1:0.9.10+13.10.20130828.2-0ubuntu1 (revision 3785 from lp:compiz/0.9.10).

Approved by PS Jenkins bot.

3785. By Łukasz Zemczak on 2013-08-28

Fix the Replaces/Breaks version in the default plugin

3784. By Christopher Townsend on 2013-08-27

Ctrl-Alt-Del should open the gnome-system-monitor at the processes tab. This fix uses the commands plugin to override the default action. This includes:
 - Install the commands plugin by default.
 - Breaks/Replaces the compiz-plugins package for versions earlier than 0.9.10.
 - Patch commands.xml and integrated.xml to map gnome-system-monitor to Ctrl-Alt-Del by default.
 - Start the command plugin upon Compiz starting. Fixes: https://bugs.launchpad.net/bugs/890747.

Approved by PS Jenkins bot, Brandon Schaefer.

3783. By Christopher Townsend on 2013-08-26

Removed logic in the calculateWallOffset() function in the Expo plugin that only accounted for offsetting the expo animation on the left-most and top-most monitor. Also removed the TestNoOffsetIfOutputIsNotOrigin test since this test is now invalid. Fixes: https://bugs.launchpad.net/bugs/1031710.

Approved by Brandon Schaefer, PS Jenkins bot.

3782. By PS Jenkins bot on 2013-08-22

Releasing 1:0.9.10+13.10.20130822-0ubuntu1 (revision 3781 from lp:compiz/0.9.10).

Approved by PS Jenkins bot.

3781. By Łukasz Zemczak on 2013-08-21

Merge in saucy-released changelog, prepare revision to start off from with the new daily-release

3780. By Łukasz Zemczak on 2013-08-20

Remove the unity support test patch, we don't need it - also, the version in saucy already has this patch removed.

Approved by PS Jenkins bot, Andrea Azzarone.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-06-01 00:10:24 +0000
3+++ debian/changelog 2013-09-16 14:44:07 +0000
4@@ -1,8 +1,1362 @@
5-compiz (1:0.9.10-0ubuntu1) UNRELEASED; urgency=low
6-
7+compiz (1:0.9.10+13.10.20130828.2-0ubuntu1) saucy; urgency=low
8+
9+ [ Chris Townsend ]
10+ * Removed logic in the calculateWallOffset() function in the Expo
11+ plugin that only accounted for offsetting the expo animation on the
12+ left-most and top-most monitor. Also removed the
13+ TestNoOffsetIfOutputIsNotOrigin test since this test is now invalid.
14+ (LP: #1031710)
15+ * Ctrl-Alt-Del should open the gnome-system-monitor at the processes
16+ tab. This fix uses the commands plugin to override the default
17+ action. This includes: - Install the commands plugin by default. -
18+ Breaks/Replaces the compiz-plugins package for versions earlier than
19+ 0.9.10. - Patch commands.xml and integrated.xml to map gnome-system-
20+ monitor to Ctrl-Alt-Del by default. - Start the command plugin upon
21+ Compiz starting. (LP: #890747)
22+
23+ [ Łukasz 'sil2100' Zemczak ]
24+ * Fix the Replaces/Breaks version in the default plugin
25+
26+ [ Ubuntu daily release ]
27+ * Automatic snapshot from revision 3785
28+
29+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Wed, 28 Aug 2013 19:13:51 +0000
30+
31+compiz (1:0.9.10+13.10.20130822-0ubuntu1) saucy; urgency=low
32+
33+ [ Sam Spilsbury ]
34 * Bump version to 0.9.10
35
36- -- Sam Spilsbury <smspillaz@interpol> Thu, 25 Apr 2013 11:13:32 +0800
37+ [ Łukasz 'sil2100' Zemczak ]
38+ * Remove debian/patches/unity_support_test.patch:
39+ - Running the support test from compiz has bad side effects, from now
40+ on we run it from Xsession.d
41+ * Automatic snapshot from revision 3644
42+
43+ [ Iven Hsu ]
44+ * Opacify: Only dim the windows above the active window.(LP:
45+ #1189374). (LP: #1189374)
46+ * KWD: Fix compile errors with KDE 4.11. The KWin developers made
47+ kdecorationbridge.h private. See:
48+ http://lists.freedesktop.org/archives/compiz/2013-March/003479.html
49+ (LP: #1193792). (LP: #1193792)
50+
51+ [ Nikolay Martynov ]
52+ * When static switcher is enabled and has an option to show
53+ application icon turned on the icons are expected to be ~1/3 of a
54+ thumbnail (48px). Instead they are displayed in 512px size and
55+ completely cover everything. This change addresses this issue. See
56+ LP #1173914. (LP: #1173914, #1186426)
57+
58+ [ BryanFRitt ]
59+ * Fixed the non-working Annotate 'Clear' Button. Moved this option's
60+ CCSM position upwards to keep the button shortcuts together. (LP:
61+ #1202907). (LP: #1202907)
62+
63+ [ Mehrdad Afshari ]
64+ * Added "move window to previous monitor" feature to compiz Put
65+ plugin. (LP: #1178581)
66+
67+ [ Hu Kang ]
68+ * gtk-window-decorator: destroy action menu when any of the (close,
69+ min, max) buttons on the title bar is pressed. (LP: #1101648)
70+ * Remove redundant src/logmessage/include/core/logmessage.h (LP:
71+ #1067246). (LP: #1067246)
72+
73+ [ Steve Langasek ]
74+ * Fix for bug #763148 (with added test cases): when the desktop is
75+ resized, windows should stay on their original workspace. (LP:
76+ #763148)
77+
78+ [ Brandon Schaefer ]
79+ * Unrevert 3728, fix failing tests. Change the behaviour of
80+ undecorating windows. Previously when a window was undecorated, we
81+ would shift it back to an appropriate position according to its
82+ gravity member. That behaviour was problematic because in the
83+ StaticGravity case the window has to just stay in the same place.
84+ But then if you had a window with StaticGravity which then did get a
85+ decoration and later removed it, it would be placed as though it was
86+ decorated and appear to be in the wrong place. The correct behaviour
87+ is to place all windows as though they have decorations, and then
88+ when decorations are removed, to move the window back to the corner
89+ as indicated in its gravity and then expand its size to cover the
90+ obscured regions no longer hidden because the decorations went away.
91+ (LP: #1165343).   1. Completely remove decorOffsetMove and other
92+ related code from      decor.cpp. Put the logic to handle the
93+ window->input () - window->border ()      placement offset inside of
94+ setWindowFrameExtents instead. Now the window      will always be
95+ offset from its original non-decorated position to the new
96+      decorated position, rather than having to guess between
97+ decoration sizes.   2. Make saveGeometry and restoreGeometry work
98+ relative to window->border ()      as opposed to including it in the
99+ saved geometry. It is possible that the      border size might
100+ change during maximization, as such, we don't want to      save the
101+ position with the border before maximizing. Instead save the
102+ position      as if it were never decorated so that when the window
103+ is restored it can be      restored to its original position and
104+ then adjusted for its new border size.   3. Fix a few typoes in the
105+ tests.   4. Moved some commonly used matchers into compiz::testing
106+   5. Make COMPIZ_PLUGIN_DIR accept multiple directories and look in
107+ each one      of them for the plugin   6. Set COMPIZ_PLUGIN_DIR
108+ appropriately for each plugin that we wish to load      on startup
109+ so that we load locally built plugins as opposed to installed
110+      ones.   7. Uncomment compiz_discover_tests for the acceptance
111+ tests. Now they are      run by default. (LP: #1195522). (LP:
112+ #1195522, #1165343)
113+ * If we receive a stateNotifyChange, we check if we are in a max
114+ state. If so, overwrite the xwc with either X | W, or Y | H
115+ depending on the semi max state with the orig position before we
116+ went into a semi max state. This way when we leave any sort of max
117+ state the orig position is restored. If the window is being grabbed
118+ we do not overwrite the position, which it gets its own value at
119+ that point (instead of the orig pos). (LP: #892012)
120+
121+ [ Marco Trevisan (Treviño) ]
122+ * OpenGL Screen: Ignore the MSAA configs during initialization This
123+ fixes a crash with new MESA drivers and high monitor resolutions
124+ caused by the fact that we're accidentally using some MSAA configs
125+ with some drivers in Mesa 9.0. Taking in account the values of
126+ GLX_SAMPLES and GLX_SAMPLE_BUFFERS fixes the issue. See mesa bug
127+ https://bugs.freedesktop.org/show_bug.cgi?id=61182. (LP: #1174495)
128+ * OpenGLES Screen: Ignore the MSAA configs during initialization.
129+ * GLScreen: break the iteration as soon as we've found a valid egl
130+ config.
131+
132+ [ Michail Bitzes ]
133+ * Plugin wizard ported to OpenGL|ES. Use GLVertexBuffer. Enable
134+ building for GLES. Enable architectures armel and armhf. (LP:
135+ #1196003). (LP: #1196003)
136+
137+ [ Chris Townsend ]
138+ * Fixed issue where minimizing an unredirect full screen window would
139+ repaint the full screen window after minimizing it even though it
140+ isn't really there. . (LP: #1053895)
141+
142+ [ Sami Jaktholm ]
143+ * *Grid code: Prevent center and corner gridded windows from jumping
144+ viewports. (Thanks and credits for this go to Sami Jaktholm) Prevent
145+ top and bottom gridded windows from jumping viewports by making
146+ those semi-maximize horizontally. As those are actually semi-
147+ maximized horizontally, we will treat them as such and let core
148+ handle the restoring, just like we already do for vertically semi-
149+ maximized grid windows (left/right). Now "Strg+Super+Down" will
150+ restore top and bottom gridded windows correctly as well. Also
151+ multiple gridding to top, bottom, left or right will not overwrite
152+ the stored original size anymore. Restore windows also when
153+ workspace switcher (expo) is active. (Thanks and credits for this go
154+ to Sami Jaktholm) Allow cycling for all gridded windows if
155+ explicitly specified by the user in CCSM. Forbid cycling through
156+ different sizes for corner and center-gridded windows also per
157+ default, now fully fixing bug #878820 and following the design
158+ specification by Ayatana Design there, making behaviour consistent.
159+ Introduced 3 new bools: horzMaximizedGridPosition,
160+ vertMaximizedGridPosition, anyMaximizedGridPosition Used these bools
161+ inside the if condition checks. Simplified complicated if condition
162+ by removing redundant additional size check. Cleanup all around.
163+ *Grid xml: Added cycle_sizes bool option, which allows the user to
164+ choose the prefered behaviour (fixed versus flexible sizes on
165+ multiple presses on the same grid keyboard shortcut). Default of
166+ this option is off, cycling disabled as specified by design. Added
167+ punctuation where missing and removed it where usually is none.
168+ Fixed typos, improved description and titles. *Expo code: Tell grid
169+ when viewport change is in progress. (Thanks and credits for this go
170+ to Sami Jaktholm) (fixes: LP: #878820, LP: #879218, LP: #882754 and
171+ LP: #1082001, partially fixes: #1116538, #1164332). (LP: #882754,
172+ #878820, #1164332, #1082001, #879218, #1116538)
173+ * Grid: Check that composite and opengl ABIs are COMPIZ_COMPOSITE_ABI
174+ and COMPIZ_OPENGL_ABI instead of CORE_ABIVERSION. (LP: #1181461)
175+ * Fade: Fix a typo that causes fade to constantly damage windows with
176+ a modified saturation. (LP: #1159054)
177+ * Grid: Fix window misplacement if a window is restored but the size
178+ doesn't change. - Set isGridResized to false before configuring the
179+ window in GridScreen::restoreWindow. If the restored geometry is the
180+ same as current geometry, configureXWindow will trigger moveNotify
181+ instead of resizeNotify. As isGridResized is still true,
182+ GridWindow::moveNotify blocks the restoration movement and the
183+ pointer detaches from the decoration. - Don't use pointerBufs when
184+ calculating position of the restored window with snapback windows
185+ disabled. The window will be positioned a bit too high (or low) and
186+ the pointer detaches from decoration if the movement was actually
187+ tracked. This was a workaround for the first point and can be safely
188+ removed. (LP: #1115344)
189+ * Fix memory leaks in titleinfo plugin. (LP: #1101569, #1101454)
190+ * Expo plugin: 1) Always fetch the dndButton action in dndFini. The
191+ action given to dndFini might be a key or edge binding action if
192+ expo was terminated during window DnD. We shouldn't set their state
193+ to CompAction::StateInitButton or the bindings break. 2) Pass NULL
194+ action to termExpo if invoked from handleEvent Previously we passed
195+ the action of expoKey to termExpo which in turn passed it to
196+ dndFini. DndFini changed the action state to
197+ CompAction::StateInitButton that broke the keybinding. Now that
198+ dndFini fetches the dndButton action itself, there's no need to
199+ fetch it in handleEvent too as dndFini is the only one using the
200+ action. (LP: #1131106)
201+ * Expo: Cast denominators of integer divisions to floats before
202+ performing a matrix translation to viewports with the results.
203+ Otherwise rounding errors in cases the results are not an integers
204+ cause the viewports to be painted offscreen. (LP: #438580)
205+ * Port dbus introspection to compiz 0.9. - move xml creation to a
206+ separate class (IntrospectionResponse) for easier memory management
207+ (allocate buffer and writer in ctor, free in dtor). - move
208+ duplicated response sending code to a separate method that takes
209+ IntrospectionResponse and sends the resulting xml. - Refactor
210+ handle*IntrospectMessage to work with compiz 0.9 interfaces. This
211+ also fixes the broken list method which was a result of logic error.
212+ The code to invoke list handler was never reached. This fixes most
213+ of the issues noted in bug 749084. (LP: #749084)
214+ * Bias the current viewport in addWindowSizeChanges. If window is
215+ visible in the current viewport, use that viewport when calculating
216+ geometries in addWindowSizeChanges. Otherwise the current method is
217+ used. This way visible windows are maximized in the current
218+ viewport. However, offscreen windows won't jump back to the active
219+ viewport if window maximizes by itself or addWindowSizeChanges is
220+ called for some other reason. (LP: #776435)
221+ * Expo: Recompute glow quads if a desktop window is resized. (LP:
222+ #1090713). (LP: #1090713)
223+ * Decor: Use maximized border extents only if window is fully
224+ maximized. The decorator draws a normal border around semi-maximized
225+ windows. When maximized border extents were used for semi-maximized
226+ windows, compiz didn't reserve any space for the border in its
227+ geometry calculations. At least following problems are a result of
228+ this behavior: - Semi-maximized windows have 1px borders drawn on
229+ adjacent workspaces (LP: #986051). - Grid placed window overlaps the
230+ adjacent viewport (LP: #898870). (LP: #986051, #898870)
231+
232+ [ gebner@2b7e.org ]
233+ * Adding a uniform to a GLVertexBuffer that uses AutoProgram causes
234+ compiz to segfault. Example: gWindow->addShaders("cms", "",
235+ fragment_shader); gWindow->vertexBuffer()->addUniform("cms_lut",
236+ unit); // segfault happens later in PrivateVertexBuffer::render The
237+ patch modifies PrivateVertexBuffer::render to set the uniform on the
238+ generated AutoProgram instead of the provided program, which in this
239+ case is NULL, causing a segfault. (LP: #1162598). (LP: #1162598)
240+
241+ [ MC Return ]
242+ * Cube-addon (Cube Reflection and Deformation): If the user disables
243+ "Draw top face"/"Draw bottom face" we do not want to draw anything
244+ (LP: #1162484). The original, non-deformed caps will only work for
245+ the non-deformed cube, so we can just use the original function in
246+ that case. We need to clear the texture if no texture files are
247+ specified in "Image files", otherwise the old texture would still be
248+ drawn, even if all image files are removed (LP: #1162711). Now we
249+ will default back and use the cube cap colors and opacities defined
250+ in the "Desktop Cube" plugin (if "Draw top/bottom face" are enabled
251+ only, see above). This way the user can choose between (for
252+ top/bottom): 1. Do not draw a cube cap face at all ("Draw top/bottom
253+ face" option disabled) 2. Use color and opacity specified in
254+ "Desktop Cube" (empty images list) 3. Use a texture for the cap
255+ (image is in the list, which is default) Removed redundant mCurrent
256+ = mCurrent % mFiles.size (); calculation, this has already been
257+ done: cap->mCurrent = (cap->mCurrent + change + count) % count;
258+ count and change both need to be != 0 for mCurrent to change. Fixed
259+ indentation, removed redundant brackets and newlines, declaration
260+ and assignment of local variables in one line, if possible, minor
261+ cleanup. (LP: #1162484, LP: #1162711). (LP: #1162484, #1162711)
262+ * Stack (Window) Switcher (currently excluded from compilation): Fixed
263+ window title drawn although "Show Window Title" is disabled. (LP:
264+ #1070782). (LP: #1070782)
265+ * *Grid code: Prevent center and corner gridded windows from jumping
266+ viewports. (Thanks and credits for this go to Sami Jaktholm) Prevent
267+ top and bottom gridded windows from jumping viewports by making
268+ those semi-maximize horizontally. As those are actually semi-
269+ maximized horizontally, we will treat them as such and let core
270+ handle the restoring, just like we already do for vertically semi-
271+ maximized grid windows (left/right). Now "Strg+Super+Down" will
272+ restore top and bottom gridded windows correctly as well. Also
273+ multiple gridding to top, bottom, left or right will not overwrite
274+ the stored original size anymore. Restore windows also when
275+ workspace switcher (expo) is active. (Thanks and credits for this go
276+ to Sami Jaktholm) Allow cycling for all gridded windows if
277+ explicitly specified by the user in CCSM. Forbid cycling through
278+ different sizes for corner and center-gridded windows also per
279+ default, now fully fixing bug #878820 and following the design
280+ specification by Ayatana Design there, making behaviour consistent.
281+ Introduced 3 new bools: horzMaximizedGridPosition,
282+ vertMaximizedGridPosition, anyMaximizedGridPosition Used these bools
283+ inside the if condition checks. Simplified complicated if condition
284+ by removing redundant additional size check. Cleanup all around.
285+ *Grid xml: Added cycle_sizes bool option, which allows the user to
286+ choose the prefered behaviour (fixed versus flexible sizes on
287+ multiple presses on the same grid keyboard shortcut). Default of
288+ this option is off, cycling disabled as specified by design. Added
289+ punctuation where missing and removed it where usually is none.
290+ Fixed typos, improved description and titles. *Expo code: Tell grid
291+ when viewport change is in progress. (Thanks and credits for this go
292+ to Sami Jaktholm) (fixes: LP: #878820, LP: #879218, LP: #882754 and
293+ LP: #1082001, partially fixes: #1116538, #1164332). (LP: #882754,
294+ #878820, #1164332, #1082001, #879218, #1116538)
295+ * *Resizeinfo, xml changes: Added option for bold/normal font, default
296+ is still bold. Added option to change the font size (10-14), default
297+ is still 12 pixel. Enhanced and corrected a few tooltips.
298+ *Resizeinfo, code changes: Choose between PANGO_WEIGHT_BOLD and
299+ PANGO_WEIGHT_NORMAL. Use individual font size specified by the user
300+ in CCSM. Fixed computation of wrong damageRegion, it was
301+ additionally adding the window size, making it way too large.
302+ Removed useless declaration of int width and height. Declaration and
303+ assignment of local variables in one line, if possible. Minor
304+ indentation fixes. (LP: #1166195, LP: #1166196 and LP: #1166245).
305+ (LP: #1166195, #1166196, #1166245)
306+ * *Move xml: Implemented options to configure: "Snapoff Distance"
307+ "Snapback Semimaximized Windows" and "Snapback Distance" Improved a
308+ few tooltips. *Move code: Replaced SNAP_BACK and SNAP_OFF hardcoded
309+ constants and made those configurable. Implemented a strategy to
310+ snap off horizontally maximized windows by dragging them along the x
311+ axis. Implemented snapping back of horizontally maximized windows
312+ and fixed the snapping for vertically maximized windows (wrong
313+ cursor calculation). Fixed a few wrong calculations in the if
314+ condition checks responsible for snapping off and back. Merged if
315+ condition checks. Just compute various local variables if we do not
316+ return false. Removed redundant brackets, fixed indentation and
317+ improved readability. (LP: #1165198, LP: #1167933). (LP: #1167208,
318+ #1167933, #1165198)
319+ * Freewins xml: Fixed False->false and True->true typos. Credits and
320+ thanks for finding cause and fix go to raveit65 ! (LP: #1163606).
321+ (LP: #1163606)
322+ * Screenshot code cleanup: Used standard bool for mGrab. Merged a few
323+ if condition checks. Declaration and assignment of local variables
324+ in one line. Removed redundant brackets. Added and removed newlines
325+ to improve readability. Added a missing break (just a style issue).
326+ Fixed indentation. C++ style for comments.
327+ * *Move xml: Slightly improved long description of the move plugin.
328+ Implemented option to change the key move increment size. Removed
329+ <precision> settings as they just work for floats. *Move code:
330+ Removed hardcoded KEY_MOVE_INC variable. Introduced int
331+ moveIncrement to not have to execute optionGetKeyMoveInc () to get
332+ the value twice. (LP: #1167933, part 2). (LP: #1167933)
333+ * Shift Switcher code cleanup: Merged a few if-if condition checks.
334+ Declaration and assignment of local variables in one line. Removed
335+ redundant brackets. Added and removed newlines to improve
336+ readability. Fixed indentation.
337+ * Composite code cleanup: Merged a few if-if condition checks.
338+ Declaration and assignment of local variables in one line. Removed
339+ redundant brackets. Added and removed newlines to improve
340+ readability. Fixed indentation.
341+ * *Grid code: Simplified bool GridScreen::restoreWindow (...): If Grid
342+ has not touched the window we return false and let core do the dirty
343+ work. (Thanks go to Sam Spilsbury for suggesting this solution.)
344+ *Grid xml: Improved the CCSM Grid put_restore_key tooltip. (LP:
345+ #1116538). (LP: #1116538)
346+ * *Cube Gears: Added glDepthMask (GL_TRUE); and glDepthFunc (GL_LESS);
347+ to void GearsScreen::cubePaintInside (...) to fix the culling on
348+ multimonitor systems (green gear was always rendered in front). Also
349+ fixed indentation and removed some redundant newlines. (LP:
350+ #1168919). (LP: #1168919)
351+ * *Showmouse code cleanup: Assignment and declaration of local
352+ variables in one line. Removed redundant brackets. Fixed
353+ indentation. Removed and added newlines for better readability.
354+ *Showmouse code changes: Removed these redundant gl calls: glEnable
355+ (GL_TEXTURE_2D); glDisable (GL_TEXTURE_2D); (partially fixes LP:
356+ #1051290 and LP: #1051295). (LP: #1051290, #1051295)
357+ * *Workspacenames: New Feature: Implemented option to adjust vertical
358+ offset for top and bottom of screen workspacename placement. Set the
359+ default offset to 50 pixel. Cleanup: Added brackets to for loop. Use
360+ prefix increments. Indentation fixes. Added and removed newlines for
361+ better readability. Added comment. Removed TEXT_BORDER constant.
362+ Improved tooltips. (LP: #1172063). (LP: #1172063)
363+ * *Screenshot, xml: Better plugin summary. Added option to disable the
364+ drawing of the screenshot selection indicator. Added options to
365+ change color and opacity of the outline and the inside of the
366+ rectangle indicator, default colors have not been changed. Other
367+ minor improvements. *Screenshot, code: Introduced the new variable
368+ bool selectionSizeChanged, which is true if the size of the
369+ selection has changed. We just want to draw the screenshot selection
370+ box, if we are grabbed, the size has changed and the CCSM option to
371+ draw it is enabled. Do not render anything if indicator is disabled.
372+ Indicator colors are now configurable. Increased indicator box
373+ outline line width to 2.0. Only damage the full screen once, if the
374+ grab gets terminated, during grab just damage the region painted,
375+ which is the screenshot selection box (LP: #1172234). *SCreenshot,
376+ cleanup: Minor cleanup in the rendering code. Removed redundant
377+ #ifndef USE_GLES compiler option, GLES can cope with enabling and
378+ disabling GL_BLEND. Use prefix- instead of postfix increments.
379+ Declaration and assignment of local variables in one line. Reduced
380+ the scope of the variables x1, y1, x2 and y2. Replaced magic number
381+ 65535.0f with const float MaxUShortFloat = std::numeric_limits
382+ <unsigned short>::max ();. Indentation fixes. C++ style for
383+ comments, added comments. (LP: #1169353, LP: #1172234). (LP:
384+ #1169353, #1172234)
385+ * Shift Switcher code cleanup: Use prefix instead of postfix increment
386+ and decrement. Declaration and assignment of local variables in one
387+ line. Merged if statements. Added brackets to for loops. Fixed
388+ indentation. Added and removed newlines for better readability.
389+ Added comment.
390+ * Cube Addon .xml cleanup: Better plugin description. Uppercase
391+ titles. Improved tooltips and names.
392+ * Animation code cleanup: Use prefix- instead of postfix- in- and
393+ decrements. Removed redundant brackets. Added and removed newlines
394+ where appropriate. Fixed indentation.
395+ * Grid, code cleanup: Merged if statements. Replaced magic number
396+ 65535.0f with const float MaxUShortFloat = std::numeric_limits
397+ <unsigned short>::max ();. Use prefix- instead of postfix-increment.
398+ Removed redundant (float) casts. Removed redundant brackets. Added
399+ and removed newlines to improve readability. Minor indentation
400+ fixes.
401+ * Workspacenames .xml cleanup: Better description of the plugin's
402+ functionality. Improved tooltips.
403+ * Cube .xml cleanup: Better plugin description. Uppercase titles.
404+ Improved tooltips.
405+ * Shift Switcher .xml cleanup: Better description of the plugin's
406+ function. Fixed load before "bs" plugin typo -> it is the obs
407+ plugin. Created a "Switcher Mode" tab and moved Flip/Cover mode
408+ settings there. Created a subgroup for mouse-specific settings.
409+ Better tooltips with enhanced descriptions. Improved titles. Fixes
410+ all around (typos, etc.).
411+ * Refactor screenshot code to make it clearer and also to allow us to
412+ take screenshots in glPaintOutput as opposed to paint (). Taking
413+ screenshots in paint () was probably correct pre-GLES, but isn't
414+ really correct now - we want to be able to read off of the currently
415+ bound scratch framebuffer where we last painted the frame. Reading
416+ off the frontbuffer is an imprecise operation because the contents
417+ of both buffers are really undefined after a swap. In the case where
418+ we are not painting to a scratch framebuffer object, we'll just end
419+ up reading from the backbuffer anyways, which would be correct to do
420+ mid-frame. Also added the new static const GLenums
421+ DRAW_FRAMEBUFFER_BINDING and READ_FRAMEBUFFER_BINDING to opengl.h.
422+ (LP: #771875). (LP: #771875)
423+ * shift.h: Minor indentation fixes (mostly replaced tabs with spaces).
424+ * Show Desktop .xml cleanup: Improved plugin description. Renamed
425+ "Misc. Options" tab to "General" Improved tooltips.
426+ * Stack Window Switcher (stackswitch): Declaration and assignment of
427+ local variables in one line. Merged if condition checks. Use prefix
428+ de- and increments. Removed redundant brackets. Fixed indentation.
429+ Note: stackswitch is still excluded from compilation, because it has
430+ not been ported to the new GLES-compatible modern post-r3320 Compiz
431+ codebase yet, so this cannot really be tested at the moment (except
432+ in Compiz pre-r3320). Nevertheless this MP is needed to reduce the
433+ diff size for the GLES port of this plugin, which will follow soon.
434+ * Ring Switcher .xml cleanup: Better description of the "Ring
435+ Switcher". Uppercase for titles. More precise names for the tabs.
436+ Improved tooltip wording and descriptions. Changed the order of
437+ options in "General Options" tab: "Ring Windows" and "Overlay Icon"
438+ options are now on top. No settings have been changed.
439+ * *Shift Window Switcher, new features: Implemented new option to
440+ adjust the vertical offset of the text placement and fixed vertical
441+ placement calculation for top and bottom positions. The default
442+ offset is 50 pixels now. Removed hardcoded and redundant float
443+ border. Use 256x256 pixels resolution for icon textures, instead of
444+ 96x96. Minor indentation fixes. (LP: #1173684). (LP: #1173684)
445+ * Opacity, Brightness and Saturation (obs) .xml cleanup: Better plugin
446+ description. Improved setting names and tooltips.
447+ * Opacity, Brightness and Saturation (obs) code cleanup: Replaced
448+ #define MODIFIER_COUNT 3 with const unsigned short MODIFIER_COUNT =
449+ 3; (the variable MODIFIER_COUNT is needed in obs.h and obs.cpp). Use
450+ prefix instead of postfix increment. Merged if condition checks.
451+ Declaration and assignment of local variables in one line. Removed
452+ redundant brackets. Added and removed newlines if appropriate.
453+ Indentation fixes.
454+ * Improved and optimized ABI logic checks consistently for all
455+ plugins. (LP: #1178228). (LP: #1178228)
456+ * *Grid, code changes and fixes: Fixed segfault in Compiz when
457+ unchecking "Snap windows back to original size". This option now
458+ fully works and will snap back windows to current size, if they are
459+ dragged off via mouse. Fixed segfault in Compiz when unchecking
460+ "Snapoff Maximized/Semi-maximized Windows" - this option is now
461+ removed as this setting is configurable via "Move" plugin already.
462+ The snapoff threshold global setting is now configurable instead of
463+ hardcoded. Fixed broken cursor y-coordinate calculation. Fixed
464+ window placement cursor calculation for non-original-size-restored
465+ windows. Make sure grid-maximizing will never overwrite the windows'
466+ original size. Removed useless code until someone can convince me
467+ that we need it (LP: #1020857). This fixes the weird positioning
468+ (50, 50) when restoring mouse-grid-maximized windows via keyboard.
469+ Added missing ABI checks of OpenGL and Composite. *Grid, xml changes
470+ and fixes: Put Corners/Edges setting into own tab. New tab named
471+ "Resize Actions". Removed hardcoded SNAPOFF_THRESHOLD and made it
472+ configurable. Improved tooltips. Re-applied the quilt patch to the
473+ changed grid.xml.in. Changed the put_restore_key to
474+ "Ctrl+Super+Down" to fix restoring of grid-maximized windows for
475+ Ubuntu as well. (LP: #1172641) *Grid, minor code cleanup: Removed
476+ redundant (int) casts. Improved readability for the if condition
477+ checks. Added and removed newlines, if appropriate. Added comments.
478+ Indentation fixes. (LP: #745159, LP: #1020857, LP: #1172641). (LP:
479+ #1020857, #745159, #1172641)
480+ * Resize, minor code cleanup: Declaration and assignment of local
481+ variables in one line. Added and removed newlines, if appropriate.
482+ Removed redundant brackets. Indentation fixes.
483+ * Wobbly Windows, code cleanup: Declaration and assignment of local
484+ variables in one line. Merged if statements. Removed redundant
485+ brackets. Added missing break. Removed and added newlines for better
486+ readability. Fixed indentation.
487+ * Ring, Shift and Stack Window Switcher: Increased the non-power-of-2
488+ icon texture resolution from 96x96 to 512x512 pixels, in the case of
489+ the ring switcher from 64 to 512. Static Switcher: Replaced #define
490+ of MAX_ICON_SIZE with type-safe extern const unsigned short and set
491+ the icon resolution to 512 as well. Compiztoolbox: Increased the
492+ non-power-of-2 icon texture resolution const unsigned short
493+ ICON_SIZE from 48 to 512 and const unsigned int MAX_ICON_SIZE from
494+ 256 to 512 as well. Changed the type of MAX_ICON_SIZE from const
495+ unsigned int to const unsigned short. Scale: Increased the non-
496+ power-of-2 icon texture resolution from 96x96 to 512x512 pixels. KDE
497+ Compatibility: Increased the icon texture resolution from 256x256 to
498+ 512x512 pixels. (LP: #1173914). (LP: #1173914)
499+ * Removed redundant Expo configuration changes from ubuntu-
500+ config.patch: The reflection scale change, because reflection is
501+ disabled by default anyway. The inactive viewport saturation change
502+ from 100.0% to 40.0%, because this option does not work (and never
503+ did AFAICR), but if it finally gets fixed Expo's look would
504+ dramatically change. (LP: #1178965). (LP: #1178965)
505+ * Expo plugin: Fixed inactive viewports saturation setting being
506+ ignored. Let's "fade to grey"... :) (LP: #1179183). (LP: #1179183)
507+ * compizconfig/*, libdecoration/*: Use prefix instead of postfix de-
508+ and increments.
509+ * *Ring Switcher, new feature: Implemented "Vertical Offset" option
510+ with a default of 50 pixels. This allows the CCSM user to easily and
511+ exactly configure where the window title text should be displayed.
512+ Ring Switcher, cleanup: Simplified
513+ RingWindow::compareRingWindowDepth (...). Bail out of functions
514+ ASAP, do not initialize anything you do not need, if you exit
515+ anyway. Merged if condition checks. Declaration and assignment of
516+ local variables in one line. Removed redundant brackets. Added and
517+ removed newlines, if appropriate. Fixed indentation. (LP: #1173684).
518+ (LP: #1173684)
519+ * gtk/*, include/*, kde/*: Use prefix instead of postfix de- and
520+ increments.
521+ * Scale Addons code cleanup: Always bail out of functions ASAP, do not
522+ calculate unnecessary stuff before. Merged if-condition checks.
523+ Declaration and assignment of local variables in one line. Reduced
524+ the scope of some variables. Use pre- instead of postfix in- and
525+ decrements. Added and removed newlines where appropriate. Added
526+ brackets to foreach macro loops and removed them otherwise (if
527+ redundant). Fixed indentation. Note: This plugin has a huge chunk of
528+ code, which has been commented out. (apparantly/according to the
529+ comment, because it does not work) I was very cautious in
530+ refactoring this part of the code, as it currently is excluded from
531+ compilation and thus cannot be tested. TODO: Test, repair and
532+ integrate this code (or remove it if it is redundant). TODO: Fix
533+ half-broken "Exit Scale On Pull". TODO: Fix the scale-will-only-
534+ terminate-if-initiate_key-is-defined bug.
535+ * *EZoom (Enhanced Zoom Desktop) code cleanup: Optimized ABI check.
536+ Use prefix- instead of postfix-increment. Assignment and declaration
537+ of local variables in one line. Merged if statements. Removed
538+ redundant brackets. Fixed indentation. Added and removed newlines to
539+ improve readability. *EZoom (Enhanced Zoom Desktop) code changes:
540+ Replaced #define WIDTH (x2 - x1) with int width = x2 - x1; and
541+ #define HEIGHT (y2 - y1) with int height = y2 - y1; Replaced WIDTHOK
542+ and HEIGHTOK macros with local variables: WIDTHOK and HEIGHTOK just
543+ need to be calculated once and can then be used for all cases in
544+ void EZoomScreen::ensureVisibilityArea (...). static_cast <float>
545+ for int denominators in divisions. Removed these redundant gl calls:
546+ glEnable (GL_TEXTURE_2D); glDisable (GL_TEXTURE_2D); Zoom Box fixes:
547+ Enabled GL_BLEND for the zoom box to fix transparency issues. Made
548+ outline and fill color and transparency of the zoom box
549+ configurable. Outline width is 2.0 for the zoom box as well now.
550+ (same like for grid preview and screenshot selector outlines) Fixed
551+ zoom box damage handling. Minor restructuring in zoom box rendering
552+ code. Minor ezoom.xml.in cleanup and enhancements. Load after
553+ mousepoll. (fixes LP: #1171665, partially fixes LP: #1051290 and LP:
554+ #1051295). (LP: #1171665, #1051290, #1051295)
555+ * Wall: Fixed broken wall edge flipping functions: "Edge Flip Pointer"
556+ "Edge Flip Move" Removed void WallScreen::updateScreenEdgeRegions ()
557+ completely. This function not needed hereat all, no other plugin
558+ needs to re-define the screen edge regions by itself - just core
559+ should do that. The screen edge region updating also confused the
560+ edge flipping functionality. case ConfigureNotify: just breaks out
561+ now Added missing default: case and a break (just a style issue).
562+ Minor cleanup in bool WallScreen::initiateFlip (...). One
563+ declaration per line. Note: "Edge Flip DnD" still seems to be
564+ broken, but will be fixed in a follow-up proposal. (LP: #771448, LP:
565+ #858845). (LP: #771448, #858845)
566+ * Wallpaper .xml.in cleanup: Better plugin description. Improved
567+ option names. Better wording of tooltips. Removed redundant
568+ newlines. Wallpaper code cleanup: Use prefix instead of postfix
569+ increments. Declaration and assignment of variables in one line.
570+ Added some newlines to improve readability. Removed redundant
571+ brackets. Fixed indentation.
572+ * EZoom plugin, code improvements: Bail out of functions ASAP, do not
573+ calculate stuff you might not need. Replaced: if (zoom_level == 1.0f
574+ && zooms.at (out).newZoom == 1.0f) with: if (zoom_level == zooms.at
575+ (out).newZoom) because we always want to get out of here if the
576+ target level is the same as current zoom level, not only in the case
577+ both are 1.0f. EZoom plugin, code cleanup: Assignment and
578+ declaration of variables in one line, if possible. Added and removed
579+ some newlines. Merged if condition checks. Indentation fixes.
580+ * Mousepoll code cleanup: Removed the unused variables
581+ MP_OPTION_MOUSE_POLL_INTERVAL and MP_OPTION_NUM. Declaration and
582+ assignment of variables in one line. Added and removed newlines.
583+ Removed redundant brackets. Fixed indentation.
584+ * Annotate plugin, code cleanup: Use prefix instead of postfix
585+ increment. Declaration and assignment of local variables in one
586+ line. Removed redundant brackets. Added and removed newlines if
587+ appropriate. Fixed indentation. Annotate plugin, fixes: Use
588+ GL_LINE_LOOP to draw the rectangle outline as glRecti is not
589+ supported on GLES. Simplified the coordinate calculation as the
590+ offset is not really needed here.
591+ * Titleinfo, minor code cleanup: Declaration and assignment of local
592+ variables in one line. Removed redundant brackets. Added and removed
593+ newlines. Fixed indentation.
594+ * Text plugin code cleanup: Do not declare variables you do not need
595+ if you return anyway. Use prefix instead of postfix increments.
596+ Merged if condition checks. Declaration and assignment of variables
597+ in one line. Added and removed newlines. Removed redundant brackets.
598+ Fixed indentation.
599+ * ccp code cleanup: Declare variables if you need them, do not declare
600+ them if you return. Declare CCSSettingValue *val; outside the
601+ foreach loop. Use prefix instead of postfix increments. Merged if
602+ condition checks. Declaration and assignment of variables in one
603+ line. Removed redundant brackets. Added and removed newlines. Fixed
604+ indentation.
605+ * Commands, minor code cleanup: Declaration and assignment of
606+ variables in one line. Return ASAP. Added and removed newlines.
607+ Fixed indentation.
608+ * Cube code cleanup: Replaced 0xffff with GLfloat MaxUShortFloat =
609+ static_cast <GLfloat> (std::numeric_limits <unsigned short>::max
610+ ());. Use prefix instead of postfix de- and increments. Declaration
611+ and assignment of variables in one line. Declare variables shortly
612+ before you need them. Merged if condition checks. Added missing
613+ breaks (just a style issue). Added and removed brackets. Added and
614+ removed newlines. Fixed indentation.
615+ * action.cpp and actions.cpp code cleanup: Use pre- instead of postfix
616+ increment. Declaration and assignment of variables in one line.
617+ Merged if condition checks. Removed redundant brackets. Added and
618+ removed newlines. Fixed indentation.
619+ * Rotate Cube code cleanup: Simplified a few calculations of this
620+ type: (360.0 / (x * 2.0)) == 180 / x Declaration and assignment of
621+ variables in one line. Use pre- instead of postfix de- and
622+ increments. Merged if condition checks. Added and removed newlines
623+ and brackets. Fixed indentation. Added TODO comments.
624+ * Fade plugin, minor code cleanup: Declaration and assignment of local
625+ variables in one line. Merged if condition checks. Use pre- instead
626+ of postfix de- and increments. Removed redundant brackets. Added and
627+ removed newlines. Fixed indentation.
628+ * Opacify code cleanup: Declaration of local variables outside of
629+ loops. Calculate activeOpacity and targetOpacity just once, not for
630+ each window. Use prefix instead of postfix increments. Merged if
631+ condition checks. Declaration and assignment of local variables in
632+ one line. Added and removed newlines. Removed redundant brackets.
633+ Fixed indentation. Opacify, functionality fix: Improved the toggling
634+ logic by setting isToggle in the constructor according to the
635+ startup setting, then calling setFunctions (isToggle);,which then
636+ calls screen->handleEventSetEnabled (os, os->isToggle); to fix
637+ Opacify ignoring the "Toggle Opacify on by default" setting. (LP:
638+ #787814). (LP: #787814)
639+ * Widget, minor code cleanup: Declaration and assignment of local
640+ variables in one line. Merged if condition checks. Added and removed
641+ newlines. Added default case to switch (just a style issue). Removed
642+ redundant brackets. Fixed indentation.
643+ * window.cpp code cleanup: Declare variables outside of loops. Reduced
644+ the scope of variables. Do not assign values to variables if those
645+ values are not used. Always bail out of functions ASAP, do not
646+ calculate stuff you might not need. Use pre- instead of postfix de-
647+ and increments. Declaration and assignment of variables in one line.
648+ Merged if condition checks. Added and removed brackets. Added and
649+ removed newlines. Fixed indentation. Added TODOs (removal of magic
650+ numbers).
651+ * Fix for cube.cpp, regression r3720 - Inner sides of cube invisible
652+ now. Wrong variable type was accidentially used, cullInv is of type
653+ int, not bool. (LP: #1183852). (LP: #1184852, #1183852)
654+ * src/output*.cpp cleanup: Return ASAP, do not calculate stuff you do
655+ not need. Declaration and assignment of variables in one line.
656+ Declare local variables outside of loops. Use prefix instead of
657+ postfix increment. Added and removed newlines. Fixed indentation.
658+ * Expo, code cleanup: Declaration of local variables outside of loops.
659+ Use prefix instead of postfix increments. Declaration and assignment
660+ of local variables in one line, if possible. Reduced the scope of
661+ some variables. Removed redundant brackets. Used static_cast <>
662+ (type) instead of (type) cast. Added and removed newlines if
663+ appropriate. Fixed indentation. Added TODOs. Expo, speed
664+ improvements: Do not calculate screen->vpSize ().width () and
665+ screen->vpSize ().height () multiple times, instead save them in the
666+ unsigned ints vpCountHorz and vpCountVert and use those variables
667+ instead. Speed up the curve calculations by using additional
668+ variables to save results to not have to re-calculate those all the
669+ time. The new variables introduced are degToRad, screenWidth,
670+ screenWidthSquared, curveDistSquaredPlusQuarter,
671+ pOne2MinusCurveDist, v0Squared and v2Squared. Also introduced const
672+ float halfGapX = gapX / 2.0 and used this variable in the
673+ calculations of curveDistance and curveRadius. Simplified
674+ calculations of this type: (M_PI / 180.0f) * curveAngle / 2.0, which
675+ is equal to: (M_PI / 360.0f) * curveAngle Do not call
676+ optionGetGroundSize (); twice, instead save the value in the float
677+ groundSize and use that variable in the following calculations.
678+ Removed the creation of the redundant bool hide, which is just used
679+ once in an if-condition check. It does not help to have this bool.
680+ Try to avoid redundant GL_BLEND state changes, they are expensive -
681+ only enable GL_BLEND if it is disabled and just disable it, if it
682+ was disabled before, otherwise do nothing. Try to avoid redundant GL
683+ filter changes - just query the filter state if the mipmap option in
684+ CCSM is enabled. Also just set back the filter to the previous state
685+ if we actually changed it, otherwise do nothing. -5.5f * 2 = -11.0f.
686+ No need to calculate M_PI / 180.0f 720 times: Calculate this value
687+ once instead and save it in the const float mpi, use mpi in the
688+ following looped calculations. Use const int scw in the same loop
689+ instead of calling screen->width () 360 times. glow.cpp: Massively
690+ increased calculation speed of the glow texture: No need for any
691+ macros here -> removed them and replaced them with local variables.
692+ Precalculate values, store them in local variables and use those in
693+ the following calculations (new variables are the ints winRealX,
694+ winRealY, winRealWidth, winRealHeight, halfWinRealWidth,
695+ halfWinRealHeight, xPlusHalfWidth, yPlusHalfHeight, xPlusGlowOff,
696+ yPlusGlowOff, xMinusGlowOff, yMinusGlowOff and the float glowPart).
697+ Used w->geometry ().widthIncBorders () and w->geometry
698+ ().heightIncBorders () to determine winRealWidth and winRealHeight.
699+ Expo, fixes: Do not force "One wall per output" on the user, if his
700+ displays use different resolutions. "One big wall" makes a lot of
701+ sense for many multi-screen configs, where not all of the screens
702+ have exactly the same resolution, so if the user explicitely chooses
703+ this mode, Compiz should respect the user's choice. (LP: #1009592).
704+ (LP: #1009592)
705+ * Compiz, redundant and outdated files cleanup: Removed outdated NEWS
706+ files. Removed outdated AUTHORS and ChangeLog files. Removed
707+ plugins/freewins/COPYING - we do not need another copy of the GPL v2
708+ here. Removed another copy of the GPL v2 from plugins/workarounds.
709+ This will reduce package sizes, download time and bring some order
710+ to chaos.
711+ * Expo, .xml.in fixes: Better description of the plugin. Improved and
712+ fixed tooltips. Moved the "Curve Strength" option closer to
713+ "Deformation". Refreshed the quilt patch for Ubuntu: There is no
714+ need to set the default distance to 0.005 as this setting has no
715+ effect without deformation. Set default multi-screen mode to "One
716+ wall per output" for Ubuntu, because "One big wall" works now for
717+ all display configurations and could potentially change the
718+ appearance for Ubuntu users. (LP: #1074487). (LP: #1074487)
719+ * Added contribute directory. Added QtCreatorConfig.xml, a
720+ configuration file for Qt Creator, which adjusts Qt Creator's C++
721+ indentation style to be the same that is used in the Compiz project
722+ (X11, mixed spaces and tabs).
723+ * Mousepoll: Fixed mousepoll version mismatch. (COMPIZ_MOUSEPOLL_ABI
724+ was missing) (LP: #1195659). (LP: #1195659)
725+ * Expo: Simplified the GL filter handling.
726+ * Fixed broken text in all plugins (missing COMPIZ_TEXT_ABI). (LP:
727+ #1196493). (LP: #1196493)
728+ * CCSM: Fixed vertical alignment of the text on the stylized keys.
729+ (Shift, Super, Ctrl, Alt) (LP: #1196345). (LP: #1196345)
730+ * Thumbnail, cleanup: Merged if condition checks. Declaration of
731+ variables when they are needed (C++ style). Removed redundant
732+ brackets. Removed useless "/* Could someone please explain how this
733+ works */" comment. Removed extern const unsigned short
734+ TEXT_DISTANCE, because this variable does not exist anymore (value
735+ is configurable already). Changed if (something > 0.0) to if
736+ (something), 10 times. Changed pointedWin = 0; to pointedWin =
737+ NULL;. Used centerX () and centerY () abstractions from
738+ compiz::window::Geometry to determine the icon center coordinates.
739+ Added and removed newlines, if appropriate. Fixed indentation.
740+ Thumbnail, code speedup: Return ASAP, do not calculate stuff you
741+ might not need. No need for WIN_W (w) and WIN_H (w) macros, removed
742+ those and replaced them with the local variables int winWidth, int
743+ winHeight, int dockWidth and int dockHeight. No need for WIN_X (w)
744+ and WIN_Y (w) macros, replaced those with int dockX and int dockY.
745+ Introduced int tHeight = thumb.height;, int tWidth = thumb.width;,
746+ int halfTWidth = tWidth / 2; and int halfTHeight = tHeight / 2; and
747+ used those variables in the following calculations. Use
748+ igMidPoint[0] and igMidPoint[1] as arguments in the screen-
749+ >outputDeviceForPoint (arg1, arg2) function, instead of re-
750+ calculating the arguments again. Thumbnail, GL speedup: Introduced
751+ GLfloat wxPlusWidth = wx + width;, GLfloat wyPlusHeight = wy +
752+ height;, GLfloat wxPlusWPlusOff = wxPlusWidth + off;, GLfloat
753+ wyPlusHPlusOff = wyPlusHeight + off;, GLfloat wxMinusOff = wx - off;
754+ and GLfloat wyMinusOff = wy - off; and used those coordinates in the
755+ vertexData arrays. No need to re- calculate those values multiple
756+ times. Just query optionGetShowDelay () once and use int showDelay
757+ later. We just enable blending if it is currently disabled and
758+ disable blending only, if it was disabled before.
759+ * src/session.cpp cleanup: Declaration and assignment of local
760+ variables in one line. (this *should* fix bug #1101405) Use pre-
761+ instead of postfix increments. Added and removed newlines. Added
762+ missing break (just a style issue). Fixed indentation. (LP:
763+ #1101405). (LP: #1101405)
764+ * Firepaint, code cleanup: Declare variables outside of loops.
765+ Declaration and assignment of local variables in one line. Use pre-
766+ instead of postfix increment. Removed redundant newlines. Removed
767+ redundant casts. (from (float) optionGetFireColor) Removed redundant
768+ brackets. Added missing break (style issue only). Added comment and
769+ TODO. Fixed indentation. Firepaint, speedup: We just enable GL_BLEND
770+ if it is disabled and we just disable GL_BLEND if it was disabled
771+ before. Introduced the GLfloats xMinusW, xPlusW, yMinusH and yPlusH
772+ to store calculated coordinates instead of recalculating them
773+ multiple times. Introduced float fireLife = optionGetFireLife ();,
774+ float fireWidth = optionGetFireSize ();, float fireHeight =
775+ fireWidth * 1.5f; and bool mystFire = optionGetFireMystical (); and
776+ used those variables inside the loop. Firepaint, .xml.in cleanup:
777+ Firepaint now has 2 tabs, 'General' and 'Particle Settings'. The
778+ name of this plugin is Firepaint, <short> should not contain the
779+ description. Better description of the plugin. Uppercase option
780+ titles. Punctuation for tooltips. Improved tooltips. Firepaint,
781+ fixes: Initialize all class member variables in the ParticleSystem::
782+ ParticleSystem () ctor (LP: #1101512, LP: #1101580). (LP: #1101512,
783+ #1101580)
784+ * img* plugins code cleanup: Always bail out of function ASAP, do not
785+ calculate stuff you might not need. Declare variables outside of
786+ loops so they won't be re-declared in each loop. Use prefix instead
787+ of postfix increments. Declaration and assignment of variables in
788+ one line. Merged if condition checks. Added and removed brackets.
789+ Added and removed newlines, if appropriate. Minor code structure
790+ improvements, declare variables when you need them, not much
791+ earlier. Fixed indentation.
792+ * Text, speed improvements: Introduced const float halfPi = PI / 2.0f;
793+ and const float triHalfPi = halfPi * 3; and used those to draw the
794+ rounded background. Introduced GLfloat xPlusWidth = x + width; and
795+ GLfloat yMinusHeight = y - height; and used those coordinates for
796+ the vertexData array. Text, cleanup: Declaration of local variables
797+ outside of loops. Fixed indentation.
798+ * cube.cpp, code cleanup: #include "privates.h", not <privates.h>.
799+ Merged if condition checks. Declaration of variables, where you need
800+ them to improve the code structure and readability. Use C++ standard
801+ bool for topDir, bottomDir, allCaps and mCapsPainted[output] (bool
802+ true/false instead Bool TRUE/FALSE). Initialize all of the class
803+ member variables in the constructor. Replaced if (priv->mSky.size ()
804+ > 0) with if (!priv->mSky.empty ()). Removed redundant brackets.
805+ Fixed indentation. Added TODO. cube.cpp, code speedup: Do not call
806+ optionGetInactiveOpacity () twice, instead save the value as float
807+ inactiveOpacity and use this variable in the following calculation.
808+ Introduced the variables float halfHsize = hsize / 2.0; and float
809+ tsSize = 360.0f / size; and used those in following calculations to
810+ not have to recalculate those values multiple times. Do not
811+ calculate M_PI / sides and 2 * M_PI / sides multiple times in loops,
812+ instead save those values in the GLfloats mps and tmps and use those
813+ values inside the loops. Use GLdouble mDist2 = 0.5 / mDistance; in
814+ the GLdouble clipPlane* arrays, instead of recalculating this value
815+ multiple times. Use GLfloat oneMinusFStepX = 1.0f - fStepX; and
816+ GLfloat oneMinusFStepY = 1.0f - fStepY; instead of calculating those
817+ values multiple times. Use float outputWidth = outputPtr->width ();
818+ and float outputHeight = outputPtr->height (); instead of calling
819+ the functions multiple times. Introduced the GLfloat normInvert =
820+ 0.5f * invert; and used this variable instead of recalculating this
821+ value multiple times. Introduced the GLfloats mSkyWidth and
822+ mSkyHeight and used those in the following loops instead of calling
823+ mSkySize.width () and mSkySize.height () multiple times. Try to
824+ avoid redundant GL_BLEND state changes, because OpenGL will blindly
825+ change the global state, no matter what it currently is set to and
826+ that state change is expensive. So we query and save the actual
827+ blending state in the variable GLboolean glBlendEnabled =
828+ glIsEnabled (GL_BLEND); and just enable it if it isn't already and
829+ just disable it, if it was disabled before. (LP: #1101422, LP:
830+ #1195977) cube.cpp, other fixes: Return false in function
831+ PrivateCubeScreen::updateGeometry (int, int) if sides should ever be
832+ 0, which should never happen, but should make Coverity happy. (LP:
833+ #1101541) Initialize all class member variables in the
834+ PrivateCubeScreen:: PrivateCubeScreen (CompScreen *) constructor.
835+ (mTc, mNOutput, mOutput, mOutputMask, mCleared, mCapsPainted) (LP:
836+ #1101575). (LP: #1195977, #1101541, #1101422, #1101575)
837+ * plugins/ezoom/src/ezoom.cpp: Also initialize xtrans and ytrans in
838+ the ctors. Just just enable blending if it is disabled and just
839+ disable it if it was disabled before. Introduced the variables
840+ oWidth, oHeight, halfOWidth and halfOHeight to speed up following
841+ calculations. Return ASAP, do not calculate possibly redundant
842+ stuff. Declaration and assignment of local variables in one line.
843+ Improved readability. Added and removed newlines. Minor indentation
844+ fixes. plugins/ezoom/ezoom.xml.in: Removed redundant whitespaces
845+ from a tooltip. (LP: #1101572). (LP: #1101572)
846+
847+ [ Hu Kang stevenhooke11@gmail.com ]
848+ * workarounds.cpp: Fix typo in call to XShapeSelectInput. (LP:
849+ #1167284). (LP: #1167284)
850+ * Use XIDefineCursor rather than XDefineCursor. compiz should show a
851+ busy cursor during the application startup stage. the corresponding
852+ code is in scr/screen.cpp:
853+ cps::StartupSequenceImpl::updateStateFeedback () the patch changes
854+ all XDefineCursor to XIDefineCursor (see XInput2 extension) (LP:
855+ #1179155). (LP: #1179155)
856+
857+ [ Łukasz 'sil2100' Zemczak ]
858+ * Qt is stupid since it uses the stupid X11 protocol - let's not set
859+ all the attributes (especially override_redirect) every time, only
860+ in cases when it's actually needed (LP: #1141079). (LP: #1141079)
861+
862+ [ Andrea Azzarone ]
863+ * Satisfy matchers on getProperty as soon as they are set. The order
864+ of evaluation for matchers in Google Mock appears to be undefined -
865+ this means that we can't rely on the first argument being matched
866+ first and the second argument being matched afterwards. In turn,
867+ this means that any GValue may be passed to a GValueMatch which, by
868+ a design flaw, is unable to handle any values of a type it does not
869+ expect (at least not without an API change). It will silently pass
870+ the incorrect type to g_type_get_* which causes internal assertion
871+ failures. At the moment we're just interleaving the calls to
872+ getProperty and get_property - that way the expectations are
873+ satisfied and go away as soon as they're set. This in turn means
874+ that Google Mock only has to traverse one matcher rather than
875+ multiple matchers. (LP: #1187468). (LP: #1187468)
876+ * Extends invisible borders to the title bar too. (LP: #717444). (LP:
877+ #717444)
878+ * Disable grid/put_maximize_key on ubuntu.
879+ * Port to new gmock. Disable some faling tests because of weird leaks.
880+ (LP: #1185265)
881+ * Update window geo only on new decoration size only if mapped. (LP:
882+ #1198000). (LP: #1198000)
883+ * Disable show_desktop_key by default on ubuntu. Will provide the same
884+ option under the unityshell panel. (LP: #1204664)
885+ * Use Glib::RefPtr<Glib::Source> in glib_integration_test and compiz
886+ core too. After the fix of bug
887+ https://bugzilla.gnome.org/show_bug.cgi?id=561885
888+ Glib::Source::~Source is called when both Source::unreference() and
889+ SourceCallbackData::destroy_notify_callback() are called. (LP:
890+ #1214459)
891+
892+ [ Sam Spilsbury ]
893+ * Also take into account the gravity requirements when validating
894+ reposition requests. Get most of that code under test too. (LP:
895+ #1159324). (LP: #1159324)
896+ * Install compizconfig backends to the correct libdir (LP: #1163611).
897+ (LP: #1163611)
898+ * Don't timeout after 3000ms when asking compiz for a startup message.
899+ It can sometimes take longer in the valgrind case. Also timeouts are
900+ bad design for tests. (LP: #1169170). (LP: #1169170)
901+ * Check for USE_GCONF if USE_GSETTINGS is unavailable when
902+ instantiating different types of settings objects. (LP: #1169172).
903+ (LP: #1169172)
904+ * Link in CMAKE_THREAD_LIBS_INIT through GTEST_BOTH_LIBRARIES so it
905+ gets included in everything. Remove redundant links. Require
906+ FindThreads.cmake. (LP: #1171364). (LP: #1171364)
907+ * Explicitly check if the smart pointers are null rather than
908+ converting implicitly to bool as boost 1.53 now marks the bool
909+ operator as explicit (LP: #1172601). (LP: #1172601)
910+ * Rewrite screen size change tests. 1. Rename the overly-terse
911+ variables names to variables names that have some significance 2.
912+ Split the giant three-test structure into multiple tests each with
913+ only one assert 3. Remove a lot of redundant calculation 4. Remove
914+ magic numbers peppered throughout the code. Use constants and
915+ express asserts as relationships between those constants. 5.
916+ Refactor some of the more common test-advancement code (such as
917+ changing the screen size) into the test fixture as common methods.
918+ (LP: #1167983). (LP: #1167983)
919+ * Refactor screenshot code to make it clearer and also to allow us to
920+ take screenshots in glPaintOutput as opposed to paint (). Taking
921+ screenshots in paint () was probably correct pre-GLES, but isn't
922+ really correct now - we want to be able to read off of the currently
923+ bound scratch framebuffer where we last painted the frame. Reading
924+ off the frontbuffer is an imprecise operation because the contents
925+ of both buffers are really undefined after a swap. In the case where
926+ we are not painting to a scratch framebuffer object, we'll just end
927+ up reading from the backbuffer anyways, which would be correct to do
928+ mid-frame. Also added the new static const GLenums
929+ DRAW_FRAMEBUFFER_BINDING and READ_FRAMEBUFFER_BINDING to opengl.h.
930+ (LP: #771875). (LP: #771875)
931+ * Set libcompizconfig_libdir before the modules get a chance to see
932+ it. (LP: #1173799). (LP: #1173799)
933+ * Try to launch tests on another server if there's tests running in
934+ parallel. Provide our own compiz_xorg_gtest_main and subclass
935+ xorg::testing::Environment to try and launch tests on another
936+ display if there's tests running on one already. This isn't by any
937+ means perfect - there are still race conditions surrounding
938+ XOpenDisplay and parallel test runs but it makes a more smaller time
939+ gap for conditions such as:  1. Client has a server grab on the
940+ display we're checking     and won't let go.  2. Two servers get
941+ launched on one port and one set of tests     interfere with the
942+ other. It also means that we're now unable to configure the display
943+ port, log file and config file on the command line. But we weren't
944+ using that anyways. Finally, the logs now point to
945+ /tmp/Compiz.Xorg.GTest.displaynum.log (LP: #1178514). (LP: #1178514)
946+ * Fix some files not installing: 1. gsettings schemas never get added
947+ to the install_manifest list because we use install (CODE) so we
948+ need to add a custom uninstall target for those, and also need to
949+ recompile on uninstall too 2. Run the gtk-update-icon-cache stage
950+ during install for ccsm and also add icon-theme.cache to the
951+ uninstall target (LP: #1168475). (LP: #1168475)
952+ * Wall: Fixed broken wall edge flipping functions: "Edge Flip Pointer"
953+ "Edge Flip Move" Removed void WallScreen::updateScreenEdgeRegions ()
954+ completely. This function not needed hereat all, no other plugin
955+ needs to re-define the screen edge regions by itself - just core
956+ should do that. The screen edge region updating also confused the
957+ edge flipping functionality. case ConfigureNotify: just breaks out
958+ now Added missing default: case and a break (just a style issue).
959+ Minor cleanup in bool WallScreen::initiateFlip (...). One
960+ declaration per line. Note: "Edge Flip DnD" still seems to be
961+ broken, but will be fixed in a follow-up proposal. (LP: #771448, LP:
962+ #858845). (LP: #771448, #858845)
963+ * Add a small compiz_autopilot_acceptance_tests binary based on gtest.
964+ This will find autopilot and run a predefined list of tests, wrapped
965+ up in the familiar google test format. The predefined list is
966+ basically a bunch of tests which effectively interact with the
967+ window manager. (LP: #1170013). (LP: #1170013)
968+ * Change the behaviour of undecorating windows. Previously when a
969+ window was undecorated, we would shift it back to an appropriate
970+ position according to its gravity member. That behaviour was
971+ problematic because in the StaticGravity case the window has to just
972+ stay in the same place. But then if you had a window with
973+ StaticGravity which then did get a decoration and later removed it,
974+ it would be placed as though it was decorated and appear to be in
975+ the wrong place. The correct behaviour is to place all windows as
976+ though they have decorations, and then when decorations are removed,
977+ to move the window back to the corner as indicated in its gravity
978+ and then expand its size to cover the obscured regions no longer
979+ hidden because the decorations went away. (LP: #1165343). (LP:
980+ #1165343)
981+ * Added some new hooks to PluginClassHandler to allow a VTable to
982+ specify if loaded. PluginClassHandler::get () was designed to simply
983+ instantiate an instance of that class for the core structure, but it
984+ did this without checking if the plugin was loaded. Added some new
985+ methods to PluginClassHandler exposed by LoadedPluginClassBridge and
986+ only accessible by those who implement PluginKey to specify globally
987+ whether or not a plugin is actually loaded, so that
988+ PluginClassHandler can return accordingly. Integration and unit
989+ tests added as appropriate (LP: #1169620) (LP: #1101026). (LP:
990+ #1101026, #1169620)
991+ * Satisfy matchers on getProperty as soon as they are set. The order
992+ of evaluation for matchers in Google Mock appears to be undefined -
993+ this means that we can't rely on the first argument being matched
994+ first and the second argument being matched afterwards. In turn,
995+ this means that any GValue may be passed to a GValueMatch which, by
996+ a design flaw, is unable to handle any values of a type it does not
997+ expect (at least not without an API change). It will silently pass
998+ the incorrect type to g_type_get_* which causes internal assertion
999+ failures. At the moment we're just interleaving the calls to
1000+ getProperty and get_property - that way the expectations are
1001+ satisfied and go away as soon as they're set. This in turn means
1002+ that Google Mock only has to traverse one matcher rather than
1003+ multiple matchers. (LP: #1187468). (LP: #1187468)
1004+ * Revert revision 3278.
1005+ * Immediately update the window matrices and regions if the number of
1006+ textures changed. (LP: #1189369). (LP: #1189369)
1007+ * Provide a basic decor plugin acceptance test suite. This change
1008+ provides a simple acceptance test suite for the decor plugin. It
1009+ creates a fake window decorator (cdt::FakeDecorator) and allows
1010+ users to create fake decorations (eg cdt::FakePixmapDecoration)
1011+ which can be serialized as decoration properties and set on windows
1012+ under xorg-gtest. It also launches compiz with the opengl, composite
1013+ and decor plugins loaded and runs some basic tests. Among them:
1014+ BaseDecorAcceptance. Startup: Basic canary "can we start compiz with
1015+ these plugins" test
1016+ FakeDecoratorSessionOwnerNameSetOnSelectionOwner: Create a fake
1017+ decorator, ensure that libdecoration sets our session name "fake" on
1018+ the selection owner FakeDecoratorReceiveClientMessage: Create fake
1019+ decorator, ensure that libdecoration posts a client message to the
1020+ root window announcing that the new decorator exists.
1021+ DecorationSupportsWindowType: Create a fake decorator, announce
1022+ support for the WINDOW type decorations and ensure that the correct
1023+ atom is set on the session owner window.
1024+ DecorationSupportsPixmapType: Create a fake decorator, announce
1025+ support for the PIXMAP type decorations and ensure that the correct
1026+ atom is set on the session owner window.
1027+ DecorFakeDecoratorAcceptance. WindowDefaultFallbackNoExtents: By
1028+ default, newly created windows should recieve a fallback decoration
1029+ but they should not have any frame extents.
1030+ DecorWithPixmapDefaultsAcceptance. These tests create a default
1031+ pixmap decoration to use in the hypothetical situation that the
1032+ window decorator hasn't yet generated a decoration for this window.
1033+ FallbackRecieveInputFrameNotify: Verify that we get a
1034+ _COMPIZ_WINDOW_DECOR_INPUT_FRAME property set on the client when it
1035+ is created and mapped (eg, an input frame window was annonuced to be
1036+ created) FallbackHasInputFrameInParent: Verify that a second window
1037+ exists in the frame window after this message was recieved.
1038+ FallbackNormalWindowExtentOnDecoration: Verify that
1039+ _NET_FRAME_EXTENTS is set to the default window extents for the
1040+ default decoration when the window was mapped.
1041+ FallbackNormalWindowInputOnFrame: Verify that the input window
1042+ matches the extents set. PixmapDecoratedWindowAcceptance. These
1043+ tests create a new window and an associated unique decoration for
1044+ that window. MaximizeBorderExtentsOnMaximize: Maximize the window
1045+ and ensure that the correct border extents are used.
1046+ MaximizeBorderExtentsOnVertMaximize: Vertically maximize the window
1047+ and ensure that the correct border extents are used.
1048+ MaximizeBorderExtentsOnHorzMaximize: Horizontally maximize the
1049+ window and ensure that the correct border extents are used.
1050+ MaximizeFrameWindowSizeEqOutputSize: Maximie the window and ensure
1051+ that the frame window exactly equals the output size.
1052+ VertMaximizeFrameWindowSizeEqOutputYHeight: Maximize the window and
1053+ ensure that the frame window's Y and Height values are consistent
1054+ with the output size. HorzMaximizeFrameWindowSizeEqOutputXWidth:
1055+ Ditto horizontal maximization.
1056+ DISABLED_VertMaximizeFrameWindowSizeSameXWidth: Maximize the window
1057+ vertically and ensure that the frame window's border-relative X
1058+ position and width does not change. This test is disabled, as the
1059+ behavior in compiz is currently broken, (but it means that we can
1060+ fix it later and enable the test).
1061+ DISABLED_HorzMaximizeFrameWindowSizeSameYHeight Maximize the window
1062+ horizontally and ensure that the frame window's border-relative Y
1063+ position and height does not change. This test is disabled, as the
1064+ behavior in compiz is currently broken, (but it means that we can
1065+ fix it later and enable the test). (LP: #1188900). (LP: #1188900)
1066+ * Only mark for no further instantiations once we've finished
1067+ destructing the plugin (LP: #1193596). (LP: #1193596)
1068+ * Add more acceptance tests for the decor plugin.
1069+ PixmapDecoratedWindowAcceptance. UndecoratedWindowExpandToOrigSize
1070+ Test that upon undecoration, the window has exactly the same
1071+ geometry as it did before decoration.
1072+ DISABLED_UndecorateStaticGravityWindow Tests that for windows with a
1073+ static gravity, the window has exactly the same geometry as it did
1074+ before decoration. Disabled, as core is currently not moving the
1075+ window with the static gravity back to where it started.
1076+ AdjustmentExtents/PixmapDecorationAdjustment.
1077+ AdjustRestoredWindowBorderMovesClient/P Test that changing the
1078+ border extents causes the client window's absolute geometry to
1079+ change. DISABLED_AdjustRestoredWindowBorderShrinkClient/P Tests that
1080+ changing the border extents causes the client window's absolute
1081+ geometry to shrink by the amount of border. Disabled, as the current
1082+ behavior is to expand the frame window as opposed to shrinking the
1083+ client (but this will be changed).
1084+ DISABLED_ClientExpandsAsBorderShrinks/P Tests that as the border
1085+ shrinks away, the client expands back to its original size.
1086+ Disabled, as the current behavior is to expand the frame window as
1087+ opposed to shrinking the client (but this will be changed).
1088+ DISABLED_ClientExpandsAsBorderShrinksWhilstMaximized/P Tests that
1089+ even if the client is maximized, if the restored border shrinks away
1090+ it demaximizes back to the same position while also accounting for
1091+ any change in the restored window border size. Disabled, as the
1092+ current behavior is to expand the frame window as opposed to
1093+ shrinking the client (but this will be changed).
1094+ DISABLED_ClientExpandsAsBorderShrinksWhilstUndecorated/P Tests that
1095+ even when the client is not permitted to be decorated because the
1096+ decoration hint was removed, when it is redecorated it will be moved
1097+ to the correct position taking into account any changes in its
1098+ border size. Disabled, as the current behavior is to expand the
1099+ frame window as opposed to shrinking the client (but this will be
1100+ changed). DISABLED_AdjustRestoredWindowInputNoMoveClient/P Tests
1101+ that adjusting the input extents (as independent from the border
1102+ extents) of the client does not cause the client to move. Disabled,
1103+ as this behavior appears to be broken in core. Move the
1104+ "GetImmediateParent" function into the compiz::testing namespace so
1105+ that it can be used by other tests. (LP: #1188900)
1106+ * Unrevert 3728, fix failing tests. Change the behaviour of
1107+ undecorating windows. Previously when a window was undecorated, we
1108+ would shift it back to an appropriate position according to its
1109+ gravity member. That behaviour was problematic because in the
1110+ StaticGravity case the window has to just stay in the same place.
1111+ But then if you had a window with StaticGravity which then did get a
1112+ decoration and later removed it, it would be placed as though it was
1113+ decorated and appear to be in the wrong place. The correct behaviour
1114+ is to place all windows as though they have decorations, and then
1115+ when decorations are removed, to move the window back to the corner
1116+ as indicated in its gravity and then expand its size to cover the
1117+ obscured regions no longer hidden because the decorations went away.
1118+ (LP: #1165343).   1. Completely remove decorOffsetMove and other
1119+ related code from      decor.cpp. Put the logic to handle the
1120+ window->input () - window->border ()      placement offset inside of
1121+ setWindowFrameExtents instead. Now the window      will always be
1122+ offset from its original non-decorated position to the new
1123+      decorated position, rather than having to guess between
1124+ decoration sizes.   2. Make saveGeometry and restoreGeometry work
1125+ relative to window->border ()      as opposed to including it in the
1126+ saved geometry. It is possible that the      border size might
1127+ change during maximization, as such, we don't want to      save the
1128+ position with the border before maximizing. Instead save the
1129+ position      as if it were never decorated so that when the window
1130+ is restored it can be      restored to its original position and
1131+ then adjusted for its new border size.   3. Fix a few typoes in the
1132+ tests.   4. Moved some commonly used matchers into compiz::testing
1133+   5. Make COMPIZ_PLUGIN_DIR accept multiple directories and look in
1134+ each one      of them for the plugin   6. Set COMPIZ_PLUGIN_DIR
1135+ appropriately for each plugin that we wish to load      on startup
1136+ so that we load locally built plugins as opposed to installed
1137+      ones.   7. Uncomment compiz_discover_tests for the acceptance
1138+ tests. Now they are      run by default. (LP: #1195522). (LP:
1139+ #1195522, #1165343)
1140+ * Add a simple script for making releases.
1141+ * Port to new gmock. Disable some faling tests because of weird leaks.
1142+ (LP: #1185265)
1143+ * Don't add the frame to the toplevel stack if it hasn't been created
1144+ yet. In the event that a window is unreparented or destroyed, we
1145+ usually need to add its frame window to the toplevel window stack
1146+ until the time at which we recieve a DestroyNotify for it, as there
1147+ may be incoming ConfigureNotify events puporting to stack other
1148+ windows relative to that frame. However, this does not apply in the
1149+ case where we have not yet received a CreateNotify for the frame
1150+ window. In that case, it is not possible for any stacking requests
1151+ to be made relative to this window, so it does not need to be added
1152+ immediately. Instead, we can add it at the time that we recieve a
1153+ CreateNotify for it as a regular override redirect window until the
1154+ time that it is later destroyed. (LP: #1171314). (LP: #1171314)
1155+ * Remove redundant src/logmessage/include/core/logmessage.h (LP:
1156+ #1067246). (LP: #1067246)
1157+ * Adjust acceptance tests for the fix to LP: #1198000 1. Always set
1158+ frame extents before updating the frame 2. Added
1159+ COMPIZ_NO_CONFIGURE_BUFFER_LOCKS so that we don't have to deal with
1160+ the delayed configure requests logic in the tests where it does not
1161+ help 3. Split restoredDecorationSize in to
1162+ restoredDecorationBorderSize and restoredDecorationInputSize so that
1163+ we can measure the size of the decoration both in terms of its
1164+ visible and invisible border 4. Wait for the default decoration
1165+ properly 5. Capture the initial geometry of the window with and
1166+ without decorations when the window gets its first decoration. Use
1167+ these values to calculate the size changes in the window from then
1168+ on instead of its creation values 6. Just flag when the window was
1169+ first decorated in setWindowFrameExtents rather than checking if it
1170+ is mapped. We only want to not resize the window once. (LP:
1171+ #1198000)
1172+ * Release version 0.9.10.0
1173+ * Bump VERSION to 0.9.10.2
1174+
1175+ [ Ubuntu daily release ]
1176+ * Automatic snapshot from revision 3781
1177+
1178+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Thu, 22 Aug 2013 06:58:07 +0000
1179+
1180+compiz (1:0.9.9~daily13.04.18.1~13.04-0ubuntu4) saucy; urgency=low
1181+
1182+ * Remove debian/patches/unity_support_test.patch
1183+ - Running the support test from compiz has bad side effects, so we no
1184+ longer require this patch (also LP: #1066764)
1185+
1186+ -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Mon, 12 Aug 2013 13:11:18 +0200
1187+
1188+compiz (1:0.9.9~daily13.04.18.1~13.04-0ubuntu3) saucy; urgency=low
1189+
1190+ * No change rebuild to drop the buggy libhybris depends
1191+
1192+ -- Sebastien Bacher <seb128@ubuntu.com> Thu, 08 Aug 2013 10:50:09 +0200
1193+
1194+compiz (1:0.9.9~daily13.04.18.1~13.04-0ubuntu2) saucy; urgency=low
1195+
1196+ * Fixing FTBFS in saucy:
1197+ - Cherry pick boost1.53 fixes from upstream branch.
1198+ - Do not enable -Wno-unused-private-field.
1199+
1200+ -- Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu.com> Mon, 01 Jul 2013 20:56:50 +0100
1201+
1202+compiz (1:0.9.9~daily13.04.18.1~13.04-0ubuntu1) raring; urgency=low
1203+
1204+ [ Ken VanDine ]
1205+ * Revert 3636 from lp:compiz/0.9.9 to fix Qt apps getting window decorations
1206+ placed behind the panel. (LP: #1165343)
1207+ - This reintroduces bug 1159324, Guake window appears placed by offset
1208+ non-existent decoration
1209+ * [regression-r3635] Guake window appears placed by offset non-
1210+ existent decoration (LP: #1159324)
1211+
1212+ [ Ubuntu daily release ]
1213+ * Automatic snapshot from revision 3650
1214+
1215+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Thu, 18 Apr 2013 05:46:57 +0000
1216+
1217+compiz (1:0.9.9~daily13.04.15-0ubuntu1) raring; urgency=low
1218+
1219+ [ Łukasz 'sil2100' Zemczak ]
1220+ * [regression-r3606] Compiz broken with QT menus/floating controls in
1221+ 13.04 (LP: #1141079)
1222+
1223+ [ Ubuntu daily release ]
1224+ * Automatic snapshot from revision 3648
1225+
1226+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Mon, 15 Apr 2013 04:17:27 +0000
1227+
1228+compiz (1:0.9.9~daily13.04.10-0ubuntu1) raring; urgency=low
1229+
1230+ [ Steve Langasek ]
1231+ * Adding/Removing an external monitor causes open windows to move to
1232+ another workspace (LP: #763148)
1233+
1234+ [ Ubuntu daily release ]
1235+ * Automatic snapshot from revision 3646
1236+
1237+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Wed, 10 Apr 2013 04:03:14 +0000
1238+
1239+compiz (1:0.9.9~daily13.04.05-0ubuntu1) raring; urgency=low
1240+
1241+ [ Daniel van Vugt ]
1242+ [Daniel van Vugt]
1243+ * Merge lp:compiz/raring back in to lp:compiz/0.9.9 so we can maintain
1244+ raring from lp:compiz/0.9.9. The last common revision was 3629, so...
1245+ * Automatic snapshot from revision 3629
1246+
1247+ [ MC Return <mc.return@gmx.net>, Sam Spilsbury <smspillaz@gmail.com>, Sam Spilsbury ]
1248+ * Workspacenames plugin: Damage handling is broken and the plugin
1249+ damages the full screen instead of just the painted part of it (LP:
1250+ #1162246)
1251+ * [regression-r3320] Workspacenames Plug-in: Flickering background on
1252+ appearance, fade-out seems smooth (LP: #1075578)
1253+
1254+ [ Brandon Schaefer ]
1255+ * [regression] Shortcut overlay does not hide when modifier key is
1256+ pressed (LP: #1075207)
1257+ * Unity blocks other programs from binding globally to Super+* (* =
1258+ any key) (LP: #950160)
1259+
1260+ [ Sam Spilsbury <Sam@ACER-SUSE.SUSE>, Sam <Sam@XPS-SUSE.XPS>, Sam Spillaz <smspillaz@gmail.com>, Sam Spilsbury <smspillaz@gmail.com>, Sam Spilsbury <sam.spilsbury@canonical.com>, MC Return <mc.return@gmx.net>, Sam Spilsbury <Sam@XPS-SUSE.site>, users <warlock@banana.(none)>, Scott Moreau <oreaus@gmail.com>, Danny Baumann <dannybaumann@web.de>, warlock <warlock.cc@gmail.com>, Sam Spilsbury <smspillaz@XPS-U.(none)>, warlock <warlock@opencompositing.org>, Roland Bär ]
1261+ * [needs-packaging] Wishlist: Missing plug-In: Freewins (Freely
1262+ Transformable Windows) (LP: #1012194)
1263+
1264+ [ MC Return <mc.return@gmx.net>, Sam Spilsbury <sam.spilsbury@canonical.com>, Sam Spilsbury ]
1265+ * Showdesktop plugin: Wishlist/Feature-Request: Implement "Random"
1266+ movement direction option (LP: #1161343)
1267+
1268+ [ MC Return ]
1269+ * Wall plugin: Redundant if (screen->otherGrabExist ("wall", 0)) check
1270+ in WallScreen::initiateFlip (LP: #1160878)
1271+ * CompWindow::syncPosition () function is empty and calls to it
1272+ redundant (LP: #1160624)
1273+ * Showdesktop plugin: Wishlist/Feature-Request: Implement "Random"
1274+ movement direction option (LP: #1161343)
1275+ * Multimonitor: Grid plugin: Wrong calculation of top left mouse-grid-
1276+ resize corner coordinates (LP: #1139835)
1277+
1278+ [ Sam Spilsbury ]
1279+ * After Upgrade to Boost 1.53 Build Fails (LP: #1131864)
1280+ * Showdesktop plugin: Wishlist/Feature-Request: Implement "Random"
1281+ movement direction option (LP: #1161343)
1282+ * [regression] Unmaximized windows can't be closed, minimized, moved
1283+ (LP: #1158161)
1284+ * Latest compiz update breaks Java Swing decorations (LP: #1138517)
1285+ * [regression-r3635] Guake window appears placed by offset non-
1286+ existent decoration (LP: #1159324)
1287+ * [regression-r3623] Wallpaper bleeds through on top right when a
1288+ window is opened maximized (LP: #1140505)
1289+ * xiphos crashed with SIGSEGV in sword::VerseKey::copyFrom() (LP:
1290+ #1159234)
1291+
1292+ [ Ubuntu daily release ]
1293+ * Automatic snapshot from revision 3644
1294+
1295+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Fri, 05 Apr 2013 04:03:10 +0000
1296+
1297+compiz (1:0.9.9~daily13.03.29-0ubuntu1) raring; urgency=low
1298+
1299+ [ Michael Terry ]
1300+ * [regression-r3635] Guake window appears placed by offset non-
1301+ existent decoration (LP: #1159324)
1302+
1303+ [ Ubuntu daily release ]
1304+ * Automatic snapshot from revision 3641
1305+
1306+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Fri, 29 Mar 2013 07:23:54 +0000
1307+
1308+compiz (1:0.9.9~daily13.03.25-0ubuntu1) raring; urgency=low
1309+
1310+ [ Michael Terry ]
1311+ * [regression] Unmaximized windows can't be closed, minimized, moved
1312+ (LP: #1158161)
1313+
1314+ [ MC Return ]
1315+ * Multimonitor: Grid plugin: Wrong calculation of top left mouse-grid-
1316+ resize corner coordinates (LP: #1139835)
1317+
1318+ [ Ubuntu daily release ]
1319+ * Automatic snapshot from revision 3639
1320+
1321+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Mon, 25 Mar 2013 04:02:57 +0000
1322+
1323+compiz (1:0.9.9~daily13.03.20-0ubuntu1) raring; urgency=low
1324+
1325+ [ Sam Spilsbury ]
1326+ * Latest compiz update breaks Java Swing decorations (LP: #1138517)
1327+ * [regression-r3623] Wallpaper bleeds through on top right when a
1328+ window is opened maximized (LP: #1140505)
1329+
1330+ [ Ubuntu daily release ]
1331+ * Automatic snapshot from revision 3636
1332+
1333+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Wed, 20 Mar 2013 04:02:51 +0000
1334+
1335+compiz (1:0.9.9~daily13.03.08-0ubuntu1) raring; urgency=low
1336+
1337+ [ Brandon Schaefer ]
1338+ * [regression] Shortcut overlay does not hide when modifier key is
1339+ pressed (LP: #1075207)
1340+ * Unity blocks other programs from binding globally to Super+* (* =
1341+ any key) (LP: #950160)
1342+
1343+ [ Automatic PS uploader ]
1344+ * Automatic snapshot from revision 3633
1345+
1346+ -- Automatic PS uploader <ps-jenkins@lists.canonical.com> Fri, 08 Mar 2013 10:34:21 +0000
1347+
1348+compiz (1:0.9.9~daily13.03.06-0ubuntu1) raring; urgency=low
1349+
1350+ [ Łukasz 'sil2100' Zemczak ]
1351+ * Latest compiz update breaks Java Swing decorations (LP: #1138517)
1352+
1353+ [ Automatic PS uploader ]
1354+ * Automatic snapshot from revision 3631
1355+
1356+ -- Automatic PS uploader <ps-jenkins@lists.canonical.com> Wed, 06 Mar 2013 13:26:19 +0000
1357+
1358+compiz (1:0.9.9~daily13.03.01-0ubuntu1) raring; urgency=low
1359+
1360+ [ MC Return ]
1361+ * Multiple minor code and style issues (LP: #1134251)
1362+
1363+ [ Automatic PS uploader ]
1364+ * Automatic snapshot from revision 3629
1365+
1366+ -- Automatic PS uploader <ps-jenkins@lists.canonical.com> Fri, 01 Mar 2013 04:02:19 +0000
1367
1368 compiz (1:0.9.9~daily13.02.28-0ubuntu1) raring; urgency=low
1369
1370
1371=== modified file 'debian/control'
1372--- debian/control 2013-08-19 16:32:52 +0000
1373+++ debian/control 2013-09-16 14:44:07 +0000
1374@@ -168,9 +168,17 @@
1375 ${shlibs:Depends},
1376 ${misc:Depends},
1377 Replaces: compiz-plugins-main-default (<< 1:0.9.8),
1378+<<<<<<< TREE
1379 compiz-plugins (<< 1:0.9.10),
1380+=======
1381+ compiz-plugins (<< 1:0.9.10+13.10.20130828.1),
1382+>>>>>>> MERGE-SOURCE
1383 Breaks: compiz-plugins-main-default (<< 1:0.9.8),
1384+<<<<<<< TREE
1385 compiz-plugins (<< 1:0.9.10),
1386+=======
1387+ compiz-plugins (<< 1:0.9.10+13.10.20130828.1),
1388+>>>>>>> MERGE-SOURCE
1389 Description: OpenGL window and compositing manager - default plugins
1390 Compiz brings to life a variety of visual effects that make the Linux desktop
1391 easier to use, more powerful and intuitive, and more accessible for users
1392
1393=== modified file 'debian/patches/series'
1394--- debian/patches/series 2013-02-28 18:48:38 +0000
1395+++ debian/patches/series 2013-09-16 14:44:07 +0000
1396@@ -5,5 +5,4 @@
1397 ccsm_add_first_run_warning.patch
1398 ccsm_disable_unity_checkbox.patch
1399 99_valid_ccsm_desktop_file.patch
1400-unity_support_test.patch
1401 100_workaround_virtualbox_hang.patch
1402
1403=== modified file 'debian/patches/ubuntu-config.patch'
1404--- debian/patches/ubuntu-config.patch 2013-09-06 22:46:03 +0000
1405+++ debian/patches/ubuntu-config.patch 2013-09-16 14:44:07 +0000
1406@@ -682,42 +682,6 @@
1407 unsigned int DEFAULT_VIEWPORT_HEIGHT = 1;
1408
1409 bool Advance (Display *d, bool r)
1410---- a/plugins/grid/grid.xml.in
1411-+++ b/plugins/grid/grid.xml.in
1412-@@ -23,17 +23,16 @@
1413- <option name="put_center_key" type="key">
1414- <_short>Put Center Key</_short>
1415- <_long>Move window to the center.</_long>
1416-- <default>&lt;Control&gt;&lt;Alt&gt;KP_5</default>
1417- </option>
1418- <option name="put_left_key" type="key">
1419- <_short>Put Left Key</_short>
1420- <_long>Move window to the left edge.</_long>
1421-- <default>&lt;Control&gt;&lt;Alt&gt;KP_4</default>
1422-+ <default>&lt;Control&gt;&lt;Super&gt;Left</default>
1423- </option>
1424- <option name="put_right_key" type="key">
1425- <_short>Put Right Key</_short>
1426- <_long>Move window to the right edge.</_long>
1427-- <default>&lt;Control&gt;&lt;Alt&gt;KP_6</default>
1428-+ <default>&lt;Control&gt;&lt;Super&gt;Right</default>
1429- </option>
1430- <option name="put_top_key" type="key">
1431- <_short>Put Top Key</_short>
1432-@@ -68,12 +67,11 @@
1433- <option name="put_maximize_key" type="key">
1434- <_short>Maximize Key</_short>
1435- <_long>Maximize window.</_long>
1436-- <default>&lt;Control&gt;&lt;Alt&gt;KP_0</default>
1437- </option>
1438- <option name="put_restore_key" type="key">
1439- <_short>Restore</_short>
1440- <_long>Restore window to it's original size. Note: Use the same shortcut you are using to unmaximize a window to be able to restore grid-maximized windows.</_long>
1441-- <default>&lt;Alt&gt;F5</default>
1442-+ <default>&lt;Control&gt;&lt;Super&gt;Down</default>
1443- </option>
1444- </group>
1445- <group>
1446 --- a/plugins/ezoom/ezoom.xml.in
1447 +++ b/plugins/ezoom/ezoom.xml.in
1448 @@ -30,7 +30,7 @@
1449@@ -852,6 +816,7 @@
1450 </option>
1451 <option name="ground_color1" type="color">
1452 <_short>Ground Color (near)</_short>
1453+<<<<<<< TREE
1454 --- a/compizconfig/integration/gnome/gsettings/org.compiz.integrated.gschema.xml
1455 +++ b/compizconfig/integration/gnome/gsettings/org.compiz.integrated.gschema.xml
1456 @@ -10,6 +10,9 @@
1457@@ -893,3 +858,46 @@
1458 </option>
1459 </group>
1460 <group>
1461+=======
1462+--- a/compizconfig/integration/gnome/gsettings/org.compiz.integrated.gschema.xml
1463++++ b/compizconfig/integration/gnome/gsettings/org.compiz.integrated.gschema.xml
1464+@@ -10,6 +10,9 @@
1465+ <key type="s" name="command-screenshot">
1466+ <default>"gnome-screenshot"</default>
1467+ </key>
1468++ <key type="as" name="run-command-21">
1469++ <default>["&lt;Control&gt;&lt;Alt&gt;Delete"]</default>
1470++ </key>
1471+ <key type="as" name="run-command-12">
1472+ <default>["Disabled"]</default>
1473+ </key>
1474+@@ -46,6 +49,9 @@
1475+ <key type="as" name="run-command-1">
1476+ <default>["Disabled"]</default>
1477+ </key>
1478++ <key type="s" name="command-21">
1479++ <default>"/usr/bin/gnome-system-monitor -p"</default>
1480++ </key>
1481+ <key type="s" name="command-12">
1482+ <default>""</default>
1483+ </key>
1484+--- a/plugins/commands/commands.xml.in
1485++++ b/plugins/commands/commands.xml.in
1486+@@ -117,7 +117,7 @@
1487+ <option name="command20" type="string">
1488+ <_short>Command line 20</_short>
1489+ <_long>Command line to be executed in shell when run_command20 is invoked</_long>
1490+- <default></default>
1491++ <default>/usr/bin/gnome-system-monitor -p</default>
1492+ </option>
1493+ </group>
1494+ <group>
1495+@@ -205,6 +205,7 @@
1496+ <option name="run_command20_key" type="key">
1497+ <_short>Run command 20</_short>
1498+ <_long>A keybinding that when invoked, will run the shell command identified by command20</_long>
1499++ <default>&lt;Control&gt;&lt;Alt&gt;Delete</default>
1500+ </option>
1501+ </group>
1502+ <group>
1503+>>>>>>> MERGE-SOURCE
1504
1505=== removed file 'debian/patches/unity_support_test.patch'
1506--- debian/patches/unity_support_test.patch 2012-10-09 13:05:32 +0000
1507+++ debian/patches/unity_support_test.patch 1970-01-01 00:00:00 +0000
1508@@ -1,90 +0,0 @@
1509-# Description: force llvmpipe in the unity profile if we are in the grey zone,
1510-# meaning: the card and drivers have opengl support, however,
1511-# it doesn't met unity requirements (opengl < 1.4, no vertex
1512-# shaders support…).
1513-# Forwarded: not-needed
1514-# Bug: https://launchpad.net/bugs/1039155
1515-# Author: Daniel van Vugt <daniel.van.vugt@canonical.com>
1516-=== modified file 'src/plugin.cpp'
1517---- old/src/plugin.cpp 2012-07-30 10:15:41 +0000
1518-+++ new/src/plugin.cpp 2012-10-09 10:52:12 +0000
1519-@@ -116,6 +116,60 @@
1520- }
1521-
1522- static bool
1523-+setOpenGLPluginEnvironment ()
1524-+{
1525-+ /*
1526-+ * Check if the hardware is adequate for Unity and if not, use LLVMpipe.
1527-+ * Unfortunately the design of Mesa requires that this be done before
1528-+ * libGL is loaded, which means before the opengl plugin is loaded.
1529-+ */
1530-+ bool toggledLLVM = false;
1531-+
1532-+ if (!getenv ("LIBGL_ALWAYS_SOFTWARE"))
1533-+ {
1534-+ const char *profile = getenv ("COMPIZ_CONFIG_PROFILE");
1535-+ if (profile && !strcmp (profile, "ubuntu"))
1536-+ {
1537-+ int result = system ("/usr/lib/nux/unity_support_test");
1538-+ int status = WEXITSTATUS (result);
1539-+ compLogMessage ("core", CompLogLevelInfo,
1540-+ "Unity is %s",
1541-+ status == 0 ? "fully supported by your hardware." :
1542-+ status == 127 ? "undetectable" :
1543-+ "not supported by your hardware. "
1544-+ "Enabling software rendering instead (slow).");
1545-+ if (status > 0 && status < 127)
1546-+ {
1547-+ setenv ("LIBGL_ALWAYS_SOFTWARE", "1", 1);
1548-+ toggledLLVM = true;
1549-+ }
1550-+ }
1551-+ }
1552-+
1553-+ return toggledLLVM;
1554-+}
1555-+
1556-+static void
1557-+unsetUnityshellPluginEnvironment ()
1558-+{
1559-+ unsetenv ("LIBGL_ALWAYS_SOFTWARE");
1560-+}
1561-+
1562-+static void
1563-+setPluginEnvironment (const char *name)
1564-+{
1565-+ if (!strcmp (name, "opengl"))
1566-+ setOpenGLPluginEnvironment ();
1567-+}
1568-+
1569-+static void
1570-+unsetPluginEnvironment (const char *name)
1571-+{
1572-+ if (!strcmp (name, "unityshell"))
1573-+ unsetUnityshellPluginEnvironment ();
1574-+}
1575-+
1576-+static bool
1577- dlloaderLoadPlugin (CompPlugin *p,
1578- const char *path,
1579- const char *name)
1580-@@ -127,6 +181,8 @@
1581- if (cloaderLoadPlugin (p, path, name))
1582- return true;
1583-
1584-+ setPluginEnvironment (name);
1585-+
1586- if (path)
1587- {
1588- file = path;
1589-@@ -197,6 +253,8 @@
1590- if (!loaded && dlhand)
1591- dlclose (dlhand);
1592-
1593-+ unsetPluginEnvironment (name);
1594-+
1595- return loaded;
1596- }
1597-
1598-

Subscribers

People subscribed via source and target branches