Merge lp:~3v1n0/compiz/migration-script-gsettings-sync into lp:compiz/0.9.13

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: 4073
Merged at revision: 4078
Proposed branch: lp:~3v1n0/compiz/migration-script-gsettings-sync
Merge into: lp:compiz/0.9.13
Diff against target: 30 lines (+12/-6)
2 files modified
debian/00_remove_obsolete_plugins_in_unity_session_v2.py (+11/-5)
debian/compiz-gnome.migrations (+1/-1)
To merge this branch: bzr merge lp:~3v1n0/compiz/migration-script-gsettings-sync
Reviewer Review Type Date Requested Status
Andrea Azzarone Approve
Review via email: mp+301148@code.launchpad.net

Commit message

Unity MigrationScript: sync gsettings on exit, and only use dconf on failure

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'debian/00_remove_obsolete_plugins_in_unity_session_v1.py' => 'debian/00_remove_obsolete_plugins_in_unity_session_v2.py'
2--- debian/00_remove_obsolete_plugins_in_unity_session_v1.py 2016-07-14 10:52:42 +0000
3+++ debian/00_remove_obsolete_plugins_in_unity_session_v2.py 2016-07-26 09:21:51 +0000
4@@ -45,8 +45,14 @@
5 except ValueError:
6 pass
7
8- # gsettings doesn't work directly, the key is somewhat reverted. Work one level under then: dconf!
9- # gsettings.set_strv("active-plugins", active_plugins)
10- from subprocess import Popen, PIPE, STDOUT
11- p = Popen(("dconf load "+core_profile_path).split(), stdout=PIPE, stdin=PIPE, stderr=STDOUT)
12- p.communicate(input=bytes("[/]\nactive-plugins={}".format(active_plugins), 'utf-8'))
13+ gsettings.set_strv("active-plugins", active_plugins)
14+ Gio.Settings.sync()
15+
16+ # Sometimes settings don't get written correctly, so in case we fallback to dconf
17+ if core_settings.get_strv("active-plugins") != active_plugins:
18+ try:
19+ from subprocess import Popen, PIPE, STDOUT
20+ p = Popen(("dconf load "+core_profile_path).split(), stdout=PIPE, stdin=PIPE, stderr=STDOUT)
21+ p.communicate(input=bytes("[/]\nactive-plugins={}".format(active_plugins), 'utf-8'))
22+ except:
23+ pass
24
25=== modified file 'debian/compiz-gnome.migrations'
26--- debian/compiz-gnome.migrations 2016-07-14 10:52:42 +0000
27+++ debian/compiz-gnome.migrations 2016-07-26 09:21:51 +0000
28@@ -1,1 +1,1 @@
29-debian/00_remove_obsolete_plugins_in_unity_session_v1.py
30+debian/00_remove_obsolete_plugins_in_unity_session_v2.py

Subscribers

People subscribed via source and target branches