Merge lp:~3v1n0/compiz/grid-lowgfx-fixes into lp:compiz

[Marco Trevisan (Treviño)]

grid: ignore alpha in colors when not blending, and fix animations

The fade-out animation was still happening when the duration was set to 1,
while it was broken when it was 0. Fixed both.

In unity-lowgfx.ini set the animation duration to 0 in grid and d not
draw stretched windows. Enable blending again as it's really not
expensive in this case, while not having it, really makes the user
experience a lot poorer.

[Andrea Azzarone (azzar1)]

LGTM.

review: Approve

=== modified file 'debian/unity-lowgfx.ini'
--- debian/unity-lowgfx.ini	2017-06-29 00:58:46 +0000
+++ debian/unity-lowgfx.ini	2017-06-29 00:58:46 +0000
@@ -12,8 +12,8 @@
 s0_fade_time = 1
 
 [grid]
-s0_animation_duration = 1
-s0_disable_blend = true
+s0_animation_duration = 0
+s0_draw_stretched_window = false
 
 [resize]
 s0_mode = 2

=== modified file 'plugins/grid/src/grid.cpp'
--- plugins/grid/src/grid.cpp	2016-09-07 11:10:35 +0000
+++ plugins/grid/src/grid.cpp	2017-06-29 00:58:46 +0000
@@ -532,7 +532,7 @@
 	Animation& anim = *iter;
 
 	float curve = powf (CURVE_ANIMATION, -anim.progress);
-	float alpha = (optionGetFillColorAlpha () / MaxUShortFloat) * anim.opacity;
+	float alpha = blend ? (optionGetFillColorAlpha () / MaxUShortFloat) * anim.opacity : 0.85;
 	color = optionGetFillColor ();
 
 	colorData[0] = alpha * color[0];
@@ -570,7 +570,7 @@
 				      anim.currentRect.height () - 2);
 
 	/* draw outline */
-	alpha = (optionGetOutlineColorAlpha () / MaxUShortFloat) * anim.opacity;
+	alpha = blend ? (optionGetOutlineColorAlpha () / MaxUShortFloat) * anim.opacity : 1;
 	color = optionGetOutlineColor ();
 
 	colorData[0] = alpha * color[0];
@@ -603,7 +603,7 @@
     if (!animating)
     {
 	/* draw filled rectangle */
-	float alpha = optionGetFillColorAlpha () / MaxUShortFloat;
+	float alpha = blend ? optionGetFillColorAlpha () / MaxUShortFloat : 0.85;
 	color = optionGetFillColor ();
 
 	colorData[0] = alpha * color[0];
@@ -885,7 +885,7 @@
 		    animations.at (current).fromRect = w->serverBorderRect ();
 		    animations.at (current).currentRect	= w->serverBorderRect ();
 		    animations.at (current).duration = optionGetAnimationDuration ();
-		    animations.at (current).timer = animations.at (current).duration;
+		    animations.at (current).progress = 0.0f;
 		    animations.at (current).targetRect = desiredSlot;
 		    animations.at (current).window = w->id();
 
@@ -1199,18 +1199,24 @@
     for (iter = animations.begin (); iter != animations.end (); ++iter)
     {
 	Animation& anim = *iter;
-	anim.timer -= msSinceLastPaint;
+	GLfloat msSinceLastPaintFloat = static_cast<GLfloat>(msSinceLastPaint);
+	GLfloat animDurationFloat = static_cast<GLfloat>(anim.duration);
+	GLfloat progress_delta = 1.0f;
 
-	if (anim.timer < 0)
-	    anim.timer = 0;
+	if (animDurationFloat > 0.0f)
+	    progress_delta = msSinceLastPaintFloat / animDurationFloat;
 
 	if (anim.fadingOut)
-	    anim.opacity -= msSinceLastPaint * 0.002;
+	{
+	    anim.opacity -= progress_delta;
+	}
 	else
+	{
 	    if (anim.opacity < 1.0f)
 		anim.opacity = anim.progress * anim.progress;
 	    else
 		anim.opacity = 1.0f;
+	}
 
 	if (anim.opacity < 0)
 	{
@@ -1219,10 +1225,10 @@
 	    anim.complete = true;
 	}
 
-	anim.progress =	(anim.duration - anim.timer) / anim.duration;
+	anim.progress = std::min<GLfloat>(anim.progress + progress_delta, 1.0);
     }
 
-    if (optionGetDrawStretchedWindow ())
+    if (optionGetDrawStretchedWindow () && !optionGetDisableBlend ())
     {
 	CompWindow *cw = screen->findWindow (CompOption::getIntOptionNamed (o, "window"));
 
@@ -1292,7 +1298,6 @@
     targetRect = CompRect (0, 0, 0, 0);
     currentRect = CompRect (0, 0, 0, 0);
     opacity = 0.0f;
-    timer = 0.0f;
     duration = 0;
     complete = false;
     fadingOut = false;
@@ -1400,7 +1405,7 @@
     {
 	Animation& anim = *iter;
 
-	if (anim.timer > 0.0f && anim.window == window->id())
+	if (anim.progress < 1.0f && anim.window == window->id())
 	{
 	    GLWindowPaintAttrib wAttrib(attrib);
 	    GLMatrix wTransform (matrix);

=== modified file 'plugins/grid/src/grid.h'
--- plugins/grid/src/grid.h	2013-04-30 00:18:41 +0000
+++ plugins/grid/src/grid.h	2017-06-29 00:58:46 +0000
@@ -96,7 +96,6 @@
 	CompRect targetRect;
 	CompRect currentRect;
 	GLfloat  opacity;
-	GLfloat  timer;
 	Window   window;
 	int      duration;
 	bool     complete;