Merge lp:~3v1n0/compiz-expo-plugin/oneiric.fix_875557 into lp:~compiz-team/compiz-expo-plugin/oneiric

[Marco Trevisan (Treviño)]

Don't reset the dndState on expo terminate.
doing this causes the dndFini function not to work when called, and so not to release the grab on selected window(s).
This shouldn't lead to issues in the case that dndFini is not called, since the dndState variable is reset to None once expo is fired again.

[Omer Akram (om26er)]

Marco, do you plan to work on test case for this fix? seems we can't SRU unless its fixed in precise(with testcase)

[Marco Trevisan (Treviño) (3v1n0)]

It's actually very hard to test this without autopilot support.
We need that, so I can write a test.

[Sam Spilsbury (smspillaz)]

Since this is something thats more or less an interaction issue with other plugins and not really something that can be easily manually tested because it is a race condition, I'm in favor of just merging this without tests.

[Sam Spilsbury (smspillaz)]

review: Approve

=== modified file 'src/expo.cpp'
--- src/expo.cpp	2011-10-05 06:48:41 +0000
+++ src/expo.cpp	2011-11-26 20:47:23 +0000
@@ -148,8 +148,6 @@
     else
 	vpUpdateMode = VPUpdateMouseOver;
 
-    dndState  = DnDNone;
-
     screen->removeAction (&optionGetDndButton ());
     screen->removeAction (&optionGetExitButton ());
     screen->removeAction (&optionGetNextVpButton ());