Merge lp:~3v1n0/bamf/window-action-menu into lp:bamf
Status: | Merged |
---|---|
Approved by: | Brandon Schaefer |
Approved revision: | 592 |
Merged at revision: | 591 |
Proposed branch: | lp:~3v1n0/bamf/window-action-menu |
Merge into: | lp:bamf |
Diff against target: |
215 lines (+108/-1) 6 files modified
src/bamf-legacy-screen.c (+66/-0) src/bamf-legacy-window-test.c (+5/-0) src/bamf-legacy-window.c (+30/-0) src/bamf-legacy-window.h (+6/-0) src/bamf-xutils.c (+1/-0) src/bamf-xutils.h (+0/-1) |
To merge this branch: | bzr merge lp:~3v1n0/bamf/window-action-menu |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brandon Schaefer (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
Commit message
BamfLegacyScreen: When in Unity monitor for compiz ClientMessage's to show action menu
If we get a _COMPIZ_
_COMPIZ_
to show the window action menu, and thus let's ask the proper BamfLegacyWindow
to do that, thanks to libwnck.
Description of the change
In Unity monitor for compiz Client messages, and if requested (by Alt+Space, Alt+right-click, or directly by it) we show the classic "libwnck" window actions menu in the proper position (top-left corner of the window if activated by keyboard, in the click position otherwise).
The rationale for putting this instead than in unity itself is that having it in unity, a part that it would have needed to add one more build dependency (not a big deal considering that bamf already is), it would have us forced to add one more libwnck screen which means a window event filter, and a lot of logic computation that we don't need at all (as we already do it in bamf itself).
So imho this is the best approach not to duplicate things.
PASSED: Continuous integration, rev:592 jenkins. qa.ubuntu. com/job/ bamf-ci/ 98/ jenkins. qa.ubuntu. com/job/ bamf-trusty- amd64-ci/ 6 jenkins. qa.ubuntu. com/job/ bamf-trusty- armhf-ci/ 6 jenkins. qa.ubuntu. com/job/ bamf-trusty- armhf-ci/ 6/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/bamf- ci/98/rebuild
http://