BAMF

Merge lp:~3v1n0/bamf/view-tab-close-typo-fix into lp:bamf

  1. view-tab-close-typo-fix
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: 571
Merged at revision: 549
Proposed branch: lp:~3v1n0/bamf/view-tab-close-typo-fix
Merge into: lp:bamf
Diff against target: 14 lines (+3/-1)
1 file modified
lib/libbamf/bamf-view.c (+3/-1)
To merge this branch: bzr merge lp:~3v1n0/bamf/view-tab-close-typo-fix
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Andrea Azzarone (community) Approve
Review via email: mp+169241@code.launchpad.net

Commit message

BamfView: disconnect proper callback if a bamf-tab is closed

I guess it was a typo, we need to disconnect to the callback we've been
connected to before...

Description of the change

Tiny fix on old code...

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:571
http://jenkins.qa.ubuntu.com/job/bamf-ci/51/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/bamf-saucy-amd64-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/bamf-saucy-armhf-ci/32

Click here to trigger a rebuild:
http://s-jenkins:8080/job/bamf-ci/51/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/libbamf/bamf-view.c'
2--- lib/libbamf/bamf-view.c 2013-06-13 14:57:20 +0000
3+++ lib/libbamf/bamf-view.c 2013-06-13 15:56:38 +0000
4@@ -505,7 +505,9 @@
5 g_return_if_fail (BAMF_IS_VIEW (view));
6
7 if (BAMF_IS_TAB (view))
8- g_signal_handlers_disconnect_by_func (view, bamf_view_on_child_added, self);
9+ {
10+ g_signal_handlers_disconnect_by_func (view, bamf_view_child_xid_changed, self);
11+ }
12
13 if (priv->cached_children)
14 {

Subscribers

People subscribed via source and target branches