Merge lp:~3v1n0/bamf/unset-proxy-on-set-path into lp:bamf/0.4
Proposed by
Marco Trevisan (Treviño)
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Marco Trevisan (Treviño) | ||||||||||||
Approved revision: | 464 | ||||||||||||
Merged at revision: | 463 | ||||||||||||
Proposed branch: | lp:~3v1n0/bamf/unset-proxy-on-set-path | ||||||||||||
Merge into: | lp:bamf/0.4 | ||||||||||||
Diff against target: |
385 lines (+123/-126) 4 files modified
lib/libbamf/bamf-application.c (+32/-16) lib/libbamf/bamf-indicator.c (+5/-0) lib/libbamf/bamf-view.c (+58/-91) lib/libbamf/bamf-window.c (+28/-19) |
||||||||||||
To merge this branch: | bzr merge lp:~3v1n0/bamf/unset-proxy-on-set-path | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Approve | ||
Andrea Azzarone (community) | Approve | ||
Review via email: mp+106117@code.launchpad.net |
Commit message
libbamf: unset the previously defined proxy if adding a new one
This fixes some crashes, and memory leaks.
Description of the change
When setting an object path in libbamf, the previous proxy was never unreff'ed or disconnected by signals, this caused some crashes like bug #1000577.
Correctly unsetting the proxy and disconnecting from its signals, fixes the issue.
To post a comment you must log in.
LGTM