Merge lp:~3v1n0/bamf/lo-startupwmclass-ignore into lp:bamf/0.2

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Brandon Schaefer
Approved revision: 492
Merged at revision: 492
Proposed branch: lp:~3v1n0/bamf/lo-startupwmclass-ignore
Merge into: lp:bamf/0.2
Diff against target: 20 lines (+9/-1)
1 file modified
src/bamf-matcher.c (+9/-1)
To merge this branch: bzr merge lp:~3v1n0/bamf/lo-startupwmclass-ignore
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
Review via email: mp+190408@code.launchpad.net

Commit message

BamfMatcher: ignore StartupWMClass for LibreOffice Windows

LO windows can be very slow to update their window class, and this may
lead to matching errors.

To post a comment you must log in.
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/bamf-matcher.c'
2--- src/bamf-matcher.c 2013-01-29 18:20:17 +0000
3+++ src/bamf-matcher.c 2013-10-10 16:17:15 +0000
4@@ -1684,7 +1684,15 @@
5
6 if (desktop_file)
7 {
8- desktop_class = bamf_matcher_get_desktop_file_class (self, desktop_file);
9+ if (is_open_office_window (self, window))
10+ {
11+ // LO is not fast enough to update its class, and this can lead to matching errors
12+ filter_by_wmclass = FALSE;
13+ }
14+ else
15+ {
16+ desktop_class = bamf_matcher_get_desktop_file_class (self, desktop_file);
17+ }
18
19 if ((!filter_by_wmclass && !desktop_class) || g_strcmp0 (desktop_class, target_class) == 0)
20 {

Subscribers

People subscribed via source and target branches