BAMF

Merge lp:~3v1n0/bamf/libbamf-private into lp:bamf

  1. libbamf-private
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 453
Merged at revision: 537
Proposed branch: lp:~3v1n0/bamf/libbamf-private
Merge into: lp:bamf
Diff against target: 0 lines
To merge this branch: bzr merge lp:~3v1n0/bamf/libbamf-private
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Brandon Schaefer (community) Approve
Review via email: mp+163897@code.launchpad.net

Commit message

LibBamfPrivate: add new private library to share code between client and daemon

Description of the change

Move generated dbus code to libbamf-private, so that it can be shared between daemon and library at compile time.

Also, renamed the bamf_dbus* functions to have a '_' prefixed name so that they won't be exported on dbus.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:449
http://jenkins.qa.ubuntu.com/job/bamf-ci/28/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-saucy-amd64-ci/9/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-saucy-armhf-ci/9/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/bamf-ci/28/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:450
http://jenkins.qa.ubuntu.com/job/bamf-ci/29/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-saucy-amd64-ci/10/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-saucy-armhf-ci/10/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/bamf-ci/29/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:451
http://jenkins.qa.ubuntu.com/job/bamf-ci/30/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/bamf-saucy-amd64-ci/11
    SUCCESS: http://jenkins.qa.ubuntu.com/job/bamf-saucy-armhf-ci/11

Click here to trigger a rebuild:
http://s-jenkins:8080/job/bamf-ci/30/rebuild

review: Approve (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Still looks good :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:452
http://jenkins.qa.ubuntu.com/job/bamf-ci/31/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/bamf-saucy-amd64-ci/12
    SUCCESS: http://jenkins.qa.ubuntu.com/job/bamf-saucy-armhf-ci/12

Click here to trigger a rebuild:
http://s-jenkins:8080/job/bamf-ci/31/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/bamf-autolanding/16/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-saucy-amd64-autolanding/8/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-saucy-armhf-autolanding/7/console

review: Needs Fixing (continuous-integration)
lp:~3v1n0/bamf/libbamf-private updated
453. By Marco Trevisan (Treviño)

Merging with trunk...

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

Empty

Subscribers

People subscribed via source and target branches