lp:~3v1n0/bamf/lib-factory-xids-matching

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:bamf/0.4 at revision 462

Michal Hruby (community): Approve on 2012-04-27

Diff: 892 lines (+410/-120)

9 files modified

lib/libbamf/Makefile.am (+1/-0)
lib/libbamf/bamf-application-private.h (+30/-0)
lib/libbamf/bamf-application.c (+71/-8)
lib/libbamf/bamf-factory.c (+157/-44)
lib/libbamf/bamf-factory.h (+17/-0)
lib/libbamf/bamf-matcher.c (+68/-38)
lib/libbamf/bamf-view-private.h (+2/-0)
lib/libbamf/bamf-view.c (+62/-29)
lib/libbamf/bamf-window.c (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #928912: multiple instances or double icons of application detected on bamfdaemon respawn

Medium

Fix Released

Link a bug report

Related blueprints

480. By Marco Trevisan (Treviño) on 2012-04-26

BamfFactory: use BamfFactoryViewType instead of strings comparisons when possible.

This cleans the code and is for sure more safe.

479. By Marco Trevisan (Treviño) on 2012-04-26

libbamf, bamfview: disconect to the destroyed signal when needed

478. By Marco Trevisan (Treviño) on 2012-04-26

BamfView: reset flags and nullify proxy on proxy destruction

477. By Marco Trevisan (Treviño) on 2012-04-26

BamfFactory: try to re-associate also windows by xids

This shouldn't be needed since the path is not changed in this case
but, let's be safe!

476. By Marco Trevisan (Treviño) on 2012-04-26

BamfFactory: use also the childen xids to match views

When bamfdaemon has been killed and re-opened, the library should
try to reassociate the opened applications by desktop files, if that
check fails we should fallback on the children xids comparison:
if at least one child of a closed bamf application matches, then
we should re-associate it with the new path.

475. By Marco Trevisan (Treviño) on 2012-04-26

BamfApplication: add protected get_cached_xids function, to retrieve the children xids

We keep in cache a list of xids that the application owns.
Available only to the library, not outside

474. By Marco Trevisan (Treviño) on 2012-04-23

BamfApplication: fix memory leak on get_windows

473. By Marco Trevisan (Treviño) on 2012-04-23

BamfApplication: use typed factory getter

472. By Marco Trevisan (Treviño) on 2012-04-23

BamfWindow: use typed factory getter

471. By Marco Trevisan (Treviño) on 2012-04-23

BamfMatcher: use factory's view_for_path_type function to get BamfView's

This should increase the performances when creating a new view, since
we don't need to create an unneeded view, fetch for its type, and finally
re-create the correctly typed view. Now we do all in one step if possible.